Re: Fwd: How to name modules, automatic and otherwise

2017-02-16 Thread Hervé BOUTEMY
tuesday, I was at a Jigsaw presentation from Remi Forax in France, where the fact that nothing was taken into consideration looked something that was happenning (and the recent publication shows that it has happened now) Then Remi and I discussed and looked for ideas on what lighter proposal to

[GitHub] maven-plugins pull request #103: Fix link to assembly-component.html

2017-02-16 Thread arend-von-reinersdorff
GitHub user arend-von-reinersdorff opened a pull request: https://github.com/apache/maven-plugins/pull/103 Fix link to assembly-component.html You can merge this pull request into a Git repository by running: $ git pull https://github.com/arend-von-reinersdorff/maven-plugins

Re: Running a plugin integration test from an IDE?

2017-02-16 Thread org . apache . maven . user
On 2017-02-16T18:32:10 +0100 "Robert Scholte" wrote: > If you have a project under maven-assembly-plugin/src/it/projects/bugs and > want to debug it, try: > > mvn verify -Prun-its -Dinvoker.mavenExecutable=mvnDebug > -Dinvoker.test=projects/bugs (point to

Re: Fwd: How to name modules, automatic and otherwise

2017-02-16 Thread Manfred Moser
And it looks like they are saying .. just add the groupId (or similar namespace) to the modulename. A bit like some artifact repeat the groupId in the artifactId to be specific... seems like a wasted opportunity to define a good usage pattern. The idea of actually supporting same module names

Re: Fwd: How to name modules, automatic and otherwise

2017-02-16 Thread Brian Fox
On Thu, Feb 16, 2017 at 1:38 PM, Igor Fedorenko wrote: > Can't we just block auto-named modules from the build? We control > dependencies and should be able to look inside and barf if we don't like > anything, no? > Yes but this only applies to things that are modularized.

Re: Fwd: How to name modules, automatic and otherwise

2017-02-16 Thread Igor Fedorenko
Can't we just block auto-named modules from the build? We control dependencies and should be able to look inside and barf if we don't like anything, no? I realize this does not set good defaults for non-maven projects, so there will be some friction there, but hopefully maven userbase is big

Re: Fwd: How to name modules, automatic and otherwise

2017-02-16 Thread Brian Fox
I generally agree the concerns were mostly ignored. Specifically the dangers in not carefully approaching and setting best practices in the names, thereby willfully ignoring what happened with NPM. The inclusion of the Module-Name metadata is frankly, more than I expected we would get. I think

Re: Running a plugin integration test from an IDE?

2017-02-16 Thread Robert Scholte
If you have a project under maven-assembly-plugin/src/it/projects/bugs and want to debug it, try: mvn verify -Prun-its -Dinvoker.mavenExecutable=mvnDebug -Dinvoker.test=projects/bugs (point to test-directory) You'll see that Maven will hang during the invoker, at which time you have to

Re: Fwd: How to name modules, automatic and otherwise

2017-02-16 Thread Manfred Moser
I just read it all .. sigh. Looks like our concerns got ignored to me Manfred Robert Scholte wrote on 2017-02-16 09:23: > FYI, > > Robert > > --- Forwarded message --- > From: mark.reinh...@oracle.com > To: jpms-spec-expe...@openjdk.java.net > Cc: > Subject: How to name modules,

Fwd: How to name modules, automatic and otherwise

2017-02-16 Thread Robert Scholte
FYI, Robert --- Forwarded message --- From: mark.reinh...@oracle.com To: jpms-spec-expe...@openjdk.java.net Cc: Subject: How to name modules, automatic and otherwise Date: Thu, 16 Feb 2017 17:48:27 +0100 This note is in reply to the concerns about automatic modules raised by Robert

Re: Running a plugin integration test from an IDE?

2017-02-16 Thread Manfred Moser
I use the takari testing with the Android Maven Plugin all the time and it works great for me. Manfred PS: also associated with Takari efforts.. Igor Fedorenko wrote on 2017-02-16 03:52: > I don't use intellij, but if you are willing to try eclipse/m2e then > there are at least two viable

Re: Running a plugin integration test from an IDE?

2017-02-16 Thread org . apache . maven . user
Hello! I think I may have explained myself poorly. I'm not really looking for a general way to take a project and make it debuggable. I'm looking for a concrete way to work on a bug in the Assembly plugin. On 2017-02-16T13:39:33 + John Patrick wrote: > this might

Re: Running a plugin integration test from an IDE?

2017-02-16 Thread John Patrick
this might work and is what I get into the company/project root pom so all developers can use the approach. create a debug profile and get the tests to use is so you can debug in your preferred IDE. it doesn't give you the nice red/green process bars and fancy output but it might help you debug

Re: Running a plugin integration test from an IDE?

2017-02-16 Thread Igor Fedorenko
I don't use intellij, but if you are willing to try eclipse/m2e then there are at least two viable ways to implement "debuggable" integration tests. Personally I prefer takari plugin testing harness [1] (disclosure: I wrote the thing, so I am definitely biased). Alternatively, you can also use

Re: Running a plugin integration test from an IDE?

2017-02-16 Thread org . apache . maven . user
On 2017-02-14T15:13:46 + org.apache.maven.u...@io7m.com wrote: > > I can't work out how to run this integration > test from an IDE (Intellij IDEA, in this case) so that I can try to > step through the execution with a debugger and see what's going on. So nobody knows how to run an integration