[IT MNG-6173] (was Re: Timeline for 3.5.0-alpha-2)

[Christian Schulte]

Am 03/04/17 um 14:56 schrieb Stephen Connolly:
> We are still in alpha, so bugs with severity S1-S3 are eligible (and S4
> with a risk assessment)
> Severity is something like this (but as a project we probably need to
> define the categories for Maven core)
> 
> S1: blows up for everyone, no workaround
> S2: blows up under certain circumstances, no workaround. Also feature does
> not work, no workaround.
> S3: blows up but there is a workaround. Most other bugs
> S4: cosmetic issues

Seems to be S2 for at least the flatten-maven-plugin. The reporter
updated the description in JIRA mentioning this. Branch MNG-6173 created
in the core and IT repository. I only updated the range in the IT to
read [3.5.0-alpha-1 instead of just [3.5.0.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Timeline for 3.5.0-alpha-2

[Christian Schulte]

Am 03/04/17 um 18:54 schrieb Hervé BOUTEMY:
> I have one question, which is recurring for every issue: what is the impact?
> 
> I understand the logic: it should fix a bug (that is told introduced in Maven 
> 3.3.1), and the bug is explained by the logic behind the javadoc.
> But no pointer to any code using this method, and that shows that Maven 3.3.1 
> does not work any more, when previous version were ok.
> Then what is explained here as a bugfix could cause issues for others.
> 
> I'm -1 unless I have some details on the impact

Please see the linked issues. The reporter did a great job finding out
about when the issue got introduced. His findings are consistent with



and his analysis also is consistent with



What impact the changes have, I cannot tell. That's why we should take
this to JIRA.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Timeline for 3.5.0-alpha-2

[Christian Schulte]

Am 03/04/17 um 18:54 schrieb Hervé BOUTEMY:
> I have one question, which is recurring for every issue: what is the impact?
> 
> I understand the logic: it should fix a bug (that is told introduced in Maven 
> 3.3.1), and the bug is explained by the logic behind the javadoc.
> But no pointer to any code using this method, and that shows that Maven 3.3.1 
> does not work any more, when previous version were ok.
> Then what is explained here as a bugfix could cause issues for others.
> 
> I'm -1 unless I have some details on the impact
> 
> Regards,
> 
> Hervé

I added this to the JIRA issue. I do not know if the reporter is
following dev@. This better be discussed in JIRA then, so that the
reporter can easily take part in the discussion.



Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Timeline for 3.5.0-alpha-2

[Hervé BOUTEMY]

I have one question, which is recurring for every issue: what is the impact?

I understand the logic: it should fix a bug (that is told introduced in Maven 
3.3.1), and the bug is explained by the logic behind the javadoc.
But no pointer to any code using this method, and that shows that Maven 3.3.1 
does not work any more, when previous version were ok.
Then what is explained here as a bugfix could cause issues for others.

I'm -1 unless I have some details on the impact

Regards,

Hervé

Le samedi 4 mars 2017, 13:33:55 CET Christian Schulte a écrit :
> Am 03/02/17 um 22:55 schrieb Stephen Connolly:
> > I'd like to declare feature freeze for alpha-2 on March 9th.
> > 
> > If a feature does not land in alpha-2 it will not be in beta-1 (i.e. Only
> > bug fixes or rip out features that are causing S1/S2 issues will be in
> > the diff from alpha-2 to beta-1)
> > 
> > I am aiming beta-2 approx 2 weeks after alpha-2 and the GA approx 2 weeks
> > after that.
> Should we include
> 
> 
> 
> FIX-3.5.0? It has just been reported. It also has an IT pull request. If
> no one objects, I'll create a branch and later merge it to master.
> 
> Regards,



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Timeline for 3.5.0-alpha-2

[Robert Scholte]

I've created two more issues:

MNG-6181 Wagon produces a lot of noise at debug loglevel
MNG-6180 groupId has plain color when goal fails

I have no proper solution yet for MNG-6181, maybe we simply need to change  
the loglevel for wagon to INFO.


Robert

On Sat, 04 Mar 2017 02:45:21 +0100, Hervé BOUTEMY   
wrote:


sorry to open such discussion, but given the good feedback on alpha-1  
(which
is a good news), are alpha-2 then beta-1 then beta-2 before GA really  
useful?

Not a little bit too much?
Or are there really changes I don't see that require such detailed
qualification path?

Regards,

Hervé

Le jeudi 2 mars 2017, 21:55:29 CET Stephen Connolly a écrit :

I'd like to declare feature freeze for alpha-2 on March 9th.

If a feature does not land in alpha-2 it will not be in beta-1 (i.e.  
Only
bug fixes or rip out features that are causing S1/S2 issues will be in  
the

diff from alpha-2 to beta-1)

I am aiming beta-2 approx 2 weeks after alpha-2 and the GA approx 2  
weeks

after that.

Sent from my iPhone
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Timeline for 3.5.0-alpha-2

[Karl Heinz Marbaise]

Hi,

I see it the same way...I think we might need an alpha-2 but then I 
don't a requirement for further releases before the final GA...



I would like to get two changes into alpha-2 (MNG-6057, MNG-6170) which 
fixing things.
MNG-6170 fixes an edge case in relationship with -T XX calling a goal 
only and MNG-6057 fixes the problem using ${revision}, ${sha1} and 
${changelist} usable in version tag of the pom which gives you the 
opportunity to define the version of a whole project including modules 
just by a property either in pom itself or via command line.


So I would like to have an alpha-2 for them to get more feedback about 
these things...



Kind regards
Karl Heinz Marbaise

On 04/03/17 02:45, Hervé BOUTEMY wrote:

sorry to open such discussion, but given the good feedback on alpha-1 (which
is a good news), are alpha-2 then beta-1 then beta-2 before GA really useful?
Not a little bit too much?
Or are there really changes I don't see that require such detailed
qualification path?

Regards,

Hervé

Le jeudi 2 mars 2017, 21:55:29 CET Stephen Connolly a écrit :

I'd like to declare feature freeze for alpha-2 on March 9th.

If a feature does not land in alpha-2 it will not be in beta-1 (i.e. Only
bug fixes or rip out features that are causing S1/S2 issues will be in the
diff from alpha-2 to beta-1)

I am aiming beta-2 approx 2 weeks after alpha-2 and the GA approx 2 weeks
after that.

Sent from my iPhone
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org





Mit freundlichem Gruß
Karl-Heinz Marbaise
--
SoftwareEntwicklung Beratung SchulungTel.: +49 (0) 2405 / 415 893
Dipl.Ing.(FH) Karl-Heinz MarbaiseUSt.IdNr: DE191347579
Hauptstrasse 177
52146 Würselen   http://www.soebes.de

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Timeline for 3.5.0-alpha-2

[Stephen Connolly]

We are still in alpha, so bugs with severity S1-S3 are eligible (and S4
with a risk assessment)
Severity is something like this (but as a project we probably need to
define the categories for Maven core)

S1: blows up for everyone, no workaround
S2: blows up under certain circumstances, no workaround. Also feature does
not work, no workaround.
S3: blows up but there is a workaround. Most other bugs
S4: cosmetic issues


On Sat 4 Mar 2017 at 12:34, Christian Schulte  wrote:

> Am 03/02/17 um 22:55 schrieb Stephen Connolly:
> > I'd like to declare feature freeze for alpha-2 on March 9th.
> >
> > If a feature does not land in alpha-2 it will not be in beta-1 (i.e.
> Only bug fixes or rip out features that are causing S1/S2 issues will be in
> the diff from alpha-2 to beta-1)
> >
> > I am aiming beta-2 approx 2 weeks after alpha-2 and the GA approx 2
> weeks after that.
>
> Should we include
>
> 
>
> FIX-3.5.0? It has just been reported. It also has an IT pull request. If
> no one objects, I'll create a branch and later merge it to master.
>
> Regards,
> --
> Christian
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone

Re: Timeline for 3.5.0-alpha-2

[Christian Schulte]

Am 03/02/17 um 22:55 schrieb Stephen Connolly:
> I'd like to declare feature freeze for alpha-2 on March 9th.
> 
> If a feature does not land in alpha-2 it will not be in beta-1 (i.e. Only bug 
> fixes or rip out features that are causing S1/S2 issues will be in the diff 
> from alpha-2 to beta-1)
> 
> I am aiming beta-2 approx 2 weeks after alpha-2 and the GA approx 2 weeks 
> after that.

Should we include



FIX-3.5.0? It has just been reported. It also has an IT pull request. If
no one objects, I'll create a branch and later merge it to master.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Timeline for 3.5.0-alpha-2

[Hervé BOUTEMY]

1 non-final then the final, *if everything happens as expected*: ok, fine for 
me, 
I can live with that extra step :)

Le samedi 4 mars 2017, 08:12:35 CET Stephen Connolly a écrit :
> I was only planning 1 beta.
> 
> And if alpha-2 is good enough and we are confident we can skip the beta...
> 
> I want to avoid RCs, we should have one take only for the actual release
> 
> On Sat 4 Mar 2017 at 01:47, Hervé BOUTEMY  wrote:
> > sorry to open such discussion, but given the good feedback on alpha-1
> > (which
> > is a good news), are alpha-2 then beta-1 then beta-2 before GA really
> > useful?
> > Not a little bit too much?
> > Or are there really changes I don't see that require such detailed
> > qualification path?
> > 
> > Regards,
> > 
> > Hervé
> > 
> > Le jeudi 2 mars 2017, 21:55:29 CET Stephen Connolly a écrit :
> > > I'd like to declare feature freeze for alpha-2 on March 9th.
> > > 
> > > If a feature does not land in alpha-2 it will not be in beta-1 (i.e.
> > > Only
> > > bug fixes or rip out features that are causing S1/S2 issues will be in
> > 
> > the
> > 
> > > diff from alpha-2 to beta-1)
> > > 
> > > I am aiming beta-2 approx 2 weeks after alpha-2 and the GA approx 2
> > > weeks
> > > after that.
> > > 
> > > Sent from my iPhone
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> > 
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> > 
> > --
> 
> Sent from my phone



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-integration-testing pull request #19: [MNG-6173] MavenSession.getAllPr...

[cboehme]

GitHub user cboehme opened a pull request:

https://github.com/apache/maven-integration-testing/pull/19

[MNG-6173] MavenSession.getAllProjects() should return all projects in the 
reactor

Integration tests for issue 
[MNG-6173](https://issues.apache.org/jira/browse/MNG-6173) as requested.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cboehme/maven-integration-testing 
MNG-6173-get-all-projects

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-integration-testing/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit 46e501ef71f5918b79c87056980d4f35f0924490
Author: Christoph Böhme 
Date:   2017-03-03T21:07:17Z

[MNG-6173] getAllProjects() should return all projects

Adds a test for checking that MavenSession.getAllProjects() returns the full
list of projects in the reactor even when only some of them are selected
for being built.

commit 7b8edbe31c32a4460a254dcd1c8db81587c0df56
Author: Christoph Böhme 
Date:   2017-03-04T07:33:26Z

[MNG-6173] Test getProjects() and getProjectDependencyGraph()

Adds a test for checking that MavenSession.getProjects() contains the
projects being built and that MavenSession.getProjectDependencyGraph()
is set.

The fix for MNG-6173 changed the way these to properties are
initialised. This integration test verifies that the initialisation is
still correct.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Timeline for 3.5.0-alpha-2

[Stephen Connolly]

I was only planning 1 beta.

And if alpha-2 is good enough and we are confident we can skip the beta...

I want to avoid RCs, we should have one take only for the actual release

On Sat 4 Mar 2017 at 01:47, Hervé BOUTEMY  wrote:

> sorry to open such discussion, but given the good feedback on alpha-1
> (which
> is a good news), are alpha-2 then beta-1 then beta-2 before GA really
> useful?
> Not a little bit too much?
> Or are there really changes I don't see that require such detailed
> qualification path?
>
> Regards,
>
> Hervé
>
> Le jeudi 2 mars 2017, 21:55:29 CET Stephen Connolly a écrit :
> > I'd like to declare feature freeze for alpha-2 on March 9th.
> >
> > If a feature does not land in alpha-2 it will not be in beta-1 (i.e. Only
> > bug fixes or rip out features that are causing S1/S2 issues will be in
> the
> > diff from alpha-2 to beta-1)
> >
> > I am aiming beta-2 approx 2 weeks after alpha-2 and the GA approx 2 weeks
> > after that.
> >
> > Sent from my iPhone
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone