[GitHub] maven-integration-testing pull request #20: Integration tests for various JI...

[ChristianSchulte]

GitHub user ChristianSchulte opened a pull request:

https://github.com/apache/maven-integration-testing/pull/20

Integration tests for various JIRA issues. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ChristianSchulte/maven-integration-testing 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-integration-testing/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit b4391c672a88cc6819dba0666952b50faaedb68f
Author: Christian Schulte 
Date:   2015-12-20T18:34:40Z

[MNG-5359] Declared execution in PluginMgmt gets bound to lifecycle 
(regression)

commit 11dccc9e061f3326b6ef61c97e6e1242803fd0d1
Author: Christian Schulte 
Date:   2016-01-30T19:21:33Z

[MNG-4463] Dependency management import should support version ranges.

commit b2a25c9af3db26ba099a40018843baf48ae6ae66
Author: Christian Schulte 
Date:   2016-06-22T15:41:42Z

[MNG-5527] Dependency management import should support relocations.

commit bae3d8c959ce528d9dcbb41d5039128494582f3e
Author: Christian Schulte 
Date:   2016-06-19T15:18:51Z

[MNG-5600] Dependency management import should support exclusions.

commit 619d2466c74a1f05074861f9bd8f95e0092ee8ba
Author: Christian Schulte 
Date:   2016-02-20T13:42:20Z

[MNG-5971] Imported dependencies should be available to inheritance 
processing

commit 1287046f9372810baf643576674e13d8b689f9a5
Author: Christian Schulte 
Date:   2016-08-13T00:04:02Z

[MNG-6079] 3.4 regression: cannot override version of a 
dependencyManagement in a submodule any more

commit 0bd5b8396bdc1c882679090ade5d67affc4aec3a
Author: Christian Schulte 
Date:   2016-01-27T07:09:55Z

[MNG-5227] The 'optional' flag of a dependency should be manageable.

commit 7e7901459eb97fb05e6e71c050d448ed0db89dcc
Author: Christian Schulte 
Date:   2016-12-13T22:28:45Z

[MNG-5761] Dependency management is not transitive.

commit a7576d90f761321c397d4d51e2e01991a6bfdd56
Author: Christian Schulte 
Date:   2016-12-19T00:51:44Z

[MNG-6135] Maven plugins and core extensions are not dependencies, they 
should be resolved the same way as projects.

o Updated to add all missing POMs to the test repository. Due to core 
extensions getting
  resolved as projects, the POMs of all dependencies need to be available 
in that
  repository even if the dependency is filtered out during resolution.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: What to do with the 6 issues left as 3.5.0-candidates?

[Stephen Connolly]

On Sat 25 Mar 2017 at 19:00, Christian Schulte  wrote:

> Am 03/25/17 um 07:17 schrieb Hervé BOUTEMY:
> > MNG-6112 is harder to estimate side effects IMHO
> > and since this has been available for a long time, I'm really not
> satisfied
> > that it has been integrated *after vote for 3.0.5-beta-1 started* (and in
> > addition without any discussion)
>
> Issue has been mentioned by Michael Osipov somewhen during development
> of 3.4.0 in MNG-4645. I just created a separate issue in JIRA for it.
> There has been a discussion. There also has been an in depth search
> starting from GIT back to the initial commit in subversion by me
> documented in MNG-4645.
>
> 
>

To risky. Out of scope for 3.5.0


> >
> >  I'd say punt to 3.5.1: benefit is not worth the risk for now (we lived
> for
> > years with that, we can stay with it for a couple of months to have wider
> > tests)
>
> Last time I looked at it, Maven never updated release versions. Commit
> is just making this explicit in the repository declaration. This
> sentence "There are still 10  issues left in JIRA for 3.5.0," in the
> vote email for beta-1 made me look at the list. I thought we already
> agreed to these issues for 3.5.0 and just wanted to close the remaining
> issues assigned to me.


Not merged in time (and remember we agreed no merging without a seconded)


>
> Regards,
> --
> Christian
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone

Re: What to do with the 6 issues left as 3.5.0-candidates?

[Christian Schulte]

Am 03/25/17 um 07:17 schrieb Hervé BOUTEMY:
> MNG-6112 is harder to estimate side effects IMHO
> and since this has been available for a long time, I'm really not satisfied 
> that it has been integrated *after vote for 3.0.5-beta-1 started* (and in 
> addition without any discussion)

Issue has been mentioned by Michael Osipov somewhen during development
of 3.4.0 in MNG-4645. I just created a separate issue in JIRA for it.
There has been a discussion. There also has been an in depth search
starting from GIT back to the initial commit in subversion by me
documented in MNG-4645.



> 
>  I'd say punt to 3.5.1: benefit is not worth the risk for now (we lived for 
> years with that, we can stay with it for a couple of months to have wider 
> tests)

Last time I looked at it, Maven never updated release versions. Commit
is just making this explicit in the repository declaration. This
sentence "There are still 10  issues left in JIRA for 3.5.0," in the
vote email for beta-1 made me look at the list. I thought we already
agreed to these issues for 3.5.0 and just wanted to close the remaining
issues assigned to me.

Regards,
-- 
Christian


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #109: Updated dependences

[khmarbaise]

Github user khmarbaise commented on the issue:

https://github.com/apache/maven/pull/109
  
Please mention the JIRA issue in your commit message like this:
```
[MNG-6196] ...
```
otherwise it's hard to follow changes in history...also updating the JIRA 
issue title would be a good idea if you have a good idea what is more 
descriptive...;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request #109: Updated dependences

[slachiewicz]

GitHub user slachiewicz opened a pull request:

https://github.com/apache/maven/pull/109

Updated dependences

Mockito 2.7.19
slf4j 1.7.25
logback-classic 1.2.2

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/slachiewicz/maven feature/MNG-6196

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven/pull/109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #109


commit 324ed1c063785a66a8ebbd1e6e54e6031bf4013f
Author: Sylwester Lachiewicz 
Date:   2017-03-25T16:31:32Z

Updated dependences:

Mockito 2.7.19
slf4j 1.7.25
logback-classic 1.2.2




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

[Hervé BOUTEMY]

thanks for the complements
FTR, I checked and added pointers to code

Regards,

Hervé

Le samedi 25 mars 2017, 07:38:30 CET Igor Fedorenko a écrit :
> Good description, Hervé. One small addition. I believe -Pembedded
> enables "auto" mode,
https://github.com/apache/maven-integration-testing/blob/master/core-it-suite/
pom.xml#L322

> where verifier uses "forked" mode for tests that
> set environment variables and "embedded" mode for all other cases.
https://github.com/apache/maven-shared/blob/trunk/maven-verifier/src/main/java/
org/apache/maven/it/Verifier.java#L1381

> Individual ITs can still force forked mode with verifier.setForkJvm, of
> course.
> 
> > ok, let's share what I know from embedded ITs (sorry, long email, but
> > IMHO
> > useful to share some details):
> > 
> > - by default, Verifier forks for every IT and launches Maven with the
> > shell
> > script through ForkedLauncher [1]
> > 
> > - in embedded mode, there is no fork but use of MavenCli.doMain(String[]
> > args,
> > workingDir, stdin, stdout) by Embedded3xLauncher [2], which will recreate
> > a
> > Classworlds classloader context in the current JVM: AFAIK, this makes the
> > embedded situation really the same as forked one from a classloader point
> > of
> > view, with CLI args passed, working dir, stdin and stdout
> > 
> > - a few ITs require shell script and don't have any meaning without it:
> > in
> > this case, even if the build is in embedded mode, the IT forces the
> > Verifier to
> > used forked execution, for example in mng5889 [3]
> > 
> > - every IT that we want absolutely not to be embedded has to do this
> > "verifier.setForkJvm( true );" call, or the IT won't be in expected
> > situation:
> > as you point out, mng4625 currently does not do this call, then may not
> > be
> > really effective with the embedded profile. This can be considered as a
> > bug and
> > explains why currently this IT fails in my "embedded-ITs" branch => I'll
> > improve now the IT to support the embedded profile by forcing forked
> > execution
> > 
> > :)
> > 
> > Now that I wrote this, summarizing what I knew and what was already
> > reported
> > as issues, it looks to me that embedded mode may trigger a few failures
> > that
> > can and should be fixed by forcing forked execution (which won't change
> > the
> > overall effect: most ITs will run embedded then execution time will be a
> > lot
> > lower than full forked execution)
> > 
> > the only risk is that some ITs don't fail when run in embedded mode but
> > in
> > fact don't really test what they are supposed to test
> > 
> > This seems a reasonable risk to take here, given the benefit: we'll
> > improve ITs
> > if necessary.
> > If nobody objects, I'll do the merge to master in a few days
> > 
> > Regards,
> > 
> > Hervé
> > 
> > [1]
> > http://maven.apache.org/shared/maven-verifier/xref/org/apache/maven/it/
> > ForkedLauncher.html#L60
> > 
> > [2]
> > http://maven.apache.org/ref/3.5.0-beta-1/maven-embedder/xref/org/apache/
> > maven/cli/MavenCli.html#L262
> > 
> > [3]
> > https://github.com/apache/maven-integration-testing/blob/master/core-it-su
> > ite/src/test/java/org/apache/maven/it/
> > MavenITmng5889CoreExtensionsTest.java#L57
> > 
> > Le vendredi 24 mars 2017, 21:29:38 CET Olivier Lamy a écrit :
> > > sure tempting :-)
> > > But is is the same classloader mechanism as a "normal" Maven run?
> > > (should
> > > be really close but not sure exactly so maybe we can miss some cases)
> > > 
> > > On Fri, 24 Mar 2017 at 6:47 pm, Stephen Connolly <
> > > 
> > > stephen.alan.conno...@gmail.com> wrote:
> > > > Have we some of the tests running in both modes?
> > > > 
> > > > Specifically at least 4625 as it caught some interesting CLI parsing
> > > > issues, but there may be a couple more
> > > > 
> > > > On Fri 24 Mar 2017 at 07:15, Hervé Boutemy  
wrote:
> > > > > as you can see, in embedded mode, core ITs can run in 17 minutes,
> > > > > when
> > > > > in
> > > > > classic mode they run in 1h30
> > > > > 
> > > > > any objection to merge this embedded mode into master?
> > > > > 
> > > > > Regards,
> > > > > 
> > > > > Hervé
> > > > > 
> > > > > Le vendredi 24 mars 2017 04:17:49 CET, vous avez écrit :
> > > > > > See
> > > > > 
> > > > > https://builds.apache.org/job/maven-3.x-jenkinsfile/job/embedded-ITs
> > > > > /3/
> > > > > 
> > > > > 
> > > > > 
> > > > > 
> > > > > -
> > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > > > For additional commands, e-mail: dev-h...@maven.apache.org
> > > > > 
> > > > > --
> > > > 
> > > > Sent from my phone
> > 
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For 

Re: I am current working through the core release process

[Stephen Connolly]

On Sat 25 Mar 2017 at 12:11, Hervé BOUTEMY  wrote:

> Le samedi 25 mars 2017, 11:56:50 CET Stephen Connolly a écrit :
> > On 25 March 2017 at 11:56, Stephen Connolly <
> stephen.alan.conno...@gmail.com
> > > wrote:
> > >
> > > Ok I believe I have done everything...
> >
> > In other words, reply here if I have missed doing anything... I still
> want
> > to do anything I missed, but just let me know if I missed anything!
> while at it, perhaps one additional step would be to publish core-its run
> with
> the release: I did it (sorry, wasn't mean to help :) ...)
> http://maven.apache.org/core-its/core-it-suite/
>
> the publication itself is quite easy: just classical "mvn -Preporting site
> site:stage && mvn scm-publish:publish-scm"
>

Tsk tsk...

I want to ideally be able to run the whole thing on my personal Jenkins so
that it has access to my password and gpg key


> Regards,
>
> Hervé
>
> >
> > > Ugh this is a mess for the core release procedure. I think it will take
> > > another release for me to write it all down and then maybe propose
> updates
> > > to the process for 3.5.1
> > >
> > > On 25 March 2017 at 10:38, Hervé BOUTEMY 
> wrote:
> > >> Le samedi 25 mars 2017, 09:57:31 CET Stephen Connolly a écrit :
> > >> > Please do *not* help.
> > >>
> > >> yes, useful to ask explicitely for that: not usual :)))
> > >>
> > >> > I need to check that I have the full process and some
> > >> > people "helped" for alpha-1.
> > >> >
> > >> > The current process as written needs improvements but I need to do
> the
> > >> > whole thing to be sure on the changes I'd like to propose
> > >> >
> > >> > -Stephen
> > >>
> > >> -
> > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > >> For additional commands, e-mail: dev-h...@maven.apache.org
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone

Re: I am current working through the core release process

[Hervé BOUTEMY]

Le samedi 25 mars 2017, 11:56:50 CET Stephen Connolly a écrit :
> On 25 March 2017 at 11:56, Stephen Connolly  > wrote:
> > 
> > Ok I believe I have done everything...
> 
> In other words, reply here if I have missed doing anything... I still want
> to do anything I missed, but just let me know if I missed anything!
while at it, perhaps one additional step would be to publish core-its run with 
the release: I did it (sorry, wasn't mean to help :) ...) 
http://maven.apache.org/core-its/core-it-suite/

the publication itself is quite easy: just classical "mvn -Preporting site 
site:stage && mvn scm-publish:publish-scm"

Regards,

Hervé

> 
> > Ugh this is a mess for the core release procedure. I think it will take
> > another release for me to write it all down and then maybe propose updates
> > to the process for 3.5.1
> > 
> > On 25 March 2017 at 10:38, Hervé BOUTEMY  wrote:
> >> Le samedi 25 mars 2017, 09:57:31 CET Stephen Connolly a écrit :
> >> > Please do *not* help.
> >> 
> >> yes, useful to ask explicitely for that: not usual :)))
> >> 
> >> > I need to check that I have the full process and some
> >> > people "helped" for alpha-1.
> >> > 
> >> > The current process as written needs improvements but I need to do the
> >> > whole thing to be sure on the changes I'd like to propose
> >> > 
> >> > -Stephen
> >> 
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> >> For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [2/2] maven git commit: [MNG-6113] Rename the 'Central Repository' to 'Maven Central Repository' in the 4.0.0 super POM.

[Stephen Connolly]

FTR, this was a commit on a branch and the branch is now deleted... so all
is OK here

On 25 March 2017 at 08:29, Stephen Connolly  wrote:

> Is this withdrawn or where is the revert commit?
>
> On Tue 21 Mar 2017 at 18:44, Hervé BOUTEMY  wrote:
>
>> -1
>>
>> see MNG-5164
>>
>> Regards,
>>
>> Hervé
>>
>> Le mardi 21 mars 2017, 18:20:21 CET schu...@apache.org a écrit :
>> > [MNG-6113] Rename the 'Central Repository' to 'Maven Central
>> Repository' in
>> > the 4.0.0 super POM.
>> >
>> >
>> > Project: http://git-wip-us.apache.org/repos/asf/maven/repo
>> > Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/0f0040a1
>> > Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/0f0040a1
>> > Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/0f0040a1
>> >
>> > Branch: refs/heads/MNG-6113
>> > Commit: 0f0040a1915bfd14cf60342eb1680ed59eaea92b
>> > Parents: 27ab750
>> > Author: Christian Schulte 
>> > Authored: Tue Mar 21 00:31:53 2017 +0100
>> > Committer: Christian Schulte 
>> > Committed: Tue Mar 21 19:20:00 2017 +0100
>> >
>> > --
>> >  .../src/main/resources/org/apache/maven/model/pom-4.0.0.xml  | 4
>> ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> > --
>> >
>> >
>> > http://git-wip-us.apache.org/repos/asf/maven/blob/0f0040a1/
>> maven-model-build
>> > er/src/main/resources/org/apache/maven/model/pom-4.0.0.xml
>> > --
>> diff
>> > --git
>> > a/maven-model-builder/src/main/resources/org/apache/
>> maven/model/pom-4.0.0.x
>> > ml
>> > b/maven-model-builder/src/main/resources/org/apache/
>> maven/model/pom-4.0.0.x
>> > ml index 9487a9a..c9770b0 100644
>> > ---
>> > a/maven-model-builder/src/main/resources/org/apache/
>> maven/model/pom-4.0.0.x
>> > ml +++
>> > b/maven-model-builder/src/main/resources/org/apache/
>> maven/model/pom-4.0.0.x
>> > ml @@ -26,7 +26,7 @@ under the License.
>> >
>> >  
>> >central
>> > -  Central Repository
>> > +  Maven Central Repository
>> >https://repo.maven.apache.org/maven2
>> >default
>> >
>> > @@ -41,7 +41,7 @@ under the License.
>> >
>> >  
>> >central
>> > -  Central Repository
>> > +  Maven Central Repository
>> >https://repo.maven.apache.org/maven2
>> >default
>> >
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>> --
> Sent from my phone
>

Re: I am current working through the core release process

[Stephen Connolly]

On 25 March 2017 at 11:56, Stephen Connolly  wrote:

> Ok I believe I have done everything...
>
>
In other words, reply here if I have missed doing anything... I still want
to do anything I missed, but just let me know if I missed anything!



> Ugh this is a mess for the core release procedure. I think it will take
> another release for me to write it all down and then maybe propose updates
> to the process for 3.5.1
>
> On 25 March 2017 at 10:38, Hervé BOUTEMY  wrote:
>
>> Le samedi 25 mars 2017, 09:57:31 CET Stephen Connolly a écrit :
>> > Please do *not* help.
>> yes, useful to ask explicitely for that: not usual :)))
>>
>> > I need to check that I have the full process and some
>> > people "helped" for alpha-1.
>> >
>> > The current process as written needs improvements but I need to do the
>> > whole thing to be sure on the changes I'd like to propose
>> >
>> > -Stephen
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>>
>

Re: I am current working through the core release process

[Stephen Connolly]

Ok I believe I have done everything...

Ugh this is a mess for the core release procedure. I think it will take
another release for me to write it all down and then maybe propose updates
to the process for 3.5.1

On 25 March 2017 at 10:38, Hervé BOUTEMY  wrote:

> Le samedi 25 mars 2017, 09:57:31 CET Stephen Connolly a écrit :
> > Please do *not* help.
> yes, useful to ask explicitely for that: not usual :)))
>
> > I need to check that I have the full process and some
> > people "helped" for alpha-1.
> >
> > The current process as written needs improvements but I need to do the
> > whole thing to be sure on the changes I'd like to propose
> >
> > -Stephen
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

[Igor Fedorenko]

Good description, Hervé. One small addition. I believe -Pembedded
enables "auto" mode, where verifier uses "forked" mode for tests that
set environment variables and "embedded" mode for all other cases.
Individual ITs can still force forked mode with verifier.setForkJvm, of
course.

-- 
Regards,
Igor

On Sat, Mar 25, 2017, at 01:02 AM, Hervé BOUTEMY wrote:
> ok, let's share what I know from embedded ITs (sorry, long email, but
> IMHO 
> useful to share some details):
> 
> - by default, Verifier forks for every IT and launches Maven with the
> shell 
> script through ForkedLauncher [1]
> 
> - in embedded mode, there is no fork but use of MavenCli.doMain(String[]
> args, 
> workingDir, stdin, stdout) by Embedded3xLauncher [2], which will recreate
> a 
> Classworlds classloader context in the current JVM: AFAIK, this makes the 
> embedded situation really the same as forked one from a classloader point
> of 
> view, with CLI args passed, working dir, stdin and stdout
> 
> - a few ITs require shell script and don't have any meaning without it:
> in 
> this case, even if the build is in embedded mode, the IT forces the
> Verifier to 
> used forked execution, for example in mng5889 [3]
> 
> - every IT that we want absolutely not to be embedded has to do this 
> "verifier.setForkJvm( true );" call, or the IT won't be in expected
> situation: 
> as you point out, mng4625 currently does not do this call, then may not
> be 
> really effective with the embedded profile. This can be considered as a
> bug and 
> explains why currently this IT fails in my "embedded-ITs" branch => I'll 
> improve now the IT to support the embedded profile by forcing forked
> execution 
> :)
> 
> 
> Now that I wrote this, summarizing what I knew and what was already
> reported 
> as issues, it looks to me that embedded mode may trigger a few failures
> that 
> can and should be fixed by forcing forked execution (which won't change
> the 
> overall effect: most ITs will run embedded then execution time will be a
> lot 
> lower than full forked execution)
> 
> the only risk is that some ITs don't fail when run in embedded mode but
> in 
> fact don't really test what they are supposed to test
> 
> This seems a reasonable risk to take here, given the benefit: we'll
> improve ITs 
> if necessary.
> If nobody objects, I'll do the merge to master in a few days
> 
> Regards,
> 
> Hervé
> 
> [1]
> http://maven.apache.org/shared/maven-verifier/xref/org/apache/maven/it/
> ForkedLauncher.html#L60
> 
> [2]
> http://maven.apache.org/ref/3.5.0-beta-1/maven-embedder/xref/org/apache/
> maven/cli/MavenCli.html#L262
> 
> [3]
> https://github.com/apache/maven-integration-testing/blob/master/core-it-suite/src/test/java/org/apache/maven/it/
> MavenITmng5889CoreExtensionsTest.java#L57
> 
> Le vendredi 24 mars 2017, 21:29:38 CET Olivier Lamy a écrit :
> > sure tempting :-)
> > But is is the same classloader mechanism as a "normal" Maven run? (should
> > be really close but not sure exactly so maybe we can miss some cases)
> > 
> > On Fri, 24 Mar 2017 at 6:47 pm, Stephen Connolly <
> > 
> > stephen.alan.conno...@gmail.com> wrote:
> > > Have we some of the tests running in both modes?
> > > 
> > > Specifically at least 4625 as it caught some interesting CLI parsing
> > > issues, but there may be a couple more
> > > 
> > > On Fri 24 Mar 2017 at 07:15, Hervé Boutemy  wrote:
> > > > as you can see, in embedded mode, core ITs can run in 17 minutes, when
> > > > in
> > > > classic mode they run in 1h30
> > > > 
> > > > any objection to merge this embedded mode into master?
> > > > 
> > > > Regards,
> > > > 
> > > > Hervé
> > > > 
> > > > Le vendredi 24 mars 2017 04:17:49 CET, vous avez écrit :
> > > > > See
> > > > 
> > > > https://builds.apache.org/job/maven-3.x-jenkinsfile/job/embedded-ITs/3/
> > > > 
> > > > 
> > > > 
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > > For additional commands, e-mail: dev-h...@maven.apache.org
> > > > 
> > > > --
> > > 
> > > Sent from my phone
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Build failed in Jenkins: core-integration-testing-maven-3-embedded #7571

[Hervé BOUTEMY]

I could not figure out why this job, that launches core ITs in embedded mode, 
does fail: il looks that it's more strict on avoiding downloading dependencies 
during ITs

but I can't reproduce the failure on my desktop: I don't understand what makes 
the repository so strict

Any idea?

Regards,

Hervé

Le samedi 25 mars 2017, 10:37:58 CET Apache Jenkins Server a écrit :
> See
>  71/display/redirect?page=changes>
> 
> Changes:
> 
> [hboutemy] upgraded parent pom to benefit from site staging configuration
> 
> --
> [...truncated 1.46 MB...]
> [INFO]
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ servlet ---
> [INFO] No tests to run.
> [INFO]
> [INFO]
> 
> [INFO] Building enterprise java beans 1.0
> [INFO]
> 
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ ejbs
> --- [WARNING] Using platform encoding (UTF-8 actually) to copy filtered
> resources, i.e. build is platform dependent! [INFO] Copying 1 resource
> [INFO]
> [INFO] --- maven-compiler-plugin:2.0.2:compile (default-compile) @ ejbs ---
> [INFO] No sources to compile
> [INFO]
> [INFO] --- maven-resources-plugin:2.7:testResources (default-testResources)
> @ ejbs --- [WARNING] Using platform encoding (UTF-8 actually) to copy
> filtered resources, i.e. build is platform dependent! [INFO] skip non
> existing resourceDirectory
>  /core-integration-testing-trunk/core-it-suite/target/test-classes/mng-5898/e
> jbs/src/test/resources> [INFO]
> [INFO] --- maven-compiler-plugin:2.0.2:testCompile (default-testCompile) @
> ejbs --- [INFO] No sources to compile
> [INFO]
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ ejbs ---
> [INFO] No tests to run.
> [INFO]
> [INFO]
> 
> [INFO] Building ear assembly 1.0
> [INFO]
> 
> [INFO]
> [INFO] --- maven-ear-plugin:2.8:generate-application-xml
> (default-generate-application-xml) @ ear --- [INFO] Downloading:
> file:target/null/org/codehaus/plexus/plexus-archiver/2.1.2/plexus-archiver-
> 2.1.2.pom [WARNING] The POM for
> org.codehaus.plexus:plexus-archiver:jar:2.1.2 is missing, no dependency
> information available [INFO] Downloading:
> file:target/null/org/apache/maven/shared/maven-filtering/1.0-beta-2/maven-f
> iltering-1.0-beta-2.pom [WARNING] The POM for
> org.apache.maven.shared:maven-filtering:jar:1.0-beta-2 is missing, no
> dependency information available [INFO]
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] project  SUCCESS [  0.001
> s] [INFO] sub projects ... SUCCESS [ 
> 0.000 s] [INFO] logging 
> SUCCESS [  0.407 s] [INFO] core project classes
> ... SUCCESS [  0.030 s] [INFO] servlets
> ... SUCCESS [  0.000 s] [INFO]
> servlet  SUCCESS [  0.011 s]
> [INFO] enterprise java beans .. SUCCESS [ 
> 0.048 s] [INFO] ear assembly ...
> FAILURE [  0.033 s] [INFO]
> 
> [INFO] BUILD FAILURE
> [INFO]
> 
> [INFO] Total time: 0.561 s
> [INFO] Finished at: 2017-03-25T10:29:59Z
> [INFO] Final Memory: 15M/279M
> [INFO]
> 
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-ear-plugin:2.8:generate-application-xml
> (default-generate-application-xml) on project ear: Execution
> default-generate-application-xml of goal
> org.apache.maven.plugins:maven-ear-plugin:2.8:generate-application-xml
> failed: Plugin org.apache.maven.plugins:maven-ear-plugin:2.8 or one of its
> dependencies could not be resolved: The following artifacts could not be
> resolved: org.apache.maven:maven-plugin-parameter-documenter:jar:2.0.6,
> org.apache.maven:maven-error-diagnostics:jar:2.0.6,
> org.apache.maven:maven-plugin-descriptor:jar:2.0.6: Failure to find
> org.apache.maven:maven-plugin-parameter-documenter:jar:2.0.6 in
> file:target/null was cached in the local repository, resolution will not be
> reattempted until the update interval of central has elapsed or updates are
> forced -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException:
> Failed to execute goal
> 

Re: I am current working through the core release process

[Hervé BOUTEMY]

Le samedi 25 mars 2017, 09:57:31 CET Stephen Connolly a écrit :
> Please do *not* help.
yes, useful to ask explicitely for that: not usual :)))

> I need to check that I have the full process and some
> people "helped" for alpha-1.
> 
> The current process as written needs improvements but I need to do the
> whole thing to be sure on the changes I'd like to propose
> 
> -Stephen



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

I am current working through the core release process

[Stephen Connolly]

Please do *not* help. I need to check that I have the full process and some
people "helped" for alpha-1.

The current process as written needs improvements but I need to do the
whole thing to be sure on the changes I'd like to propose

-Stephen
-- 
Sent from my phone

[ANN] Apache Maven 3.5.0-beta-1 Released

[Stephen Connolly]

The Apache Maven team would like to announce the release of Maven
3.5.0-beta-1.

http://maven.apache.org/

NOTE: This is an BETA release. There is the potential that features may be
removed between this release and the first GA release in the 3.5.x release
line.
Please consult the Known Issues section below before use

You can download the appropriate sources, etc. from the archives section on
the download page as Maven 3.3.9 is still the recommended GA release

https://archive.apache.org/dist/maven/maven-3/3.5.0-beta-1/

Known Issues

The following issues were identified during release testing of this ALPHA
release but have not been deemed as release blockers:

* [MNG-6190] maven-resolver-provider's `DefaultArtifactDescriptorReader`
has mismatched constructor and initService methods (this issue does not
affect normal usage of Maven)
* [MNG-6191] `mvn -f` complains about illegal `readlink` option under macOS
* [MNG-6192] The distribution zip file has unordered entries and some tools
- most notably Maven wrapper - will fail to unzip the distribution

Why not Maven 3.4.0?

After Maven 3.3.9 was released, the Eclipse Aether project was retired and
the code base was migrated to the Apache Maven project.

The original goal for the 3.4.0 release was to replace Aether with the
exact same code after migration to the Apache Maven project and then
proceed with bug fixes to the resolver code as well as other areas of Maven.

The migration of the code between the two foundations took longer than
expected and as a result there were other changes committed to Maven core
that were outside the scope of intent for 3.4.0.

In order to refocus on the original intent for 3.4.0, the decision was
taken to revert the Maven core history to the point of the 3.3.9 release
and merge in the desired changes one at a time.

Because there had been a lot of communication about different features
being delivered and bugs fixed in Maven 3.4.0 and the new history may not
contain them in the first release, the decision was taken to forever burn
the 3.4.x release line.

More detail on this decision can be read in the [mailing list archive](
http://www.mail-archive.com/dev@maven.apache.org/msg112103.html).

Release Notes - Maven - Version 3.5.0-beta-1

** Bug
* [MNG-5895] - Problem with CI friendly usage of ${..} which is already
defined via property in pom file.
* [MNG-6057] - Problem with CI friendly usage of ${..} reactor order is
changed
* [MNG-6090] - CI friendly properties break submodule builds
* [MNG-6170] - NPE in cases using Multithreaded -T X versions:set
-DnewVersion=1.0-SNAPSHOT
* [MNG-6173] - MavenSession.getAllProjects() should return all projects
in the reactor
* [MNG-6176] - Javadoc errors prevent release with Java 8
* [MNG-6177] - The --file command line option of the Windows and Unix
launchers does not work for directory names like "Spaces & Special Char"
* [MNG-6180] - groupId has plain color when goal fails
* [MNG-6181] - HttpClient produces a lot of noise at debug loglevel
* [MNG-6183] - Dependency management debug message corrections.

** Improvement
* [MNG-6078] - Can't overwrite properties which have been defined in
.mvn/maven.config
* [MNG-6115] - Add Jansi native library search path to our start
scripts to avoid extraction to temp file on each run
* [MNG-6179] - Remove unused prerequisites
* [MNG-6189] - WARN if maven-site-plugin configuration contains
reportPlugins element

** New Feature
* [MNG-6182] - ModelResolver interface enhancement: addition of
resolveModel( Dependency ) supporting version ranges


















-- 
Sent from my phone

Re: [2/2] maven git commit: [MNG-6113] Rename the 'Central Repository' to 'Maven Central Repository' in the 4.0.0 super POM.

[Stephen Connolly]

Is this withdrawn or where is the revert commit?

On Tue 21 Mar 2017 at 18:44, Hervé BOUTEMY  wrote:

> -1
>
> see MNG-5164
>
> Regards,
>
> Hervé
>
> Le mardi 21 mars 2017, 18:20:21 CET schu...@apache.org a écrit :
> > [MNG-6113] Rename the 'Central Repository' to 'Maven Central Repository'
> in
> > the 4.0.0 super POM.
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/0f0040a1
> > Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/0f0040a1
> > Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/0f0040a1
> >
> > Branch: refs/heads/MNG-6113
> > Commit: 0f0040a1915bfd14cf60342eb1680ed59eaea92b
> > Parents: 27ab750
> > Author: Christian Schulte 
> > Authored: Tue Mar 21 00:31:53 2017 +0100
> > Committer: Christian Schulte 
> > Committed: Tue Mar 21 19:20:00 2017 +0100
> >
> > --
> >  .../src/main/resources/org/apache/maven/model/pom-4.0.0.xml  | 4
> ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > --
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/maven/blob/0f0040a1/maven-model-build
> > er/src/main/resources/org/apache/maven/model/pom-4.0.0.xml
> > --
> diff
> > --git
> >
> a/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> > ml
> >
> b/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> > ml index 9487a9a..c9770b0 100644
> > ---
> >
> a/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> > ml +++
> >
> b/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.x
> > ml @@ -26,7 +26,7 @@ under the License.
> >
> >  
> >central
> > -  Central Repository
> > +  Maven Central Repository
> >https://repo.maven.apache.org/maven2
> >default
> >
> > @@ -41,7 +41,7 @@ under the License.
> >
> >  
> >central
> > -  Central Repository
> > +  Maven Central Repository
> >https://repo.maven.apache.org/maven2
> >default
> >
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Sent from my phone

Re: [2/2] maven git commit: [MNG-6113] Rename the 'Central Repository' to 'Maven Central Repository' in the 4.0.0 super POM.

[Hervé BOUTEMY]

Le mardi 21 mars 2017, 19:51:08 CET Christian Schulte a écrit :
> Am 03/21/17 um 19:44 schrieb Hervé BOUTEMY:
> > -1
> > 
> > see MNG-5164
> 
> Thanks for pointing this out.
you know, it's just a "git blame": our convention that comment starts with the 
Jira id is really great to give more sense to our codebase evolution

And that's why having good descriptions in Jira issues is also critical: it 
will be read years after being written, by someone trying to figure out why a 
code is written like it is (because now it looks like a bug...).

That makes me remember you that MNG-6183 is waiting for such a description 
(and MNG-6182 for a review since I did what I saw from code change, but I may 
have missed some important points)

> I closed the issue "Won't Fix" and flagged
> it a duplicate of MNG-5164. Branch is dropped.
thank you

> This would have went unnoticed into the 3.4.0 release :-).
no, that was not unnoticed: that was only evaluated and chosen to be not told, 
focusing on more critical issues (to avoid adding even more pressure on more 
different topics: focus on priorities...)

Regards,

Hervé

> 
> Regards,



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

[Olivier Lamy]

Sounds a very good to speed up it execution!

On Sat, 25 Mar 2017 at 4:02 pm, Hervé BOUTEMY  wrote:

> ok, let's share what I know from embedded ITs (sorry, long email, but IMHO
> useful to share some details):
>
> - by default, Verifier forks for every IT and launches Maven with the shell
> script through ForkedLauncher [1]
>
> - in embedded mode, there is no fork but use of MavenCli.doMain(String[]
> args,
> workingDir, stdin, stdout) by Embedded3xLauncher [2], which will recreate a
> Classworlds classloader context in the current JVM: AFAIK, this makes the
> embedded situation really the same as forked one from a classloader point
> of
> view, with CLI args passed, working dir, stdin and stdout
>
> - a few ITs require shell script and don't have any meaning without it: in
> this case, even if the build is in embedded mode, the IT forces the
> Verifier to
> used forked execution, for example in mng5889 [3]
>
> - every IT that we want absolutely not to be embedded has to do this
> "verifier.setForkJvm( true );" call, or the IT won't be in expected
> situation:
> as you point out, mng4625 currently does not do this call, then may not be
> really effective with the embedded profile. This can be considered as a
> bug and
> explains why currently this IT fails in my "embedded-ITs" branch => I'll
> improve now the IT to support the embedded profile by forcing forked
> execution
> :)
>
>
> Now that I wrote this, summarizing what I knew and what was already
> reported
> as issues, it looks to me that embedded mode may trigger a few failures
> that
> can and should be fixed by forcing forked execution (which won't change the
> overall effect: most ITs will run embedded then execution time will be a
> lot
> lower than full forked execution)
>
> the only risk is that some ITs don't fail when run in embedded mode but in
> fact don't really test what they are supposed to test
>
> This seems a reasonable risk to take here, given the benefit: we'll
> improve ITs
> if necessary.
> If nobody objects, I'll do the merge to master in a few days
>
> Regards,
>
> Hervé
>
> [1]
> http://maven.apache.org/shared/maven-verifier/xref/org/apache/maven/it/
> ForkedLauncher.html#L60
> 
>
> [2]
> http://maven.apache.org/ref/3.5.0-beta-1/maven-embedder/xref/org/apache/
> maven/cli/MavenCli.html#L262
> 
>
> [3]
> https://github.com/apache/maven-integration-testing/blob/master/core-it-suite/src/test/java/org/apache/maven/it/
> MavenITmng5889CoreExtensionsTest.java#L57
> 
>
> Le vendredi 24 mars 2017, 21:29:38 CET Olivier Lamy a écrit :
> > sure tempting :-)
> > But is is the same classloader mechanism as a "normal" Maven run? (should
> > be really close but not sure exactly so maybe we can miss some cases)
> >
> > On Fri, 24 Mar 2017 at 6:47 pm, Stephen Connolly <
> >
> > stephen.alan.conno...@gmail.com> wrote:
> > > Have we some of the tests running in both modes?
> > >
> > > Specifically at least 4625 as it caught some interesting CLI parsing
> > > issues, but there may be a couple more
> > >
> > > On Fri 24 Mar 2017 at 07:15, Hervé Boutemy 
> wrote:
> > > > as you can see, in embedded mode, core ITs can run in 17 minutes,
> when
> > > > in
> > > > classic mode they run in 1h30
> > > >
> > > > any objection to merge this embedded mode into master?
> > > >
> > > > Regards,
> > > >
> > > > Hervé
> > > >
> > > > Le vendredi 24 mars 2017 04:17:49 CET, vous avez écrit :
> > > > > See
> > > >
> > > >
> https://builds.apache.org/job/maven-3.x-jenkinsfile/job/embedded-ITs/3/
> > > >
> > > >
> > > >
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > > For additional commands, e-mail: dev-h...@maven.apache.org
> > > >
> > > > --
> > >
> > > Sent from my phone
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
> --
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

CMS diff:

[Sam]

Clone URL (Committers only):
https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://maven.apache.org/markdown%2Fcontinuous-integration.md

Sam

Index: trunk/content/markdown/continuous-integration.md
===
--- trunk/content/markdown/continuous-integration.md(revision 1655891)
+++ trunk/content/markdown/continuous-integration.md(working copy)
@@ -5,12 +5,13 @@
 Following is an alphabetical list of some CI servers we've heard
 mentioned around the Maven community:
 
--   [Apache Continuum](http://continuum.apache.org/)
--   [Bamboo (Atlassian)](http://www.atlassian.com/software/bamboo/)
--   [BuildHive (CouldBees)](https://buildhive.cloudbees.com/)
--   [CODESHIP](https://codeship.com/)
--   [Cruise Control](http://cruisecontrol.sourceforge.net/)
--   [Hudson](http://hudson-ci.org/)
--   [Jenkins](http://jenkins-ci.org/)
--   [TeamCity (JetBrains)](http://www.jetbrains.com/teamcity/)
--   [Travis](https://travis-ci.org/)
+  -   [Apache Continuum](http://continuum.apache.org/)
+  -   [Bamboo (Atlassian)](http://www.atlassian.com/software/bamboo/)
+  -   [BuildHive (CouldBees)](https://buildhive.cloudbees.com/)
+  -   [CircleCI - Continuous Integration](https://circleci.com/)
+  -   [CODESHIP](https://codeship.com/)
+  -   [Cruise Control](http://cruisecontrol.sourceforge.net/)
+  -   [Hudson](http://hudson-ci.org/)
+  -   [Jenkins](http://jenkins-ci.org/)
+  -   [TeamCity (JetBrains)](http://www.jetbrains.com/teamcity/)
+  -   [Travis](https://travis-ci.org/)


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: What to do with the 6 issues left as 3.5.0-candidates?

[Hervé BOUTEMY]

for the sake of completeness, there are 2 issues which have been merged to 
master a few hours after beta-1 vote started, without asking for review:

MNG-6112
MNG-6190

MNG-6190 looks like a stupid bug that was reported just after the vote 
started: looks like a safe option to integrate it, I'm ok on the result (not 
on the way it has been merged)

MNG-6112 is harder to estimate side effects IMHO
and since this has been available for a long time, I'm really not satisfied 
that it has been integrated *after vote for 3.0.5-beta-1 started* (and in 
addition without any discussion)

 I'd say punt to 3.5.1: benefit is not worth the risk for now (we lived for 
years with that, we can stay with it for a couple of months to have wider 
tests)

Regards,

Hervé

Le vendredi 24 mars 2017, 10:45:14 CET Stephen Connolly a écrit :
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20fixVe
> rsion%20%3D%203.5.0-candidate%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> 
> Here is my opinions:
> 
> https://issues.apache.org/jira/browse/MNG-6167 - it's too late now. punt to
> 3.5.1
> 
> https://issues.apache.org/jira/browse/MNG-6168 - If this is available and
> ready quickly (i.e. in the next week), we can review the changes and assess
> the risk
> 
> https://issues.apache.org/jira/browse/MNG-6186 - looks like not merged and
> released upstream yet... punt to 3.5.1
> 
> https://issues.apache.org/jira/browse/MNG-6188 - it's too late now. punt to
> 3.5.1 (anyway I see similar issues with other native tooling that uses
> console colouring)
> 
> https://issues.apache.org/jira/browse/MNG-6169 - definitely too late. punt
> to 3.5.1
> 
> https://issues.apache.org/jira/browse/MNG-6185 - sounds like only a javadoc
> change. If available quickly should be ok
> 
> If there is agreement then I will move MNG-6185 and MNG-6168 into fix for
> 3.5.0 and the rest to 3.5.1-candidates



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: What to do with the 6 issues left as 3.5.0-candidates?

[Hervé BOUTEMY]

I'd prefer to avoid all the "final" modifiers appearing from time to time: our 
convention is not to use final modifier

Regards,

Hervé

Le vendredi 24 mars 2017, 22:07:34 CET Christian Schulte a écrit :
> Am 03/24/17 um 11:45 schrieb Stephen Connolly:
> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20fix
> > Version%20%3D%203.5.0-candidate%20AND%20resolution%20%3D%20Unresolved%20OR
> > DER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> > 
> > Here is my opinions:
> > 
> > https://issues.apache.org/jira/browse/MNG-6168 - If this is available and
> > ready quickly (i.e. in the next week), we can review the changes and
> > assess
> > the risk
> 
> Branch is here:
>  /MNG-6168>
> 
> Commit is here:
>  c7630cc79adb98407db13315b4a709ee>
> 
> Will merge to master, as soon as the build job succeeds. It's just
> updates to use the try-with-resources statement instead of
> try-catch-finally with IOUtil.close.
> 
> Regards,



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: What to do with the 6 issues left as 3.5.0-candidates?

[Hervé BOUTEMY]

or we need testers interested in working on it, testing, reporting: not 
everything will come from infra (& associated bucks) but from community

Regards,

Hervé

Le samedi 25 mars 2017, 01:41:03 CET Christian Schulte a écrit :
> We really need Solaris and OSX Jenkins build nodes :-)
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: What to do with the 6 issues left as 3.5.0-candidates?

[Hervé BOUTEMY]

Le vendredi 24 mars 2017, 15:35:50 CET Robert Scholte a écrit :
> On Fri, 24 Mar 2017 14:51:22 +0100, Stephen Connolly
> 
>  wrote:
> > On 24 March 2017 at 10:51, Robert Scholte  wrote:
> >> On Fri, 24 Mar 2017 11:45:14 +0100, Stephen Connolly <
> >> stephen.alan.conno...@gmail.com> wrote:
> >> 
> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%
> >> 
> >>> 20MNG%20AND%20fixVersion%20%3D%203.5.0-candidate%20AND%20r
> >>> esolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%
> >>> 20priority%20DESC%2C%20created%20ASC
> >>> 
> >>> Here is my opinions:
> >>> 
> >>> https://issues.apache.org/jira/browse/MNG-6167 - it's too late now.
> >>> punt
> >>> to
> >>> 3.5.1
> >>> 
> >>> https://issues.apache.org/jira/browse/MNG-6168 - If this is available
> >>> and
> >>> ready quickly (i.e. in the next week), we can review the changes and
> >>> assess
> >>> the risk
> >>> 
> >>> https://issues.apache.org/jira/browse/MNG-6186 - looks like not merged
> >>> and
> >>> released upstream yet... punt to 3.5.1
> >>> 
> >>> https://issues.apache.org/jira/browse/MNG-6188 - it's too late now.
> >>> punt
> >>> to
> >>> 3.5.1 (anyway I see similar issues with other native tooling that uses
> >>> console colouring)
> >>> 
> >>> https://issues.apache.org/jira/browse/MNG-6169 - definitely too late.
> >>> punt
> >>> to 3.5.1
> >>> 
> >>> https://issues.apache.org/jira/browse/MNG-6185 - sounds like only a
> >>> javadoc
> >>> change. If available quickly should be ok
> >>> 
> >>> If there is agreement then I will move MNG-6185 and MNG-6168 into fix
> >>> for
> >>> 3.5.0 and the rest to 3.5.1-candidates
> >> 
> >> I agree on MNG-6185 and MNG-6168.
> >> 
> >> IMHO if MNG-6186 isn't fixed upstream upstream, we should fix it with
> >> our
> >> own proposed patch. If users see that their diskspace is decreasing and
> >> discover that the lib/ext if full of temporary files, they have a fair
> >> point to complain.
> > 
> > I think the remaining bit open there is to remove the duplicate code once
> > upstream has the required functionality. the disk space issue has been
> > fixed IIUC
> 
> Confirmed, I see apache-maven-3.5.0-beta-1/lib/jansi-native.
yes, this was MNG-6115 fix (done with some HawtJNI copy/paste inside :) )

> In that case let's push this one to 3.5.1
+1 that's my intent

> 
> >> All others can be pushed to 3.5.1
+1

> >> 
> >> Robert
> >> 
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> >> For additional commands, e-mail: dev-h...@maven.apache.org
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org