Re: Broken surefire defaults?

2018-02-25 Thread Romain Manni-Bucau
Great news, thanks a lot!

Le 25 févr. 2018 23:22, "Enrico Olivelli"  a écrit :

> Il dom 25 feb 2018, 22:42 Romain Manni-Bucau  ha
> scritto:
>
> > Hi guys
> >
> > Surefire sets some java 9 modules by default when running tests on j9.
> >
> > I understand the intention but it means surefire doesnt test accurately
> the
> > code in the build since you will pass the tests and fail at runtime
> pretry
> > easily a d with any embedded solution like spring boot, meecrowave, tomee
> > etc...
> >
> > A very common example is a missing jaxb dependency which would be hidden
> by
> > surefire (which means surefire swallowed a bug)
> >
> > I also know you can tune it to use java.base and therefore have a normal
> > behavior but to do that you need to know it.
> >
> > Since I saw several colleagues hitting this issue i think it is worth
> > mentionning it here and request if default can be aligned on the jvm
> > instead of trying to be too clever?
> >
>
>
> Hi with upcoming  2.21, hopefully released very soon, it will work as
> expected, it won't add java.ee.se module.
> In the meantime you can add -Dxx='--add-modules' to surefire argLine
> parameter and surefire won't add any module.
> Surefire 2.21 will also habdle module-path properly
>
> Cheers
> Enrico
>
> > --
>
>
> -- Enrico Olivelli
>


Re: [VOTE] Release Apache Maven JDeps Plugin version 3.1.1

2018-02-25 Thread Olivier Lamy
+1


On 24 February 2018 at 23:38, Robert Scholte  wrote:

> Hi,
>
> We solved 6 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> ctId=12319223=12341552=Text
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%
> 2012319223%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%
> 20DESC%2C%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1398
> https://repository.apache.org/content/repositories/maven-139
> 8/org/apache/maven/plugins/maven-jdeps-plugin/3.1.1/maven-
> jdeps-plugin-3.1.1-source-release.zip
>
> Source release checksum(s):
> maven-jdeps-plugin-3.1.1-source-release.zip sha1:
> 14638ed958c6fde194f4ddc5955ac476c3d40abe
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-jdeps-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy


Re: Prepared Maven 3.5.3 Release Notes

2018-02-25 Thread Olivier Lamy
Hi,
Nice work. Ok contributors are important but title of the issue as well and
as reading the release note I except to have the most important at the top
without need to scroll down to the far bottom.

What about
Bugs:

   - MNG-6323  - Deadlock
   in multithreaded dependency resolution (reported by xxx)

so IMHO it makes something shorter and easier to read.
With the current when I start reading it I see the issue number the person
who help and asking my self so what is the issue?

On 26 February 2018 at 01:00, Karl Heinz Marbaise  wrote:

> Hi Stephen,
>
> On 25/02/18 09:06, Stephen Connolly wrote:
>
>> On Sat 24 Feb 2018 at 21:02, Gary Gregory  wrote:
>>
>> Hi All,
>>>
>>> Thank you for preparing a release.
>>>
>>
>>
>> Well I managed to consolidate some of the steps for this one... I think it
>> will be nearer 20-25 steps, down from 30
>>
>> I’m still hoping to get to a more automated solution (modulo we need a
>> release vote)
>>
>> NOTE: this is not the final release notes, rather a draft... and until the
>> vote completes there is no release.
>>
>>
>>
>>> As a user, this is useless:
>>>
>>>
>> The Maven project *really* wants to express. as our most important thing
>> about any release, the debt of gratitude we owe to any non-committer who
>> contributes in any way to the release.
>>
>> If we included the issue description in this section, people would focus
>> on
>> the description and not the values contributors.
>>
>> Perhaps we could start this section with a sentence to this effect, eg
>>
>> “We really value the contributions of these non committers, so this
>> section
>> is focused on those individuals. Descriptions of the issues fixed can be
>> found at the end of these release notes”
>>
>
> That looks like a very good idea...Added to the draft state...Thanks for
> expressing that...
>
>
>
>>
>> Bugs:
>>>
>>> - MNG-6323 
>>> reporter:
>>> Ben Caradoc-Davies
>>> - MNG-6320 
>>> reporter:
>>> Eugene Pliskin
>>> - MNG-6300 
>>> reporter:
>>> Andreas Kurth
>>> - MNG-6298 
>>> reporter:
>>> Ryan Heaton
>>> - MNG-6296 
>>> reporter:
>>> Robin Müller
>>> - MNG-6282 
>>> reporter:
>>> Dejan Stojadinović
>>> - MNG-6255 
>>> reporter:
>>> Andrew Kennedy
>>>
>>> Improvements:
>>>
>>> - MNG-6340 
>>> reporter:
>>> Tony Guan
>>> - MNG-6306 
>>> reporter:
>>> Andy Wilkinson
>>> - MNG-5992 
>>> reporter:
>>> Ryan J. McDonough
>>>
>>> I need to see the ticket DESCRIPTION. I do not care about the AUTHOR.
>>>
>>> Thank you,
>>> Gary
>>>
>>> On Sat, Feb 24, 2018 at 1:47 PM, Karl Heinz Marbaise 
>>> wrote:
>>>
>>> Hi to all,

 I have prepared Maven 3.5.3 Release notes.

 You can take a look here:

 https://github.com/khmarbaise/maven-release-notes/blob/maste
 r/content/markdown/docs/3.5.3/release-notes.md

 If you have improvements/ideas/supplementals etc. don't hesitate to
 contact me or make a PR...

 Kind regards
 Karl Heinz Marbaise

 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org



>>>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy


Re: Surefire roadmap

2018-02-25 Thread Enrico Olivelli
Il dom 25 feb 2018, 21:45 Tibor Digana  ha scritto:

> Hi Enrico,
>
> Sorry for notifying.
> I would like to ask you for a help.
> Maybe you can see my previous e-mail in this thread on mailing list with
> CLI running a build on the branch SUREFIRE-1489.
> Can you please try to run the build on your side and let us know the
> result?
> I appreciate!
>

Sure will do tomorrow, today I have run tests with jdk8 on that non
masterbranch and all worked well. The suite takes very long time so I will
try tomorrow with jdk10

Master is broken for me too, but we already knew

Enrico


> (If the CLI command is not clear, do not hesitate to ask beforehand.)
>
> Thx
> Tibor
>
>
> On Sun, Feb 25, 2018 at 9:34 PM, Tibor Digana 
> wrote:
>
>> Hey guys,
>>
>> We really do not properly read the e-mails.
>> All the links you sent me was from master branch.
>>
>> We are NOT working in master branch. Do not test master yet.
>>
>> Our focus is the branch named "SUREFIRE-1489".
>> Please run only the build on branch "SUREFIRE-1489" and nothing else yet.
>> We should proceed step by step.
>>
>> Please try to be patient and:
>> $ git clone 
>> $ git fetch
>> $ git checkout SUREFIRE-1489
>> $ mvn clean install -nsu -P run-its -Djdk.home=/path/to/jdk10
>> -Djacoco.skip=true
>>
>> I will be waiting.
>>
>> All my previous emails about ASF Jenkins was from the branch
>> "SUREFIRE-1489"  and not the master.
>>
>> With Best Regards
>> Tibor
>>
>>
>> On Sun, Feb 25, 2018 at 1:20 PM, Olivier Lamy  wrote:
>>
> something very interesting on my side.
>>> It works with empty on ASF Jenkins:
>>> https://builds.apache.org/view/M-R/view/Maven/job/maven-surefire-fs/
>>>
>> But not in this Jenkins
>>> https://jenkins.webtide.net/job/sandbox/job/surefire-master-jdk8/5/console
>>>  or using Travis
>>> https://travis-ci.org/olamy/maven-surefire/builds/345892147
>>>
>> Sorry I cannot test locally with an empty repo as my internet is very
>>> slow today.
>>> but anyway we should not have a build with a need of an empty repo...
>>> Funny as ironically the Maven team cannot have a stable build working
>>> everywhere :-)
>>>
>>
>>> On 25 February 2018 at 19:45, Robert Scholte 
>>> wrote:
>>>
 Hi all,

 I'm on *master* and simply running 'mvn clean verify' and the unittests
 of Surefire Bootstrap fail.
 I get 28 errors, which can be brought back into 2 exceptions:
 - java.lang.NoClassDefFoundError: Could not initialize class
 org.apache.maven.surefire.booter.SystemUtils
 - java.lang.NoClassDefFoundError: org/apache/commons/lang3/SystemUtils
   Caused by: java.lang.ClassNotFoundException:
 org.apache.commons.lang3.JavaVersion

 I've removed my local repository, same result.

 Robert

 On Sun, 25 Feb 2018 04:04:02 +0100, Tibor Digana <
 tibordig...@apache.org> wrote:

 Hello Olivier, Robert,

 I think this issue you saw was caused by the old hack with
 commons-lang3 in module surefire-booter/pom.xml.
 I reproduced it on WindowsXP but not on Windows7, funny.
 I removed the change in the pom.xml and committed (git push force) to
 our branch SUREFIRE-1489. Now the branch SUREFIRE-1489 contains changes
 from three JIRAs, but that's ok, we will create new ones according to 
 Jiras.
 I run this command:

 mvn clean install -P run-its -Dintegration-test-port=8000 
 -Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program Files\Java\jdk10" 
 -Djacoco.skip=true

 I am overriding the branch, so it is better to clone it fresh.

 Please let me know if it is fine on your side.

 With Best Regards,
 Tibor




 On Sun, Feb 25, 2018 at 2:51 AM, Tibor Digana 
 wrote:

> Try to delete local maven repository on Travis and run the branch
> SUREFIRE-1489 with --no-snapshot-updates.
> I hope we will have good results.
> Good night!
>
> On Sun, Feb 25, 2018 at 2:34 AM, Tibor Digana 
> wrote:
>
>> What branch is for the build /maven-surefire-fs?
>> Any special build configuration or sources are different from master?
>>
>> On Sun, Feb 25, 2018 at 2:28 AM, Olivier Lamy 
>> wrote:
>>
>>> Did you read my emails? The thread with subject " [3/3]
>>> maven-surefire git
>>> commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on
>>> jdk10" "
>>> I assume no so here few links
>>> https://builds.apache.org/view/M-R/view/Maven/job/maven-
>>> surefire-fs/2/console
>>>
>>> https://jenkins.webtide.net/job/sandbox/job/surefire-master-jdk8/4/console
>>> https://travis-ci.org/olamy/maven-surefire/builds/345611495
>>>
>>> There are all Jenkins or Travis builds with an empty maven repo.
>>>
>>>
>>>
>>> On 25 February 2018 at 

Re: Broken surefire defaults?

2018-02-25 Thread Enrico Olivelli
Il dom 25 feb 2018, 22:42 Romain Manni-Bucau  ha
scritto:

> Hi guys
>
> Surefire sets some java 9 modules by default when running tests on j9.
>
> I understand the intention but it means surefire doesnt test accurately the
> code in the build since you will pass the tests and fail at runtime pretry
> easily a d with any embedded solution like spring boot, meecrowave, tomee
> etc...
>
> A very common example is a missing jaxb dependency which would be hidden by
> surefire (which means surefire swallowed a bug)
>
> I also know you can tune it to use java.base and therefore have a normal
> behavior but to do that you need to know it.
>
> Since I saw several colleagues hitting this issue i think it is worth
> mentionning it here and request if default can be aligned on the jvm
> instead of trying to be too clever?
>


Hi with upcoming  2.21, hopefully released very soon, it will work as
expected, it won't add java.ee.se module.
In the meantime you can add -Dxx='--add-modules' to surefire argLine
parameter and surefire won't add any module.
Surefire 2.21 will also habdle module-path properly

Cheers
Enrico

> --


-- Enrico Olivelli


Re: Surefire roadmap

2018-02-25 Thread Olivier Lamy
On 26 February 2018 at 06:34, Tibor Digana  wrote:

> Hey guys,
>
> We really do not properly read the e-mails.
>
Haha you're so funny I don't know you personally so I will take it as a
sarcastic humour...
Please look at this thread http://markmail.org/message/jo2xicpuvn7n

All the links you sent me was from master branch.
>

Seriously it's probably more than 10 days I keep telling naster doesn't
build.
I don't care about branches there are so many so it's impossible to know
what to use!!!


>
> We are NOT working in master branch. Do not test master yet.
>

That's the branch everyone is looking at.
When folks/potential people who wants to contribute/fix issue look at.
So this must be fixed. AGAIN it's probably 10days I keep telling you..
Note I haven't reverted any of your commits without asking you here.
So If it's not fixed today I will push fixes to master.

PLEASE AGAIN READ EMAILS: In this thread, I have asked to switch master to
3.0.0 and make 1.7



>
> Our focus is the branch named "SUREFIRE-1489".
> Please run only the build on branch "SUREFIRE-1489" and nothing else yet.
> We should proceed step by step.
>
> Please try to be patient and:
> $ git clone 
> $ git fetch
> $ git checkout SUREFIRE-1489
> $ mvn clean install -nsu -P run-its -Djdk.home=/path/to/jdk10
> -Djacoco.skip=true
>
> I will be waiting.
>
> All my previous emails about ASF Jenkins was from the branch
> "SUREFIRE-1489"  and not the master.
>
> With Best Regards
> Tibor
>
>
>
> On Sun, Feb 25, 2018 at 1:20 PM, Olivier Lamy  wrote:
>
>> something very interesting on my side.
>> It works with empty on ASF Jenkins: https://builds.apache
>> .org/view/M-R/view/Maven/job/maven-surefire-fs/
>> But not in this Jenkins https://jenkins.webtid
>> e.net/job/sandbox/job/surefire-master-jdk8/5/console  or using Travis
>> https://travis-ci.org/olamy/maven-surefire/builds/345892147
>> Sorry I cannot test locally with an empty repo as my internet is very
>> slow today.
>> but anyway we should not have a build with a need of an empty repo...
>> Funny as ironically the Maven team cannot have a stable build working
>> everywhere :-)
>>
>> On 25 February 2018 at 19:45, Robert Scholte 
>> wrote:
>>
>>> Hi all,
>>>
>>> I'm on *master* and simply running 'mvn clean verify' and the unittests
>>> of Surefire Bootstrap fail.
>>> I get 28 errors, which can be brought back into 2 exceptions:
>>> - java.lang.NoClassDefFoundError: Could not initialize class
>>> org.apache.maven.surefire.booter.SystemUtils
>>> - java.lang.NoClassDefFoundError: org/apache/commons/lang3/SystemUtils
>>>   Caused by: java.lang.ClassNotFoundException:
>>> org.apache.commons.lang3.JavaVersion
>>>
>>> I've removed my local repository, same result.
>>>
>>> Robert
>>>
>>> On Sun, 25 Feb 2018 04:04:02 +0100, Tibor Digana 
>>> wrote:
>>>
>>> Hello Olivier, Robert,
>>>
>>> I think this issue you saw was caused by the old hack with commons-lang3
>>> in module surefire-booter/pom.xml.
>>> I reproduced it on WindowsXP but not on Windows7, funny.
>>> I removed the change in the pom.xml and committed (git push force) to
>>> our branch SUREFIRE-1489. Now the branch SUREFIRE-1489 contains changes
>>> from three JIRAs, but that's ok, we will create new ones according to Jiras.
>>> I run this command:
>>>
>>> mvn clean install -P run-its -Dintegration-test-port=8000 
>>> -Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program Files\Java\jdk10" 
>>> -Djacoco.skip=true
>>>
>>> I am overriding the branch, so it is better to clone it fresh.
>>>
>>> Please let me know if it is fine on your side.
>>>
>>> With Best Regards,
>>> Tibor
>>>
>>>
>>>
>>>
>>> On Sun, Feb 25, 2018 at 2:51 AM, Tibor Digana 
>>> wrote:
>>>
 Try to delete local maven repository on Travis and run the branch
 SUREFIRE-1489 with --no-snapshot-updates.
 I hope we will have good results.
 Good night!

 On Sun, Feb 25, 2018 at 2:34 AM, Tibor Digana 
 wrote:

> What branch is for the build /maven-surefire-fs?
> Any special build configuration or sources are different from master?
>
> On Sun, Feb 25, 2018 at 2:28 AM, Olivier Lamy 
> wrote:
>
>> Did you read my emails? The thread with subject " [3/3]
>> maven-surefire git
>> commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on
>> jdk10" "
>> I assume no so here few links
>> https://builds.apache.org/view/M-R/view/Maven/job/maven-
>> surefire-fs/2/console
>> https://jenkins.webtide.net/job/sandbox/job/surefire-master-
>> jdk8/4/console
>> https://travis-ci.org/olamy/maven-surefire/builds/345611495
>>
>> There are all Jenkins or Travis builds with an empty maven repo.
>>
>>
>>
>> On 25 February 2018 at 11:11, Tibor Digana 
>> wrote:
>>
>> > Hi Olivier,

Broken surefire defaults?

2018-02-25 Thread Romain Manni-Bucau
Hi guys

Surefire sets some java 9 modules by default when running tests on j9.

I understand the intention but it means surefire doesnt test accurately the
code in the build since you will pass the tests and fail at runtime pretry
easily a d with any embedded solution like spring boot, meecrowave, tomee
etc...

A very common example is a missing jaxb dependency which would be hidden by
surefire (which means surefire swallowed a bug)

I also know you can tune it to use java.base and therefore have a normal
behavior but to do that you need to know it.

Since I saw several colleagues hitting this issue i think it is worth
mentionning it here and request if default can be aligned on the jvm
instead of trying to be too clever?


New branch jdk1.6 in https://gitbox.apache.org/repos/asf/maven-jenkins-env.git

2018-02-25 Thread Tibor Digana
Hi All,

I have created a branch which adds switch-case for JDK 1.6 (latest) in
Groovy library jenkinsEnv.

Can I push it to master?

Cheers
Tibor


Re: Surefire roadmap

2018-02-25 Thread Tibor Digana
Hi Enrico,

Sorry for notifying.
I would like to ask you for a help.
Maybe you can see my previous e-mail in this thread on mailing list with
CLI running a build on the branch SUREFIRE-1489.
Can you please try to run the build on your side and let us know the result?
I appreciate!

(If the CLI command is not clear, do not hesitate to ask beforehand.)

Thx
Tibor


On Sun, Feb 25, 2018 at 9:34 PM, Tibor Digana 
wrote:

> Hey guys,
>
> We really do not properly read the e-mails.
> All the links you sent me was from master branch.
>
> We are NOT working in master branch. Do not test master yet.
>
> Our focus is the branch named "SUREFIRE-1489".
> Please run only the build on branch "SUREFIRE-1489" and nothing else yet.
> We should proceed step by step.
>
> Please try to be patient and:
> $ git clone 
> $ git fetch
> $ git checkout SUREFIRE-1489
> $ mvn clean install -nsu -P run-its -Djdk.home=/path/to/jdk10
> -Djacoco.skip=true
>
> I will be waiting.
>
> All my previous emails about ASF Jenkins was from the branch
> "SUREFIRE-1489"  and not the master.
>
> With Best Regards
> Tibor
>
>
>
> On Sun, Feb 25, 2018 at 1:20 PM, Olivier Lamy  wrote:
>
>> something very interesting on my side.
>> It works with empty on ASF Jenkins: https://builds.apache
>> .org/view/M-R/view/Maven/job/maven-surefire-fs/
>> But not in this Jenkins https://jenkins.webtid
>> e.net/job/sandbox/job/surefire-master-jdk8/5/console  or using Travis
>> https://travis-ci.org/olamy/maven-surefire/builds/345892147
>> Sorry I cannot test locally with an empty repo as my internet is very
>> slow today.
>> but anyway we should not have a build with a need of an empty repo...
>> Funny as ironically the Maven team cannot have a stable build working
>> everywhere :-)
>>
>> On 25 February 2018 at 19:45, Robert Scholte 
>> wrote:
>>
>>> Hi all,
>>>
>>> I'm on *master* and simply running 'mvn clean verify' and the unittests
>>> of Surefire Bootstrap fail.
>>> I get 28 errors, which can be brought back into 2 exceptions:
>>> - java.lang.NoClassDefFoundError: Could not initialize class
>>> org.apache.maven.surefire.booter.SystemUtils
>>> - java.lang.NoClassDefFoundError: org/apache/commons/lang3/SystemUtils
>>>   Caused by: java.lang.ClassNotFoundException:
>>> org.apache.commons.lang3.JavaVersion
>>>
>>> I've removed my local repository, same result.
>>>
>>> Robert
>>>
>>> On Sun, 25 Feb 2018 04:04:02 +0100, Tibor Digana 
>>> wrote:
>>>
>>> Hello Olivier, Robert,
>>>
>>> I think this issue you saw was caused by the old hack with commons-lang3
>>> in module surefire-booter/pom.xml.
>>> I reproduced it on WindowsXP but not on Windows7, funny.
>>> I removed the change in the pom.xml and committed (git push force) to
>>> our branch SUREFIRE-1489. Now the branch SUREFIRE-1489 contains changes
>>> from three JIRAs, but that's ok, we will create new ones according to Jiras.
>>> I run this command:
>>>
>>> mvn clean install -P run-its -Dintegration-test-port=8000 
>>> -Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program Files\Java\jdk10" 
>>> -Djacoco.skip=true
>>>
>>> I am overriding the branch, so it is better to clone it fresh.
>>>
>>> Please let me know if it is fine on your side.
>>>
>>> With Best Regards,
>>> Tibor
>>>
>>>
>>>
>>>
>>> On Sun, Feb 25, 2018 at 2:51 AM, Tibor Digana 
>>> wrote:
>>>
 Try to delete local maven repository on Travis and run the branch
 SUREFIRE-1489 with --no-snapshot-updates.
 I hope we will have good results.
 Good night!

 On Sun, Feb 25, 2018 at 2:34 AM, Tibor Digana 
 wrote:

> What branch is for the build /maven-surefire-fs?
> Any special build configuration or sources are different from master?
>
> On Sun, Feb 25, 2018 at 2:28 AM, Olivier Lamy 
> wrote:
>
>> Did you read my emails? The thread with subject " [3/3]
>> maven-surefire git
>> commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on
>> jdk10" "
>> I assume no so here few links
>> https://builds.apache.org/view/M-R/view/Maven/job/maven-
>> surefire-fs/2/console
>> https://jenkins.webtide.net/job/sandbox/job/surefire-master-
>> jdk8/4/console
>> https://travis-ci.org/olamy/maven-surefire/builds/345611495
>>
>> There are all Jenkins or Travis builds with an empty maven repo.
>>
>>
>>
>> On 25 February 2018 at 11:11, Tibor Digana 
>> wrote:
>>
>> > Hi Olivier,
>> >
>> > I am trying to be friendly and helpful.
>> >
>> > Maybe a hint:
>> > One problem I found weeks ago was in Maven Central which contained a
>> > SNAPSHOT version built with Java 1.7.
>> > I had to do this on my PC:
>> > $ mvn
>> > org.codehaus.mojo:build-helper-maven-plugin:3.0.0:remove-
>> project-artifact
>> > 

Re: Surefire roadmap

2018-02-25 Thread Tibor Digana
Hey guys,

We really do not properly read the e-mails.
All the links you sent me was from master branch.

We are NOT working in master branch. Do not test master yet.

Our focus is the branch named "SUREFIRE-1489".
Please run only the build on branch "SUREFIRE-1489" and nothing else yet.
We should proceed step by step.

Please try to be patient and:
$ git clone 
$ git fetch
$ git checkout SUREFIRE-1489
$ mvn clean install -nsu -P run-its -Djdk.home=/path/to/jdk10
-Djacoco.skip=true

I will be waiting.

All my previous emails about ASF Jenkins was from the branch
"SUREFIRE-1489"  and not the master.

With Best Regards
Tibor



On Sun, Feb 25, 2018 at 1:20 PM, Olivier Lamy  wrote:

> something very interesting on my side.
> It works with empty on ASF Jenkins: https://builds.
> apache.org/view/M-R/view/Maven/job/maven-surefire-fs/
> But not in this Jenkins https://jenkins.webtide.net/job/sandbox/job/
> surefire-master-jdk8/5/console  or using Travis https://travis-ci.org/
> olamy/maven-surefire/builds/345892147
> Sorry I cannot test locally with an empty repo as my internet is very slow
> today.
> but anyway we should not have a build with a need of an empty repo...
> Funny as ironically the Maven team cannot have a stable build working
> everywhere :-)
>
> On 25 February 2018 at 19:45, Robert Scholte  wrote:
>
>> Hi all,
>>
>> I'm on *master* and simply running 'mvn clean verify' and the unittests
>> of Surefire Bootstrap fail.
>> I get 28 errors, which can be brought back into 2 exceptions:
>> - java.lang.NoClassDefFoundError: Could not initialize class
>> org.apache.maven.surefire.booter.SystemUtils
>> - java.lang.NoClassDefFoundError: org/apache/commons/lang3/SystemUtils
>>   Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang3.
>> JavaVersion
>>
>> I've removed my local repository, same result.
>>
>> Robert
>>
>> On Sun, 25 Feb 2018 04:04:02 +0100, Tibor Digana 
>> wrote:
>>
>> Hello Olivier, Robert,
>>
>> I think this issue you saw was caused by the old hack with commons-lang3
>> in module surefire-booter/pom.xml.
>> I reproduced it on WindowsXP but not on Windows7, funny.
>> I removed the change in the pom.xml and committed (git push force) to our
>> branch SUREFIRE-1489. Now the branch SUREFIRE-1489 contains changes from
>> three JIRAs, but that's ok, we will create new ones according to Jiras.
>> I run this command:
>>
>> mvn clean install -P run-its -Dintegration-test-port=8000 
>> -Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program Files\Java\jdk10" 
>> -Djacoco.skip=true
>>
>> I am overriding the branch, so it is better to clone it fresh.
>>
>> Please let me know if it is fine on your side.
>>
>> With Best Regards,
>> Tibor
>>
>>
>>
>>
>> On Sun, Feb 25, 2018 at 2:51 AM, Tibor Digana 
>> wrote:
>>
>>> Try to delete local maven repository on Travis and run the branch
>>> SUREFIRE-1489 with --no-snapshot-updates.
>>> I hope we will have good results.
>>> Good night!
>>>
>>> On Sun, Feb 25, 2018 at 2:34 AM, Tibor Digana 
>>> wrote:
>>>
 What branch is for the build /maven-surefire-fs?
 Any special build configuration or sources are different from master?

 On Sun, Feb 25, 2018 at 2:28 AM, Olivier Lamy  wrote:

> Did you read my emails? The thread with subject " [3/3] maven-surefire
> git
> commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on
> jdk10" "
> I assume no so here few links
> https://builds.apache.org/view/M-R/view/Maven/job/maven-
> surefire-fs/2/console
> https://jenkins.webtide.net/job/sandbox/job/surefire-
> master-jdk8/4/console
> https://travis-ci.org/olamy/maven-surefire/builds/345611495
>
> There are all Jenkins or Travis builds with an empty maven repo.
>
>
>
> On 25 February 2018 at 11:11, Tibor Digana 
> wrote:
>
> > Hi Olivier,
> >
> > I am trying to be friendly and helpful.
> >
> > Maybe a hint:
> > One problem I found weeks ago was in Maven Central which contained a
> > SNAPSHOT version built with Java 1.7.
> > I had to do this on my PC:
> > $ mvn
> > org.codehaus.mojo:build-helper-maven-plugin:3.0.0:
> remove-project-artifact
> > -Dbuildhelper.failOnError=false
> > $ mvn install *-nsu*
> > and try with JAVA_HOME=JDK 1.8 for first time and then with
> jdk.home=...
> > with other JDKs.
> >
> > I remember your mail and the stacktrace with commons-lang3-3.5.jar
> but I
> > could not reproduce identical symptoms on my PC and Jenkins lately.
> > Therefore I have opened the master log [1] and I do not see that
> stacktrace
> > you had before.
> > I am building locally and on Jenkins almost every day but the issue
> with
> > calling commons-lang3 has not occurred, sorry.
> >
>
> 

[GitHub] maven issue #135: [MNG-6296] Parse properties before configuring the logging...

2018-02-25 Thread slachiewicz
Github user slachiewicz commented on the issue:

https://github.com/apache/maven/pull/135
  
Merged to master 
http://git-wip-us.apache.org/repos/asf/maven/commit/b2afafe5


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Access project properties in non-plugin code

2018-02-25 Thread Basin Ilya
Thanks Robert.


25.02.2018 17:58, Robert Scholte пишет:
> The preferred way is to change or extend the plugin.
> It should be possible to do this:
> 
> public class CustomMojo extends OtherMojo {
> 
>   @Parameter
>   private String whatever;
> }
> 
> if the OtherMojo is accessible enough.
> 
> Any other solution might become a hard fight.
> 
> Robert
> 
> On Sun, 25 Feb 2018 15:28:28 +0100, Basin Ilya  wrote:
> 
>> I want to add custom configuration options to a library used by a plugin
>> without modifying the plugin code. After that I want to add an explicit
>> plugin dependency (changing the default library version) in my pom and
>> also define some configuration for the library in the same pom.
>>
>>
>> 25.02.2018 17:09, Robert Scholte пишет:
>>> The answer should be 'no'.
>>> It often helps if you're describing the usecase.
>>> What are you trying to achieve?
>>>
>>> Robert
>>>
>>> On Sun, 25 Feb 2018 15:05:08 +0100, Basin Ilya 
>>> wrote:
>>>
 Hi

 Can a plugin dependency (which is not a plugin itself) access the
 plugin
 configuration when it's called by the plugin? Or at least access the
 current maven project properties? Through some thread-local or static
 member.


 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>> For additional commands, e-mail: dev-h...@maven.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Prepared Maven 3.5.3 Release Notes

2018-02-25 Thread Karl Heinz Marbaise

Hi Stephen,

On 25/02/18 09:06, Stephen Connolly wrote:

On Sat 24 Feb 2018 at 21:02, Gary Gregory  wrote:


Hi All,

Thank you for preparing a release.



Well I managed to consolidate some of the steps for this one... I think it
will be nearer 20-25 steps, down from 30

I’m still hoping to get to a more automated solution (modulo we need a
release vote)

NOTE: this is not the final release notes, rather a draft... and until the
vote completes there is no release.




As a user, this is useless:



The Maven project *really* wants to express. as our most important thing
about any release, the debt of gratitude we owe to any non-committer who
contributes in any way to the release.

If we included the issue description in this section, people would focus on
the description and not the values contributors.

Perhaps we could start this section with a sentence to this effect, eg

“We really value the contributions of these non committers, so this section
is focused on those individuals. Descriptions of the issues fixed can be
found at the end of these release notes”


That looks like a very good idea...Added to the draft state...Thanks for 
expressing that...







Bugs:

- MNG-6323  reporter:
Ben Caradoc-Davies
- MNG-6320  reporter:
Eugene Pliskin
- MNG-6300  reporter:
Andreas Kurth
- MNG-6298  reporter:
Ryan Heaton
- MNG-6296  reporter:
Robin Müller
- MNG-6282  reporter:
Dejan Stojadinović
- MNG-6255  reporter:
Andrew Kennedy

Improvements:

- MNG-6340  reporter:
Tony Guan
- MNG-6306  reporter:
Andy Wilkinson
- MNG-5992  reporter:
Ryan J. McDonough

I need to see the ticket DESCRIPTION. I do not care about the AUTHOR.

Thank you,
Gary

On Sat, Feb 24, 2018 at 1:47 PM, Karl Heinz Marbaise 
wrote:


Hi to all,

I have prepared Maven 3.5.3 Release notes.

You can take a look here:

https://github.com/khmarbaise/maven-release-notes/blob/maste
r/content/markdown/docs/3.5.3/release-notes.md

If you have improvements/ideas/supplementals etc. don't hesitate to
contact me or make a PR...

Kind regards
Karl Heinz Marbaise

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Access project properties in non-plugin code

2018-02-25 Thread Robert Scholte

The answer should be 'no'.
It often helps if you're describing the usecase.
What are you trying to achieve?

Robert

On Sun, 25 Feb 2018 15:05:08 +0100, Basin Ilya  wrote:


Hi

Can a plugin dependency (which is not a plugin itself) access the plugin
configuration when it's called by the plugin? Or at least access the
current maven project properties? Through some thread-local or static
member.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Access project properties in non-plugin code

2018-02-25 Thread Basin Ilya
Hi

Can a plugin dependency (which is not a plugin itself) access the plugin
configuration when it's called by the plugin? Or at least access the
current maven project properties? Through some thread-local or static
member.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Surefire roadmap

2018-02-25 Thread Olivier Lamy
something very interesting on my side.
It works with empty on ASF Jenkins:
https://builds.apache.org/view/M-R/view/Maven/job/maven-surefire-fs/
But not in this Jenkins
https://jenkins.webtide.net/job/sandbox/job/surefire-master-jdk8/5/console
 or using Travis https://travis-ci.org/olamy/maven-surefire/builds/345892147
Sorry I cannot test locally with an empty repo as my internet is very slow
today.
but anyway we should not have a build with a need of an empty repo...
Funny as ironically the Maven team cannot have a stable build working
everywhere :-)

On 25 February 2018 at 19:45, Robert Scholte  wrote:

> Hi all,
>
> I'm on *master* and simply running 'mvn clean verify' and the unittests of
> Surefire Bootstrap fail.
> I get 28 errors, which can be brought back into 2 exceptions:
> - java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.maven.surefire.booter.SystemUtils
> - java.lang.NoClassDefFoundError: org/apache/commons/lang3/SystemUtils
>   Caused by: java.lang.ClassNotFoundException:
> org.apache.commons.lang3.JavaVersion
>
> I've removed my local repository, same result.
>
> Robert
>
> On Sun, 25 Feb 2018 04:04:02 +0100, Tibor Digana 
> wrote:
>
> Hello Olivier, Robert,
>
> I think this issue you saw was caused by the old hack with commons-lang3
> in module surefire-booter/pom.xml.
> I reproduced it on WindowsXP but not on Windows7, funny.
> I removed the change in the pom.xml and committed (git push force) to our
> branch SUREFIRE-1489. Now the branch SUREFIRE-1489 contains changes from
> three JIRAs, but that's ok, we will create new ones according to Jiras.
> I run this command:
>
> mvn clean install -P run-its -Dintegration-test-port=8000 
> -Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program Files\Java\jdk10" 
> -Djacoco.skip=true
>
> I am overriding the branch, so it is better to clone it fresh.
>
> Please let me know if it is fine on your side.
>
> With Best Regards,
> Tibor
>
>
>
>
> On Sun, Feb 25, 2018 at 2:51 AM, Tibor Digana 
> wrote:
>
>> Try to delete local maven repository on Travis and run the branch
>> SUREFIRE-1489 with --no-snapshot-updates.
>> I hope we will have good results.
>> Good night!
>>
>> On Sun, Feb 25, 2018 at 2:34 AM, Tibor Digana 
>> wrote:
>>
>>> What branch is for the build /maven-surefire-fs?
>>> Any special build configuration or sources are different from master?
>>>
>>> On Sun, Feb 25, 2018 at 2:28 AM, Olivier Lamy  wrote:
>>>
 Did you read my emails? The thread with subject " [3/3] maven-surefire
 git
 commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on
 jdk10" "
 I assume no so here few links
 https://builds.apache.org/view/M-R/view/Maven/job/maven-
 surefire-fs/2/console

 https://jenkins.webtide.net/job/sandbox/job/surefire-master-jdk8/4/console
 https://travis-ci.org/olamy/maven-surefire/builds/345611495

 There are all Jenkins or Travis builds with an empty maven repo.



 On 25 February 2018 at 11:11, Tibor Digana 
 wrote:

 > Hi Olivier,
 >
 > I am trying to be friendly and helpful.
 >
 > Maybe a hint:
 > One problem I found weeks ago was in Maven Central which contained a
 > SNAPSHOT version built with Java 1.7.
 > I had to do this on my PC:
 > $ mvn
 >
 org.codehaus.mojo:build-helper-maven-plugin:3.0.0:remove-project-artifact
 > -Dbuildhelper.failOnError=false
 > $ mvn install *-nsu*
 > and try with JAVA_HOME=JDK 1.8 for first time and then with
 jdk.home=...
 > with other JDKs.
 >
 > I remember your mail and the stacktrace with commons-lang3-3.5.jar
 but I
 > could not reproduce identical symptoms on my PC and Jenkins lately.
 > Therefore I have opened the master log [1] and I do not see that
 stacktrace
 > you had before.
 > I am building locally and on Jenkins almost every day but the issue
 with
 > calling commons-lang3 has not occurred, sorry.
 >

 See above. Maybe it's "it fail on my machine" or "it works on my
 machine"
 BUT I have produced a lot of evidences there is a problem so please do
 not
 ignore that


 >
 > I would like to help you but I do not know what's going on your PC.
 Maybe
 > on Sunday we should talk on IRC, I am open for that.


 > Not everyone can do whatever. Everybody has to open a branch with a
 name of
 > Jira, kindly ask the developers to talk about long term concept, to
 make a
 > code-review and wait for a response. We are not always available and
 > therefore we have to wait for someone else and sometimes we have to
 find a
 > person in commit list, go to the developer, track her/him on e-mail
 and
 > IRC.
 > But I would prefer IRC during the day or evening.
 

Re: Surefire roadmap

2018-02-25 Thread Robert Scholte

Hi all,

I'm on *master* and simply running 'mvn clean verify' and the unittests of  
Surefire Bootstrap fail.

I get 28 errors, which can be brought back into 2 exceptions:
- java.lang.NoClassDefFoundError: Could not initialize class  
org.apache.maven.surefire.booter.SystemUtils

- java.lang.NoClassDefFoundError: org/apache/commons/lang3/SystemUtils
  Caused by: java.lang.ClassNotFoundException:  
org.apache.commons.lang3.JavaVersion


I've removed my local repository, same result.

Robert

On Sun, 25 Feb 2018 04:04:02 +0100, Tibor Digana   
wrote:



Hello Olivier, Robert,

I think this issue you saw was caused by the old hack with commons-lang3  
in module surefire-booter/pom.xml.

I reproduced it on WindowsXP but not on Windows7, funny.
I removed the change in the pom.xml and committed (git push force) to  
our branch SUREFIRE-1489. Now the branch SUREFIRE-1489 contains >changes  
from three JIRAs, but that's ok, we will create new ones according to  
Jiras.

I run this command:
mvn clean install -P run-its -Dintegration-test-port=8000  
-Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program  
Files\Java\jdk10" -Djacoco.skip=true

I am overriding the branch, so it is better to clone it fresh.

Please let me know if it is fine on your side.

With Best Regards,
Tibor




On Sun, Feb 25, 2018 at 2:51 AM, Tibor Digana   
wrote:
Try to delete local maven repository on Travis and run the branch  
SUREFIRE-1489 with --no-snapshot-updates.

I hope we will have good results.
Good night!

On Sun, Feb 25, 2018 at 2:34 AM, Tibor Digana   
wrote:

What branch is for the build /maven-surefire-fs?
Any special build configuration or sources are different from master?

On Sun, Feb 25, 2018 at 2:28 AM, Olivier Lamy  wrote:
Did you read my emails? The thread with subject " [3/3]  
maven-surefire git

commit: Revert "[SUREFIRE-1473] upgrade commons-lang3 to avoid NPE on
jdk10" "
I assume no so here few links
https://builds.apache.org/view/M-R/view/Maven/job/maven-
surefire-fs/2/console
https://jenkins.webtide.net/job/sandbox/job/surefire-master-jdk8/4/console
https://travis-ci.org/olamy/maven-surefire/builds/345611495

There are all Jenkins or Travis builds with an empty maven repo.



On 25 February 2018 at 11:11, Tibor Digana  
 wrote:



Hi Olivier,

I am trying to be friendly and helpful.

Maybe a hint:
One problem I found weeks ago was in Maven Central which contained a
SNAPSHOT version built with Java 1.7.
I had to do this on my PC:
$ mvn
org.codehaus.mojo:build-helper-maven-plugin:3.0.0:remove-project-artifact
-Dbuildhelper.failOnError=false
$ mvn install *-nsu*
and try with JAVA_HOME=JDK 1.8 for first time and then with  
jdk.home=...

with other JDKs.

I remember your mail and the stacktrace with commons-lang3-3.5.jar  
but I

could not reproduce identical symptoms on my PC and Jenkins lately.
Therefore I have opened the master log [1] and I do not see that  
stacktrace

you had before.
I am building locally and on Jenkins almost every day but the issue  
with

calling commons-lang3 has not occurred, sorry.



See above. Maybe it's "it fail on my machine" or "it works on my  
machine"
BUT I have produced a lot of evidences there is a problem so please  
do not

ignore that




I would like to help you but I do not know what's going on your PC.  
Maybe

on Sunday we should talk on IRC, I am open for that.



Not everyone can do whatever. Everybody has to open a branch with a  
name of
Jira, kindly ask the developers to talk about long term concept, to  
make a

code-review and wait for a response. We are not always available and
therefore we have to wait for someone else and sometimes we have to  
find a
person in commit list, go to the developer, track her/him on e-mail  
and

IRC.
But I would prefer IRC during the day or evening.



I don't think irc is a good place for decisions as it's limited  
number of

participants.
I see our project as a community and not as a limited number of  
people who

can be on irc at a certain time.
Mailing list are the basis of how Apache projects works because you  
have

history (you can search), async response mode etc...

Anyway I asked here fro having master jdk7 minimum with bumping  
version to

3.0.0.
we can have a maintenance branch 2.x
But let's move forward before jdk7 get deprecated (oh oops it's  
already the

case).
Joke apart. I really want a release supporting jdk10 at least  
something not

failing with CNFE




[1]:
https://builds.apache.org/job/maven-wip/job/maven-surefire/
job/master/20/consoleFull

Cheers
Tibor




On Sun, Feb 25, 2018 at 12:47 AM, Olivier Lamy   
wrote:


> Please Tibor read the emails and I'm so sorry to repeat again  
myself but

> it looks you do not listen anyone...
> MASTER DOESN'T BUILD!!!
> using jdk7 or jdk8 or jdk9 or jdk10
> I send few links with failure and as far as I can understand from  

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-25 Thread Dan Tran
  correction

found this reference, found on 3.5.2 but I only encounter this on 3.5.3 RC

https://stackoverflow.com/questions/48723899/maven-
numberformatexception-when-packaging


On Sun, Feb 25, 2018 at 1:13 AM, Dan Tran  wrote:

> found this reference, found on 3.5.2 but I only encounter this on 3.5.2 RC
>
> https://stackoverflow.com/questions/48723899/maven-
> numberformatexception-when-packaging
>
> On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran  wrote:
>
>> my build contains 270+ modules using java 8.  The failure found on
>> windows. Have not tested on Linux  yet
>>
>> -D
>>
>> On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran  wrote:
>>
>>> Encounter random failure at antrun MOJO + smart builder
>>>
>>> here is the error message
>>>
>>> [ERROR] Failed to execute goal 
>>> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
>>> (work.around.to.clean.up.classes.before.jsonschema.start) on project
>>> adm-schema: Error executing Ant tasks: For input string: "1;" -> [Help 1]
>>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>>> execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
>>> (work.around.to.clean.up.classes.before.jsonschema.start) on project
>>> adm-schema: Error executing Ant tasks: For input string: "1;"
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:213)
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:154)
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:146)
>>> at 
>>> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
>>> (LifecycleModuleBuilder.java:117)
>>> at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
>>> (SmartBuilderImpl.java:205)
>>> at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run
>>> (SmartBuilderImpl.java:77)
>>> at java.util.concurrent.Executors$RunnableAdapter.call
>>> (Executors.java:511)
>>> at java.util.concurrent.FutureTask.run (FutureTask.java:266)
>>> at java.util.concurrent.ThreadPoolExecutor.runWorker
>>> (ThreadPoolExecutor.java:1149)
>>> at java.util.concurrent.ThreadPoolExecutor$Worker.run
>>> (ThreadPoolExecutor.java:624)
>>> at java.lang.Thread.run (Thread.java:748)
>>> Caused by: org.apache.maven.plugin.MojoExecutionException: Error
>>> executing Ant tasks: For input string: "1;"
>>> at org.apache.maven.plugin.antrun.AntRunMojo.execute
>>> (AntRunMojo.java:347)
>>> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
>>> (DefaultBuildPluginManager.java:137)
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:208)
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:154)
>>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>>> (MojoExecutor.java:146)
>>> at 
>>> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
>>> (LifecycleModuleBuilder.java:117)
>>> at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
>>> (SmartBuilderImpl.java:205)
>>> at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run
>>> (SmartBuilderImpl.java:77)
>>> at java.util.concurrent.Executors$RunnableAdapter.call
>>> (Executors.java:511)
>>> at java.util.concurrent.FutureTask.run (FutureTask.java:266)
>>> at java.util.concurrent.ThreadPoolExecutor.runWorker
>>> (ThreadPoolExecutor.java:1149)
>>> at java.util.concurrent.ThreadPoolExecutor$Worker.run
>>> (ThreadPoolExecutor.java:624)
>>> at java.lang.Thread.run (Thread.java:748)
>>> Caused by: java.lang.NumberFormatException: For input string: "1;"
>>> at java.lang.NumberFormatException.forInputString
>>> (NumberFormatException.java:65)
>>> at java.lang.Integer.parseInt (Integer.java:580)
>>> at java.lang.Integer. (Integer.java:867)
>>> at org.fusesource.jansi.AnsiPrintStream.filter
>>> (AnsiPrintStream.java:129)
>>> at org.fusesource.jansi.FilterPrintStream.write
>>> (FilterPrintStream.java:59)
>>> at org.fusesource.jansi.FilterPrintStream.write
>>> (FilterPrintStream.java:70)
>>> at java.io.PrintStream.write (PrintStream.java:480)
>>> at sun.nio.cs.StreamEncoder.writeBytes (StreamEncoder.java:221)
>>> at sun.nio.cs.StreamEncoder.implFlushBuffer (StreamEncoder.java:291)
>>> at sun.nio.cs.StreamEncoder.flushBuffer (StreamEncoder.java:104)
>>> at java.io.OutputStreamWriter.flushBuffer
>>> (OutputStreamWriter.java:185)
>>> at java.io.PrintStream.newLine (PrintStream.java:546)
>>> at java.io.PrintStream.println (PrintStream.java:807)
>>> at org.apache.tools.ant.DefaultLogger.printMessage
>>> (DefaultLogger.java:346)
>>> at org.apache.tools.ant.DefaultLogger.targetStarted
>>> (DefaultLogger.java:218)
>>> at org.apache.tools.ant.Project.fireTargetStarted
>>> (Project.java:2140)
>>> at 

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-25 Thread Dan Tran
found this reference, found on 3.5.2 but I only encounter this on 3.5.2 RC

https://stackoverflow.com/questions/48723899/maven-numberformatexception-when-packaging

On Sun, Feb 25, 2018 at 12:53 AM, Dan Tran  wrote:

> my build contains 270+ modules using java 8.  The failure found on
> windows. Have not tested on Linux  yet
>
> -D
>
> On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran  wrote:
>
>> Encounter random failure at antrun MOJO + smart builder
>>
>> here is the error message
>>
>> [ERROR] Failed to execute goal 
>> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
>> (work.around.to.clean.up.classes.before.jsonschema.start) on project
>> adm-schema: Error executing Ant tasks: For input string: "1;" -> [Help 1]
>> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to
>> execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
>> (work.around.to.clean.up.classes.before.jsonschema.start) on project
>> adm-schema: Error executing Ant tasks: For input string: "1;"
>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>> (MojoExecutor.java:213)
>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>> (MojoExecutor.java:154)
>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>> (MojoExecutor.java:146)
>> at 
>> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
>> (LifecycleModuleBuilder.java:117)
>> at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
>> (SmartBuilderImpl.java:205)
>> at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run
>> (SmartBuilderImpl.java:77)
>> at java.util.concurrent.Executors$RunnableAdapter.call
>> (Executors.java:511)
>> at java.util.concurrent.FutureTask.run (FutureTask.java:266)
>> at java.util.concurrent.ThreadPoolExecutor.runWorker
>> (ThreadPoolExecutor.java:1149)
>> at java.util.concurrent.ThreadPoolExecutor$Worker.run
>> (ThreadPoolExecutor.java:624)
>> at java.lang.Thread.run (Thread.java:748)
>> Caused by: org.apache.maven.plugin.MojoExecutionException: Error
>> executing Ant tasks: For input string: "1;"
>> at org.apache.maven.plugin.antrun.AntRunMojo.execute
>> (AntRunMojo.java:347)
>> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
>> (DefaultBuildPluginManager.java:137)
>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>> (MojoExecutor.java:208)
>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>> (MojoExecutor.java:154)
>> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
>> (MojoExecutor.java:146)
>> at 
>> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
>> (LifecycleModuleBuilder.java:117)
>> at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
>> (SmartBuilderImpl.java:205)
>> at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run
>> (SmartBuilderImpl.java:77)
>> at java.util.concurrent.Executors$RunnableAdapter.call
>> (Executors.java:511)
>> at java.util.concurrent.FutureTask.run (FutureTask.java:266)
>> at java.util.concurrent.ThreadPoolExecutor.runWorker
>> (ThreadPoolExecutor.java:1149)
>> at java.util.concurrent.ThreadPoolExecutor$Worker.run
>> (ThreadPoolExecutor.java:624)
>> at java.lang.Thread.run (Thread.java:748)
>> Caused by: java.lang.NumberFormatException: For input string: "1;"
>> at java.lang.NumberFormatException.forInputString
>> (NumberFormatException.java:65)
>> at java.lang.Integer.parseInt (Integer.java:580)
>> at java.lang.Integer. (Integer.java:867)
>> at org.fusesource.jansi.AnsiPrintStream.filter
>> (AnsiPrintStream.java:129)
>> at org.fusesource.jansi.FilterPrintStream.write
>> (FilterPrintStream.java:59)
>> at org.fusesource.jansi.FilterPrintStream.write
>> (FilterPrintStream.java:70)
>> at java.io.PrintStream.write (PrintStream.java:480)
>> at sun.nio.cs.StreamEncoder.writeBytes (StreamEncoder.java:221)
>> at sun.nio.cs.StreamEncoder.implFlushBuffer (StreamEncoder.java:291)
>> at sun.nio.cs.StreamEncoder.flushBuffer (StreamEncoder.java:104)
>> at java.io.OutputStreamWriter.flushBuffer
>> (OutputStreamWriter.java:185)
>> at java.io.PrintStream.newLine (PrintStream.java:546)
>> at java.io.PrintStream.println (PrintStream.java:807)
>> at org.apache.tools.ant.DefaultLogger.printMessage
>> (DefaultLogger.java:346)
>> at org.apache.tools.ant.DefaultLogger.targetStarted
>> (DefaultLogger.java:218)
>> at org.apache.tools.ant.Project.fireTargetStarted (Project.java:2140)
>> at org.apache.tools.ant.Target.performTasks (Target.java:454)
>> at org.apache.tools.ant.Project.executeSortedTargets
>> (Project.java:1393)
>> at org.apache.tools.ant.Project.executeTarget (Project.java:1364)
>> at org.apache.maven.plugin.antrun.AntRunMojo.execute
>> (AntRunMojo.java:313)
>> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
>> 

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-25 Thread Dan Tran
my build contains 270+ modules using java 8.  The failure found on windows.
Have not tested on Linux  yet

-D

On Sun, Feb 25, 2018 at 12:23 AM, Dan Tran  wrote:

> Encounter random failure at antrun MOJO + smart builder
>
> here is the error message
>
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (work.around.to.clean.up.classes.before.jsonschema.start) on project
> adm-schema: Error executing Ant tasks: For input string: "1;" -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (work.around.to.clean.up.classes.before.jsonschema.start) on project
> adm-schema: Error executing Ant tasks: For input string: "1;"
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:146)
> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
> (SmartBuilderImpl.java:205)
> at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run
> (SmartBuilderImpl.java:77)
> at java.util.concurrent.Executors$RunnableAdapter.call
> (Executors.java:511)
> at java.util.concurrent.FutureTask.run (FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker
> (ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run
> (ThreadPoolExecutor.java:624)
> at java.lang.Thread.run (Thread.java:748)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error
> executing Ant tasks: For input string: "1;"
> at org.apache.maven.plugin.antrun.AntRunMojo.execute
> (AntRunMojo.java:347)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:146)
> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
> (SmartBuilderImpl.java:205)
> at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run
> (SmartBuilderImpl.java:77)
> at java.util.concurrent.Executors$RunnableAdapter.call
> (Executors.java:511)
> at java.util.concurrent.FutureTask.run (FutureTask.java:266)
> at java.util.concurrent.ThreadPoolExecutor.runWorker
> (ThreadPoolExecutor.java:1149)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run
> (ThreadPoolExecutor.java:624)
> at java.lang.Thread.run (Thread.java:748)
> Caused by: java.lang.NumberFormatException: For input string: "1;"
> at java.lang.NumberFormatException.forInputString
> (NumberFormatException.java:65)
> at java.lang.Integer.parseInt (Integer.java:580)
> at java.lang.Integer. (Integer.java:867)
> at org.fusesource.jansi.AnsiPrintStream.filter
> (AnsiPrintStream.java:129)
> at org.fusesource.jansi.FilterPrintStream.write
> (FilterPrintStream.java:59)
> at org.fusesource.jansi.FilterPrintStream.write
> (FilterPrintStream.java:70)
> at java.io.PrintStream.write (PrintStream.java:480)
> at sun.nio.cs.StreamEncoder.writeBytes (StreamEncoder.java:221)
> at sun.nio.cs.StreamEncoder.implFlushBuffer (StreamEncoder.java:291)
> at sun.nio.cs.StreamEncoder.flushBuffer (StreamEncoder.java:104)
> at java.io.OutputStreamWriter.flushBuffer
> (OutputStreamWriter.java:185)
> at java.io.PrintStream.newLine (PrintStream.java:546)
> at java.io.PrintStream.println (PrintStream.java:807)
> at org.apache.tools.ant.DefaultLogger.printMessage
> (DefaultLogger.java:346)
> at org.apache.tools.ant.DefaultLogger.targetStarted
> (DefaultLogger.java:218)
> at org.apache.tools.ant.Project.fireTargetStarted (Project.java:2140)
> at org.apache.tools.ant.Target.performTasks (Target.java:454)
> at org.apache.tools.ant.Project.executeSortedTargets
> (Project.java:1393)
> at org.apache.tools.ant.Project.executeTarget (Project.java:1364)
> at org.apache.maven.plugin.antrun.AntRunMojo.execute
> (AntRunMojo.java:313)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:146)
> at 

Re: [VOTE] Release Apache Maven 3.5.3

2018-02-25 Thread Dan Tran
Encounter random failure at antrun MOJO + smart builder

here is the error message

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-antrun-plugin:1.8:run
(work.around.to.clean.up.classes.before.jsonschema.start) on project
adm-schema: Error executing Ant tasks: For input string: "1;" -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run
(work.around.to.clean.up.classes.before.jsonschema.start) on project
adm-schema: Error executing Ant tasks: For input string: "1;"
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:213)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:146)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
(SmartBuilderImpl.java:205)
at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run
(SmartBuilderImpl.java:77)
at java.util.concurrent.Executors$RunnableAdapter.call
(Executors.java:511)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error executing
Ant tasks: For input string: "1;"
at org.apache.maven.plugin.antrun.AntRunMojo.execute
(AntRunMojo.java:347)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:146)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
(SmartBuilderImpl.java:205)
at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run
(SmartBuilderImpl.java:77)
at java.util.concurrent.Executors$RunnableAdapter.call
(Executors.java:511)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: java.lang.NumberFormatException: For input string: "1;"
at java.lang.NumberFormatException.forInputString
(NumberFormatException.java:65)
at java.lang.Integer.parseInt (Integer.java:580)
at java.lang.Integer. (Integer.java:867)
at org.fusesource.jansi.AnsiPrintStream.filter
(AnsiPrintStream.java:129)
at org.fusesource.jansi.FilterPrintStream.write
(FilterPrintStream.java:59)
at org.fusesource.jansi.FilterPrintStream.write
(FilterPrintStream.java:70)
at java.io.PrintStream.write (PrintStream.java:480)
at sun.nio.cs.StreamEncoder.writeBytes (StreamEncoder.java:221)
at sun.nio.cs.StreamEncoder.implFlushBuffer (StreamEncoder.java:291)
at sun.nio.cs.StreamEncoder.flushBuffer (StreamEncoder.java:104)
at java.io.OutputStreamWriter.flushBuffer (OutputStreamWriter.java:185)
at java.io.PrintStream.newLine (PrintStream.java:546)
at java.io.PrintStream.println (PrintStream.java:807)
at org.apache.tools.ant.DefaultLogger.printMessage
(DefaultLogger.java:346)
at org.apache.tools.ant.DefaultLogger.targetStarted
(DefaultLogger.java:218)
at org.apache.tools.ant.Project.fireTargetStarted (Project.java:2140)
at org.apache.tools.ant.Target.performTasks (Target.java:454)
at org.apache.tools.ant.Project.executeSortedTargets (Project.java:1393)
at org.apache.tools.ant.Project.executeTarget (Project.java:1364)
at org.apache.maven.plugin.antrun.AntRunMojo.execute
(AntRunMojo.java:313)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:146)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at io.takari.maven.builder.smart.SmartBuilderImpl.buildProject
(SmartBuilderImpl.java:205)
at io.takari.maven.builder.smart.SmartBuilderImpl$ProjectBuildTask.run
(SmartBuilderImpl.java:77)
at java.util.concurrent.Executors$RunnableAdapter.call
(Executors.java:511)
at 

Re: Prepared Maven 3.5.3 Release Notes

2018-02-25 Thread Stephen Connolly
On Sat 24 Feb 2018 at 21:02, Gary Gregory  wrote:

> Hi All,
>
> Thank you for preparing a release.


Well I managed to consolidate some of the steps for this one... I think it
will be nearer 20-25 steps, down from 30

I’m still hoping to get to a more automated solution (modulo we need a
release vote)

NOTE: this is not the final release notes, rather a draft... and until the
vote completes there is no release.


>
> As a user, this is useless:
>

The Maven project *really* wants to express. as our most important thing
about any release, the debt of gratitude we owe to any non-committer who
contributes in any way to the release.

If we included the issue description in this section, people would focus on
the description and not the values contributors.

Perhaps we could start this section with a sentence to this effect, eg

“We really value the contributions of these non committers, so this section
is focused on those individuals. Descriptions of the issues fixed can be
found at the end of these release notes”


> Bugs:
>
>- MNG-6323  reporter:
>Ben Caradoc-Davies
>- MNG-6320  reporter:
>Eugene Pliskin
>- MNG-6300  reporter:
>Andreas Kurth
>- MNG-6298  reporter:
>Ryan Heaton
>- MNG-6296  reporter:
>Robin Müller
>- MNG-6282  reporter:
>Dejan Stojadinović
>- MNG-6255  reporter:
>Andrew Kennedy
>
> Improvements:
>
>- MNG-6340  reporter:
>Tony Guan
>- MNG-6306  reporter:
>Andy Wilkinson
>- MNG-5992  reporter:
>Ryan J. McDonough
>
> I need to see the ticket DESCRIPTION. I do not care about the AUTHOR.
>
> Thank you,
> Gary
>
> On Sat, Feb 24, 2018 at 1:47 PM, Karl Heinz Marbaise 
> wrote:
>
> > Hi to all,
> >
> > I have prepared Maven 3.5.3 Release notes.
> >
> > You can take a look here:
> >
> > https://github.com/khmarbaise/maven-release-notes/blob/maste
> > r/content/markdown/docs/3.5.3/release-notes.md
> >
> > If you have improvements/ideas/supplementals etc. don't hesitate to
> > contact me or make a PR...
> >
> > Kind regards
> > Karl Heinz Marbaise
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
>
-- 
Sent from my phone