Re: JSR250 in the lib
Guess it just comes from guice or friends and since they dont support recent API it was not upgraded. We can upgrade it or just isolate it IMO - but requires some careness since custom components can use it so needs an evolution to toggle it probably. Le lun. 14 oct. 2019 à 03:43, Tibor Digana a écrit : > It is a similar issue to the problem with "javax.inject" API. > What about relocating these two APIs to a package "org.apache.maven"? Any > thoughts? > > On Mon, Oct 14, 2019 at 12:11 AM Petar Tahchiev > wrote: > > > Hello guys, > > > > I just decided to upgrade my build from 3.5.0 to 3.6.2 last night and I > > stumbled across multiple problems, latest one being the following > > exception: > > > > Nested exception is java.lang.NoSuchMethodError: > > javax.annotation.Resource.lookup()Ljava/lang/String; > > > > Seems like maven 3.6.2 comes with jsr-250-api-1.0.jar in the lib/ folder > > and that seems to cause problems for me because I have moneta in my > > classpath which brings newer version of jsr250: > > > > [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ drmartens > --- > > [INFO] com.demo:drmartens:war:1.0-SNAPSHOT > > [INFO] \- > > > > > com.nemesis.platform:nemesis-platform-core:jar:2.1.67.BUILD-SNAPSHOT:compile > > [INFO]\- org.javamoney:moneta:pom:1.3:compile > > [INFO] \- javax.annotation:javax.annotation-api:jar:1.3.2:compile > > [INFO] > > > > > > So I was able to fix this following this recommendation: > > > > > https://stackoverflow.com/questions/52607814/how-to-remove-a-maven-lib-jsr250-api-1-0-jar-from-the-plugin-classpath-jetty > > using extensions, but I was wondering: why do we need the JSR250 in the > lib > > folder? Also why do we need such an old version? > > -- > > Regards, Petar! > > Karlovo, Bulgaria. > > --- > > Public PGP Key at: > > http://pgp.mit.edu:11371/pks/lookup?op=get=0x19658550C3110611 > > Key Fingerprint: A369 A7EE 61BC 93A3 CDFF 55A5 1965 8550 C311 0611 > > >
Re: JSR250 in the lib
It is a similar issue to the problem with "javax.inject" API. What about relocating these two APIs to a package "org.apache.maven"? Any thoughts? On Mon, Oct 14, 2019 at 12:11 AM Petar Tahchiev wrote: > Hello guys, > > I just decided to upgrade my build from 3.5.0 to 3.6.2 last night and I > stumbled across multiple problems, latest one being the following > exception: > > Nested exception is java.lang.NoSuchMethodError: > javax.annotation.Resource.lookup()Ljava/lang/String; > > Seems like maven 3.6.2 comes with jsr-250-api-1.0.jar in the lib/ folder > and that seems to cause problems for me because I have moneta in my > classpath which brings newer version of jsr250: > > [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ drmartens --- > [INFO] com.demo:drmartens:war:1.0-SNAPSHOT > [INFO] \- > > com.nemesis.platform:nemesis-platform-core:jar:2.1.67.BUILD-SNAPSHOT:compile > [INFO]\- org.javamoney:moneta:pom:1.3:compile > [INFO] \- javax.annotation:javax.annotation-api:jar:1.3.2:compile > [INFO] > > > So I was able to fix this following this recommendation: > > https://stackoverflow.com/questions/52607814/how-to-remove-a-maven-lib-jsr250-api-1-0-jar-from-the-plugin-classpath-jetty > using extensions, but I was wondering: why do we need the JSR250 in the lib > folder? Also why do we need such an old version? > -- > Regards, Petar! > Karlovo, Bulgaria. > --- > Public PGP Key at: > http://pgp.mit.edu:11371/pks/lookup?op=get=0x19658550C3110611 > Key Fingerprint: A369 A7EE 61BC 93A3 CDFF 55A5 1965 8550 C311 0611 >
Re: Surefire 3.0.0-M4 release?
The SUREFIRE-1689 progress has been finished until the CI build succeeds. T On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte wrote: > Ah, there it is :) > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau > wrote: > > > Didnt expect my comment about shade to take so much space in this thread > > but yes we rely on asm for relocation: > > > https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453 > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte a > > écrit : > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau > >> wrote: > >> > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte a > >> > écrit : > >> > > >> >> As far as I know, surefire won't touch the Plexus Java code that > >> >> requires > >> >> ASM. > >> >> It is ONLY required when the runtime is Java 8 or lower AND you > need > >> to > >> >> read the module descriptors. > >> >> > >> >> Maven Shade is a different case: it must parse the Java bytecode (and > >> >> only > >> >> when using minifyJar), hence it needs the latest ASM. > >> >> > >> > > >> > + Relocation ;) > >> > >> Well, the unexpected answer is actually No, see > >> > >> > >> > https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java > >> > >> (but it might be better to do so...) > >> > >> > > >> > > >> >> Robert > >> >> > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana > >> >> > >> >> > >> >> wrote: > >> >> > >> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0. > >> >> > The support for JDk 13 and 14 is in the version 7.2. > >> >> > We have similar upgrade in > >> >> > https://github.com/apache/maven-shade-plugin/pull/29 > >> >> > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy > >> wrote: > >> >> > > >> >> >> Hi, > >> >> >> It's now almost 10 months since last and around 30 issues fixed. > >> >> >> Maybe time for a new release? > >> >> >> Moving issues still open to 3.0.0-M5? > >> >> >> > >> >> >> cheers > >> >> >> -- > >> >> >> Olivier Lamy > >> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy > >> >> > >> >> - > >> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> >> For additional commands, e-mail: dev-h...@maven.apache.org > >> >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
JSR250 in the lib
Hello guys, I just decided to upgrade my build from 3.5.0 to 3.6.2 last night and I stumbled across multiple problems, latest one being the following exception: Nested exception is java.lang.NoSuchMethodError: javax.annotation.Resource.lookup()Ljava/lang/String; Seems like maven 3.6.2 comes with jsr-250-api-1.0.jar in the lib/ folder and that seems to cause problems for me because I have moneta in my classpath which brings newer version of jsr250: [INFO] --- maven-dependency-plugin:3.1.1:tree (default-cli) @ drmartens --- [INFO] com.demo:drmartens:war:1.0-SNAPSHOT [INFO] \- com.nemesis.platform:nemesis-platform-core:jar:2.1.67.BUILD-SNAPSHOT:compile [INFO]\- org.javamoney:moneta:pom:1.3:compile [INFO] \- javax.annotation:javax.annotation-api:jar:1.3.2:compile [INFO] So I was able to fix this following this recommendation: https://stackoverflow.com/questions/52607814/how-to-remove-a-maven-lib-jsr250-api-1-0-jar-from-the-plugin-classpath-jetty using extensions, but I was wondering: why do we need the JSR250 in the lib folder? Also why do we need such an old version? -- Regards, Petar! Karlovo, Bulgaria. --- Public PGP Key at: http://pgp.mit.edu:11371/pks/lookup?op=get=0x19658550C3110611 Key Fingerprint: A369 A7EE 61BC 93A3 CDFF 55A5 1965 8550 C311 0611
Re: Surefire 3.0.0-M4 release?
Ah, there it is :) On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau wrote: Didnt expect my comment about shade to take so much space in this thread but yes we rely on asm for relocation: https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453 Le dim. 13 oct. 2019 à 00:20, Robert Scholte a écrit : On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau wrote: > Le sam. 12 oct. 2019 à 13:33, Robert Scholte a > écrit : > >> As far as I know, surefire won't touch the Plexus Java code that >> requires >> ASM. >> It is ONLY required when the runtime is Java 8 or lower AND you need to >> read the module descriptors. >> >> Maven Shade is a different case: it must parse the Java bytecode (and >> only >> when using minifyJar), hence it needs the latest ASM. >> > > + Relocation ;) Well, the unexpected answer is actually No, see https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java (but it might be better to do so...) > > >> Robert >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana >> >> >> wrote: >> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0. >> > The support for JDk 13 and 14 is in the version 7.2. >> > We have similar upgrade in >> > https://github.com/apache/maven-shade-plugin/pull/29 >> > >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy wrote: >> > >> >> Hi, >> >> It's now almost 10 months since last and around 30 issues fixed. >> >> Maybe time for a new release? >> >> Moving issues still open to 3.0.0-M5? >> >> >> >> cheers >> >> -- >> >> Olivier Lamy >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Surefire 3.0.0-M4 release?
On Sun, 13 Oct 2019 00:35:51 +0200, Tibor Digana wrote: It is ONLY required when the runtime is Java 8 or lower AND you need to read the module descriptors. thx for clarifying. Am i right if I say that it would happen with J9/Toolchain used in Compiler but J8 in the Maven build? Is it realistic? Maybe some people would do it due to some other plugins unreliable on J9+ WDYT? It depends on the purpose. Suppose there's a plugin that wants to do all kinds of analysis on dependencies where Java 8 is good enough, expect for the module decriptors, then this feature with ASM makes it possible. On Sun, Oct 13, 2019 at 12:20 AM Robert Scholte wrote: On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau wrote: > Le sam. 12 oct. 2019 à 13:33, Robert Scholte a > écrit : > >> As far as I know, surefire won't touch the Plexus Java code that >> requires >> ASM. >> It is ONLY required when the runtime is Java 8 or lower AND you need to >> read the module descriptors. >> >> Maven Shade is a different case: it must parse the Java bytecode (and >> only >> when using minifyJar), hence it needs the latest ASM. >> > > + Relocation ;) Well, the unexpected answer is actually No, see https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java (but it might be better to do so...) > > >> Robert >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana >> >> >> wrote: >> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0. >> > The support for JDk 13 and 14 is in the version 7.2. >> > We have similar upgrade in >> > https://github.com/apache/maven-shade-plugin/pull/29 >> > >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy wrote: >> > >> >> Hi, >> >> It's now almost 10 months since last and around 30 issues fixed. >> >> Maybe time for a new release? >> >> Moving issues still open to 3.0.0-M5? >> >> >> >> cheers >> >> -- >> >> Olivier Lamy >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Surefire 3.0.0-M4 release?
Didnt expect my comment about shade to take so much space in this thread but yes we rely on asm for relocation: https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453 Le dim. 13 oct. 2019 à 00:20, Robert Scholte a écrit : > On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau > wrote: > > > Le sam. 12 oct. 2019 à 13:33, Robert Scholte a > > écrit : > > > >> As far as I know, surefire won't touch the Plexus Java code that > >> requires > >> ASM. > >> It is ONLY required when the runtime is Java 8 or lower AND you need to > >> read the module descriptors. > >> > >> Maven Shade is a different case: it must parse the Java bytecode (and > >> only > >> when using minifyJar), hence it needs the latest ASM. > >> > > > > + Relocation ;) > > Well, the unexpected answer is actually No, see > > > https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java > > (but it might be better to do so...) > > > > > > >> Robert > >> > >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana > >> > >> > >> wrote: > >> > >> > We still use plexus-java:1.0.3 which depends on ASM 7.0. > >> > The support for JDk 13 and 14 is in the version 7.2. > >> > We have similar upgrade in > >> > https://github.com/apache/maven-shade-plugin/pull/29 > >> > > >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy > wrote: > >> > > >> >> Hi, > >> >> It's now almost 10 months since last and around 30 issues fixed. > >> >> Maybe time for a new release? > >> >> Moving issues still open to 3.0.0-M5? > >> >> > >> >> cheers > >> >> -- > >> >> Olivier Lamy > >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
