[GitHub] [maven-site] michael-o commented on a change in pull request #188: Introduce section heading for BOM pattern

2020-08-01 Thread GitBox


michael-o commented on a change in pull request #188:
URL: https://github.com/apache/maven-site/pull/188#discussion_r463952483



##
File path: 
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##
@@ -48,6 +48,8 @@ Introduction to the Dependency Mechanism
 
* {{{Importing_Dependencies}Importing Dependencies}}
 
+   * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}

Review comment:
   That is not what I was referring to.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [RESULT] [VOTE] Release Maven Resolver version 1.5.0

2020-08-01 Thread Michael Osipov
See MRESOLVER-123. Please define slow in comparable numbers.

 Ursprüngliche Nachricht Von: Dan Tran  
Datum: 01.08.20  11:33  (GMT+01:00) An: Maven Developers List 
 Betreff: Re: [RESULT] [VOTE] Release Maven Resolver 
version 1.5.0 I am interesting pickup latest maven-resolver hoping it can solve 
somerandom issue at our buildsSince 1.5.0 no longer available, I rebuilt maven 
3.6.3 with maven-resolver1.5.1-SNAPSHOT.   and hook it up our internal buildThe 
startup of my build is quite slow... however, I am looking forward totesting 
again with next maven-resolver voteThanks-DOn Wed, Jul 22, 2020 at 1:03 AM Mark 
Derricutt  wrote:> Hervé, Michael - missed the email about the 
vote earlier, just went hunting> for the repo details to try it out on our 
internal range resolver/locking> tool.>> +1 NON Binding here - passes my unit 
tests on my library, and the maven> mojo that uses it runs fine as works as 
expected.>> Mark>>> On 22 July 2020 at 6:05:39 PM, Hervé BOUTEMY 
(herve.bout...@free.fr)> wrote:>> hey, keep cool, take time: 72h is the 
minimum, not the period after which> the vote stops there was some discussions, 
people are on vacation, it takes> more time than usual, nothing that a little 
bit of time won't solve> Regards, Hervé Le mardi 21 juillet 2020, 20:32:49 CEST 
Michael Osipov a> écrit : > Hi, > > The vote has passed and failed to reach a 
quorum. Only> one, non-binding > vote has been cast. Therefore, I cancel the 
release and> will drop the > staging repo tomorrow. > > Michael>

Re: [RESULT] [VOTE] Release Maven Resolver version 1.5.0

2020-08-01 Thread Dan Tran
I am interesting pickup latest maven-resolver hoping it can solve some
random issue at our builds

Since 1.5.0 no longer available, I rebuilt maven 3.6.3 with maven-resolver
1.5.1-SNAPSHOT.   and hook it up our internal build

The startup of my build is quite slow... however, I am looking forward to
testing again with next maven-resolver vote

Thanks

-D

On Wed, Jul 22, 2020 at 1:03 AM Mark Derricutt  wrote:

> Hervé, Michael - missed the email about the vote earlier, just went hunting
> for the repo details to try it out on our internal range resolver/locking
> tool.
>
> +1 NON Binding here - passes my unit tests on my library, and the maven
> mojo that uses it runs fine as works as expected.
>
> Mark
>
>
> On 22 July 2020 at 6:05:39 PM, Hervé BOUTEMY (herve.bout...@free.fr)
> wrote:
>
> hey, keep cool, take time: 72h is the minimum, not the period after which
> the vote stops there was some discussions, people are on vacation, it takes
> more time than usual, nothing that a little bit of time won't solve
> Regards, Hervé Le mardi 21 juillet 2020, 20:32:49 CEST Michael Osipov a
> écrit : > Hi, > > The vote has passed and failed to reach a quorum. Only
> one, non-binding > vote has been cast. Therefore, I cancel the release and
> will drop the > staging repo tomorrow. > > Michael
>


[GitHub] [maven-site] mkarg commented on a change in pull request #188: Introduce section heading for BOM pattern

2020-08-01 Thread GitBox


mkarg commented on a change in pull request #188:
URL: https://github.com/apache/maven-site/pull/188#discussion_r463934565



##
File path: 
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##
@@ -48,6 +48,8 @@ Introduction to the Dependency Mechanism
 
* {{{Importing_Dependencies}Importing Dependencies}}
 
+   * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}

Review comment:
   I think what Ed wanted to say with this is correct: "Bill of Material - 
style POM, a.k.a. BOM"





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] [maven-site] michael-o commented on a change in pull request #188: Introduce section heading for BOM pattern

2020-08-01 Thread GitBox


michael-o commented on a change in pull request #188:
URL: https://github.com/apache/maven-site/pull/188#discussion_r463934456



##
File path: 
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##
@@ -48,6 +48,8 @@ Introduction to the Dependency Mechanism
 
* {{{Importing_Dependencies}Importing Dependencies}}
 
+   * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}

Review comment:
   poms > POMs





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven Shared Utils version 3.3.3

2020-08-01 Thread Hervé BOUTEMY
ok, I see: it will be tricky to reproduce...
I fear I won't be able to publish to "Reproducible Central" 
https://github.com/jvm-repo-rebuild/reproducible-central

for future releases, I think we should avoid such toolchain usage
It means that before doing a release, checking if javadoc can be built should 
also be done, to avoid discovering issues during the release

Regards,

Hervé

Le vendredi 31 juillet 2020, 08:42:26 CEST Dennis Lundberg a écrit :
> Thanks Hervé,
> 
> The build was done using AdoptOpenJdk 8 update 242, but using toolchains.
> Failed Javadoc was one of the reasons for using toolchains, there were just
> soo many errors. The toolchain itself used Java 7 update 79 from Oracle, so
> the bytecode should be different if you don't use toolchains.
> 
> You can see more details about my build process and problems in this JIRA
> issue:
> https://issues.apache.org/jira/browse/MNGSITE-419
> 
> --
> Dennis Lundberg
> 
> Den tors 30 juli 2020 kl 22:36 skrev Hervé BOUTEMY :
> > +1
> > 
> > trying to check reproducible builds, found that reference build was done
> > with
> > JDK 8 on Windows
> > But I got 2 issues to reproduce:
> > 1. javadoc fails with JDK 8
> > 2. your bytecode is different from mine
> > 
> > what detailed distribution of JDK did you use, please? Mine is
> > AdoptOpenJDK
> > 1.8.0_202
> > 
> > Regards,
> > 
> > Hervé
> > 
> > Le vendredi 24 juillet 2020, 16:08:10 CEST Dennis Lundberg a écrit :
> > > Hi,
> > > 
> > > We solved 12
> > 
> > > issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12342
> > 
> > 756=Text=12317922=Create_token=A5KQ-2QAV-T4
> > JA> 
> > > -FDED_7bf996098e890abc72bf3628a70b9090574f431d_lin
> > > 
> > > There are still a couple of issues left in
> > 
> > > JIRA:
> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AN
> > 
> > D%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20maven-shared-u
> > ti> 
> > > ls%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
> > > 
> > > Staging
> > 
> > > repo:
> > https://repository.apache.org/content/repositories/maven-1598/https://
> > 
> > repository.apache.org/service/local/repositories/maven-1598/content/org/ap
> > ac
> > 
> > he/maven/shared/maven-shared-utils/3.3.3/maven-shared-utils-3.3.3-source-r
> > el> 
> > > ease.zip
> > > 
> > > Source release checksum(s):
> > 
> > > maven-shared-utils-3.3.3-source-release.zip sha512:
> > 6085d3bb3d065efaca7ed43f7342c2b71c624235ff38cd1410a06a4c915e39a13cb00e65e8
> > c0> 
> > > cd7203dc5b2d1deeb392eaab2aa0a43bfadb7c9d4286a2b473bc
> > > 
> > > Staging
> > 
> > > site:
> > https://maven.apache.org/components/shared-archives/maven-shared-utils
> > 
> > > -LATEST/
> > > 
> > > Guide to testing staged
> > 
> > > releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.
> > 
> > > html
> > > 
> > > Vote open for at least 72 hours.
> > > 
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > > 
> > > As some of you might have noticed we ended up with version 3.3.3 instead
> > 
> > of
> > 
> > > the planned 3.3.1. I had some issues with the release process and burned
> > 
> > 2
> > 
> > > releases. I will address that in a JIRA issue shortly. Please let me
> > > know
> > > if I have missed anything.
> > > 
> > > --
> > > Dennis Lundberg
> > 
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org