[GitHub] [maven-site] dzikoysk edited a comment on pull request #168: [MNGSITE-412] Add NanoMaven to the list of available repository managers

2020-05-17 Thread GitBox
dzikoysk edited a comment on pull request #168: URL: https://github.com/apache/maven-site/pull/168#issuecomment-629833688 > > Project looks active only in last month, website, hosting repo site - not very clear about how to use it, who manages it etc. This is just a minimal proje

[GitHub] [maven-site] rfscholte commented on pull request #168: [MNGSITE-412] Add NanoMaven to the list of available repository managers

2020-05-17 Thread GitBox
rfscholte commented on pull request #168: URL: https://github.com/apache/maven-site/pull/168#issuecomment-629865416 I do think the name conflicts. NanoMaven is clearly referring to Apache Maven, but it is unclear that the project is not part of Apache Maven. To prevent any possible confusi

[GitHub] [maven-site] dzikoysk commented on pull request #168: [MNGSITE-412] Add Reposilite to the list of available repository managers

2020-05-18 Thread GitBox
dzikoysk commented on pull request #168: URL: https://github.com/apache/maven-site/pull/168#issuecomment-630034983 I agree that the name was referring to Apache Maven, but I don't think it makes any confusion, it's like saying that GitHub or GitLab is a part of Git and its specification 🤷

[GitHub] [maven-site] dzikoysk edited a comment on pull request #168: [MNGSITE-412] Add Reposilite to the list of available repository managers

2020-05-18 Thread GitBox
dzikoysk edited a comment on pull request #168: URL: https://github.com/apache/maven-site/pull/168#issuecomment-630034983 I agree that the name was referring to Apache Maven, but I don't think it makes any confusion, it's like saying that GitHub or GitLab is a part of Git and its specifica

[GitHub] [maven-site] dzikoysk edited a comment on pull request #168: [MNGSITE-412] Add Reposilite to the list of available repository managers

2020-05-18 Thread GitBox
dzikoysk edited a comment on pull request #168: URL: https://github.com/apache/maven-site/pull/168#issuecomment-630034983 I agree that the name was referring to Apache Maven, but I don't think it makes any confusion, it's like saying that GitHub or GitLab is a part of Git and its specifica

[GitHub] [maven-site] dzikoysk edited a comment on pull request #168: [MNGSITE-412] Add Reposilite to the list of available repository managers

2020-05-18 Thread GitBox
dzikoysk edited a comment on pull request #168: URL: https://github.com/apache/maven-site/pull/168#issuecomment-630034983 I agree that the name was referring to Apache Maven, but I don't think it makes any confusion, it's like saying that GitHub or GitLab is a part of Git and its specifica

[GitHub] [maven-site] elharo opened a new pull request #169: [MNGSITE-393] assume Maven 3

2020-05-18 Thread GitBox
elharo opened a new pull request #169: URL: https://github.com/apache/maven-site/pull/169 @rfscholte and fix some grammar This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [maven-site] elharo merged pull request #169: [MNGSITE-393] assume Maven 3

2020-05-18 Thread GitBox
elharo merged pull request #169: URL: https://github.com/apache/maven-site/pull/169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
michael-o commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427583663 ## File path: pom.xml ## @@ -196,11 +196,11 @@ under the License. 3.0 -7 +8 Review comment: @olamy I am the bureaucrati

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
michael-o commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427584057 ## File path: pom.xml ## @@ -211,6 +211,8 @@ under the License. 2.7 2.22.1 2020-03-06T20:49:49Z +1.8 Review comment: I

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427587877 ## File path: pom.xml ## @@ -196,11 +196,11 @@ under the License. 3.0 -7 +8 Review comment: it's ALREADY there https://issu

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427588408 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plugins

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
michael-o commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591526 ## File path: pom.xml ## @@ -196,11 +196,11 @@ under the License. 3.0 -7 +8 Review comment: Good, let's re-merge MSITE-

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591510 ## File path: pom.xml ## @@ -473,28 +474,28 @@ under the License. org.slf4j slf4j-api - 1.5.3 + 1.7.29 test

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
michael-o commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591833 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plug

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427588408 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plugins

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427595053 ## File path: pom.xml ## @@ -473,28 +474,28 @@ under the License. org.slf4j slf4j-api - 1.5.3 + 1.7.29 test

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427601611 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plugins

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
michael-o commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427603026 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plug

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

2020-05-19 Thread GitBox
olamy commented on a change in pull request #21: URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427603657 ## File path: src/it/projects/new-configuration/pom.xml ## @@ -76,7 +76,7 @@ under the License. org.apache.maven.plugins

[GitHub] [maven-site] elharo opened a new pull request #170: [MNGSITE-393} we do not support Maven 2

2020-05-23 Thread GitBox
elharo opened a new pull request #170: URL: https://github.com/apache/maven-site/pull/170 @slachiewicz This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [maven-site] elharo commented on pull request #170: [MNGSITE-393] we do not support Maven 2

2020-05-23 Thread GitBox
elharo commented on pull request #170: URL: https://github.com/apache/maven-site/pull/170#issuecomment-633090938 This doesn't change that. It just removes mention of Maven 2 from this page as part of a long effort to purge all Maven 2 from or main docs. --

[GitHub] [maven-site] elharo merged pull request #170: [MNGSITE-393] we do not support Maven 2

2020-05-23 Thread GitBox
elharo merged pull request #170: URL: https://github.com/apache/maven-site/pull/170 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site-plugin] elharo opened a new pull request #22: add .checkstyle to .gitignore

2020-05-24 Thread GitBox
elharo opened a new pull request #22: URL: https://github.com/apache/maven-site-plugin/pull/22 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [maven-site-plugin] elharo opened a new pull request #23: remove unused code

2020-05-24 Thread GitBox
elharo opened a new pull request #23: URL: https://github.com/apache/maven-site-plugin/pull/23 @olamy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [maven-site-plugin] elharo opened a new pull request #24: remove Maven 2 support

2020-05-24 Thread GitBox
elharo opened a new pull request #24: URL: https://github.com/apache/maven-site-plugin/pull/24 @olamy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-site-plugin] elharo merged pull request #22: add .checkstyle to .gitignore

2020-05-24 Thread GitBox
elharo merged pull request #22: URL: https://github.com/apache/maven-site-plugin/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-site-plugin] elharo merged pull request #23: remove unused code

2020-05-24 Thread GitBox
elharo merged pull request #23: URL: https://github.com/apache/maven-site-plugin/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-site-plugin] elharo opened a new pull request #25: [MSITE-859] update apache commons lang and IO

2020-05-24 Thread GitBox
elharo opened a new pull request #25: URL: https://github.com/apache/maven-site-plugin/pull/25 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [maven-site-plugin] slachiewicz commented on pull request #24: [MSITE-845] remove Maven 2 support

2020-05-24 Thread GitBox
slachiewicz commented on pull request #24: URL: https://github.com/apache/maven-site-plugin/pull/24#issuecomment-633230040 We already have PR #12 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [maven-site-plugin] elharo commented on pull request #24: [MSITE-845] remove Maven 2 support

2020-05-24 Thread GitBox
elharo commented on pull request #24: URL: https://github.com/apache/maven-site-plugin/pull/24#issuecomment-633232518 Can that one be merged? This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [maven-site-plugin] slachiewicz commented on pull request #24: [MSITE-845] remove Maven 2 support

2020-05-24 Thread GitBox
slachiewicz commented on pull request #24: URL: https://github.com/apache/maven-site-plugin/pull/24#issuecomment-633245302 build looks green https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-site-plugin/job/MSITE-845/ ---

[GitHub] [maven-site-plugin] elharo merged pull request #25: [MSITE-859] update apache commons lang and IO

2020-05-24 Thread GitBox
elharo merged pull request #25: URL: https://github.com/apache/maven-site-plugin/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-site] elharo opened a new pull request #171: docs: remove links that don't go where they say

2020-05-25 Thread GitBox
elharo opened a new pull request #171: URL: https://github.com/apache/maven-site/pull/171 @hboutemy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-site-plugin] elharo commented on pull request #24: [MSITE-845] remove Maven 2 support

2020-05-25 Thread GitBox
elharo commented on pull request #24: URL: https://github.com/apache/maven-site-plugin/pull/24#issuecomment-633556128 @Tibor17 do you want to merge #12 before I merge this one? This is an automated message from the Apache Gi

[GitHub] [maven-site-plugin] asfgit closed pull request #12: [MSITE-845] Drop Maven 2 support

2020-05-26 Thread GitBox
asfgit closed pull request #12: URL: https://github.com/apache/maven-site-plugin/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-site-plugin] elharo opened a new pull request #29: [MSITE-861] remove obsolete dependency

2020-05-26 Thread GitBox
elharo opened a new pull request #29: URL: https://github.com/apache/maven-site-plugin/pull/29 @michael-o exclusion no longer necessary with latest doxias [INFO] +- org.apache.maven.doxia:doxia-site-renderer:jar:1.9.2:compile [INFO] | +- org.apache.maven.doxia:doxia-skin-m

[GitHub] [maven-site-plugin] slachiewicz closed pull request #27: [MSITE-757] More cleanup after upgrade to Maven 3.0.5

2020-05-26 Thread GitBox
slachiewicz closed pull request #27: URL: https://github.com/apache/maven-site-plugin/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-site-plugin] elharo merged pull request #24: [MSITE-757] remove Maven 2 support

2020-05-26 Thread GitBox
elharo merged pull request #24: URL: https://github.com/apache/maven-site-plugin/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-artifact-transfer] elharo merged pull request #12: [MNGSITE-393] drop Maven 2

2020-05-26 Thread GitBox
elharo merged pull request #12: URL: https://github.com/apache/maven-artifact-transfer/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [maven-site] elharo merged pull request #171: docs: remove links that don't go where they say

2020-05-26 Thread GitBox
elharo merged pull request #171: URL: https://github.com/apache/maven-site/pull/171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-site-plugin] slachiewicz commented on pull request #27: [MSITE-757] More cleanup after upgrade to Maven 3.0.5

2020-05-26 Thread GitBox
slachiewicz commented on pull request #27: URL: https://github.com/apache/maven-site-plugin/pull/27#issuecomment-633969397 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [maven-site-plugin] elharo opened a new pull request #28: docs: use https

2020-05-26 Thread GitBox
elharo opened a new pull request #28: URL: https://github.com/apache/maven-site-plugin/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [maven-site-plugin] elharo merged pull request #26: [MSITE-757] drop Maven 2 mention

2020-05-26 Thread GitBox
elharo merged pull request #26: URL: https://github.com/apache/maven-site-plugin/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-artifact-transfer] elharo opened a new pull request #12: [MNGSITE-393] drop Maven 2

2020-05-26 Thread GitBox
elharo opened a new pull request #12: URL: https://github.com/apache/maven-artifact-transfer/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-site-plugin] slachiewicz commented on pull request #24: [MSITE-845] remove Maven 2 support

2020-05-26 Thread GitBox
slachiewicz commented on pull request #24: URL: https://github.com/apache/maven-site-plugin/pull/24#issuecomment-633713346 Ok #12 merged to master. Please rebase a d resolve conflicts in this pr This is an automated message f

[GitHub] [maven-site-plugin] slachiewicz opened a new pull request #27: [MSITE-757] More cleanup after upgrade to Maven 3.0.5

2020-05-26 Thread GitBox
slachiewicz opened a new pull request #27: URL: https://github.com/apache/maven-site-plugin/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-site-plugin] elharo commented on pull request #27: [MSITE-757] More cleanup after upgrade to Maven 3.0.5

2020-05-26 Thread GitBox
elharo commented on pull request #27: URL: https://github.com/apache/maven-site-plugin/pull/27#issuecomment-634132747 seems to have broken Jenkins: https://builds.apache.org/job/maven-box/job/maven-site-plugin/job/master/99/

[GitHub] [maven-site-plugin] elharo merged pull request #29: [MSITE-861] remove obsolete dependency

2020-05-26 Thread GitBox
elharo merged pull request #29: URL: https://github.com/apache/maven-site-plugin/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-site-plugin] elharo opened a new pull request #26: [MSITE-845] drop Maven 2 mention

2020-05-26 Thread GitBox
elharo opened a new pull request #26: URL: https://github.com/apache/maven-site-plugin/pull/26 @olamy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-site-plugin] elharo merged pull request #28: docs: use https

2020-05-26 Thread GitBox
elharo merged pull request #28: URL: https://github.com/apache/maven-site-plugin/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-doxia-site] asfgit closed pull request #1: [DOXIA-608] Add licenses to make RAT happy

2020-05-27 Thread GitBox
asfgit closed pull request #1: URL: https://github.com/apache/maven-doxia-site/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven-site-plugin] elharo opened a new pull request #30: [MNGSITE-393] remove Maven 1 and 2 info

2020-05-28 Thread GitBox
elharo opened a new pull request #30: URL: https://github.com/apache/maven-site-plugin/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [maven-site-plugin] elharo merged pull request #30: [MNGSITE-393] remove Maven 1 and 2 info

2020-05-28 Thread GitBox
elharo merged pull request #30: URL: https://github.com/apache/maven-site-plugin/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-site] dzikoysk commented on pull request #168: [MNGSITE-412] Add Reposilite to the list of available repository managers

2020-05-30 Thread GitBox
dzikoysk commented on pull request #168: URL: https://github.com/apache/maven-site/pull/168#issuecomment-636315538 Any thoughts on that? :) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-site] asfgit closed pull request #168: [MNGSITE-412] Add Reposilite to the list of available repository managers

2020-05-30 Thread GitBox
asfgit closed pull request #168: URL: https://github.com/apache/maven-site/pull/168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-shared-jar] elharo opened a new pull request #3: ignore more metadata files

2020-05-31 Thread GitBox
elharo opened a new pull request #3: URL: https://github.com/apache/maven-shared-jar/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [maven-shared-jar] elharo opened a new pull request #4: [MSHARED-905] set Maven 3.1.0 as minimum and cleanup dependencies

2020-05-31 Thread GitBox
elharo opened a new pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [maven-site] elharo opened a new pull request #172: docs: https links

2020-05-31 Thread GitBox
elharo opened a new pull request #172: URL: https://github.com/apache/maven-site/pull/172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-shared-jar] slachiewicz commented on pull request #4: [MSHARED-905] set Maven 3.1.0 as minimum and cleanup dependencies

2020-05-31 Thread GitBox
slachiewicz commented on pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636472449 https://github.com/apache/maven-shared-jar/commit/580f53c1b63a7630cb3a70822035f4531bfadf2b This is an au

[GitHub] [maven-shared-jar] slachiewicz edited a comment on pull request #4: [MSHARED-905] set Maven 3.1.0 as minimum and cleanup dependencies

2020-05-31 Thread GitBox
slachiewicz edited a comment on pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636472449 See other jira and commit https://github.com/apache/maven-shared-jar/commit/580f53c1b63a7630cb3a70822035f4531bfadf2b -

[GitHub] [maven-shared-jar] elharo merged pull request #3: ignore more metadata files

2020-05-31 Thread GitBox
elharo merged pull request #3: URL: https://github.com/apache/maven-shared-jar/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven-shared-jar] elharo commented on pull request #4: [MSHARED-905] set Maven 3.1.0 as minimum and cleanup dependencies

2020-05-31 Thread GitBox
elharo commented on pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636474949 That code doesn't seem to be in HEAD? This is an automated message from the Apache Git Service. To respond to

[GitHub] [maven-shared-jar] elharo commented on pull request #4: [MSHARED-887] set Maven 3.1.0 as minimum and cleanup dependencies

2020-05-31 Thread GitBox
elharo commented on pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636486988 @slachiewicz After looking at that commit, the difference seems to be that this PR imports plexus-containers-default and that one imports org.eclipse.sisu.plexus. I'm

[GitHub] [maven-site] elharo merged pull request #172: docs: https links

2020-05-31 Thread GitBox
elharo merged pull request #172: URL: https://github.com/apache/maven-site/pull/172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-shared-jar] slachiewicz commented on pull request #4: [MSHARED-887] set Maven 3.1.0 as minimum and cleanup dependencies

2020-05-31 Thread GitBox
slachiewicz commented on pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636504356 I use the plexus version that was imported by the Maven 3.1 dependencies (3.1.1 already has a different version). It seems to me that if we use a newer version of Plexus

[GitHub] [maven-shared-jar] elharo closed pull request #4: [MSHARED-887] set Maven 3.1.0 as minimum and cleanup dependencies

2020-06-01 Thread GitBox
elharo closed pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven-site-plugin] jonvolfson opened a new pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

2020-06-02 Thread GitBox
jonvolfson opened a new pull request #31: URL: https://github.com/apache/maven-site-plugin/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [maven-site-plugin] jonvolfson commented on pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

2020-06-02 Thread GitBox
jonvolfson commented on pull request #31: URL: https://github.com/apache/maven-site-plugin/pull/31#issuecomment-637769611 @elharo @bimargulies This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [maven-site-plugin] elharo commented on a change in pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

2020-06-02 Thread GitBox
elharo commented on a change in pull request #31: URL: https://github.com/apache/maven-site-plugin/pull/31#discussion_r434153263 ## File path: src/it/projects/MSITE-856/pom.xml ## @@ -0,0 +1,69 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/X

[GitHub] [maven-site-plugin] jonvolfson commented on a change in pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

2020-06-03 Thread GitBox
jonvolfson commented on a change in pull request #31: URL: https://github.com/apache/maven-site-plugin/pull/31#discussion_r434688818 ## File path: src/main/java/org/apache/maven/plugins/site/render/SiteMap.java ## @@ -172,9 +172,13 @@ private static void extractItems( List item

[GitHub] [maven-site-plugin] elharo commented on a change in pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

2020-06-03 Thread GitBox
elharo commented on a change in pull request #31: URL: https://github.com/apache/maven-site-plugin/pull/31#discussion_r434760284 ## File path: src/it/projects/MSITE-856/src/site/site.xml ## @@ -0,0 +1,30 @@ + + + + +http://maven.apache.org/DECORATION/1.6.0"; + xmlns:xsi

[GitHub] [maven-site-plugin] jonvolfson commented on a change in pull request #31: [MSITE-856] - NullPointer on org.apache.maven.plugins.site.render.SiteMap.relativePath

2020-06-03 Thread GitBox
jonvolfson commented on a change in pull request #31: URL: https://github.com/apache/maven-site-plugin/pull/31#discussion_r434863055 ## File path: src/it/projects/MSITE-856/verify.bsh ## @@ -0,0 +1,48 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [maven-site] elharo opened a new pull request #173: docs: subversion URLs no longer exist

2020-06-05 Thread GitBox
elharo opened a new pull request #173: URL: https://github.com/apache/maven-site/pull/173 @rfscholte use Github This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-site] rfscholte commented on a change in pull request #173: docs: subversion URLs no longer exist

2020-06-05 Thread GitBox
project. In order to remove all doubt, this page only applies to code + which has a Github URL that starts with + <<<https://github.com/apache/maven>>> or a Gitbox URL + starting with <<<https://git-wip-us.apache.org/repos/asf/maven>>> Review comment:

[GitHub] [maven-artifact-transfer] elharo opened a new pull request #13: update mockito-core to 2.28.2

2020-06-06 Thread GitBox
elharo opened a new pull request #13: URL: https://github.com/apache/maven-artifact-transfer/pull/13 Deliberately did not file a JIRA issue for this per latest communication from project lead This is an automated message fro

[GitHub] [maven-artifact-transfer] elharo merged pull request #13: update mockito-core to 2.28.2

2020-06-06 Thread GitBox
elharo merged pull request #13: URL: https://github.com/apache/maven-artifact-transfer/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [maven-artifact-transfer] elharo opened a new pull request #14: docs: fix minor doc comment issues

2020-06-06 Thread GitBox
elharo opened a new pull request #14: URL: https://github.com/apache/maven-artifact-transfer/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [maven-artifact-transfer] elharo merged pull request #14: docs: fix minor doc comment issues

2020-06-06 Thread GitBox
elharo merged pull request #14: URL: https://github.com/apache/maven-artifact-transfer/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [maven-artifact-transfer] olamy commented on pull request #13: update mockito-core to 2.28.2

2020-06-06 Thread GitBox
olamy commented on pull request #13: URL: https://github.com/apache/maven-artifact-transfer/pull/13#issuecomment-640130752 **NO NEED OF PR FOR THIS** This is an automated message from the Apache Git Service. To respond to th

[GitHub] [maven-artifact-transfer] slachiewicz opened a new pull request #15: [MSHARED-920] Inject RepositoryManager

2020-06-07 Thread GitBox
slachiewicz opened a new pull request #15: URL: https://github.com/apache/maven-artifact-transfer/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [maven-artifact-transfer] asfgit closed pull request #15: [MSHARED-920] Inject RepositoryManager

2020-06-07 Thread GitBox
asfgit closed pull request #15: URL: https://github.com/apache/maven-artifact-transfer/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [maven-site] elharo opened a new pull request #174: [MNGSITE-393] clean up old info

2020-06-10 Thread GitBox
elharo opened a new pull request #174: URL: https://github.com/apache/maven-site/pull/174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-site] elharo opened a new pull request #175: docs: clarify dependency scope rules

2020-06-10 Thread GitBox
elharo opened a new pull request #175: URL: https://github.com/apache/maven-site/pull/175 @suztomo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [maven-site] elharo merged pull request #174: [MNGSITE-393] clean up old info

2020-06-10 Thread GitBox
elharo merged pull request #174: URL: https://github.com/apache/maven-site/pull/174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-artifact-transfer] kwin opened a new pull request #16: MSHARED-922 remove checksum calculation from ProjectDeployer

2020-06-11 Thread GitBox
kwin opened a new pull request #16: URL: https://github.com/apache/maven-artifact-transfer/pull/16 The checksums are generated in aether/maven-resolver This is an automated message from the Apache Git Service. To respond to t

[GitHub] [maven-reporting-exec] elharo opened a new pull request #2: update junit

2020-06-11 Thread GitBox
elharo opened a new pull request #2: URL: https://github.com/apache/maven-reporting-exec/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [maven-reporting-exec] elharo opened a new pull request #3: [MSHARED-925] remove guava dependency

2020-06-11 Thread GitBox
elharo opened a new pull request #3: URL: https://github.com/apache/maven-reporting-exec/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [maven-reporting-exec] elharo opened a new pull request #4: update velocity

2020-06-11 Thread GitBox
elharo opened a new pull request #4: URL: https://github.com/apache/maven-reporting-exec/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [maven-reporting-exec] elharo opened a new pull request #5: add .checkstyle to .ignore

2020-06-11 Thread GitBox
elharo opened a new pull request #5: URL: https://github.com/apache/maven-reporting-exec/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [maven-reporting-exec] elharo opened a new pull request #6: update maven-shared-utils

2020-06-11 Thread GitBox
elharo opened a new pull request #6: URL: https://github.com/apache/maven-reporting-exec/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [maven-reporting-exec] elharo merged pull request #5: add .checkstyle to .ignore

2020-06-11 Thread GitBox
elharo merged pull request #5: URL: https://github.com/apache/maven-reporting-exec/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-artifact-transfer] michael-o commented on pull request #16: [MSHARED-922] remove checksum calculation from ProjectDeployer

2020-06-11 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-artifact-transfer/pull/16#issuecomment-642617311 I wonder whether this could affect older Maven versions which update to a plugin with this shared component version.

[GitHub] [maven-artifact-transfer] kwin commented on pull request #16: [MSHARED-922] remove checksum calculation from ProjectDeployer

2020-06-11 Thread GitBox
kwin commented on pull request #16: URL: https://github.com/apache/maven-artifact-transfer/pull/16#issuecomment-642622795 The relevant IT is executed with Maven 3.0.5 and newer (https://github.com/apache/maven-artifact-transfer/blob/87842f9c712eb6496b32d4aff09307d0970d9f7b/src/it/maven-pro

[GitHub] [maven-reporting-exec] elharo merged pull request #6: update maven-shared-utils

2020-06-11 Thread GitBox
elharo merged pull request #6: URL: https://github.com/apache/maven-reporting-exec/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-reporting-exec] elharo commented on pull request #3: [MSHARED-925] remove guava dependency

2020-06-11 Thread GitBox
elharo commented on pull request #3: URL: https://github.com/apache/maven-reporting-exec/pull/3#issuecomment-642632642 For test code it probably doesn't matter, but in general that's not a good idea. Collections.singletonList violates the Liskov Substitution Principle. This is a common de

[GitHub] [maven-reporting-exec] elharo merged pull request #3: [MSHARED-925] remove guava dependency

2020-06-11 Thread GitBox
elharo merged pull request #3: URL: https://github.com/apache/maven-reporting-exec/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-artifact-transfer] michael-o commented on pull request #16: [MSHARED-922] remove checksum calculation from ProjectDeployer

2020-06-11 Thread GitBox
michael-o commented on pull request #16: URL: https://github.com/apache/maven-artifact-transfer/pull/16#issuecomment-642647582 Makes sense. I'll run all tests on Jenkins. @rfscholte @khmarbaise opinions? This is an automated

[GitHub] [maven-reporting-exec] elharo merged pull request #2: update junit

2020-06-11 Thread GitBox
elharo merged pull request #2: URL: https://github.com/apache/maven-reporting-exec/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [maven-reporting-exec] elharo commented on pull request #4: update velocity

2020-06-11 Thread GitBox
elharo commented on pull request #4: URL: https://github.com/apache/maven-reporting-exec/pull/4#issuecomment-642675049 On further investigation, it looks like we can completely remove the velocity dependence. This is an au

<    1   2   3   4   5   6   7   8   9   10   >