[GitHub] maven-surefire issue #165: Merge master to junit5
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/165 @britter Sorry for late reply. This error is normal behavior because you used `mvn verify`. In surefire you should use `mvn install -P run-its`. We cannot merge master to junit5 because pushing back would become multiple commits. What about if I squash your commits to one? And then it would go to a new branch based on master current HEAD? This branch has old history. Question, Do you have anything in our code to add regarding junit5 activity? You know best. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #163: Surefire-report
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/163 @shafiullas This commit is quite good but you have to fix the code style and register this issue at JIRA. The code conventions are listed in https://maven.apache.org/developers/conventions/code.html In the middle of the page is XML for Eclipse and IDEA. You can use it to configure your tool. Then run the local build mvn install -P run-its. The build has 1400 tests, so it usually takes 50 minutes to complete on SSD disk. Please rework the code style according to Maven convention in our project and use `git commit --ammend`. There should be only single commit per PR and the message should refer to JIRA ID, something like: [SUREFIRE-12345] Surefire-report and you can register at our JIRA here: https://issues.apache.org/jira/projects/SUREFIRE --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #166: Support filtering of tests from Base Class...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/166#discussion_r154519321
--- Diff:
surefire-providers/surefire-testng-utils/src/main/java/org/apache/maven/surefire/testng/utils/MethodSelector.java
---
@@ -62,6 +62,17 @@ private static boolean shouldRun( ITestNGMethod test )
{
TestListResolver resolver = testListResolver;
boolean hasTestResolver = resolver != null && !resolver.isEmpty();
-return hasTestResolver && resolver.shouldRun( test.getRealClass(),
test.getMethodName() );
+boolean resolved = false;
+Class clazz = test.getRealClass();
+if (resolver != null) {
--- End diff --
Please rework the code style according to Maven convention in our project
and use `git commit --ammend`. There should be only single commit per PR and
the message should refer to JIRA ID, something like:
[SUREFIRE-12345] Support filtering of tests from Base Class (TestNG)
and you can register at our Jira here:
https://issues.apache.org/jira/projects/SUREFIRE
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #166: Support filtering of tests from Base Class (TestN...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/166 @krmahadevan Sorry for late reply. I was ill last time and busy in the work. The code conventions are listed in https://maven.apache.org/developers/conventions/code.html In the middle of the page is XML for Eclipse and IDEA. You can use it to configure your tool. Then run the local build `mvn install -P run-its`. The build has 1400 tests, so it usually takes 50 minutes to complete on SSD disk. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #166: Support filtering of tests from Base Class...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/166#discussion_r154519159
--- Diff:
surefire-providers/surefire-testng-utils/src/test/testng/utils/MethodSelectorTest.java
---
@@ -0,0 +1,299 @@
+package testng.utils;
+
+import junit.framework.TestCase;
+import org.apache.maven.surefire.testng.utils.MethodSelector;
+import org.apache.maven.surefire.testset.TestListResolver;
+import org.testng.Assert;
+import org.testng.IClass;
+import org.testng.IRetryAnalyzer;
+import org.testng.ITestClass;
+import org.testng.ITestNGMethod;
+import org.testng.internal.DefaultMethodSelectorContext;
+
+import java.lang.reflect.Method;
+
+public class MethodSelectorTest extends TestCase {
+public void testInclusionOfMethodFromBaseClass() {
+MethodSelector selector = new MethodSelector();
+DefaultMethodSelectorContext context = new
DefaultMethodSelectorContext();
+ITestNGMethod testngMethod = new
FakeTestNGMethod(ChildClassSample.class, "baseClassMethodToBeIncluded");
+TestListResolver resolver = new
TestListResolver(BaseClassSample.class.getName() +
"#baseClassMethodToBeIncluded");
+MethodSelector.setTestListResolver(resolver);
+boolean include = selector.includeMethod(context, testngMethod,
true);
+Assert.assertTrue(include);
+}
+
+private static class FakeTestNGMethod implements ITestNGMethod {
+private Class clazz;
+private String methodName;
+
+FakeTestNGMethod(Class clazz, String methodName) {
+this.clazz = clazz;
+this.methodName = methodName;
+}
+
+@Override
+public Class getRealClass() {
+return clazz;
+}
+
+@Override
+public ITestClass getTestClass() {
+return null;
+}
+
+@Override
+public void setTestClass(ITestClass iTestClass) {
+
+}
+
+@Override
+public Method getMethod() {
+return null;
+}
+
+@Override
+public String getMethodName() {
+return this.methodName;
+}
+
+@Override
+public Object[] getInstances() {
+return new Object[0];
+}
+
+@Override
+public long[] getInstanceHashCodes() {
+return new long[0];
+}
+
+@Override
+public String[] getGroups() {
+return new String[0];
+}
+
+@Override
+public String[] getGroupsDependedUpon() {
+return new String[0];
+}
+
+@Override
+public String getMissingGroup() {
+return null;
+}
+
+@Override
+public void setMissingGroup(String s) {
+
+}
+
+@Override
+public String[] getBeforeGroups() {
+return new String[0];
+}
+
+@Override
+public String[] getAfterGroups() {
+return new String[0];
+}
+
+@Override
+public String[] getMethodsDependedUpon() {
+return new String[0];
+}
+
+@Override
+public void addMethodDependedUpon(String s) {
+
+}
+
+@Override
+public boolean isTest() {
+return false;
+}
+
+@Override
+public boolean isBeforeMethodConfiguration() {
+return false;
+}
+
+@Override
+public boolean isAfterMethodConfiguration() {
+return false;
+}
+
+@Override
+public boolean isBeforeClassConfiguration() {
+return false;
+}
+
+@Override
+public boolean isAfterClassConfiguration() {
+return false;
+}
+
+@Override
+public boolean isBeforeSuiteConfiguration() {
+return false;
+}
+
+@Override
+public boolean isAfterSuiteConfiguration() {
+return false;
+}
+
+@Override
+public boolean isBeforeTestConfiguration() {
+return false;
+}
+
+@Override
+public boolean isAfterTestConfiguration() {
+return false;
+}
+
+@Override
+public boolean isBeforeGroupsConfiguration() {
+return false;
+}
+
[GitHub] maven-surefire issue #167: Speedup Standard Output if Tests
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/167 @DaGeRe Pls run the build `mvn install -P run-its "-Djdk.home=e:\Program Files\Java\jdk9\"` with default JDK 8 and additional JDK9 for few tests as you can see in system property `jdk.home`. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #167: Speedup Standard Output if Tests
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/167 @DaGeRe Yes we need to add your Jira issue to a final report which is part or final plugin release. Only you best know all details to be written in description in Jira, platform you have used, found buggy version, other references, a link to GitHub PR, etc. Here is the link https://issues.apache.org/jira/projects/SUREFIRE --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 @eolivelli Thx for contributing. Close this PR. It was pushed to master. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #171: [SUREFIRE-1445] Explicitly define SurefirePropert...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/171 @acogoluegnes Thx for support regarding Java 9. Please close this PR. I extended the test and already pushed to master. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 The comment `[SUREFIRE-1424] javax.transaction.TransactionManager not visible with Java9` should be in commit. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 If you could squash these two commits in one, it would be great. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #170: [SUREFIRE-1448] Clarified specifying multiple cat...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/170 @claycephas This PR was pushed to master yesterday. Please close this PR, Thx. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #171: [SUREFIRE-1445] Explicitly define Surefire...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r154193802
--- Diff:
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/SurefirePropertiesTest.java
---
@@ -70,9 +70,35 @@ public void testConstructWithOther()
src.setProperty( "b", "2" );
SurefireProperties orderedProperties = new SurefireProperties( src
);
// Cannot make assumptions about insertion order
-assertEquals( 2, orderedProperties.size() );
-
+int expectedCount = 0;
+// keys() uses the items property, more reliable to test than
size(),
+// which is based on the Properties class
+// see https://issues.apache.org/jira/browse/SUREFIRE-1445
+Enumeration keys = orderedProperties.keys();
+while ( keys.hasMoreElements() ) {
+keys.nextElement();
+expectedCount++;
+}
+assertEquals( 2, expectedCount );
--- End diff --
We missed one method I mentioned before. Can you add an assert that method
`getStringKeySet()` returns same elements like it is in `keys()`. Maybe this
will help:
`java.util.Collections#list(Enumeration): List`
We can do it in both tests.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #170: [SUREFIRE-1448] Clarified specifying multiple cat...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/170 Thx, this PR can be closed. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #167: Speedup Standard Output if Tests
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/167 @DaGeRe Did you create a ticket in JIRA? https://issues.apache.org/jira/browse/SUREFIRE If you did, which ticket number it is? --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #167: Speedup Standard Output if Tests
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/167#discussion_r154174674
--- Diff:
surefire-api/src/main/java/org/apache/maven/surefire/booter/ForkingRunListener.java
---
@@ -200,14 +200,8 @@ void sendProps()
@Override
public void writeTestOutput( byte[] buf, int off, int len, boolean
stdout )
{
-byte[] header = stdout ? stdOutHeader : stdErrHeader;
-byte[] content =
-new byte[buf.length * 3 + 1]; // Hex-escaping can be up to 3
times length of a regular byte.
-int i = escapeBytesToPrintable( content, 0, buf, off, len );
-content[i++] = (byte) '\n';
-byte[] encodeBytes = new byte[header.length + i];
-System.arraycopy( header, 0, encodeBytes, 0, header.length );
-System.arraycopy( content, 0, encodeBytes, header.length, i );
+final byte[] header = stdout ? stdOutHeader : stdErrHeader;
+final byte[] encodeBytes = escapeBytesToPrintable( header, buf,
off, len );
--- End diff --
Why it is so complex. Why you did not write the stream to
`PrintStream#write(byte buf[], int off, int len)` and why you did not change
`escapeBytesToPrintable` so that `header`, 'buf' would go to the method
parameters and just only one array could be allocated without any copy-paste
bytes?
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 @eolivelli We need to add a new chapter on the top in https://github.com/apache/maven-surefire/blob/master/maven-surefire-plugin/src/site/markdown/java9.md and add the following API. Please mention that version 2.21.0+ does not add "--add-modules java.se.ee", the user should specify dependencies with API and implementation, and that we support Jigsaw modularity as well. Commons Annotations javax.annotation:javax.annotation-api:1.3.1 JavaBeans Activation Framework javax.activation:javax.activation-api:1.2.0 Java Transaction API javax.transaction:javax.transaction-api:1.2 JAXB javax.xml.bind:jaxb-api:2.3.0 org.glassfish.jaxb:jaxb-runtime:2.3.0 (implementation) JAX-WS javax.xml.ws:jaxws-api:2.3.0 com.sun.xml.ws:jaxws-rt::2.3.0 (implementation) The source code for each of these is maintained at https://github.com/javaee . --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #171: [SUREFIRE-1445] Explicitly define Surefire...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153654392
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
---
@@ -71,13 +71,22 @@ public SurefireProperties( KeyValueSource source )
}
}
+@Override
+public synchronized void putAll(Map t) {
+for (Map.Entry entry : t.entrySet()) {
+this.put(entry.getKey(), entry.getValue());
+}
+}
+
@Override
public synchronized Object put( Object key, Object value )
{
items.add( key );
return super.put( key, value );
}
+
+
--- End diff --
Here only one empty line between two methods. Feel free to remove these two
you have added. Thx.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #171: [SUREFIRE-1445] Explicitly define Surefire...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153653384
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
---
@@ -71,13 +71,22 @@ public SurefireProperties( KeyValueSource source )
}
}
+@Override
+public synchronized void putAll(Map t) {
--- End diff --
Please keep using one commir in PR.
I recommend you to do `git commit--amend` and then forced push `git push
origin +master`.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #171: [SUREFIRE-1445] Explicitly define Surefire...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153652515
--- Diff:
maven-surefire-common/src/test/java/org/apache/maven/plugin/surefire/SurefirePropertiesTest.java
---
@@ -70,9 +70,16 @@ public void testConstructWithOther()
src.setProperty( "b", "2" );
SurefireProperties orderedProperties = new SurefireProperties( src
);
// Cannot make assumptions about insertion order
-assertEquals( 2, orderedProperties.size() );
-
-
+int expectedCount = 0;
+// keys() uses the items property, more reliable to test than
size(),
+// which is based on the Properties class
+// see https://issues.apache.org/jira/browse/SUREFIRE-1445
+Enumeration keys = orderedProperties.keys();
+while (keys.hasMoreElements()) {
+keys.nextElement();
+expectedCount++;
+}
+assertEquals( 2, expectedCount );
--- End diff --
Can you do the same assert with `getStringKeySet()`?
This is fine you added but can you add a new test explicitly calling
putAll()?
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #171: [SUREFIRE-1445] Explicitly define Surefire...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153652056
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
---
@@ -71,13 +71,22 @@ public SurefireProperties( KeyValueSource source )
}
}
+@Override
+public synchronized void putAll(Map t) {
+for (Map.Entry entry : t.entrySet()) {
+this.put(entry.getKey(), entry.getValue());
--- End diff --
The constructor also has "this.". Please remove it as well. Thx.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #171: [SUREFIRE-1445] Explicitly define Surefire...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153650568
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
---
@@ -71,13 +71,22 @@ public SurefireProperties( KeyValueSource source )
}
}
+@Override
+public synchronized void putAll(Map t) {
+for (Map.Entry entry : t.entrySet()) {
+this.put(entry.getKey(), entry.getValue());
--- End diff --
"this." is not necessary.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #171: [SUREFIRE-1445] Explicitly define Surefire...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/171#discussion_r153650439
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java
---
@@ -71,13 +71,22 @@ public SurefireProperties( KeyValueSource source )
}
}
+@Override
+public synchronized void putAll(Map t) {
--- End diff --
We have different conventions. Please see the spaces around brackets and
new lines.
The checkstyle plugin would crash the build. Did you try to run "mvn
install -P run-its"?
It would take quite long time to complete the build, cca one hour.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 @eolivelli I will have a look. I was busy last week. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #170: [SUREFIRE-1448] Clarified specifying multiple cat...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/170 Sorry, I mean the commit message. We have one standard of naming conventions in git history. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 @eolivelli I have finished my changes in master. Can you continue? --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #167: Speedup Standard Output if Tests
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/167 Did you test it with Ubuntu UTF-8 and on Windows with encoding 1252 and with special characters and some language dialects as well? --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #170: Clarified specifying multiple categories
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/170 @claycephas Nice! Please create Jira ticket and rename this PR to format: [SUREFIRE-] --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #169: [SUREFIRE-1405] Allows user to extend RunOrder & ...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/169 Thx for your effort but we have to wait for this till the version 3.0. The branch will have more merge conflicts. Please rebase this in few months when we will be about develop 3.0. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 It was done. But I don't think you can easily rebase it since some classes were deleted or methods moved. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #168: SUREFIRE-1424 javax.transaction.TransactionManage...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 Try to name the PR like this ([] brackets): [SUREFIRE-1424] javax.transaction.TransactionManager not visible with Java9 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #168: SUREFIRE-1424 javax.transaction.TransactionManage...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/168 I had to prefer pushing my commit regarding Jigsaw modularity supported in Surefire project because it was too big to merge after yours. Please create a new PR with your changes. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/168#discussion_r151860070 --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java --- @@ -78,12 +83,13 @@ public void shouldLoadMultipleJavaModules_ToolchainsXML() throws IOException .addGoal( "--toolchains" ) .addGoal( System.getProperty( "maven.toolchains.file" ) ) .execute( "verify" ) -.verifyErrorFree( 2 ); +.verifyErrorFree( 1 ); --- End diff -- Why it has changed from 2 to 1? There was two tests? --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/168#discussion_r151860059 --- Diff: maven-surefire-plugin/src/site/markdown/java9.md --- @@ -17,15 +17,6 @@ specific language governing permissions and limitations under the License. --> -Java 9 in JAVA_HOME --- End diff -- You should bring back the history. Some users still use 2.20.1 and there was another behavior. We should add a new point for 2.21 and recommendations. Please add the list of Java API from Jira that the Oracle guy listed Maven artifacts, implementations. This is missing in Java documentation and people will needed to be announced about them. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/150 @ckurban I could not release `2.21.0.Jigsaw` because I was ill. It's not much work do to. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #167: Speedup Standard Output if Tests
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/167 Pls do it in a new PR. Here is link for Eclipse/Idea code style xml https://maven.apache.org/developers/conventions/code.html On Wed, Oct 11, 2017 at 8:24 PM, Tibor Digana <tibor.dig...@googlemail.com> wrote: > You completely changed code style. > Please use ASF Maven code style because here I do not see relevant changes. > > On Wed, Oct 11, 2017 at 5:52 PM, DaGeRe <notificati...@github.com> wrote: > >> Currently, surefire creates a new byte array with size of the input *3 >> for saving the unescaped input. This made surefire way slower than running >> a test directly in eclipse or with gradle, if it used standardout or error >> heavily. >> By using a list for saving the elements and converting them to an array >> afterwards, this problem is solved, and stdout-heavy surefire tests get >> faster. >> -- >> You can view, comment on, or merge this pull request online at: >> >> https://github.com/apache/maven-surefire/pull/167 >> Commit Summary >> >>- Before, surefire created a new byte array with size of the input *3 >>for saving the unescaped input. This made >> >> File Changes >> >>- *M* surefire-api/src/main/java/org/apache/maven/surefire/booter/ >>ForkingRunListener.java >><https://github.com/apache/maven-surefire/pull/167/files#diff-0> >>(278) >>- *M* surefire-api/src/main/java/org/apache/maven/surefire/util/ >>internal/StringUtils.java >><https://github.com/apache/maven-surefire/pull/167/files#diff-1> >>(327) >>- *M* surefire-api/src/test/java/org/apache/maven/surefire/util/ >>internal/StringUtilsTest.java >><https://github.com/apache/maven-surefire/pull/167/files#diff-2> (84) >> >> Patch Links: >> >>- https://github.com/apache/maven-surefire/pull/167.patch >>- https://github.com/apache/maven-surefire/pull/167.diff >> >> â >> You are receiving this because you are subscribed to this thread. >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/maven-surefire/pull/167>, or mute the thread >> <https://github.com/notifications/unsubscribe-auth/AA_yR0DXigfKgA6fHyskr2on3rlGN3Jjks5srOREgaJpZM4P1tru> >> . >> > > > > -- > Cheers > Tibor > -- Cheers Tibor --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #167: Speedup Standard Output if Tests
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/167 You completely changed code style. Please use ASF Maven code style because here I do not see relevant changes. On Wed, Oct 11, 2017 at 5:52 PM, DaGeRe <notificati...@github.com> wrote: > Currently, surefire creates a new byte array with size of the input *3 for > saving the unescaped input. This made surefire way slower than running a > test directly in eclipse or with gradle, if it used standardout or error > heavily. > By using a list for saving the elements and converting them to an array > afterwards, this problem is solved, and stdout-heavy surefire tests get > faster. > -- > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/maven-surefire/pull/167 > Commit Summary > >- Before, surefire created a new byte array with size of the input *3 >for saving the unescaped input. This made > > File Changes > >- *M* surefire-api/src/main/java/org/apache/maven/surefire/ >booter/ForkingRunListener.java ><https://github.com/apache/maven-surefire/pull/167/files#diff-0> (278) >- *M* surefire-api/src/main/java/org/apache/maven/surefire/ >util/internal/StringUtils.java ><https://github.com/apache/maven-surefire/pull/167/files#diff-1> (327) >- *M* surefire-api/src/test/java/org/apache/maven/surefire/ >util/internal/StringUtilsTest.java ><https://github.com/apache/maven-surefire/pull/167/files#diff-2> (84) > > Patch Links: > >- https://github.com/apache/maven-surefire/pull/167.patch >- https://github.com/apache/maven-surefire/pull/167.diff > > â > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven-surefire/pull/167>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA_yR0DXigfKgA6fHyskr2on3rlGN3Jjks5srOREgaJpZM4P1tru> > . > -- Cheers Tibor --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 @owenfarrell Yeah, I have released 2.20.1 and I had to postpone this issue for 2.21.1. OOM was fixed in 2.20.1 and users could not wait longer. This included Java9 support. Java 9 is out and I want to release Surefire 2.21.0.Jigsaw in next few days which has higher priority. And then Surefire 2.21.1 is planed for your and other pull request fixed as well. Then 2.21.2 will fix a blocker issue, and then we will concentrate on 3.0.0.M1 and JUnit5. So this is my plan. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/150 @mpkorstanje Currently we are cutting two versions. This week `2.20.1` and `2.21.0.Jigsaw` next week having support with Jigsaw of Java 9. This PR is planned in `2.20.2` but the version will be renamed to `2.21.1` in Jira having 3 fixes which should be fast release, and then `2.20.2` with one but big fix which removes 2 blockers. After this the plugins should be stable, I hope, and we can cut `3.0.0.M1` and we will break backwards compatibility in parameters and their properties. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #163: Surefire-report
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/163 @shafiullas Please rebase your branch. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #163: Surefire-report
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/163 @shafiullas Register in Jira and open issue in https://issues.apache.org/jira/browse/SUREFIRE. The message of the commit and GitHub issue should be renamed to something like: [SUREFIRE-12345] Same issue title as current GitHub. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #163: Surefire-report
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/163#discussion_r137895395 --- Diff: maven-surefire-report-plugin/src/main/java/org/apache/maven/plugins/surefire/report/AbstractSurefireReportMojo.java --- @@ -34,13 +27,21 @@ import org.apache.maven.shared.utils.PathTool; import org.apache.maven.shared.utils.StringUtils; +import java.io.File; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.Locale; +import java.util.ResourceBundle; + /** * Abstract base class for reporting test results using Surefire. * * @author Stephen Connolly */ public abstract class AbstractSurefireReportMojo -extends AbstractMavenReport +extends AbstractMavenReport --- End diff -- Do not change lines only because of checkstyle. Do it again and fix only lines for the purpose of this issue only. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #143: maven-surefire-parser: add new method isError in ...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/143 @surli You have not answered my questions yet. Let's do it now about making releases. Register in Jira and open issue in https://issues.apache.org/jira/browse/SUREFIRE. The message of the commit should be renamed to something like: `[SUREFIRE-12345] Same issue title as in GitHub`. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #141: SUREFIRE-1331: Bump version number for 3.0.0 rele...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/141 @britter I think this was forgotten. Should I process it? --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #159: SUREFIRE-1391: Eliminate redundant call in calcul...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/159 @andrew-j-cohen We do not have rights to close this issue. Please close it! --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Fuud This branch was rebased and pushed to master. Please close it. Thx for contributing. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/114 https://issues.apache.org/jira/browse/SUREFIRE-1409 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #164: SUREFIRE-1383: Split IT569 in to multiple lifecyc...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/164 @owenfarrell Sorry I could not have a look. I was busy. Now I want to finish my code and open it for contribution. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/150#discussion_r136932755 --- Diff: surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/FailingMethodFilter.java --- @@ -1,85 +0,0 @@ -package org.apache.maven.surefire.common.junit48; - -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -import org.apache.maven.shared.utils.io.SelectorUtils; -import org.junit.runner.Description; -import org.junit.runner.manipulation.Filter; - -import java.util.Map; -import java.util.Set; - -/** - * Only run test methods in the given input map, indexed by test class - */ -final class FailingMethodFilter --- End diff -- Before deleting a class, tests with high coverage should be added and new implementation should pass on them. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r136932487
--- Diff:
surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/MatchMethodDescriptions.java
---
@@ -0,0 +1,74 @@
+package org.apache.maven.surefire.common.junit48;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.junit.runner.Description;
+import org.junit.runner.manipulation.Filter;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Only run test methods in the given failure set
+ *
+ * @author mpkorstanje
+ */
+final class MatchMethodDescriptions
+extends Filter
+{
+
+private final List filters = new ArrayList();
+
+MatchMethodDescriptions( Iterable descriptions )
+{
+for ( Description description : descriptions )
+{
+filters.add( matchMethodDescription ( description ) );
+}
+}
+
+@Override
+public boolean shouldRun( Description description )
+{
+for ( Filter filter : filters )
--- End diff --
This loop is different from the deleted class but I need to have spare time
to have deep looking.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r136932256
--- Diff:
surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/MatchMethodDescriptions.java
---
@@ -0,0 +1,74 @@
+package org.apache.maven.surefire.common.junit48;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.junit.runner.Description;
+import org.junit.runner.manipulation.Filter;
+
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Only run test methods in the given failure set
+ *
+ * @author mpkorstanje
+ */
+final class MatchMethodDescriptions
+extends Filter
+{
+
+private final List filters = new ArrayList();
+
+MatchMethodDescriptions( Iterable descriptions )
+{
+for ( Description description : descriptions )
+{
+filters.add( matchMethodDescription ( description ) );
+}
+}
+
+@Override
+public boolean shouldRun( Description description )
+{
+for ( Filter filter : filters )
+{
+if ( filter.shouldRun( description ) )
+{
+return true;
+}
+}
+return false;
+}
+
+@Override
+public String describe()
+{
+StringBuilder description = new StringBuilder( "Matching
description " );
+for ( int i = 0; i < filters.size(); i++ )
+{
+description.append( filters.get( i ).describe() );
+if ( i != filters.size() - 1 )
+{
+description.append( " OR " );
+}
+}
+return description.toString();
+}
+}
--- End diff --
Here a new line should be added.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/150#discussion_r136932062 --- Diff: surefire-providers/common-junit48/src/main/java/org/apache/maven/surefire/common/junit48/FailingMethodFilter.java --- @@ -1,85 +0,0 @@ -package org.apache.maven.surefire.common.junit48; - -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - -import org.apache.maven.shared.utils.io.SelectorUtils; -import org.junit.runner.Description; -import org.junit.runner.manipulation.Filter; - -import java.util.Map; -import java.util.Set; - -/** - * Only run test methods in the given input map, indexed by test class - */ -final class FailingMethodFilter --- End diff -- I don't think this can be removed. I have to check the algorithms of FailingMethodFilter and MatchMethodDescriptions. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/150#discussion_r136931552 --- Diff: surefire-integration-tests/src/test/resources/junit47-rerun-failing-tests-with-cucumber/pom.xml --- @@ -0,0 +1,88 @@ + + + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.maven.surefire +it-parent +1.0 + + +junit47-rerun-failing-tests-with-cucumber +jar + +Test for rerun failing cucumber tests in JUnit 47 + + +2.0.0-SNAPSHOT --- End diff -- This too. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r136931515
--- Diff:
maven-surefire-plugin/src/site/apt/examples/rerun-failing-tests.apt.vm ---
@@ -140,10 +140,14 @@ mvn
-D${thisPlugin.toLowerCase()}.rerunFailingTestsCount=2 test
The provider <<>> executes individual test class and
consequently re-runs failed tests.
The provider <<>> executes all test classes and
re-runs failed tests afterwards.
+* Re-run execution in Cucumber JVM
+
+ Since of 2.21 the provider <<>> can rerun scenarios
created by <>
+ 2.0.0-SNAPSHOT and higher.
--- End diff --
Pls change to 2.0.0 without SNAPSHOT.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #150: SUREFIRE-1372 Filter tests to be rerun by ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r136931399
--- Diff:
surefire-integration-tests/src/test/resources/junit47-rerun-failing-tests-with-cucumber/pom.xml
---
@@ -0,0 +1,88 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+
+org.apache.maven.surefire
+it-parent
+1.0
+
+
+junit47-rerun-failing-tests-with-cucumber
+jar
+
+Test for rerun failing cucumber tests in JUnit 47
+
+
+2.0.0-SNAPSHOT
+
+
+
+
+
+org.apache.maven.plugins
+maven-surefire-plugin
+${surefire.version}
+
+
+org.apache.maven.surefire
+surefire-junit47
+${surefire.version}
+
+
+
+
+
+
+
+
+junit
+junit
+${junit.version}
+test
+
+
+io.cucumber
+cucumber-java
+${cucumber.version}
+test
+
+
+io.cucumber
+cucumber-junit
+${cucumber.version}
+test
+
+
+
+
--- End diff --
This can be removed.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
My tests passed on this code. I have to continue to develop and refactor
more.
List testDepends = project.getTestArtifacts();
removeReactorDependencies( session.getSortedProjects(),
testDepends.iterator() );
List dependenciesToScan = filter( testDepends,
asList( getDependenciesToScan() ) );
TestListResolver testFilter = getIncludedAndExcludedTests();
DefaultScanResult scanResult = new DependencyScanner(
dependenciesToScan, testFilter ).scan();
for ( MavenProject project : session.getSortedProjects() )
{
if ( !"pom".equals( project.getPackaging() ) &&
!containsProjectArtifact( testDepends, project ) )
{
// zapracuj getDependenciesToScan()
File reactorChildProjectOutputDir = new File(
project.getBuild().getOutputDirectory() );
if ( reactorChildProjectOutputDir.isDirectory() )
{
DirectoryScanner scanner = new
DirectoryScanner( reactorChildProjectOutputDir, testFilter );
scanResult = scanResult.append( scanner.scan()
);
}
}
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 @owenfarrell I will try by myself. I will let you know with new branch and we can discuss it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 @owenfarrell It would be easier for you not to rever 569 in this PR but create a new PR from master. I pushed a new fix to master today. The master will be idle for you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #157: SUREFIRE-1383 dependenciesToScan Does Not ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r135766258
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,31 @@ private DefaultScanResult scanDependencies()
{
try
{
+DefaultScanResult scanResult = new DefaultScanResult(
Collections.EMPTY_LIST );
+
+List dependenciesToScan = new ArrayList();
+Collections.addAll( dependenciesToScan,
getDependenciesToScan() );
+TestListResolver includedAndExcludedTests =
getIncludedAndExcludedTests();
+
+for ( MavenProject mavenProject :
session.getSortedProjects() )
+{
+String groupArtifactId = mavenProject.getGroupId() +
":" + mavenProject.getArtifactId();
+if ( dependenciesToScan.removeAll(
Collections.singleton( groupArtifactId ) ) )
+{
+File outputDirectoryFile = new File(
mavenProject.getBuild().getOutputDirectory() );
+DirectoryScanner scanner =
+new DirectoryScanner( outputDirectoryFile,
includedAndExcludedTests );
+scanResult = scanResult.append( scanner.scan() );
+}
+}
+
// @TODO noinspection unchecked, check MavenProject 3.x
for Generics in surefire:3.0
@SuppressWarnings( "unchecked" )
-List dependenciesToScan =
-DependencyScanner.filter( project.getTestArtifacts(),
Arrays.asList( getDependenciesToScan() ) );
-DependencyScanner scanner = new DependencyScanner(
dependenciesToScan, getIncludedAndExcludedTests() );
-return scanner.scan();
+List dependenciesToScanFile =
+DependencyScanner.filter(
project.getTestArtifacts(), dependenciesToScan );
--- End diff --
Here some artifacts may have classifier `tests`. This means your loop may
appear below test artifacts and only those project artifacts (gid:aid:*) should
be excluded which appear in `getTestArtifacts()` and scans appended creating
one aggregated scan result.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #157: SUREFIRE-1383 dependenciesToScan Does Not ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r135765515
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,31 @@ private DefaultScanResult scanDependencies()
{
try
{
+DefaultScanResult scanResult = new DefaultScanResult(
Collections.EMPTY_LIST );
+
+List dependenciesToScan = new ArrayList();
+Collections.addAll( dependenciesToScan,
getDependenciesToScan() );
+TestListResolver includedAndExcludedTests =
getIncludedAndExcludedTests();
+
+for ( MavenProject mavenProject :
session.getSortedProjects() )
+{
+String groupArtifactId = mavenProject.getGroupId() +
":" + mavenProject.getArtifactId();
+if ( dependenciesToScan.removeAll(
Collections.singleton( groupArtifactId ) ) )
+{
+File outputDirectoryFile = new File(
mavenProject.getBuild().getOutputDirectory() );
+DirectoryScanner scanner =
+new DirectoryScanner( outputDirectoryFile,
includedAndExcludedTests );
+scanResult = scanResult.append( scanner.scan() );
+}
+}
+
// @TODO noinspection unchecked, check MavenProject 3.x
for Generics in surefire:3.0
@SuppressWarnings( "unchecked" )
-List dependenciesToScan =
-DependencyScanner.filter( project.getTestArtifacts(),
Arrays.asList( getDependenciesToScan() ) );
-DependencyScanner scanner = new DependencyScanner(
dependenciesToScan, getIncludedAndExcludedTests() );
-return scanner.scan();
+List dependenciesToScanFile =
--- End diff --
Pls align to single line after using static import:
`import static java.lang.Thread.currentThread;
import static
org.apache.maven.plugin.surefire.util.DependencyScanner.filter;
import static java.util.Collections.singletonMap;`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #157: SUREFIRE-1383 dependenciesToScan Does Not ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r135765205
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,31 @@ private DefaultScanResult scanDependencies()
{
try
{
+DefaultScanResult scanResult = new DefaultScanResult(
Collections.EMPTY_LIST );
+
+List dependenciesToScan = new ArrayList();
--- End diff --
missing Generics on constructor. We have Java 1.6.
`List dependenciesToScan = new ArrayList();`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #157: SUREFIRE-1383 dependenciesToScan Does Not ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r135765053
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,31 @@ private DefaultScanResult scanDependencies()
{
try
{
+DefaultScanResult scanResult = new DefaultScanResult(
Collections.EMPTY_LIST );
--- End diff --
Do you use IntelliJ IDEA? It highlights the argument in yellow.
Use this:
`DefaultScanResult scanResult = new DefaultScanResult(
Collections.emptyList() );`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 @owenfarrell I found the root cause. The dependency to scan is examined with outputDirectory, but IT 569 has shources to share in `src/test/java` so the artifact would match but that's the reason why `target/surefire-reports` is not found because your code scans `Surefire569RunTestFromDependencyJarsIT_shouldScanAndRunTestsInDependencyJars\testjar\target\classes`. I think you have to check it classifier `tests` exists which results to file name `testjar-0.0.1-SNAPSHOT-tests.jar`. Additionally you should exclude packaging `pom` from the scan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 @owenfarrell I built the project. It was ok but then I realized you modified IT 569 which I do not like because this was a feature and I want to guarantee that old tests pass without modification and additionally I have to find out if our contributors mask some of their hidden errors. I or we have to find the root cause why 569 fails with your changes. We should debug your code and then fix it. The changes on 569 you have done are interesting but I prefer to add a new one very similar like "surefire-569-RunTestFromInstalledJar". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/161 @jon-bell Thx for contributing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 @JoelNGeorge @owenfarrell Pls let me run the build and next steps. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #159: SUREFIRE-1391: Eliminate redundant call in calcul...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/159 @andrew-j-cohen Please close this PR. It was already merged in Surefire project. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/161 @jon-bell Ok, now your IT passed. I will run whole test set now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/162 @britter Done. I added enforcer configuration. I hope it will be fine. Let me know if you have something to do for me. Sometimes I am without internet connection for several days or I am connected a half day or so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/162 Sorry my bad, yes master has enforcer with JDK8 (due to javadoc checks within compile time) however maven.compoler.source/target is 1.6. I will have a look in to junit5 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #162: SUREFIRE-1384: ProviderInfo for JUnit Plattform (...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/162 @britter Actually the master is on JDK6 and the branch junit5 could be on JDK5 that time we created it. Maybe you should fix the enforcer configuration to similar to the one in master. Try to delete also folders named `2.19.2-SNAPSHOT` in your local Maven repository additionally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 @owenfarrell I have not had yet. I am reviewing other in parallel. I will have a look in few days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/161 @jon-bell I will investigate this issue: `Could not find artifact org.apache.maven.surefire:it-parent:pom:1.0 in central (https://repo.maven.apache.org/maven2)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #155: Revert junit-plattform provider code from 3.0-rc1...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/155 @britter #155 and #154 are done. Pls let me know if I should continue with #153. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #155: Revert junit-plattform provider code from 3.0-rc1...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/155 @britter In what order should this PR and https://github.com/apache/maven-surefire/pull/153 be pushed? Is https://github.com/apache/maven-surefire/pull/154 independent? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #161: SUREFIRE-1396: Provider class path is incorrect f...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/161 @jon-bell Please squash your commits into one single commit and override your branch. Name the final commit `[SUREFIRE-1396] Provider class path is incorrect for custom provider in Failsafe` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/161#discussion_r130488490 --- Diff: surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml --- @@ -0,0 +1,61 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + org.apache.maven.plugins.surefire + surefire-test-classpath-provider + 1.0-SNAPSHOT + Test provider + + +2.21-SNAPSHOT --- End diff -- You should specify parent pom ``` org.apache.maven.surefire it-parent 1.0 ../pom.xml ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/150 ok, take your time. No worries. Just rebase the PR after your team finished the release. Surefire need some week to make release as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/161#discussion_r130447743
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -2755,7 +2755,16 @@ public Classpath getProviderClasspath()
throws ArtifactResolutionException, ArtifactNotFoundException
{
final Map<String, Artifact> pluginArtifactMap =
getPluginArtifactMap();
-Artifact plugin = pluginArtifactMap.get(
"org.apache.maven.plugins:maven-surefire-plugin" );
+Class c = AbstractSurefireMojo.this.getClass();
+Artifact plugin;
+if ( c.getName().equals(
"org.apache.maven.plugin.failsafe.IntegrationTestMojo" ) )
--- End diff --
I guess this is in method `getProviderClasspath()`
Please split the method in two. First it would call `protected abstract
Artifact getMojoArtifact()` and then the original statement `return
dependencyResolver.addProviderToClasspath( pluginArtifactMap, plugin );` where
`plugin` is `Artifact`. Then force both subclasse to implement
`getMojoArtifact` which means surefire mojo will implement it as follows:
`final Map<String, Artifact> pluginArtifactMap = getPluginArtifactMap();
Artifact plugin = pluginArtifactMap.get(
"org.apache.maven.plugins:maven-surefire-plugin" );`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/161#discussion_r130445462
--- Diff:
surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml
---
@@ -0,0 +1,61 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+ org.apache.maven.plugins.surefire
+ surefire-test-classpath-provider
+ 1.0-SNAPSHOT
+ Test provider
+
+
+2.21-SNAPSHOT
+
+
+
+ org.apache.maven.surefire
+ surefire-api
+ ${surefire.version}
+
+
+
+
+
+
+src/main/resources/META-INF
+META-INF
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
--- End diff --
This plugin is again in parent pom. Not necessary here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/161#discussion_r130445317 --- Diff: surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml --- @@ -0,0 +1,61 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + org.apache.maven.plugins.surefire + surefire-test-classpath-provider + 1.0-SNAPSHOT + Test provider + + +2.21-SNAPSHOT + + + + org.apache.maven.surefire + surefire-api --- End diff -- Why? See the `build.log` in target and you will see project version and all necessary dependencies hidden in the fork transitive deps. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #161: SUREFIRE-1396: Provider class path is inco...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/161#discussion_r130444914 --- Diff: surefire-integration-tests/src/test/resources/surefire-1396-pluggableproviders-classpath-provider/pom.xml --- @@ -0,0 +1,61 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + org.apache.maven.plugins.surefire + surefire-test-classpath-provider + 1.0-SNAPSHOT + Test provider + + +2.21-SNAPSHOT --- End diff -- Pls do not use this property. It comes from [parent pom](https://github.com/apache/maven-surefire/blob/master/surefire-integration-tests/src/test/resources/pom.xml). Did you run the build like this `mvn install -P run-its`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #150: SUREFIRE-1372 Filter tests to be rerun by descrip...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/150 @mpkorstanje You changed something in your code or what happened that snapshot was not available? Is the release 2.0.0 coming soon? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #155: Revert junit-plattform provider code from 3.0-rc1...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/155 @britter We have finished feature SUREFIRE 1302 and I am going get back to JUnit5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #159: SUREFIRE-1391: Eliminate redundant call in calcul...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/159 @andrew-j-cohen thx, merged. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #158: Fix typo in docs
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/158 @StephenKing Thx, this PR was pushed to master and can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #160: SUREFIRE-1398 threadCount is set for JUnit only w...
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/160
@MatousJobanek
It should be sanity check and Mojo should fail if `threadCount` is <= 0 &&
isApplicable.
IsApplicable is TRUE if `forkMode` is "pertest" OR `parallel` is any of
("classes", "methods", "both", "suites", "suitesAndClasses",
"suitesAndMethods", "classesAndMethods", "all").
The Mojo should fail even if `threadCount` is <> 0 AND `forkMode` !=
"pertest" AND `parallel` == NULL.
The Mojo should fail if `forkCount` is < 0 AND `forkMode` == "once"
(default).
`AbstractSurefireMojo` is some methods which maybe solve this and convert
old forkMode to forkCount so it is not so direct to do like I wrote this pseudo
code.
The most important is to run the build `mvn install -P run-its`, cca 50
minutes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 I have been busy with other ticket. Where did we finish. Do you need a help? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #160: SUREFIRE-1398 Sets threadCount only when parallel...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/160 If you plan a new commit, pls do not create two. Amend the previous one. Thx. On Tue, Jul 25, 2017 at 5:29 PM, Tibor Digana <tibor.dig...@googlemail.com> wrote: > Pls check it together with documentation of param "forkMode". I think > threadCount can be used with forkMode as well. > > On Tue, Jul 25, 2017 at 4:24 PM, Matous Jobanek <notificati...@github.com> > wrote: > >> Otherwise, the TestNG fails with >> Cannot use a threadCount parameter less than 1; 1 > 0 >> in some cases when the parallel parameter was not set. To identify the >> cases, take a look at related Jira issue: https://issues.apache.org/jira >> /browse/SUREFIRE-1398 >> I removed the check for positiveness of the threadCount value as it's a >> responsibility of the user to provide correct value. >> The question is if the default value of threadCount parameter shouldn't >> be 1, to avoid such a problems...? If yes, then I'll update my PR >> -- >> You can view, comment on, or merge this pull request online at: >> >> https://github.com/apache/maven-surefire/pull/160 >> Commit Summary >> >>- SUREFIRE-1398 Sets threadCount only when parallel parameter is set >> >> File Changes >> >>- *M* maven-surefire-common/src/main/java/org/apache/maven/plugin/ >>surefire/AbstractSurefireMojo.java >><https://github.com/apache/maven-surefire/pull/160/files#diff-0> (13) >> >> Patch Links: >> >>- https://github.com/apache/maven-surefire/pull/160.patch >>- https://github.com/apache/maven-surefire/pull/160.diff >> >> â >> You are receiving this because you are subscribed to this thread. >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/maven-surefire/pull/160>, or mute the thread >> <https://github.com/notifications/unsubscribe-auth/AA_yR4lRkgmqVWg76yDzf07EhQ9kTSotks5sRfqfgaJpZM4OioY5> >> . >> > > > > -- > Cheers > Tibor > -- Cheers Tibor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #160: SUREFIRE-1398 Sets threadCount only when parallel...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/160 Pls check it together with documentation of param "forkMode". I think threadCount can be used with forkMode as well. On Tue, Jul 25, 2017 at 4:24 PM, Matous Jobanek <notificati...@github.com> wrote: > Otherwise, the TestNG fails with > Cannot use a threadCount parameter less than 1; 1 > 0 > in some cases when the parallel parameter was not set. To identify the > cases, take a look at related Jira issue: https://issues.apache.org/ > jira/browse/SUREFIRE-1398 > I removed the check for positiveness of the threadCount value as it's a > responsibility of the user to provide correct value. > The question is if the default value of threadCount parameter shouldn't > be 1, to avoid such a problems...? If yes, then I'll update my PR > -- > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/maven-surefire/pull/160 > Commit Summary > >- SUREFIRE-1398 Sets threadCount only when parallel parameter is set > > File Changes > >- *M* maven-surefire-common/src/main/java/org/apache/maven/ >plugin/surefire/AbstractSurefireMojo.java ><https://github.com/apache/maven-surefire/pull/160/files#diff-0> (13) > > Patch Links: > >- https://github.com/apache/maven-surefire/pull/160.patch >- https://github.com/apache/maven-surefire/pull/160.diff > > â > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven-surefire/pull/160>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AA_yR4lRkgmqVWg76yDzf07EhQ9kTSotks5sRfqfgaJpZM4OioY5> > . > -- Cheers Tibor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 No, no. No worries. You should build entire project `mvn install` and not the individual IT. The ITs cannot run separately, you can trigger it from building entire project from root in git. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 Would you add integration test? See the module `surefire-integration-tests` and `src/test/java/org/apache/maven/surefire/its/jiras`. It's easy. Pickup some existing test, e.g. `Surefire34SecurityManagerIT`, and just inherit `SurefireJUnit4IntegrationTestCase`and see the folder `surefire-34-securityManager` in `test/resources`. Your IT will have the same principle. The point is to start `surefire-34-securityManager/pom.xml` as embedded or forked maven process from `Surefire34SecurityManagerIT`. I guess you want to test that multi-module Maven project will have own classes propagated from child modules one one dedicated module where Surefire has tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #157: SUREFIRE-1383 dependenciesToScan Does Not ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r125169778
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,33 @@ private DefaultScanResult scanDependencies()
{
try
{
+DefaultScanResult scanResult = new DefaultScanResult(
Collections.EMPTY_LIST );
+
+List dependenciesToScanList = new ArrayList(
Arrays.asList( getDependenciesToScan() ) );
--- End diff --
No need to create two collections with
`List dependenciesToScanList = new ArrayList( Arrays.asList(
getDependenciesToScan() ) );`
One modifiable collection can be with this code:
`List dependenciesToScanList = new ArrayList();`
`Collections.addAll( dependenciesToScanList, getDependenciesToScan() );`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #157: SUREFIRE-1383 dependenciesToScan Does Not ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r125169703
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,33 @@ private DefaultScanResult scanDependencies()
{
try
{
+DefaultScanResult scanResult = new DefaultScanResult(
Collections.EMPTY_LIST );
+
+List dependenciesToScanList = new ArrayList(
Arrays.asList( getDependenciesToScan() ) );
+TestListResolver includedAndExcludedTests =
getIncludedAndExcludedTests();
+
+for ( MavenProject mavenProject :
session.getSortedProjects() )
+{
+String groupArtifactId = new StringBuilder(
mavenProject.getGroupId() ).append( ":" )
+.append( mavenProject.getArtifactId()
).toString();
+if ( dependenciesToScanList.removeAll(
Collections.singleton( groupArtifactId ) ) )
+{
+File outputDirectoryFile = new File(
mavenProject.getBuild().getOutputDirectory() );
+DirectoryScanner scanner =
+new DirectoryScanner( outputDirectoryFile,
includedAndExcludedTests );
+scanResult = scanResult.append( scanner.scan() );
+}
+
+}
+
// @TODO noinspection unchecked, check MavenProject 3.x
for Generics in surefire:3.0
@SuppressWarnings( "unchecked" )
-List dependenciesToScan =
-DependencyScanner.filter( project.getTestArtifacts(),
Arrays.asList( getDependenciesToScan() ) );
-DependencyScanner scanner = new DependencyScanner(
dependenciesToScan, getIncludedAndExcludedTests() );
-return scanner.scan();
+List dependenciesToScanFileList =
--- End diff --
`dependenciesToScanFileList` already contains plural. Pls rename
`dependenciesToScanFileList` to `dependenciesToScanFile`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #157: SUREFIRE-1383 dependenciesToScan Does Not ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r125169693
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,33 @@ private DefaultScanResult scanDependencies()
{
try
{
+DefaultScanResult scanResult = new DefaultScanResult(
Collections.EMPTY_LIST );
+
+List dependenciesToScanList = new ArrayList(
Arrays.asList( getDependenciesToScan() ) );
--- End diff --
`dependenciesToScanList` already contains plural. Pls rename
`dependenciesToScanList` to `dependenciesToScan`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #157: SUREFIRE-1383 dependenciesToScan Does Not ...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/157#discussion_r125169671
--- Diff:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
---
@@ -847,12 +847,33 @@ private DefaultScanResult scanDependencies()
{
try
{
+DefaultScanResult scanResult = new DefaultScanResult(
Collections.EMPTY_LIST );
+
+List dependenciesToScanList = new ArrayList(
Arrays.asList( getDependenciesToScan() ) );
+TestListResolver includedAndExcludedTests =
getIncludedAndExcludedTests();
+
+for ( MavenProject mavenProject :
session.getSortedProjects() )
+{
+String groupArtifactId = new StringBuilder(
mavenProject.getGroupId() ).append( ":" )
--- End diff --
Pls concatenate as follows `mavenProject.getGroupId() + ":" +
mavenProject.getArtifactId()`.
This is simple and `javac` would compile to StringBuilder anyway, but
longer in sources.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/157 Pls squash both commits to one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121260609
--- Diff:
surefire-integration-tests/src/test/resources/junit-plattform/pom.xml ---
@@ -0,0 +1,58 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd;>
+ 4.0.0
+
+ org.apache.maven.plugins.surefire
+ junit-plattform
+ 1.0-SNAPSHOT
+ Test for JUnit Plattform
+
+
+
+ org.junit.jupiter
+ junit-jupiter-api
+ 5.0.0-M4
+ test
+
+
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+
+ 1.8
+ 1.8
+
+
+
+org.apache.maven.plugins
+maven-surefire-plugin
+${surefire.version}
+
+
+
+
+
--- End diff --
New line empty should finish file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...
Github user Tibor17 commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/153#discussion_r121260527 --- Diff: surefire-integration-tests/src/test/resources/junit-plattform/pom.xml --- @@ -0,0 +1,58 @@ + + + +http://maven.apache.org/POM/4.0.0; --- End diff -- This is an old schema. http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire pull request #153: SUREFIRE-1384: ProviderInfo for JUnit Plat...
Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/153#discussion_r121260260
--- Diff:
surefire-integration-tests/src/test/resources/junit-plattform/src/test/java/junitplattform/BasicTest.java
---
@@ -0,0 +1,65 @@
+package junitplattform;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+public class BasicTest
+{
+
+private boolean setUpCalled = false;
+
+private static boolean tearDownCalled = false;
--- End diff --
This is never read. Default value `false` not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
