Re: Enable Travis on Maven Scripting Plugin
INFRA requests more insight on this topic and if we want to enable all of the repositories we have to create a script. I think the best option is to enable Travis only on repositories which satisfy these criteria: - tests finish within 50 minutes - the repository ia receiving pull requests from non committers For reference: https://issues.apache.org/jira/browse/INFRA-17763?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel=16753285#comment-16753285 Enrico Il giorno mar 15 gen 2019, 22:40 Stephen Connolly < stephen.alan.conno...@gmail.com> ha scritto: > Go for it. Nobody said no (and forgiveness is sometimes easier than > permission) > > Ask infra which they prefer, all in one go or one at a time > > On Tue 15 Jan 2019 at 20:36, Enrico Olivelli wrote: > > > ping > > > > Il giorno gio 10 gen 2019 alle ore 20:29 Enrico Olivelli > > ha scritto: > > > > > > I would like to enable Travis on other plugins, maybe I can do it on > > plugins which have active prs > > > > > > Okay? > > > Enrico > > > > > > Il lun 7 gen 2019, 02:46 Manfred Moser ha > > scritto: > > >> > > >> Fair enough. If its just for outside contributor PRs I am agree with > > not owning the risk ;-) > > >> > > >> Stephen Connolly wrote on 2019-01-04 16:06: > > >> > > >> > On Fri 4 Jan 2019 at 22:00, Tibor Digana > > wrote: > > >> > > > >> >> @Stephen Connolly > > >> >> After such a big investment, especially made on your side, in > > Jenkins > > >> >> plugin you developed you do not want to support the GitHub PRs and > > you just > > >> >> let be to go with TravisCI just like that? I do not think so! > > >> > > > >> > > > >> > I want to add GitHub support to ASF Jenkins too, but PR verification > > should > > >> > be layers. No harm in having one layer provided by > > Travis/Codeship/etc and > > >> > the second layer by Jenkins. > > >> > > > >> > The other point is even if I add PR support to the ASF Jenkins, it’s > > not > > >> > going to be automatic build for non-committers (which is the group > of > > PRs > > >> > that need the CI feedback most, and with least delay... ie before > > they walk > > >> > away) as we simply do not have throw-away infra for building PRs > that > > could > > >> > contain bitcoin miners triggered by a unit test, etc. > > >> > > > >> > Now if infra wants to set up a dedicated “safe space” for untrusted > > PRs to > > >> > be built... super... but until that happens, we’ll need something > like > > >> > Travis to take that risk for us. > > >> > > > >> > > > >> >> T > > >> >> > > >> >> > > >> >> On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > > >> >> stephen.alan.conno...@gmail.com> wrote: > > >> >> > > >> >> > +1 from me > > >> >> > > > >> >> > On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > > > wrote: > > >> >> > > > >> >> > > Hi, > > >> >> > > I would like to try out Travis on this small plugin: > > >> >> > > https://github.com/apache/maven-scripting-plugin > > >> >> > > > > >> >> > > I have pushed a minimal configuration file > > >> >> > > I need to ask to Infra, but I need approval from the community > > and > > >> >> > PMCs... > > >> >> > > > > >> >> > > Can I proceed ? > > >> >> > > > > >> >> > > Enrico > > >> >> > > > > >> >> > > > > - > > >> >> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> >> > > For additional commands, e-mail: dev-h...@maven.apache.org > > >> >> > > > > >> >> > > -- > > >> >> > Sent from my phone > > >> >> > > > >> >> > > >> > -- > > >> > Sent from my phone > > >> > > > >> > > >> > > >> - > > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> For additional commands, e-mail: dev-h...@maven.apache.org > > >> > > > -- > > > > > > > > > -- Enrico Olivelli > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > -- > Sent from my phone >
Re: Enable Travis on Maven Scripting Plugin
Go for it. Nobody said no (and forgiveness is sometimes easier than permission) Ask infra which they prefer, all in one go or one at a time On Tue 15 Jan 2019 at 20:36, Enrico Olivelli wrote: > ping > > Il giorno gio 10 gen 2019 alle ore 20:29 Enrico Olivelli > ha scritto: > > > > I would like to enable Travis on other plugins, maybe I can do it on > plugins which have active prs > > > > Okay? > > Enrico > > > > Il lun 7 gen 2019, 02:46 Manfred Moser ha > scritto: > >> > >> Fair enough. If its just for outside contributor PRs I am agree with > not owning the risk ;-) > >> > >> Stephen Connolly wrote on 2019-01-04 16:06: > >> > >> > On Fri 4 Jan 2019 at 22:00, Tibor Digana > wrote: > >> > > >> >> @Stephen Connolly > >> >> After such a big investment, especially made on your side, in > Jenkins > >> >> plugin you developed you do not want to support the GitHub PRs and > you just > >> >> let be to go with TravisCI just like that? I do not think so! > >> > > >> > > >> > I want to add GitHub support to ASF Jenkins too, but PR verification > should > >> > be layers. No harm in having one layer provided by > Travis/Codeship/etc and > >> > the second layer by Jenkins. > >> > > >> > The other point is even if I add PR support to the ASF Jenkins, it’s > not > >> > going to be automatic build for non-committers (which is the group of > PRs > >> > that need the CI feedback most, and with least delay... ie before > they walk > >> > away) as we simply do not have throw-away infra for building PRs that > could > >> > contain bitcoin miners triggered by a unit test, etc. > >> > > >> > Now if infra wants to set up a dedicated “safe space” for untrusted > PRs to > >> > be built... super... but until that happens, we’ll need something like > >> > Travis to take that risk for us. > >> > > >> > > >> >> T > >> >> > >> >> > >> >> On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > >> >> stephen.alan.conno...@gmail.com> wrote: > >> >> > >> >> > +1 from me > >> >> > > >> >> > On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > wrote: > >> >> > > >> >> > > Hi, > >> >> > > I would like to try out Travis on this small plugin: > >> >> > > https://github.com/apache/maven-scripting-plugin > >> >> > > > >> >> > > I have pushed a minimal configuration file > >> >> > > I need to ask to Infra, but I need approval from the community > and > >> >> > PMCs... > >> >> > > > >> >> > > Can I proceed ? > >> >> > > > >> >> > > Enrico > >> >> > > > >> >> > > > - > >> >> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> >> > > For additional commands, e-mail: dev-h...@maven.apache.org > >> >> > > > >> >> > > -- > >> >> > Sent from my phone > >> >> > > >> >> > >> > -- > >> > Sent from my phone > >> > > >> > >> > >> - > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > > -- > > > > > > -- Enrico Olivelli > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sent from my phone
Re: Enable Travis on Maven Scripting Plugin
ping Il giorno gio 10 gen 2019 alle ore 20:29 Enrico Olivelli ha scritto: > > I would like to enable Travis on other plugins, maybe I can do it on plugins > which have active prs > > Okay? > Enrico > > Il lun 7 gen 2019, 02:46 Manfred Moser ha scritto: >> >> Fair enough. If its just for outside contributor PRs I am agree with not >> owning the risk ;-) >> >> Stephen Connolly wrote on 2019-01-04 16:06: >> >> > On Fri 4 Jan 2019 at 22:00, Tibor Digana wrote: >> > >> >> @Stephen Connolly >> >> After such a big investment, especially made on your side, in Jenkins >> >> plugin you developed you do not want to support the GitHub PRs and you >> >> just >> >> let be to go with TravisCI just like that? I do not think so! >> > >> > >> > I want to add GitHub support to ASF Jenkins too, but PR verification should >> > be layers. No harm in having one layer provided by Travis/Codeship/etc and >> > the second layer by Jenkins. >> > >> > The other point is even if I add PR support to the ASF Jenkins, it’s not >> > going to be automatic build for non-committers (which is the group of PRs >> > that need the CI feedback most, and with least delay... ie before they walk >> > away) as we simply do not have throw-away infra for building PRs that could >> > contain bitcoin miners triggered by a unit test, etc. >> > >> > Now if infra wants to set up a dedicated “safe space” for untrusted PRs to >> > be built... super... but until that happens, we’ll need something like >> > Travis to take that risk for us. >> > >> > >> >> T >> >> >> >> >> >> On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < >> >> stephen.alan.conno...@gmail.com> wrote: >> >> >> >> > +1 from me >> >> > >> >> > On Fri 4 Jan 2019 at 18:21, Enrico Olivelli wrote: >> >> > >> >> > > Hi, >> >> > > I would like to try out Travis on this small plugin: >> >> > > https://github.com/apache/maven-scripting-plugin >> >> > > >> >> > > I have pushed a minimal configuration file >> >> > > I need to ask to Infra, but I need approval from the community and >> >> > PMCs... >> >> > > >> >> > > Can I proceed ? >> >> > > >> >> > > Enrico >> >> > > >> >> > > - >> >> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> >> > > For additional commands, e-mail: dev-h...@maven.apache.org >> >> > > >> >> > > -- >> >> > Sent from my phone >> >> > >> >> >> > -- >> > Sent from my phone >> > >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> > -- > > > -- Enrico Olivelli - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Enable Travis on Maven Scripting Plugin
I would like to enable Travis on other plugins, maybe I can do it on plugins which have active prs Okay? Enrico Il lun 7 gen 2019, 02:46 Manfred Moser ha scritto: > Fair enough. If its just for outside contributor PRs I am agree with not > owning the risk ;-) > > Stephen Connolly wrote on 2019-01-04 16:06: > > > On Fri 4 Jan 2019 at 22:00, Tibor Digana wrote: > > > >> @Stephen Connolly > >> After such a big investment, especially made on your side, in Jenkins > >> plugin you developed you do not want to support the GitHub PRs and you > just > >> let be to go with TravisCI just like that? I do not think so! > > > > > > I want to add GitHub support to ASF Jenkins too, but PR verification > should > > be layers. No harm in having one layer provided by Travis/Codeship/etc > and > > the second layer by Jenkins. > > > > The other point is even if I add PR support to the ASF Jenkins, it’s not > > going to be automatic build for non-committers (which is the group of PRs > > that need the CI feedback most, and with least delay... ie before they > walk > > away) as we simply do not have throw-away infra for building PRs that > could > > contain bitcoin miners triggered by a unit test, etc. > > > > Now if infra wants to set up a dedicated “safe space” for untrusted PRs > to > > be built... super... but until that happens, we’ll need something like > > Travis to take that risk for us. > > > > > >> T > >> > >> > >> On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > >> stephen.alan.conno...@gmail.com> wrote: > >> > >> > +1 from me > >> > > >> > On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > wrote: > >> > > >> > > Hi, > >> > > I would like to try out Travis on this small plugin: > >> > > https://github.com/apache/maven-scripting-plugin > >> > > > >> > > I have pushed a minimal configuration file > >> > > I need to ask to Infra, but I need approval from the community and > >> > PMCs... > >> > > > >> > > Can I proceed ? > >> > > > >> > > Enrico > >> > > > >> > > > - > >> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> > > For additional commands, e-mail: dev-h...@maven.apache.org > >> > > > >> > > -- > >> > Sent from my phone > >> > > >> > > -- > > Sent from my phone > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- -- Enrico Olivelli
Re: Enable Travis on Maven Scripting Plugin
Fair enough. If its just for outside contributor PRs I am agree with not owning the risk ;-) Stephen Connolly wrote on 2019-01-04 16:06: > On Fri 4 Jan 2019 at 22:00, Tibor Digana wrote: > >> @Stephen Connolly >> After such a big investment, especially made on your side, in Jenkins >> plugin you developed you do not want to support the GitHub PRs and you just >> let be to go with TravisCI just like that? I do not think so! > > > I want to add GitHub support to ASF Jenkins too, but PR verification should > be layers. No harm in having one layer provided by Travis/Codeship/etc and > the second layer by Jenkins. > > The other point is even if I add PR support to the ASF Jenkins, it’s not > going to be automatic build for non-committers (which is the group of PRs > that need the CI feedback most, and with least delay... ie before they walk > away) as we simply do not have throw-away infra for building PRs that could > contain bitcoin miners triggered by a unit test, etc. > > Now if infra wants to set up a dedicated “safe space” for untrusted PRs to > be built... super... but until that happens, we’ll need something like > Travis to take that risk for us. > > >> T >> >> >> On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < >> stephen.alan.conno...@gmail.com> wrote: >> >> > +1 from me >> > >> > On Fri 4 Jan 2019 at 18:21, Enrico Olivelli wrote: >> > >> > > Hi, >> > > I would like to try out Travis on this small plugin: >> > > https://github.com/apache/maven-scripting-plugin >> > > >> > > I have pushed a minimal configuration file >> > > I need to ask to Infra, but I need approval from the community and >> > PMCs... >> > > >> > > Can I proceed ? >> > > >> > > Enrico >> > > >> > > - >> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> > > For additional commands, e-mail: dev-h...@maven.apache.org >> > > >> > > -- >> > Sent from my phone >> > >> > -- > Sent from my phone > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Enable Travis on Maven Scripting Plugin
Il dom 6 gen 2019, 21:04 Sylwester Lachiewicz ha scritto: > In Maven Resolver we have a sample Travis configuration, so someone can > test with the forked repo. > If we go with Travis CI I would be good to have a common configuration for > all projects (ie to run run-it etc and have .travis.yml excluded from RAT). > You don't need to skip that file, see the one I put in maven-scripting-plugin, you can add the license header I saw in one Apache project (don't remember now name) where they have a > separate script to merge PR but prerequisite was to PR from forked repo has > successful Travis build. > See Calcite and Bookkeeper for instance This way we do not use "our" Apache accounts to run builds and developers > are free to configure anything (and be responsible) in its own Travis > accounts. > Enrico > > BR > Sylwester > > pt., 4 sty 2019 o 19:21 Enrico Olivelli napisał(a): > > > Hi, > > I would like to try out Travis on this small plugin: > > https://github.com/apache/maven-scripting-plugin > > > > I have pushed a minimal configuration file > > I need to ask to Infra, but I need approval from the community and > PMCs... > > > > Can I proceed ? > > > > Enrico > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- -- Enrico Olivelli
Re: Enable Travis on Maven Scripting Plugin
I believe my employer also offers free build services for OSS projects via our CodeShip offering. If people are concerned about tying PR validation exclusively to one vendor we should inspect the CloudBees CodeShip capabilities (includes Docker build agents, which can be very nice... though I confess I have not tried CodeShip yet, despite it being a product of my employer) I think CircleCI also provides some stuff in that line. We could also investigate GitHub Actions for build validation... but further down the road that may require getting Microsoft/GitHub to provide CPU time donations. On Sun 6 Jan 2019 at 20:04, Sylwester Lachiewicz wrote: > In Maven Resolver we have a sample Travis configuration, so someone can > test with the forked repo. > If we go with Travis CI I would be good to have a common configuration for > all projects (ie to run run-it etc and have .travis.yml excluded from RAT). > I saw in one Apache project (don't remember now name) where they have a > separate script to merge PR but prerequisite was to PR from forked repo has > successful Travis build. > This way we do not use "our" Apache accounts to run builds and developers > are free to configure anything (and be responsible) in its own Travis > accounts. > > BR > Sylwester > > pt., 4 sty 2019 o 19:21 Enrico Olivelli napisał(a): > > > Hi, > > I would like to try out Travis on this small plugin: > > https://github.com/apache/maven-scripting-plugin > > > > I have pushed a minimal configuration file > > I need to ask to Infra, but I need approval from the community and > PMCs... > > > > Can I proceed ? > > > > Enrico > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- Sent from my phone
Re: Enable Travis on Maven Scripting Plugin
In Maven Resolver we have a sample Travis configuration, so someone can test with the forked repo. If we go with Travis CI I would be good to have a common configuration for all projects (ie to run run-it etc and have .travis.yml excluded from RAT). I saw in one Apache project (don't remember now name) where they have a separate script to merge PR but prerequisite was to PR from forked repo has successful Travis build. This way we do not use "our" Apache accounts to run builds and developers are free to configure anything (and be responsible) in its own Travis accounts. BR Sylwester pt., 4 sty 2019 o 19:21 Enrico Olivelli napisał(a): > Hi, > I would like to try out Travis on this small plugin: > https://github.com/apache/maven-scripting-plugin > > I have pushed a minimal configuration file > I need to ask to Infra, but I need approval from the community and PMCs... > > Can I proceed ? > > Enrico > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Enable Travis on Maven Scripting Plugin
Il dom 6 gen 2019, 18:03 Hervé BOUTEMY ha scritto: > you mean this directory is not involved in the seed job [2]? > I meant only that the name of such directory was not special, it works as you described when I look into this job, I see a "Process Job DSLs" step that looks on > filesystem ".test-infra/jenkins/job_*.groovy" > > in Maven, the "maven-box" seed job [3] is created with the ASF's Gitpubsub > Jenkins plugin that creates the mutlibranch pipeline jobs, that's really > the > same idea, no? > I didn't know. I will double check but I think you are right. I never used multibranch pipelines and I don't use Jenkinsfiles which I thought it was a different approach from the Jenkins DSL/seed job one Enrico > > Regards, > > Hervé > > [2] https://builds.apache.org/job/bookkeeper-seed/ > > [3] https://builds.apache.org/job/maven-box/ > > Le dimanche 6 janvier 2019, 11:48:29 CET Enrico Olivelli a écrit : > > It is not a special directory, we are using Je kins DSL, and there is a > > 'seed job' which parses these files and creates/updates the jobs. > > This way committers without direct access to Jenkins can operate on > > configuration and we can work with review then commit. > > Therefore it is easy to reconstruct every job in case of disaster > > > > > > Enrico > > > > Il dom 6 gen 2019, 10:32 Hervé BOUTEMY ha > scritto: > > > interesting > > > > > > I suppose this is enabled by the content of .test-infra/jenkins > directory > > > [1] > > > even if I don't really understand the content and how we could add > > > something > > > like this in our configuration > > > > > > Regards, > > > > > > Hervé > > > > > > [1] > https://github.com/apache/bookkeeper/tree/master/.test-infra/jenkins > > > > > > Le samedi 5 janvier 2019, 10:35:11 CET Enrico Olivelli a écrit : > > > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha > > > > > > scritto: > > > > > Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > > > > > On Sat, 5 Jan 2019 at 12:39, Tibor Digana < > tibordig...@apache.org> > > > > > > > > > > wrote: > > > > > > > Manfred, did you see my comment on Slack? > > > > > > > Shortly, let's have dedicated machines just only for Maven > project > > > > > > > with > > > > > > > Infra support and one person from our team with Infra > permissions > > > > > > just > > > > > > > > on > > > > > > > > > > > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu > for > > > > > > us. > > > > > > > > > > all: WDYT? > > > > > > > > > > > > No way. Apache Infrastructure is a shared infrastructure. There > are > > > > > > NO > > > > > > > > > dedicated machine for any projects. > > > > > > The infra budget is shared between project. I'm pretty sure you > will > > > > > > > > > > never > > > > > > > > > > > convince infra of your idea... > > > > > > If you have time to waste maybe you can try but .. :) > > > > > > > > > > +1 > > > > > > > > > > Enrico, you wrote > > > > > "I see the same setup in Zookeeper and Bookkeeper and github pr > plugin > > > > > works > > > > > like a charm (and I partecipated in setting it up)" > > > > > > > > > > but you never gave any pointer, any demo of what Zookeeper and > > > > > > Bookkeeper > > > > > > > > do > > > > > with PRs (or I overlooked the email: that may happen...) > > > > > can you show us, please? > > > > > > > > Sure, this is an example of PR on BookKeeper, there are up to 10 > checks > > > > triggered by github, one on travis which validates the build, without > > > > tests, on every supported java version, then you have many ASF > jenkins > > > > > > jobs > > > > > > > for tests and integration tests > > > > Bookkeeper tests are huge and so we split the test suite in 5 parts, > so > > > > that it is easier to restart a single job and not to re run the full > > > > > > suite > > > > > > > (we still have some flakes) > > > > > > > > https://github.com/apache/bookkeeper/pull/1572 > > > > > > > > If you create a PR you will see that the user has the ability to > 'skip' > > > > some jobs, maybe because his change is only about the website or > about > > > > > > some > > > > > > > specific parts. > > > > In Bookkeeper we have very strict review-then-commit rules so every > one > > > > uses PRs in his every day activity on BK. > > > > > > > > On Zookeeper we have a single precommit job which builds PRs and now > we > > > > > > are > > > > > > > also enabling Travis this month (the project is migrating from Ant to > > > > > > Maven > > > > > > > and so Travis will be easy to use and most usable for non committers) > > > > > > > > In both of the two projects we have configured the 'trigger phrase' > and > > > > > > we > > > > > > > have whitelisted the apache committers github group for such trigger. > > > > > > > > Currently all of the jobs are triggered even at PR creation and at > > > > close/reopen, this can be dangerous. We can skip this for Maven and > > > > > > enable > > > > > > > only the trigger phrase. > > > > As already said this is not possible with
Re: Enable Travis on Maven Scripting Plugin
you mean this directory is not involved in the seed job [2]? when I look into this job, I see a "Process Job DSLs" step that looks on filesystem ".test-infra/jenkins/job_*.groovy" in Maven, the "maven-box" seed job [3] is created with the ASF's Gitpubsub Jenkins plugin that creates the mutlibranch pipeline jobs, that's really the same idea, no? Regards, Hervé [2] https://builds.apache.org/job/bookkeeper-seed/ [3] https://builds.apache.org/job/maven-box/ Le dimanche 6 janvier 2019, 11:48:29 CET Enrico Olivelli a écrit : > It is not a special directory, we are using Je kins DSL, and there is a > 'seed job' which parses these files and creates/updates the jobs. > This way committers without direct access to Jenkins can operate on > configuration and we can work with review then commit. > Therefore it is easy to reconstruct every job in case of disaster > > > Enrico > > Il dom 6 gen 2019, 10:32 Hervé BOUTEMY ha scritto: > > interesting > > > > I suppose this is enabled by the content of .test-infra/jenkins directory > > [1] > > even if I don't really understand the content and how we could add > > something > > like this in our configuration > > > > Regards, > > > > Hervé > > > > [1] https://github.com/apache/bookkeeper/tree/master/.test-infra/jenkins > > > > Le samedi 5 janvier 2019, 10:35:11 CET Enrico Olivelli a écrit : > > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha > > > > scritto: > > > > Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > > > > On Sat, 5 Jan 2019 at 12:39, Tibor Digana > > > > > > > > wrote: > > > > > > Manfred, did you see my comment on Slack? > > > > > > Shortly, let's have dedicated machines just only for Maven project > > > > > > with > > > > > > Infra support and one person from our team with Infra permissions > > > > just > > > > > > on > > > > > > > > > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for > > > > us. > > > > > > > > all: WDYT? > > > > > > > > > > No way. Apache Infrastructure is a shared infrastructure. There are > > > > NO > > > > > > > dedicated machine for any projects. > > > > > The infra budget is shared between project. I'm pretty sure you will > > > > > > > > never > > > > > > > > > convince infra of your idea... > > > > > If you have time to waste maybe you can try but .. :) > > > > > > > > +1 > > > > > > > > Enrico, you wrote > > > > "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > > > > works > > > > like a charm (and I partecipated in setting it up)" > > > > > > > > but you never gave any pointer, any demo of what Zookeeper and > > > > Bookkeeper > > > > > > do > > > > with PRs (or I overlooked the email: that may happen...) > > > > can you show us, please? > > > > > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > > > triggered by github, one on travis which validates the build, without > > > tests, on every supported java version, then you have many ASF jenkins > > > > jobs > > > > > for tests and integration tests > > > Bookkeeper tests are huge and so we split the test suite in 5 parts, so > > > that it is easier to restart a single job and not to re run the full > > > > suite > > > > > (we still have some flakes) > > > > > > https://github.com/apache/bookkeeper/pull/1572 > > > > > > If you create a PR you will see that the user has the ability to 'skip' > > > some jobs, maybe because his change is only about the website or about > > > > some > > > > > specific parts. > > > In Bookkeeper we have very strict review-then-commit rules so every one > > > uses PRs in his every day activity on BK. > > > > > > On Zookeeper we have a single precommit job which builds PRs and now we > > > > are > > > > > also enabling Travis this month (the project is migrating from Ant to > > > > Maven > > > > > and so Travis will be easy to use and most usable for non committers) > > > > > > In both of the two projects we have configured the 'trigger phrase' and > > > > we > > > > > have whitelisted the apache committers github group for such trigger. > > > > > > Currently all of the jobs are triggered even at PR creation and at > > > close/reopen, this can be dangerous. We can skip this for Maven and > > > > enable > > > > > only the trigger phrase. > > > As already said this is not possible with current maven-box plugin > > > > > > Enrico > > > > > > > Regards, > > > > > > > > Hervé > > > > > > > > > > Cheers > > > > > > Tibor > > > > > > > > > > > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser < > > > > > > > > manf...@simpligility.com> > > > > > > > > > > wrote: > > > > > > > I agree with Tibor. I would rather not have to deal with two > > > > > > > > different > > > > > > > > > > > CI > > > > > > > systems... > > > > > > > > > > > > > > Manfred > > > > > > > > > > > > > > Tibor Digana wrote on 2019-01-04 14:00: > > > > > > > > @Stephen Connolly > > > > > > > > After such a big investment, especially made on your
Re: Enable Travis on Maven Scripting Plugin
Enrico> limited to linux and osx, not windows. Windows can be tested via AppVeyor. The configuration is the same: one adds appveyor.yml (e.g. https://github.com/apache/calcite/blob/master/appveyor.yml ) and asks Infra team to enable AppVeyo-GitHub integration. Vladimir - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Enable Travis on Maven Scripting Plugin
It is not a special directory, we are using Je kins DSL, and there is a 'seed job' which parses these files and creates/updates the jobs. This way committers without direct access to Jenkins can operate on configuration and we can work with review then commit. Therefore it is easy to reconstruct every job in case of disaster Enrico Il dom 6 gen 2019, 10:32 Hervé BOUTEMY ha scritto: > interesting > > I suppose this is enabled by the content of .test-infra/jenkins directory > [1] > even if I don't really understand the content and how we could add > something > like this in our configuration > > Regards, > > Hervé > > [1] https://github.com/apache/bookkeeper/tree/master/.test-infra/jenkins > > Le samedi 5 janvier 2019, 10:35:11 CET Enrico Olivelli a écrit : > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha > scritto: > > > Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > > > On Sat, 5 Jan 2019 at 12:39, Tibor Digana > > > > > > wrote: > > > > > Manfred, did you see my comment on Slack? > > > > > Shortly, let's have dedicated machines just only for Maven project > > > > > with > > > > > Infra support and one person from our team with Infra permissions > just > > > > > > on > > > > > > > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for > us. > > > > > all: WDYT? > > > > > > > > No way. Apache Infrastructure is a shared infrastructure. There are > NO > > > > dedicated machine for any projects. > > > > The infra budget is shared between project. I'm pretty sure you will > > > > > > never > > > > > > > convince infra of your idea... > > > > If you have time to waste maybe you can try but .. :) > > > > > > +1 > > > > > > Enrico, you wrote > > > "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > > > works > > > like a charm (and I partecipated in setting it up)" > > > > > > but you never gave any pointer, any demo of what Zookeeper and > Bookkeeper > > > do > > > with PRs (or I overlooked the email: that may happen...) > > > can you show us, please? > > > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > > triggered by github, one on travis which validates the build, without > > tests, on every supported java version, then you have many ASF jenkins > jobs > > for tests and integration tests > > Bookkeeper tests are huge and so we split the test suite in 5 parts, so > > that it is easier to restart a single job and not to re run the full > suite > > (we still have some flakes) > > > > https://github.com/apache/bookkeeper/pull/1572 > > > > If you create a PR you will see that the user has the ability to 'skip' > > some jobs, maybe because his change is only about the website or about > some > > specific parts. > > In Bookkeeper we have very strict review-then-commit rules so every one > > uses PRs in his every day activity on BK. > > > > On Zookeeper we have a single precommit job which builds PRs and now we > are > > also enabling Travis this month (the project is migrating from Ant to > Maven > > and so Travis will be easy to use and most usable for non committers) > > > > In both of the two projects we have configured the 'trigger phrase' and > we > > have whitelisted the apache committers github group for such trigger. > > > > Currently all of the jobs are triggered even at PR creation and at > > close/reopen, this can be dangerous. We can skip this for Maven and > enable > > only the trigger phrase. > > As already said this is not possible with current maven-box plugin > > > > Enrico > > > > > Regards, > > > > > > Hervé > > > > > > > > Cheers > > > > > Tibor > > > > > > > > > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser < > > > > > > manf...@simpligility.com> > > > > > > > > wrote: > > > > > > I agree with Tibor. I would rather not have to deal with two > > > > > > different > > > > > > > > > CI > > > > > > systems... > > > > > > > > > > > > Manfred > > > > > > > > > > > > Tibor Digana wrote on 2019-01-04 14:00: > > > > > > > @Stephen Connolly > > > > > > > After such a big investment, especially made on your side, in > > > > > > Jenkins > > > > > > > > > > plugin you developed you do not want to support the GitHub PRs > and > > > > > > you > > > > > > > > > just > > > > > > > > > > > > > let be to go with TravisCI just like that? I do not think so! > > > > > > > T > > > > > > > > > > > > > > > > > > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > > > > > > > > > > > > > > stephen.alan.conno...@gmail.com> wrote: > > > > > > >> +1 from me > > > > > > >> > > > > > > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli < > eolive...@gmail.com> > > > > > > > > > > > > wrote: > > > > > > >> > Hi, > > > > > > >> > I would like to try out Travis on this small plugin: > > > > > > >> > https://github.com/apache/maven-scripting-plugin > > > > > > >> > > > > > > > >> > I have pushed a minimal configuration file > > > > > > >> > I need to ask to Infra, but I need approval from the > community > > > > > > and > > > > > > > > >
Re: Enable Travis on Maven Scripting Plugin
Il dom 6 gen 2019, 10:32 Hervé BOUTEMY ha scritto: > Le samedi 5 janvier 2019, 12:34:30 CET Enrico Olivelli a écrit : > > Travis up and running on Maven Scripting Plugin > > this is the first build with integration tests > > > > mvn verify -Prun-its > > https://travis-ci.org/apache/maven-scripting-plugin/builds/475666300 > > > > This is how the PR looks like: > > https://github.com/apache/maven-scripting-plugin/pull/2 > > > > I think it is a great step forward for contributors > +1 > such a basic setup is sufficient for 90% of our plugins, which have basic > "mvn > -Prun-its verify" requirement > > is it just about the addition of the .travis.yml on any git repository? > You have to add travis configuration file and you have to ask infra to enable it, every committer ( at least I can and I am not special) will be able to change the configuration using Travis Web Ui but only infra can activate the service. Beware that it is not only running 'verify' but also it is implicit in Travis to run mvn install -DskipTests -Djavadoc.skip.. See [1] We could enable multiple java versions and maven version but you are limited to linux and osx, not windows. I think that in our case linux + latest jdk (11 currently) is enough, as the committer will anyway test the patch on maven-box Enrico [1] https://docs.travis-ci.com/user/languages/java/#projects-using-maven > Regards, > > Hervé > > > > > Il giorno sab 5 gen 2019 alle ore 10:35 Enrico Olivelli > > > > ha scritto: > > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha > scritto: > > >> Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > >> > On Sat, 5 Jan 2019 at 12:39, Tibor Digana > wrote: > > >> > > Manfred, did you see my comment on Slack? > > >> > > Shortly, let's have dedicated machines just only for Maven project > > >> > > with > > >> > > Infra support and one person from our team with Infra permissions > > >> > > just on > > >> > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for > us. > > >> > > all: WDYT? > > >> > > > >> > No way. Apache Infrastructure is a shared infrastructure. There are > NO > > >> > dedicated machine for any projects. > > >> > The infra budget is shared between project. I'm pretty sure you will > > >> > never > > >> > convince infra of your idea... > > >> > If you have time to waste maybe you can try but .. :) > > >> > > >> +1 > > >> > > >> Enrico, you wrote > > >> "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > > >> works like a charm (and I partecipated in setting it up)" > > >> > > >> but you never gave any pointer, any demo of what Zookeeper and > Bookkeeper > > >> do with PRs (or I overlooked the email: that may happen...) > > >> can you show us, please? > > > > > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > > > triggered by github, one on travis which validates the build, without > > > tests, on every supported java version, then you have many ASF jenkins > > > jobs for tests and integration tests Bookkeeper tests are huge and so > we > > > split the test suite in 5 parts, so that it is easier to restart a > single > > > job and not to re run the full suite (we still have some flakes) > > > > > > https://github.com/apache/bookkeeper/pull/1572 > > > > > > If you create a PR you will see that the user has the ability to 'skip' > > > some jobs, maybe because his change is only about the website or about > > > some specific parts. In Bookkeeper we have very strict > review-then-commit > > > rules so every one uses PRs in his every day activity on BK. > > > > > > On Zookeeper we have a single precommit job which builds PRs and now we > > > are also enabling Travis this month (the project is migrating from Ant > to > > > Maven and so Travis will be easy to use and most usable for non > > > committers) > > > > > > In both of the two projects we have configured the 'trigger phrase' > and we > > > have whitelisted the apache committers github group for such trigger. > > > > > > Currently all of the jobs are triggered even at PR creation and at > > > close/reopen, this can be dangerous. We can skip this for Maven and > > > enable only the trigger phrase. As already said this is not possible > with > > > current maven-box plugin > > > > > > Enrico > > > > > >> Regards, > > >> > > >> Hervé > > >> > > >> > > Cheers > > >> > > Tibor > > >> > > > > >> > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser > > >> > > > > >> > > > > >> > > wrote: > > >> > > > I agree with Tibor. I would rather not have to deal with two > > >> > > > different > > >> > > > CI > > >> > > > systems... > > >> > > > > > >> > > > Manfred > > >> > > > > > >> > > > Tibor Digana wrote on 2019-01-04 14:00: > > >> > > > > @Stephen Connolly > > >> > > > > After such a big investment, especially made on your side, in > > >> > > > > Jenkins > > >> > > > > plugin you developed you do not want to support the GitHub PRs > > >> > > > > and you > > >> > > > > > >> > > > just > > >> > > > > >
Re: Enable Travis on Maven Scripting Plugin
Le samedi 5 janvier 2019, 12:34:30 CET Enrico Olivelli a écrit : > Travis up and running on Maven Scripting Plugin > this is the first build with integration tests > > mvn verify -Prun-its > https://travis-ci.org/apache/maven-scripting-plugin/builds/475666300 > > This is how the PR looks like: > https://github.com/apache/maven-scripting-plugin/pull/2 > > I think it is a great step forward for contributors +1 such a basic setup is sufficient for 90% of our plugins, which have basic "mvn -Prun-its verify" requirement is it just about the addition of the .travis.yml on any git repository? Regards, Hervé > > Il giorno sab 5 gen 2019 alle ore 10:35 Enrico Olivelli > > ha scritto: > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha scritto: > >> Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > >> > On Sat, 5 Jan 2019 at 12:39, Tibor Digana wrote: > >> > > Manfred, did you see my comment on Slack? > >> > > Shortly, let's have dedicated machines just only for Maven project > >> > > with > >> > > Infra support and one person from our team with Infra permissions > >> > > just on > >> > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for us. > >> > > all: WDYT? > >> > > >> > No way. Apache Infrastructure is a shared infrastructure. There are NO > >> > dedicated machine for any projects. > >> > The infra budget is shared between project. I'm pretty sure you will > >> > never > >> > convince infra of your idea... > >> > If you have time to waste maybe you can try but .. :) > >> > >> +1 > >> > >> Enrico, you wrote > >> "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > >> works like a charm (and I partecipated in setting it up)" > >> > >> but you never gave any pointer, any demo of what Zookeeper and Bookkeeper > >> do with PRs (or I overlooked the email: that may happen...) > >> can you show us, please? > > > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > > triggered by github, one on travis which validates the build, without > > tests, on every supported java version, then you have many ASF jenkins > > jobs for tests and integration tests Bookkeeper tests are huge and so we > > split the test suite in 5 parts, so that it is easier to restart a single > > job and not to re run the full suite (we still have some flakes) > > > > https://github.com/apache/bookkeeper/pull/1572 > > > > If you create a PR you will see that the user has the ability to 'skip' > > some jobs, maybe because his change is only about the website or about > > some specific parts. In Bookkeeper we have very strict review-then-commit > > rules so every one uses PRs in his every day activity on BK. > > > > On Zookeeper we have a single precommit job which builds PRs and now we > > are also enabling Travis this month (the project is migrating from Ant to > > Maven and so Travis will be easy to use and most usable for non > > committers) > > > > In both of the two projects we have configured the 'trigger phrase' and we > > have whitelisted the apache committers github group for such trigger. > > > > Currently all of the jobs are triggered even at PR creation and at > > close/reopen, this can be dangerous. We can skip this for Maven and > > enable only the trigger phrase. As already said this is not possible with > > current maven-box plugin > > > > Enrico > > > >> Regards, > >> > >> Hervé > >> > >> > > Cheers > >> > > Tibor > >> > > > >> > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser > >> > > > >> > > > >> > > wrote: > >> > > > I agree with Tibor. I would rather not have to deal with two > >> > > > different > >> > > > CI > >> > > > systems... > >> > > > > >> > > > Manfred > >> > > > > >> > > > Tibor Digana wrote on 2019-01-04 14:00: > >> > > > > @Stephen Connolly > >> > > > > After such a big investment, especially made on your side, in > >> > > > > Jenkins > >> > > > > plugin you developed you do not want to support the GitHub PRs > >> > > > > and you > >> > > > > >> > > > just > >> > > > > >> > > > > let be to go with TravisCI just like that? I do not think so! > >> > > > > T > >> > > > > > >> > > > > > >> > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > >> > > > > > >> > > > > stephen.alan.conno...@gmail.com> wrote: > >> > > > >> +1 from me > >> > > > >> > >> > > > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > >> > > > >> > >> > > > > >> > > > wrote: > >> > > > >> > Hi, > >> > > > >> > I would like to try out Travis on this small plugin: > >> > > > >> > https://github.com/apache/maven-scripting-plugin > >> > > > >> > > >> > > > >> > I have pushed a minimal configuration file > >> > > > >> > I need to ask to Infra, but I need approval from the community > >> > > > >> > and > >> > > > >> > >> > > > >> PMCs... > >> > > > >> > >> > > > >> > Can I proceed ? > >> > > > >> > > >> > > > >> > Enrico > >> > > > >> > > - > >> > > > >> > > > >> > To
Re: Enable Travis on Maven Scripting Plugin
interesting I suppose this is enabled by the content of .test-infra/jenkins directory [1] even if I don't really understand the content and how we could add something like this in our configuration Regards, Hervé [1] https://github.com/apache/bookkeeper/tree/master/.test-infra/jenkins Le samedi 5 janvier 2019, 10:35:11 CET Enrico Olivelli a écrit : > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha scritto: > > Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > > On Sat, 5 Jan 2019 at 12:39, Tibor Digana > > > > wrote: > > > > Manfred, did you see my comment on Slack? > > > > Shortly, let's have dedicated machines just only for Maven project > > > > with > > > > Infra support and one person from our team with Infra permissions just > > > > on > > > > > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for us. > > > > all: WDYT? > > > > > > No way. Apache Infrastructure is a shared infrastructure. There are NO > > > dedicated machine for any projects. > > > The infra budget is shared between project. I'm pretty sure you will > > > > never > > > > > convince infra of your idea... > > > If you have time to waste maybe you can try but .. :) > > > > +1 > > > > Enrico, you wrote > > "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > > works > > like a charm (and I partecipated in setting it up)" > > > > but you never gave any pointer, any demo of what Zookeeper and Bookkeeper > > do > > with PRs (or I overlooked the email: that may happen...) > > can you show us, please? > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > triggered by github, one on travis which validates the build, without > tests, on every supported java version, then you have many ASF jenkins jobs > for tests and integration tests > Bookkeeper tests are huge and so we split the test suite in 5 parts, so > that it is easier to restart a single job and not to re run the full suite > (we still have some flakes) > > https://github.com/apache/bookkeeper/pull/1572 > > If you create a PR you will see that the user has the ability to 'skip' > some jobs, maybe because his change is only about the website or about some > specific parts. > In Bookkeeper we have very strict review-then-commit rules so every one > uses PRs in his every day activity on BK. > > On Zookeeper we have a single precommit job which builds PRs and now we are > also enabling Travis this month (the project is migrating from Ant to Maven > and so Travis will be easy to use and most usable for non committers) > > In both of the two projects we have configured the 'trigger phrase' and we > have whitelisted the apache committers github group for such trigger. > > Currently all of the jobs are triggered even at PR creation and at > close/reopen, this can be dangerous. We can skip this for Maven and enable > only the trigger phrase. > As already said this is not possible with current maven-box plugin > > Enrico > > > Regards, > > > > Hervé > > > > > > Cheers > > > > Tibor > > > > > > > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser < > > > > manf...@simpligility.com> > > > > > > wrote: > > > > > I agree with Tibor. I would rather not have to deal with two > > > > different > > > > > > > CI > > > > > systems... > > > > > > > > > > Manfred > > > > > > > > > > Tibor Digana wrote on 2019-01-04 14:00: > > > > > > @Stephen Connolly > > > > > > After such a big investment, especially made on your side, in > > > > Jenkins > > > > > > > > plugin you developed you do not want to support the GitHub PRs and > > > > you > > > > > > > just > > > > > > > > > > > let be to go with TravisCI just like that? I do not think so! > > > > > > T > > > > > > > > > > > > > > > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > > > > > > > > > > > > stephen.alan.conno...@gmail.com> wrote: > > > > > >> +1 from me > > > > > >> > > > > > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > > > > > > > > > > wrote: > > > > > >> > Hi, > > > > > >> > I would like to try out Travis on this small plugin: > > > > > >> > https://github.com/apache/maven-scripting-plugin > > > > > >> > > > > > > >> > I have pushed a minimal configuration file > > > > > >> > I need to ask to Infra, but I need approval from the community > > > > and > > > > > > > >> PMCs... > > > > > >> > > > > > >> > Can I proceed ? > > > > > >> > > > > > > >> > Enrico > > > > > > > > - > > > > > > > > > >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > > >> > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > >> > > > > > > >> > -- > > > > > >> > > > > > >> Sent from my phone > > > > > > > > > > > > > > > - > > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > >
Re: Enable Travis on Maven Scripting Plugin
On Sat, Jan 5, 2019 at 8:11 AM Olivier Lamy wrote: > No way. Apache Infrastructure is a shared infrastructure. There are NO > dedicated machine for any projects. > I guess you mean physical machines here, don't you? I don't think physical machines are what matters, but having an infra that can provide some isolated and dedicated VMs/Containers to projects would be nice and probably would ease maintenance and innovation by making everything less risky. It's the current setup of build infra at Eclipse.org ( https://medium.com/@mikael.barbero/scaling-up-the-continuous-integration-infrastructure-for-eclipse-foundations-projects-6fd60d4dc41d ), and it really seems to be profitable to both project developers and infra team compared to previous approaches (multi-projects CI with shared slaves, project-specific CIs with shared slaves, project dedicated CI and slaves...). But anyway, if Travis can run a pass of build+tests that would catch a good ratio of errors and report them to contributors automatically, it could be far enough. With my (low) understanding of the build infra at Apache, it seems to me that enabling Travis is by far the action that would bring the most immediate and biggest ROI here; much more than trying a revolution at Apache build infra. Cheers,
Re: Enable Travis on Maven Scripting Plugin
Travis up and running on Maven Scripting Plugin this is the first build with integration tests mvn verify -Prun-its https://travis-ci.org/apache/maven-scripting-plugin/builds/475666300 This is how the PR looks like: https://github.com/apache/maven-scripting-plugin/pull/2 I think it is a great step forward for contributors Il giorno sab 5 gen 2019 alle ore 10:35 Enrico Olivelli ha scritto: > > > > Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha scritto: >> >> Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : >> > On Sat, 5 Jan 2019 at 12:39, Tibor Digana wrote: >> > > Manfred, did you see my comment on Slack? >> > > Shortly, let's have dedicated machines just only for Maven project with >> > > Infra support and one person from our team with Infra permissions just on >> > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for us. >> > > all: WDYT? >> > >> > No way. Apache Infrastructure is a shared infrastructure. There are NO >> > dedicated machine for any projects. >> > The infra budget is shared between project. I'm pretty sure you will never >> > convince infra of your idea... >> > If you have time to waste maybe you can try but .. :) >> +1 >> >> Enrico, you wrote >> "I see the same setup in Zookeeper and Bookkeeper and github pr plugin works >> like a charm (and I partecipated in setting it up)" >> >> but you never gave any pointer, any demo of what Zookeeper and Bookkeeper do >> with PRs (or I overlooked the email: that may happen...) >> can you show us, please? > > > Sure, this is an example of PR on BookKeeper, there are up to 10 checks > triggered by github, one on travis which validates the build, without tests, > on every supported java version, then you have many ASF jenkins jobs for > tests and integration tests > Bookkeeper tests are huge and so we split the test suite in 5 parts, so that > it is easier to restart a single job and not to re run the full suite (we > still have some flakes) > > https://github.com/apache/bookkeeper/pull/1572 > > If you create a PR you will see that the user has the ability to 'skip' some > jobs, maybe because his change is only about the website or about some > specific parts. > In Bookkeeper we have very strict review-then-commit rules so every one uses > PRs in his every day activity on BK. > > On Zookeeper we have a single precommit job which builds PRs and now we are > also enabling Travis this month (the project is migrating from Ant to Maven > and so Travis will be easy to use and most usable for non committers) > > In both of the two projects we have configured the 'trigger phrase' and we > have whitelisted the apache committers github group for such trigger. > > Currently all of the jobs are triggered even at PR creation and at > close/reopen, this can be dangerous. We can skip this for Maven and enable > only the trigger phrase. > As already said this is not possible with current maven-box plugin > > Enrico > >> >> Regards, >> >> Hervé >> >> > >> > > Cheers >> > > Tibor >> > > >> > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser >> > > >> > > wrote: >> > > > I agree with Tibor. I would rather not have to deal with two different >> > > > CI >> > > > systems... >> > > > >> > > > Manfred >> > > > >> > > > Tibor Digana wrote on 2019-01-04 14:00: >> > > > > @Stephen Connolly >> > > > > After such a big investment, especially made on your side, in Jenkins >> > > > > plugin you developed you do not want to support the GitHub PRs and >> > > > > you >> > > > >> > > > just >> > > > >> > > > > let be to go with TravisCI just like that? I do not think so! >> > > > > T >> > > > > >> > > > > >> > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < >> > > > > >> > > > > stephen.alan.conno...@gmail.com> wrote: >> > > > >> +1 from me >> > > > >> >> > > > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli >> > > > >> > > > wrote: >> > > > >> > Hi, >> > > > >> > I would like to try out Travis on this small plugin: >> > > > >> > https://github.com/apache/maven-scripting-plugin >> > > > >> > >> > > > >> > I have pushed a minimal configuration file >> > > > >> > I need to ask to Infra, but I need approval from the community and >> > > > >> >> > > > >> PMCs... >> > > > >> >> > > > >> > Can I proceed ? >> > > > >> > >> > > > >> > Enrico >> > > >> > > - >> > > >> > > > >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> > > > >> > For additional commands, e-mail: dev-h...@maven.apache.org >> > > > >> > >> > > > >> > -- >> > > > >> >> > > > >> Sent from my phone >> > > > >> > > > - >> > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> > > > For additional commands, e-mail: dev-h...@maven.apache.org >> >> >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands,
Re: Enable Travis on Maven Scripting Plugin
Il sab 5 gen 2019, 08:48 Hervé BOUTEMY ha scritto: > Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > > On Sat, 5 Jan 2019 at 12:39, Tibor Digana > wrote: > > > Manfred, did you see my comment on Slack? > > > Shortly, let's have dedicated machines just only for Maven project with > > > Infra support and one person from our team with Infra permissions just > on > > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for us. > > > all: WDYT? > > > > No way. Apache Infrastructure is a shared infrastructure. There are NO > > dedicated machine for any projects. > > The infra budget is shared between project. I'm pretty sure you will > never > > convince infra of your idea... > > If you have time to waste maybe you can try but .. :) > +1 > > Enrico, you wrote > "I see the same setup in Zookeeper and Bookkeeper and github pr plugin > works > like a charm (and I partecipated in setting it up)" > > but you never gave any pointer, any demo of what Zookeeper and Bookkeeper > do > with PRs (or I overlooked the email: that may happen...) > can you show us, please? > Sure, this is an example of PR on BookKeeper, there are up to 10 checks triggered by github, one on travis which validates the build, without tests, on every supported java version, then you have many ASF jenkins jobs for tests and integration tests Bookkeeper tests are huge and so we split the test suite in 5 parts, so that it is easier to restart a single job and not to re run the full suite (we still have some flakes) https://github.com/apache/bookkeeper/pull/1572 If you create a PR you will see that the user has the ability to 'skip' some jobs, maybe because his change is only about the website or about some specific parts. In Bookkeeper we have very strict review-then-commit rules so every one uses PRs in his every day activity on BK. On Zookeeper we have a single precommit job which builds PRs and now we are also enabling Travis this month (the project is migrating from Ant to Maven and so Travis will be easy to use and most usable for non committers) In both of the two projects we have configured the 'trigger phrase' and we have whitelisted the apache committers github group for such trigger. Currently all of the jobs are triggered even at PR creation and at close/reopen, this can be dangerous. We can skip this for Maven and enable only the trigger phrase. As already said this is not possible with current maven-box plugin Enrico > Regards, > > Hervé > > > > > > Cheers > > > Tibor > > > > > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser < > manf...@simpligility.com> > > > > > > wrote: > > > > I agree with Tibor. I would rather not have to deal with two > different > > > > CI > > > > systems... > > > > > > > > Manfred > > > > > > > > Tibor Digana wrote on 2019-01-04 14:00: > > > > > @Stephen Connolly > > > > > After such a big investment, especially made on your side, in > Jenkins > > > > > plugin you developed you do not want to support the GitHub PRs and > you > > > > > > > > just > > > > > > > > > let be to go with TravisCI just like that? I do not think so! > > > > > T > > > > > > > > > > > > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > > > > > > > > > > stephen.alan.conno...@gmail.com> wrote: > > > > >> +1 from me > > > > >> > > > > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > > > > > > > > wrote: > > > > >> > Hi, > > > > >> > I would like to try out Travis on this small plugin: > > > > >> > https://github.com/apache/maven-scripting-plugin > > > > >> > > > > > >> > I have pushed a minimal configuration file > > > > >> > I need to ask to Infra, but I need approval from the community > and > > > > >> > > > > >> PMCs... > > > > >> > > > > >> > Can I proceed ? > > > > >> > > > > > >> > Enrico > > > > > > - > > > > > > > >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > >> > For additional commands, e-mail: dev-h...@maven.apache.org > > > > >> > > > > > >> > -- > > > > >> > > > > >> Sent from my phone > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- -- Enrico Olivelli
Re: Enable Travis on Maven Scripting Plugin
Le samedi 5 janvier 2019, 08:10:51 CET Olivier Lamy a écrit : > On Sat, 5 Jan 2019 at 12:39, Tibor Digana wrote: > > Manfred, did you see my comment on Slack? > > Shortly, let's have dedicated machines just only for Maven project with > > Infra support and one person from our team with Infra permissions just on > > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for us. > > all: WDYT? > > No way. Apache Infrastructure is a shared infrastructure. There are NO > dedicated machine for any projects. > The infra budget is shared between project. I'm pretty sure you will never > convince infra of your idea... > If you have time to waste maybe you can try but .. :) +1 Enrico, you wrote "I see the same setup in Zookeeper and Bookkeeper and github pr plugin works like a charm (and I partecipated in setting it up)" but you never gave any pointer, any demo of what Zookeeper and Bookkeeper do with PRs (or I overlooked the email: that may happen...) can you show us, please? Regards, Hervé > > > Cheers > > Tibor > > > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser > > > > wrote: > > > I agree with Tibor. I would rather not have to deal with two different > > > CI > > > systems... > > > > > > Manfred > > > > > > Tibor Digana wrote on 2019-01-04 14:00: > > > > @Stephen Connolly > > > > After such a big investment, especially made on your side, in Jenkins > > > > plugin you developed you do not want to support the GitHub PRs and you > > > > > > just > > > > > > > let be to go with TravisCI just like that? I do not think so! > > > > T > > > > > > > > > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > > > > > > > > stephen.alan.conno...@gmail.com> wrote: > > > >> +1 from me > > > >> > > > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > > > > > > wrote: > > > >> > Hi, > > > >> > I would like to try out Travis on this small plugin: > > > >> > https://github.com/apache/maven-scripting-plugin > > > >> > > > > >> > I have pushed a minimal configuration file > > > >> > I need to ask to Infra, but I need approval from the community and > > > >> > > > >> PMCs... > > > >> > > > >> > Can I proceed ? > > > >> > > > > >> > Enrico > > > > - > > > > > >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > >> > For additional commands, e-mail: dev-h...@maven.apache.org > > > >> > > > > >> > -- > > > >> > > > >> Sent from my phone > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Enable Travis on Maven Scripting Plugin
On Sat, 5 Jan 2019 at 12:39, Tibor Digana wrote: > Manfred, did you see my comment on Slack? > Shortly, let's have dedicated machines just only for Maven project with > Infra support and one person from our team with Infra permissions just on > these machines. There are 6 Windows machine. So 4 Win/Ubuntu for us. > all: WDYT? > No way. Apache Infrastructure is a shared infrastructure. There are NO dedicated machine for any projects. The infra budget is shared between project. I'm pretty sure you will never convince infra of your idea... If you have time to waste maybe you can try but .. :) > > Cheers > Tibor > > On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser > wrote: > > > I agree with Tibor. I would rather not have to deal with two different CI > > systems... > > > > Manfred > > > > Tibor Digana wrote on 2019-01-04 14:00: > > > > > @Stephen Connolly > > > After such a big investment, especially made on your side, in Jenkins > > > plugin you developed you do not want to support the GitHub PRs and you > > just > > > let be to go with TravisCI just like that? I do not think so! > > > T > > > > > > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > > > stephen.alan.conno...@gmail.com> wrote: > > > > > >> +1 from me > > >> > > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > > wrote: > > >> > > >> > Hi, > > >> > I would like to try out Travis on this small plugin: > > >> > https://github.com/apache/maven-scripting-plugin > > >> > > > >> > I have pushed a minimal configuration file > > >> > I need to ask to Infra, but I need approval from the community and > > >> PMCs... > > >> > > > >> > Can I proceed ? > > >> > > > >> > Enrico > > >> > > > >> > > - > > >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > >> > For additional commands, e-mail: dev-h...@maven.apache.org > > >> > > > >> > -- > > >> Sent from my phone > > >> > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
Re: Enable Travis on Maven Scripting Plugin
On Fri 4 Jan 2019 at 22:00, Tibor Digana wrote: > @Stephen Connolly > After such a big investment, especially made on your side, in Jenkins > plugin you developed you do not want to support the GitHub PRs and you just > let be to go with TravisCI just like that? I do not think so! I want to add GitHub support to ASF Jenkins too, but PR verification should be layers. No harm in having one layer provided by Travis/Codeship/etc and the second layer by Jenkins. The other point is even if I add PR support to the ASF Jenkins, it’s not going to be automatic build for non-committers (which is the group of PRs that need the CI feedback most, and with least delay... ie before they walk away) as we simply do not have throw-away infra for building PRs that could contain bitcoin miners triggered by a unit test, etc. Now if infra wants to set up a dedicated “safe space” for untrusted PRs to be built... super... but until that happens, we’ll need something like Travis to take that risk for us. > T > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > > > +1 from me > > > > On Fri 4 Jan 2019 at 18:21, Enrico Olivelli wrote: > > > > > Hi, > > > I would like to try out Travis on this small plugin: > > > https://github.com/apache/maven-scripting-plugin > > > > > > I have pushed a minimal configuration file > > > I need to ask to Infra, but I need approval from the community and > > PMCs... > > > > > > Can I proceed ? > > > > > > Enrico > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > -- > > Sent from my phone > > > -- Sent from my phone
Re: Enable Travis on Maven Scripting Plugin
Manfred, did you see my comment on Slack? Shortly, let's have dedicated machines just only for Maven project with Infra support and one person from our team with Infra permissions just on these machines. There are 6 Windows machine. So 4 Win/Ubuntu for us. all: WDYT? Cheers Tibor On Sat, Jan 5, 2019 at 12:11 AM Manfred Moser wrote: > I agree with Tibor. I would rather not have to deal with two different CI > systems... > > Manfred > > Tibor Digana wrote on 2019-01-04 14:00: > > > @Stephen Connolly > > After such a big investment, especially made on your side, in Jenkins > > plugin you developed you do not want to support the GitHub PRs and you > just > > let be to go with TravisCI just like that? I do not think so! > > T > > > > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > > stephen.alan.conno...@gmail.com> wrote: > > > >> +1 from me > >> > >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli > wrote: > >> > >> > Hi, > >> > I would like to try out Travis on this small plugin: > >> > https://github.com/apache/maven-scripting-plugin > >> > > >> > I have pushed a minimal configuration file > >> > I need to ask to Infra, but I need approval from the community and > >> PMCs... > >> > > >> > Can I proceed ? > >> > > >> > Enrico > >> > > >> > - > >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> > For additional commands, e-mail: dev-h...@maven.apache.org > >> > > >> > -- > >> Sent from my phone > >> > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
Re: Enable Travis on Maven Scripting Plugin
I agree with Tibor. I would rather not have to deal with two different CI systems... Manfred Tibor Digana wrote on 2019-01-04 14:00: > @Stephen Connolly > After such a big investment, especially made on your side, in Jenkins > plugin you developed you do not want to support the GitHub PRs and you just > let be to go with TravisCI just like that? I do not think so! > T > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > >> +1 from me >> >> On Fri 4 Jan 2019 at 18:21, Enrico Olivelli wrote: >> >> > Hi, >> > I would like to try out Travis on this small plugin: >> > https://github.com/apache/maven-scripting-plugin >> > >> > I have pushed a minimal configuration file >> > I need to ask to Infra, but I need approval from the community and >> PMCs... >> > >> > Can I proceed ? >> > >> > Enrico >> > >> > - >> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> > For additional commands, e-mail: dev-h...@maven.apache.org >> > >> > -- >> Sent from my phone >> > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Enable Travis on Maven Scripting Plugin
Thanks I am asking INFRA to enable Travis, let's see how it works https://issues.apache.org/jira/browse/INFRA-17554 Enrico Il giorno ven 4 gen 2019 alle ore 23:00 Tibor Digana ha scritto: > > @Stephen Connolly > After such a big investment, especially made on your side, in Jenkins > plugin you developed you do not want to support the GitHub PRs and you just > let be to go with TravisCI just like that? I do not think so! > T > > > On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > > > +1 from me > > > > On Fri 4 Jan 2019 at 18:21, Enrico Olivelli wrote: > > > > > Hi, > > > I would like to try out Travis on this small plugin: > > > https://github.com/apache/maven-scripting-plugin > > > > > > I have pushed a minimal configuration file > > > I need to ask to Infra, but I need approval from the community and > > PMCs... > > > > > > Can I proceed ? > > > > > > Enrico > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > -- > > Sent from my phone > > - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Enable Travis on Maven Scripting Plugin
@Stephen Connolly After such a big investment, especially made on your side, in Jenkins plugin you developed you do not want to support the GitHub PRs and you just let be to go with TravisCI just like that? I do not think so! T On Fri, Jan 4, 2019 at 7:22 PM Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > +1 from me > > On Fri 4 Jan 2019 at 18:21, Enrico Olivelli wrote: > > > Hi, > > I would like to try out Travis on this small plugin: > > https://github.com/apache/maven-scripting-plugin > > > > I have pushed a minimal configuration file > > I need to ask to Infra, but I need approval from the community and > PMCs... > > > > Can I proceed ? > > > > Enrico > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > -- > Sent from my phone >
Re: Enable Travis on Maven Scripting Plugin
+1 from me On Fri 4 Jan 2019 at 18:21, Enrico Olivelli wrote: > Hi, > I would like to try out Travis on this small plugin: > https://github.com/apache/maven-scripting-plugin > > I have pushed a minimal configuration file > I need to ask to Infra, but I need approval from the community and PMCs... > > Can I proceed ? > > Enrico > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > -- Sent from my phone
Enable Travis on Maven Scripting Plugin
Hi, I would like to try out Travis on this small plugin: https://github.com/apache/maven-scripting-plugin I have pushed a minimal configuration file I need to ask to Infra, but I need approval from the community and PMCs... Can I proceed ? Enrico - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
