...@sonatype.com
Subject: Re: Regarding MNG-3321 - Support for Skipping Plugin Execution
To: Maven Developers List dev@maven.apache.org
Date: Monday, February 7, 2011, 3:17 PM
I think a declarative way to skip a
plugin execution which the core can then deal with is more
scalable then trying
...@gmail.com wrote:
From: Kristian Rosenvold kristian.rosenv...@gmail.com
Subject: Re: Regarding MNG-3321 - Support for Skipping Plugin Execution
To: Maven Developers List dev@maven.apache.org
Date: Monday, February 7, 2011, 7:42 AM
It really sounds to me like this
should be done with a profile
Yes. Indeed the right way to accomplish this is to use profiles.
But using profiles this way led me to troubles. There were times when I had
to control whether or not rollbacks should happen at all after a DB update
(like in production environments). To accomplish this, I had to create an
other
Akella kalyan.ake...@gmail.com
Subject: Re: Regarding MNG-3321 - Support for Skipping Plugin Execution
To: Maven Developers List dev@maven.apache.org
Date: Monday, February 7, 2011, 8:57 AM
Yes. Indeed the right way to
accomplish this is to use profiles.
But using profiles this way led me
--- On Mon, 2/7/11, Kristian Rosenvold kristian.rosenv...@gmail.com wrote:
From: Kristian Rosenvold kristian.rosenv...@gmail.com
Subject: Re: Regarding MNG-3321 - Support for Skipping Plugin Execution
To: Maven Developers List dev@maven.apache.org
Date: Monday, February 7, 2011, 7:42 AM
Thanks for the writeup, these kinds of explanations are extremely helpful.
On Feb 6, 2011, at 10:46 PM, Kalyan Akella wrote:
A few days back, I was working with the Liquibase Maven
Pluginhttp://www.liquibase.org/manual/mavenfor doing DB upgrades in
my project. This plugin has 2 specific
:
From: Jason van Zyl ja...@sonatype.com
Subject: Re: Regarding MNG-3321 - Support for Skipping Plugin Execution
To: Maven Developers List dev@maven.apache.org
Date: Monday, February 7, 2011, 3:17 PM
I think a declarative way to skip a
plugin execution which the core can then deal with is more
: Jason van Zyl ja...@sonatype.com
Subject: Re: Regarding MNG-3321 - Support for Skipping Plugin Execution
To: Maven Developers List dev@maven.apache.org
Date: Monday, February 7, 2011, 3:17 PM
I think a declarative way to skip a
plugin execution which the core can then deal with is more
Hi,
Thank you for the comments.
First of all, these changes DO NOT affect the existing integration test
suite. I verified this by running the ENTIRE suite with without my
patches. The *results are the same*.
Secondly, I am in no urgent need to get these changes to Maven 3.0.x. Do it
as you see
Awesome, thanks!
On Feb 6, 2011, at 8:06 AM, Kalyan Akella wrote:
Hi,
Thank you for the comments.
First of all, these changes DO NOT affect the existing integration test
suite. I verified this by running the ENTIRE suite with without my
patches. The *results are the same*.
Secondly,
Out of curiosity what is the first thing you used this feature for?
On Feb 6, 2011, at 8:06 AM, Kalyan Akella wrote:
Hi,
Thank you for the comments.
First of all, these changes DO NOT affect the existing integration test
suite. I verified this by running the ENTIRE suite with without my
A few days back, I was working with the Liquibase Maven
Pluginhttp://www.liquibase.org/manual/mavenfor doing DB upgrades in
my project. This plugin has 2 specific goals, among
others, which I was using,
updatehttp://www.liquibase.org/manual/maven_update
rollback
It really sounds to me like this should be done with a profile that is
triggered
by the presence of a specific file (i.e. db-changeset.sql), as can be
seen
at http://maven.apache.org/guides/introduction/introduction-to-profiles.html
At least this is the way most people handle this, which
Hi,
I attached the revised patches to the issues that implement the following:
1. ability to skip multiple plugins their executions at CLI,
2. ability to skip plugins their executions in POM using the skip
element
I'm still working on the documentation. Please apply the patches and let me
On Feb 5, 2011, at 7:43 AM, Kalyan Akella wrote:
Hi,
I attached the revised patches to the issues that implement the following:
1. ability to skip multiple plugins their executions at CLI,
2. ability to skip plugins their executions in POM using the skip
element
I'm still working
I have looked at the patch diffs and it looks really great, one of the
better patches I've seen in the issue trackers !
We had a quick chat about this patch on irc and we figured we could take
this patch for 3.0.x.
One thing we would like though, is to be able to specify multiple
exclusions, not
FWIW, I'd really love to see us limit the use of command-line parameters
that change the way the build runs. I understand this can be very useful
during debugging (if you're not able run a particular single test in an
IDE for some reason, as one example), but the danger represented by
Yeah but as release:perform forks a build the cli arguments would be
ignored... or have I missed something in the specifics of this patch
On 1 February 2011 20:07, John Casey jdca...@commonjava.org wrote:
FWIW, I'd really love to see us limit the use of command-line parameters
that change the
Technically, if we have a bag of known loopholes that can
be harmful in release I'd think the release plugin should
verify that these aren't present.
Kristian
ti., 01.02.2011 kl. 15.07 -0500, skrev John Casey:
FWIW, I'd really love to see us limit the use of command-line parameters
that
My understanding of the way the release plugin currently works, is that
it reproduces the original input CLI options to the forked
execution...such that if you use:
mvn -Papache-release release:perform
while at the same time configuring a releaseProfile of apache-release,
it'll fork
On 2/1/11 3:14 PM, Kristian Rosenvold wrote:
Technically, if we have a bag of known loopholes that can
be harmful in release I'd think the release plugin should
verify that these aren't present.
I'd tend to agree, though to be pedantic, it's possible the release
plugin would have to grow to
Given that we're talking about just 2-3(?) options after all these years
I am not going to loose any sleep in fear of combinatorial explosion.
But in any case, we should allow the user to avoid using CLI options at
all if he doesn't want to.
Which can be done with the use of properties and the
So the technical work was done implementing this but no where in the issue does
it describe why this feature is useful.
This fundamentally changes the behaviour of the lifecycle and the example
listed in the issue is skipping tests. Some explanation of why this is good
would be nice, there's
Our main topic of discussion on irc was initially if this *should* be a
3.0.X or 3.1 issue due to being somewhat of a borderline between
improvement/new feature. It seems to me like the way this discussion is
heading, it should probably be tagged 3.1.
I agree very much about getting some well
Hi,
Thank you for the patch review comments. I hope it is integrated to the
trunk.
My next steps:
1. Implement support for skipping multiple plugins/executions at the CLI.
2. Implement ability to skip plugin execution through the POM as required by
http://jira.codehaus.org/browse/MNG-3102
3.
Hi,
Any updates on the patch. Did it apply cleanly ? Any comments, changes ??
Sincere Regards,
Kalyan C. Akella
On Sat, Jan 29, 2011 at 8:01 AM, Kalyan Akella kalyan.ake...@gmail.comwrote:
Hi,
Thank you for the comments. I updated the issue,
http://jira.codehaus.org/browse/MNG-3321 with
Hi,
Thank you for the comments. I updated the issue,
http://jira.codehaus.org/browse/MNG-3321 with the modified patches.
Regarding your point about documentation, will you please point me to the
exact location where I should include the usage instructions for this
feature and other info (perhaps
I think any global option for skipping a plugin should be done in the
Execution Plan Calculation,
where we try to build the immutable plan of the actual plugins that will
be run.
Kristian
Den 27.01.2011 05:44, skrev Kalyan Akella:
Hi,
I recently came across this situation in my own project
Hi,
Thank you for the reply.
I just implemented option 1 that modifies the execution plan calculation
algorithm to eliminate plugins executions that should be skipped. Users
should pass this information as...
To skip the surefire plugin,
mvn
Thanks for the patch, which looks good. I added some comments to the
issue, http://jira.codehaus.org/browse/MNG-3321
Kristian
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail:
Hi,
I recently came across this situation in my own project where I wanted to
skip some plugin executions during a standard maven build. I could not find
a straight forward way to accomplish this (as described in MNG-3321) and so
thought of implementing this feature.
I checked out the source
31 matches
Mail list logo
