RE: compiler plugin: separate test compiler configuration

2008-11-10 Thread Jörg Schaible
Oleg Gusakov wrote: Such contriction will not work. The problem is in the way compiler plugin is instantiated: compiler environment is created, and them the same instance is reused for test-compiler, sticking to the existing plugin configuration. Execution does not get a new instance of as far

Re: compiler plugin: separate test compiler configuration

2008-11-10 Thread Oleg Gusakov
It did not work for me, and this might have been the reason. Anyway, I changed the compiler plugin and you can now use testSource and testTarget withing the same execution, if you'd like to. Thank you for the update, Oleg � wrote: Oleg Gusakov wrote: Such contriction will not work. The

Re: compiler plugin: separate test compiler configuration

2008-11-07 Thread mlorenzi
Milos Kleint wrote: well, I suppose the question was if configuring just the testCompile execution doesn't work. I suppose having a general config at sourcelevel 1.4 and then specific one for testCompile execution shall work. I've the same problem and I've tried this way too, but it

Re: compiler plugin: separate test compiler configuration

2008-11-07 Thread Oleg Gusakov
Such contriction will not work. The problem is in the way compiler plugin is instantiated: compiler environment is created, and them the same instance is reused for test-compiler, sticking to the existing plugin configuration. Execution does not get a new instance of as far as can see. That

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Daniel Le Berre
Brian E. Fox a écrit : Milos, you can say that's eclipse's problem. But is't a majority of users, whether it's good or bad, we need to respect that use case. I think it should be allowed. Just because Eclipse can't do it doesn't mean maven shouldn't. It just means if you want to use eclipse

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Michael McCallum
eclipse already blends test and compile scopes... if it plays havoc with your build just don't use the feature... On Mon, 20 Oct 2008 20:16:18 Daniel Le Berre wrote: Brian E. Fox a écrit : Milos, you can say that's eclipse's problem. But is't a majority of users, whether it's good or bad,

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Oleg Gusakov
Looks like we reached a consensus here, I will add the params. Thanks everyone for discussion and guidance! Michael McCallum wrote: eclipse already blends test and compile scopes... if it plays havoc with your build just don't use the feature... Brian E. Fox wrote: Milos, you can say

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Milos Kleint
I'm not sure we did. The execution based config for testCompile doesn't really work? Milos On Mon, Oct 20, 2008 at 5:41 PM, Oleg Gusakov [EMAIL PROTECTED] wrote: Looks like we reached a consensus here, I will add the params. Thanks everyone for discussion and guidance! Michael McCallum

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Oleg Gusakov
Milos - it does not :( Milos Kleint wrote: I'm not sure we did. The execution based config for testCompile doesn't really work? Milos On Mon, Oct 20, 2008 at 5:41 PM, Oleg Gusakov [EMAIL PROTECTED] wrote: Looks like we reached a consensus here, I will add the params. Thanks everyone for

RE: compiler plugin: separate test compiler configuration

2008-10-20 Thread Brian E. Fox
It could work if the plugin took different params for test mode. -Original Message- From: Oleg Gusakov [mailto:[EMAIL PROTECTED] Sent: Monday, October 20, 2008 12:38 PM To: Maven Developers List Subject: Re: compiler plugin: separate test compiler configuration Milos - it does

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Oleg Gusakov
: It could work if the plugin took different params for test mode. -Original Message- From: Oleg Gusakov [mailto:[EMAIL PROTECTED] Sent: Monday, October 20, 2008 12:38 PM To: Maven Developers List Subject: Re: compiler plugin: separate test compiler configuration Milos - it does not :( Milos

RE: compiler plugin: separate test compiler configuration

2008-10-20 Thread Brian E. Fox
Well yeah, that’s the correct fix but requires maven core changes. -Original Message- From: Oleg Gusakov [mailto:[EMAIL PROTECTED] Sent: Monday, October 20, 2008 1:18 PM To: Maven Developers List Subject: Re: compiler plugin: separate test compiler configuration Or if plugin instance

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Brett Porter
What about considering toolchains? - Brett On 21/10/2008, at 2:41 AM, Oleg Gusakov wrote: Looks like we reached a consensus here, I will add the params. Thanks everyone for discussion and guidance! Michael McCallum wrote: eclipse already blends test and compile scopes... if it plays havoc

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Oleg Gusakov
the correct fix but requires maven core changes. -Original Message- From: Oleg Gusakov [mailto:[EMAIL PROTECTED] Sent: Monday, October 20, 2008 1:18 PM To: Maven Developers List Subject: Re: compiler plugin: separate test compiler configuration Or if plugin instance were created per execution

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Oleg Gusakov
I made the easiest and straightforward change, fully backward compatible. I will look at toolchains later on, when I make more serious changes. Thanks, Oleg Brett Porter wrote: What about considering toolchains? - Brett On 21/10/2008, at 2:41 AM, Oleg Gusakov wrote: Looks like we reached

Re: compiler plugin: separate test compiler configuration

2008-10-20 Thread Eugene Kuleshov
Oleg, please make a large bold warning in the documentation for those parameters about issues they could cause in the IDE. I still think it is a huge mistake to encourage such features for Maven, which supposed to support best practices. regards, Eugene Oleg Gusakov wrote:

compiler plugin: separate test compiler configuration

2008-10-19 Thread Oleg Gusakov
One of the users requested a separate source/target configuration for test compiler for the reason of running junit4 tests and yet being java 1.4 in the main classes. It's a trivial change in the compiler plugin, but I decided to ask here before changing it. The proposed change - add two

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Eugene Kuleshov
This won't work very well in the IDEs. For example, Eclipse does not allow to specify different compiler settings per-source folder (i.e. main code vs. tests). So, I would advise against encouraging such feature. Besides users can still use older junit versions that work on 1.4, or they could

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Milos Kleint
just FYI, it should work fine in NetBeans. (after adding code to recognize the new parameters) But I'm not sure if the setting itself is enough to be truly useful. Since the sourcelevel is to be set to 1.5+ jdk javac only (as the 1.4 javac would spill on the 1.5 source level value), the maven

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Rémy Sanlaville
Hi, We are also interesting for a such feature. I just wonder if it is not possible to use the testCompile goal for that ? Thanks, Rémy

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Oleg Gusakov
This exactly the proposal - use test-specific settings to enable source/target, different from compile mojo. So that if nothing is configured - it's all the same, if testSource/testTarget is set - use them for testCompile only. � wrote: Hi, We are also interesting for a such feature. I just

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Milos Kleint
well, I suppose the question was if configuring just the testCompile execution doesn't work. I suppose having a general config at sourcelevel 1.4 and then specific one for testCompile execution shall work. ...maven-compiler-plugin... executions execution idxxx/id goals

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Rémy Sanlaville
Yes Milos, it was my question. In fact, it's nice to can specify specific configuration for both source and test. For instance, we want to be able to define the source and target level but also some other configuration such as compilerArgument and so on Rémy

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Oleg Gusakov
This could be arranged, but Eugene has a very valid question - Eclipse sets all those on the project level and might misbehave as soon as somebody starts debugging such a project. Milos, you can say that's eclipse's problem. But is't a majority of users, whether it's good or bad, we need to

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Daniel Le Berre
Dear all, I am the one that asked for such feature :) Let me explain why. I develop a library that needs to run on a 1.4 JVM (Eclipse requirements). Since I like Java 5+ features, the code is written in 1.5 type and I use the compiler jsr14 target to produce 1.4 bytecode. The project being a

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Brett Porter
I think the use case is valid - I have seen it a number of times before. At runtime they are already separate (you can run surefire with whatever JVM you want, regardless of what you target for compilation). The other parameter that needs to be changed is the ability to fork your own

RE: compiler plugin: separate test compiler configuration

2008-10-19 Thread Brian E. Fox
PM To: Maven Developers List Subject: Re: compiler plugin: separate test compiler configuration This could be arranged, but Eugene has a very valid question - Eclipse sets all those on the project level and might misbehave as soon as somebody starts debugging such a project. Milos, you can say

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Brett Porter
to remember. -Original Message- From: Oleg Gusakov [mailto:[EMAIL PROTECTED] Sent: Sunday, October 19, 2008 4:51 PM To: Maven Developers List Subject: Re: compiler plugin: separate test compiler configuration This could be arranged, but Eugene has a very valid question - Eclipse sets all

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Eugene Kuleshov
Daniel Le Berre wrote: I develop a library that needs to run on a 1.4 JVM (Eclipse requirements). Can you please elaborate on this? As far as I know Eclipse runs perfectly on 1.5 and despite Eclipse Platform being compatible with 1.4, more and more Eclipse projects actually require 1.5 to

RE: compiler plugin: separate test compiler configuration

2008-10-19 Thread Brian E. Fox
] Sent: Sunday, October 19, 2008 7:21 PM To: Maven Developers List Subject: Re: compiler plugin: separate test compiler configuration MCOMPILER-15 MNG-3203 is for a workaround in Maven Cheers, Brett On 20/10/2008, at 10:13 AM, Brian E. Fox wrote: There's already a jira for this since I

Re: compiler plugin: separate test compiler configuration

2008-10-19 Thread Oleg Gusakov
As Daniel is in a different time zone, I take the frivolity to elaborate these. His project - SAT4J - is the engine behind both P2 and Maven Mercury dependency conflict resolution, and as such must adhere to Eclipse platform requirements. Hope this explains the motivation. Eugene Kuleshov

RE: compiler plugin: separate test compiler configuration

2008-10-19 Thread Brian E. Fox
Milos, you can say that's eclipse's problem. But is't a majority of users, whether it's good or bad, we need to respect that use case. I think it should be allowed. Just because Eclipse can't do it doesn't mean maven shouldn't. It just means if you want to use eclipse and maven, then you