Re: Review Request 26487: Perform read right after subprocess for docker ps

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26487/#review56292 --- Ship it! src/docker/docker.cpp

Review Request 26605: Cleanup right angle bracket in the code base.

2014-10-11 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26605/ --- Review request for mesos and Jie Yu. Bugs: MESOS-1872

Re: Review Request 26605: Cleanup right angle bracket in the code base.

2014-10-11 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26605/ --- (Updated Oct. 11, 2014, 6:24 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 26605: Cleanup right angle bracket in the code base.

2014-10-11 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26605/ --- (Updated Oct. 11, 2014, 6:23 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 26605: Cleanup right angle bracket in the code base.

2014-10-11 Thread Evelina Dumitrescu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26605/ --- (Updated Oct. 11, 2014, 6:31 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 26605: Cleanup right angle bracket in the code base.

2014-10-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26605/#review56294 --- Patch looks great! Reviews applied: [26605] All tests passed. -

Review Request 26612: Introduced DockerContainerizerProcess::Container::create.

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26612/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description

Review Request 26613: Simplified launch continuations in DockerContainerizerProcess.

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26613/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description

Review Request 26614: More simplifications of Docker container launching.

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26614/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description

Review Request 26610: Consolidated launch code paths in Docker containerizer.

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26610/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description

Re: Review Request 26436: Avoid docker inspect on each usage call

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/#review56301 --- Why not do it the same way that 'update' does it? - Benjamin

Re: Review Request 26517: Symlink sandbox directories in docker containerizer

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/#review56293 --- This review motivated me to do the refactoring we had discussed in

[GitHub] mesos pull request: Added option to enable privileged mode for Doc...

2014-10-11 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/mesos/pull/26#issuecomment-58766111 Are you running the unit test as is? The best way is to enable verbose logging and run the test again. Btw can you post your patch on reviewboard? Let's move it there

Re: Review Request 26618: Removed unnecessary parameter.

2014-10-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26618/#review56305 --- Bad patch! Reviews applied: [26611, 26612, 26613, 26614, 26615,

Re: Review Request 26614: More simplifications of Docker container launching.

2014-10-11 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26614/#review56306 --- src/slave/containerizer/docker.cpp

Re: Review Request 26610: Consolidated launch code paths in Docker containerizer.

2014-10-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26610/#review56308 --- Bad patch! Reviews applied: [26610] Failed command:

Re: Review Request 26615: Even more simplification of launch paths in Docker containerizer.

2014-10-11 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26615/#review56309 --- Ship it! Ship It! - Timothy Chen On Oct. 11, 2014, 10:11 p.m.,

Re: Review Request 26616: Minor cleanup when creating Docker containers.

2014-10-11 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26616/#review56310 --- Ship it! Ship It! - Timothy Chen On Oct. 11, 2014, 10:11 p.m.,

Re: Review Request 26617: And more refactoring in the Docker containerizer to simplify.

2014-10-11 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26617/#review56312 --- Ship it! Ship It! - Timothy Chen On Oct. 11, 2014, 10:11 p.m.,

Re: Review Request 26617: And more refactoring in the Docker containerizer to simplify.

2014-10-11 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26617/#review56311 --- src/slave/containerizer/docker.cpp

Review Request 26620: Removed redundant environment for Docker containers.

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26620/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description

Review Request 26621: Replaced all tabs with spaces.

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26621/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description

Re: Review Request 26614: More simplifications of Docker container launching.

2014-10-11 Thread Benjamin Hindman
On Oct. 11, 2014, 10:33 p.m., Timothy Chen wrote: Okay, I updated this in a new review: https://reviews.apache.org/r/26620 - Benjamin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 26436: Avoid docker inspect on each usage call

2014-10-11 Thread Benjamin Hindman
On Oct. 11, 2014, 10:14 p.m., Benjamin Hindman wrote: Why not do it the same way that 'update' does it? Timothy Chen wrote: It's pretty much the same, except I named the last method containerUsage instead of __usage, based on Mpark's comment since it's not a true deferred

Review Request 26622: Don't pass task-related arguments to mesos-executor.

2014-10-11 Thread R.B. Boyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26622/ --- Review request for mesos. Bugs: MESOS-1873

Re: Review Request 26621: Replaced all tabs with spaces.

2014-10-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26621/#review56319 --- Patch looks great! Reviews applied: [26611, 26612, 26613, 26614,

Re: Review Request 24341: Added Java replicated log implementation of State.

2014-10-11 Thread Benjamin Hindman
On Sept. 29, 2014, 7:27 p.m., Jie Yu wrote: src/java/jni/org_apache_mesos_state_LogState.cpp, line 25 https://reviews.apache.org/r/24341/diff/2/?file=708149#file708149line25 This signature doesn't seem to be correct. I copied it directly from the .h file. ;-) - Benjamin

Re: Review Request 26620: Removed redundant environment for Docker containers.

2014-10-11 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26620/#review56324 --- Ship it! Ship It! - Timothy Chen On Oct. 12, 2014, 2:16 a.m.,

Re: Review Request 26621: Replaced all tabs with spaces.

2014-10-11 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26621/#review56326 --- Ship it! Ship It! - Timothy Chen On Oct. 12, 2014, 2:17 a.m.,

Re: Review Request 24341: Added Java replicated log implementation of State.

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24341/ --- (Updated Oct. 12, 2014, 4:14 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 24535: Added functionality to create SVN based diffs of arbitrary strings.

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24535/ --- (Updated Oct. 12, 2014, 4:14 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 24535: Added functionality to create SVN based diffs of arbitrary strings.

2014-10-11 Thread Benjamin Hindman
On Oct. 2, 2014, 11:13 p.m., Ben Mahler wrote: Very cool! Thanks for such a thorough review Ben! Very appreciated. On Oct. 2, 2014, 11:13 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/Makefile.am, lines 188-189

Re: Review Request 24536: Added DIFF to the replicated log state storage implementation.

2014-10-11 Thread Benjamin Hindman
On Oct. 1, 2014, 5:45 p.m., Jie Yu wrote: src/state/log.cpp, lines 363-367 https://reviews.apache.org/r/24536/diff/3/?file=708156#file708156line363 Could you please add a comment about why you wanna skip snapshots with diffs (it's not obvious to me)? Also, could you

Re: Review Request 26619: Use the right resources when starting Docker container.

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26619/ --- (Updated Oct. 12, 2014, 5:31 a.m.) Review request for mesos and Timothy Chen.