---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26487/#review56292
---
Ship it!
src/docker/docker.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26605/
---
Review request for mesos and Jie Yu.
Bugs: MESOS-1872
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26605/
---
(Updated Oct. 11, 2014, 6:24 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26605/
---
(Updated Oct. 11, 2014, 6:23 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26605/
---
(Updated Oct. 11, 2014, 6:31 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26605/#review56294
---
Patch looks great!
Reviews applied: [26605]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26612/
---
Review request for mesos and Timothy Chen.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26613/
---
Review request for mesos and Timothy Chen.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26614/
---
Review request for mesos and Timothy Chen.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26610/
---
Review request for mesos and Timothy Chen.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26436/#review56301
---
Why not do it the same way that 'update' does it?
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26517/#review56293
---
This review motivated me to do the refactoring we had discussed in
Github user tnachen commented on the pull request:
https://github.com/apache/mesos/pull/26#issuecomment-58766111
Are you running the unit test as is? The best way is to enable verbose
logging and run the test again.
Btw can you post your patch on reviewboard? Let's move it there
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26618/#review56305
---
Bad patch!
Reviews applied: [26611, 26612, 26613, 26614, 26615,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26614/#review56306
---
src/slave/containerizer/docker.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26610/#review56308
---
Bad patch!
Reviews applied: [26610]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26615/#review56309
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 11, 2014, 10:11 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26616/#review56310
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 11, 2014, 10:11 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26617/#review56312
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 11, 2014, 10:11 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26617/#review56311
---
src/slave/containerizer/docker.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26620/
---
Review request for mesos and Timothy Chen.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26621/
---
Review request for mesos and Timothy Chen.
Repository: mesos-git
Description
On Oct. 11, 2014, 10:33 p.m., Timothy Chen wrote:
Okay, I updated this in a new review: https://reviews.apache.org/r/26620
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
On Oct. 11, 2014, 10:14 p.m., Benjamin Hindman wrote:
Why not do it the same way that 'update' does it?
Timothy Chen wrote:
It's pretty much the same, except I named the last method containerUsage
instead of __usage, based on Mpark's comment since it's not a true deferred
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26622/
---
Review request for mesos.
Bugs: MESOS-1873
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26621/#review56319
---
Patch looks great!
Reviews applied: [26611, 26612, 26613, 26614,
On Sept. 29, 2014, 7:27 p.m., Jie Yu wrote:
src/java/jni/org_apache_mesos_state_LogState.cpp, line 25
https://reviews.apache.org/r/24341/diff/2/?file=708149#file708149line25
This signature doesn't seem to be correct.
I copied it directly from the .h file. ;-)
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26620/#review56324
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 12, 2014, 2:16 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26621/#review56326
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 12, 2014, 2:17 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24341/
---
(Updated Oct. 12, 2014, 4:14 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24535/
---
(Updated Oct. 12, 2014, 4:14 a.m.)
Review request for mesos, Ben Mahler and
On Oct. 2, 2014, 11:13 p.m., Ben Mahler wrote:
Very cool!
Thanks for such a thorough review Ben! Very appreciated.
On Oct. 2, 2014, 11:13 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/Makefile.am, lines 188-189
On Oct. 1, 2014, 5:45 p.m., Jie Yu wrote:
src/state/log.cpp, lines 363-367
https://reviews.apache.org/r/24536/diff/3/?file=708156#file708156line363
Could you please add a comment about why you wanna skip snapshots with
diffs (it's not obvious to me)?
Also, could you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26619/
---
(Updated Oct. 12, 2014, 5:31 a.m.)
Review request for mesos and Timothy Chen.
34 matches
Mail list logo