Re: Review Request 27493: Added CRAM-MD5 Test Authenticatee Module.

On Nov. 11, 2014, 7:49 p.m., Vinod Kone wrote: src/authentication/cram_md5/authenticatee.hpp, line 390 https://reviews.apache.org/r/27493/diff/5/?file=756742#file756742line390 why the factory method? AFAIK typed tests need a factory to function. We introduced such factory to the

Re: Review Request 27675: Updated upgrades.md and CHANGELOG to reflect changes on AuthenticationStartMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27675/ --- (Updated Nov. 12, 2014, 10:35 a.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 27675: Updated upgrades.md and CHANGELOG to reflect changes on AuthenticationStartMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27675/#review60977 --- Patch looks great! Reviews applied: [27675] All tests passed. -

Re: Review Request 27865: Made libprocess generate valid http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27865/ --- (Updated Nov. 12, 2014, 1:09 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 27865: Made libprocess generate valid http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27865/#review60983 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 12, 2014, 1:09

Re: Review Request 27865: Made libprocess generate valid http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27865/ --- (Updated Nov. 12, 2014, 1:53 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 27865: Made libprocess generate valid http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27865/#review60984 --- Patch looks great! Reviews applied: [27865] All tests passed. -

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/ --- (Updated Nov. 12, 2014, 2:47 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 27494: Integrated CRAM-MD5 Test Authenticatee module into slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27494/ --- (Updated Nov. 12, 2014, 2:48 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 27493: Added CRAM-MD5 Test Authenticatee Module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27493/ --- (Updated Nov. 12, 2014, 3:06 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 27493: Added CRAM-MD5 Test Authenticatee Module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27493/ --- (Updated Nov. 12, 2014, 3:53 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 27806: Added module loading to scheduler driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27806/ --- (Updated Nov. 12, 2014, 4:13 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 27812: Integrated authenticatee module in scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27812/ --- (Updated Nov. 12, 2014, 4:33 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 27812: Integrated authenticatee module in scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27812/ --- (Updated Nov. 12, 2014, 4:36 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 27812: Integrated CRAM-MD5 Test Authenticatee module into scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27812/ --- (Updated Nov. 12, 2014, 4:38 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 27812: Integrated CRAM-MD5 Test Authenticatee module into scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27812/ --- (Updated Nov. 12, 2014, 5:06 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 27812: Integrated CRAM-MD5 Test Authenticatee module into scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27812/#review61002 --- Bad patch! Reviews applied: [27493, 27494, 27806, 27493] Failed

Re: Review Request 27896: Fixed scheduler driver to not acknowledge status update when stop() is called.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27896/#review61003 --- src/sched/sched.cpp

Re: Review Request 27812: Integrated CRAM-MD5 Test Authenticatee module into scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27812/ --- (Updated Nov. 12, 2014, 5:40 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 27806: Added module loading to scheduler driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27806/ --- (Updated Nov. 12, 2014, 5:41 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 27806: Added module loading to scheduler driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27806/ --- (Updated Nov. 12, 2014, 5:41 p.m.) Review request for mesos, Adam B, Kapil

Re: Review Request 27496: Replaced Timer::create/cancel with Clock::timer/cancel.

On Nov. 12, 2014, 1:04 a.m., Ben Mahler wrote: 3rdparty/libprocess/include/process/timer.hpp, line 53 https://reviews.apache.org/r/27496/diff/1/?file=747095#file747095line53 Looks like you need an include for clock.hpp..? Does this compile if Clock is not transitively included?

Re: Review Request 27865: Made libprocess generate valid http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27865/#review61005 --- 3rdparty/libprocess/src/encoder.hpp

Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/ --- (Updated Nov. 12, 2014, 10:06 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/#review61011 --- Ship it! Ship It! - Vinod Kone On Nov. 12, 2014, 6:06 p.m.,

Re: Review Request 27502: Introduced a libev async watcher specifically for updating timers.

On Nov. 11, 2014, 11:17 p.m., Niklas Nielsen wrote: Can you expand a little bit on why you needed a new async watcher? Maybe add it to the review request description :-) The point of this new async watcher is to start to separate out the 3 concepts that currently use the same event loop:

Re: Review Request 27812: Integrated CRAM-MD5 Test Authenticatee module into scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27812/#review61015 --- Patch looks great! Reviews applied: [27493, 27494, 27495, 27806,

Re: Review Request 24222: Update boost-1.53.0.tar.gz to include boost::atomic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24222/#review61016 --- Craig - are you planning on getting this in? In that case, we need

Re: Review Request 24222: Update boost-1.53.0.tar.gz to include boost::atomic

On Nov. 12, 2014, 10:32 a.m., Niklas Nielsen wrote: Craig - are you planning on getting this in? In that case, we need a shepherd to follow it through. we should probably focus on just std::atomic if we can. I believe g++-4.4 supports it but a configure check would clarify. - Dominic

Re: Review Request 23913: Add C++11 (and boost) atomic support to stout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23913/#review61017 --- (Same here) Are you planning on getting this in? In that case, we

Re: Review Request 27023: Libprocess Socket std::shared_ptr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27023/#review61019 --- 3rdparty/libprocess/include/process/socket.hpp

Re: Review Request 27054: Libprocess Socket: introduce connect()

On Oct. 29, 2014, 4:57 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [27350, 27351, 27350] Failed command: ./support/apply-review.sh -n -r 27350 Error: 2014-10-29 23:57:20 URL:https://reviews.apache.org/r/27350/diff/raw/ [897/897] - 27350.patch [1] error:

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/ --- (Updated Nov. 12, 2014, 7 p.m.) Review request for mesos, Benjamin Hindman and

Re: Review Request 27350: Libprocess: Introduce mutex configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27350/ --- (Updated Nov. 12, 2014, 7:03 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27509: Used io::poll instead of libev for receiving_connect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/#review61026 --- LGTM module question below 3rdparty/libprocess/src/process.cpp

Re: Review Request 27510: Used io::poll instead of libev for sending_connect, send_data, send_file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27510/#review61028 --- LGTM modulo question below 3rdparty/libprocess/src/encoder.hpp

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/ --- (Updated Nov. 12, 2014, 7:18 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27508: Used io::poll instead of libev for ignore_data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27508/#review60671 --- 3rdparty/libprocess/src/process.cpp

Re: Review Request 27354: Introduce mutex configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27354/ --- (Updated Nov. 12, 2014, 7:23 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27350: Libprocess: Introduce mutex configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27350/#review61034 --- Ship it! Ship It! - Niklas Nielsen On Nov. 12, 2014, 11:03

Re: Review Request 27356: Introduce enable_shared_from_this configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- (Updated Nov. 12, 2014, 7:27 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27356: Introduce enable_shared_from_this configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/#review61040 --- Ship it! you need me to commit, right? - Dominic Hamon On Nov.

Re: Review Request 27508: Used io::poll instead of libev for ignore_data.

On Nov. 12, 2014, 7:22 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/src/process.cpp, lines 1621-1624 https://reviews.apache.org/r/27508/diff/1/?file=747126#file747126line1621 This was called before regardless if connect succeeded or failed - this changed here, do you know why?

Re: Review Request 27354: Introduce mutex configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27354/#review61039 --- Ship it! you need me to commit, right? - Dominic Hamon On Nov.

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

On Nov. 10, 2014, 11:29 a.m., Niklas Nielsen wrote: 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4, line 84 https://reviews.apache.org/r/27351/diff/2/?file=742017#file742017line84 This tests that is compiles but not whether it works as expected wrt ownership. Maybe that's ok?

Re: Review Request 27354: Introduce mutex configure check

On Nov. 12, 2014, 7:34 p.m., Dominic Hamon wrote: you need me to commit, right? Indeed :-) - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27354/#review61039

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

On Nov. 11, 2014, 6:14 a.m., Adam B wrote: src/tests/module.cpp, line 81 https://reviews.apache.org/r/27619/diff/3/?file=755845#file755845line81 Fix the comment Argh, these rebases are making me go bannanas :) that one slipped in once again - sorry for that. - Till

Review Request 27920: Libprocess: Introduce make_shared configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27920/ --- Review request for mesos, Dominic Hamon and Niklas Nielsen. Bugs: MESOS-2094

Review Request 27921: Introduce make_shared configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27921/ --- Review request for mesos, Dominic Hamon and Niklas Nielsen. Bugs: MESOS-2095

Re: Review Request 27920: Libprocess: Introduce make_shared configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27920/#review61051 --- Ship it! Ship It! - Dominic Hamon On Nov. 12, 2014, 11:54 a.m.,

Re: Review Request 27921: Introduce make_shared configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27921/#review61052 --- Ship it! Ship It! - Dominic Hamon On Nov. 12, 2014, 11:59 a.m.,

Re: Review Request 27356: Introduce enable_shared_from_this configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/#review61057 --- Patch looks great! Reviews applied: [27354, 27356] All tests

Review Request 27925: Replaced pthread_mutex, 'synchronizer', and 'synchronizable'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27925/ --- Review request for mesos, Dominic Hamon and Joris Van Remoortere. Repository:

Re: Review Request 27350: Libprocess: Introduce mutex configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27350/#review61060 --- Ship it! FYI, let's replace all of 'synchornizable' and

Re: Review Request 27351: Libprocess: Introduce enable_shared_from_this configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27351/#review61061 --- Ship it! It would be great to document in the Mesos style guide

Re: Review Request 27507: Used io::poll instead of libev for recv_data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27507/#review61063 --- Ship it! Ship It! - Niklas Nielsen On Nov. 11, 2014, 8:53 a.m.,

Re: Review Request 27925: Replaced pthread_mutex, 'synchronizer', and 'synchronizable'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27925/#review61064 --- 3rdparty/libprocess/src/process.cpp

Review Request 27924: Transfer task resources to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27924/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1718

Review Request 27923: Use Slave::getExecutorInfo() only once.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27923/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1718

Re: Review Request 27924: Transfer task resources to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27924/#review61066 --- src/slave/slave.hpp

Re: Review Request 27920: Libprocess: Introduce make_shared configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27920/#review61068 --- Patch looks great! Reviews applied: [27350, 27920] All tests

Re: Review Request 27924: Transfer task resources to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27924/ --- (Updated Nov. 12, 2014, 1:05 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 27350: Libprocess: Introduce mutex configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27350/ --- (Updated Nov. 12, 2014, 9:06 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 27924: Transfer task resources to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27924/ --- (Updated Nov. 12, 2014, 1:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 27924: Transfer task resources to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27924/#review61069 --- src/slave/slave.cpp

Re: Review Request 27350: Libprocess: Introduce mutex configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27350/#review61071 --- 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4

Re: Review Request 27924: Transfer task resources to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27924/ --- (Updated Nov. 12, 2014, 1:21 p.m.) Review request for mesos and Ben Mahler.

Review Request 27930: Add TASK_ERROR to CHANGELOG for 0.22.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27930/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description

Re: Review Request 27930: Add TASK_ERROR to CHANGELOG for 0.22.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27930/#review61086 --- Ship it! CHANGELOG

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/ --- (Updated Nov. 12, 2014, 10:09 p.m.) Review request for mesos, Adam B, Kapil

Re: [1/2] mesos git commit: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

I'm getting a new warning with this on OS X w/ clang 3.5 which looks like it probably should be addressed (Add parens to call the node function): ../../../mesos_public/3rdparty/libprocess/src/process.cpp:1662:49: warning: address of function 'process::node' will always evaluate to 'true'

Re: Review Request 27930: Add TASK_ERROR to CHANGELOG for 0.22.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27930/ --- (Updated Nov. 12, 2014, 2:12 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 27651: Updated CRAMMD5Authentication tests to additionally run against the test authenticatee module.

On Nov. 11, 2014, 8:52 p.m., Vinod Kone wrote: src/tests/cram_md5_authentication_tests.cpp, line 247 https://reviews.apache.org/r/27651/diff/5/?file=756784#file756784line247 bad rebase? Yikes, indeed - entirely borked. Sorry for that. - Till

Re: [1/2] mesos git commit: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

thanks for the head's up - it didn't show up in my linux clang build. testing a fix now. On Wed, Nov 12, 2014 at 2:12 PM, Cody Maloney c...@mesosphere.io wrote: I'm getting a new warning with this on OS X w/ clang 3.5 which looks like it probably should be addressed (Add parens to call the

Review Request 27932: Fix OSX build error by calling function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27932/ --- Review request for mesos, Ben Mahler and Cody Maloney. Repository: mesos-git

Re: [1/2] mesos git commit: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

https://reviews.apache.org/r/27932/ On Wed, Nov 12, 2014 at 2:15 PM, Dominic Hamon dha...@twopensource.com wrote: thanks for the head's up - it didn't show up in my linux clang build. testing a fix now. On Wed, Nov 12, 2014 at 2:12 PM, Cody Maloney c...@mesosphere.io wrote: I'm getting a

Re: Review Request 27921: Introduce make_shared configure check

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27921/#review61093 --- Patch looks great! Reviews applied: [27354, 27921] All tests

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2556

22:23:28.150763 12175 slave.cpp:775] Registered with master master@67.195.81.189:52345; given slave ID 20141112-222327-3176252227-52345-12128-S0 I1112 22:23:28.150784 12174 hierarchical_allocator_process.hpp:442] Added slave 20141112-222327-3176252227-52345-12128-S0 (proserpina.apache.org

Re: Review Request 27651: Updated CRAMMD5Authentication tests to additionally run against the test authenticatee module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27651/ --- (Updated Nov. 12, 2014, 10:31 p.m.) Review request for mesos, Adam B and Vinod

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

On Nov. 10, 2014, 10:44 a.m., Adam B wrote: src/authentication/authenticator.hpp, line 49 https://reviews.apache.org/r/27760/diff/4/?file=755828#file755828line49 So, if I want to update credentials, I have to kill my Master (hence Authenticator) and create+initialize a new one?

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

On Nov. 11, 2014, 8:06 a.m., Adam B wrote: src/master/master.hpp, lines 583-584 https://reviews.apache.org/r/27760/diff/4/?file=755830#file755830line583 This hashmap isn't really necessary yet, since we only allow a single authenticator, right? If/when we do support multiple

Re: Review Request 27675: Updated upgrades.md and CHANGELOG to reflect changes on AuthenticationStartMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27675/#review61110 --- Ship it! Ship It! - Adam B On Nov. 12, 2014, 2:35 a.m., Till

Re: Graceful Shutdown Design

I thought signal escalation as per-executor or actually everywhere where we execute a command info as a subprocess. The new grace period is meant as the time an executor has to finish off it's things - changing the other timeouts had to be done as they will in most cases be shorter. For custom

Re: Review Request 27925: Replaced pthread_mutex, 'synchronizer', and 'synchronizable'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27925/#review61115 --- Patch looks great! Reviews applied: [27925] All tests passed. -

Re: Review Request 27506: Moved process::io::* into io.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27506/#review61127 --- Ship it! Taken this is only a code move - Niklas Nielsen On

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2557

See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2557/changes

Re: Review Request 27896: Fixed scheduler driver to not acknowledge status update when stop() is called.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27896/ --- (Updated Nov. 12, 2014, 11:55 p.m.) Review request for mesos, Benjamin

Re: Review Request 27896: Fixed scheduler driver to not acknowledge status update when stop() is called.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27896/#review61135 --- Ship it! src/sched/sched.cpp

Re: Review Request 27932: Fix OSX build error by calling function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27932/#review61147 --- Ship it! Mind including a clearer summary / commit message? Looks

Re: Review Request 27932: Fix OSX build error by calling function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27932/#review61149 --- Ship it! Fixes the clang warning (Clang probably would make the

Review Request 27945: Add c++11 initializer_list check to configure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27945/ --- Review request for mesos, Ben Mahler and Dominic Hamon. Repository: mesos-git

Re: [VOTE] Release Apache Mesos 0.21.0 (rc2)

Here is another cherry pick for rc3. commit 99dc04868da8e30ad7d4e733ba5e3573602ce9e9 Author: Vinod Kone vinodk...@gmail.com Date: Tue Nov 11 17:03:37 2014 -0800 Fixed scheduler driver to not acknowledge status update when stop() is called. Review:

Re: [1/2] mesos git commit: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

Landed. Sorry for the noise. On Wed, Nov 12, 2014 at 2:17 PM, Dominic Hamon dha...@twopensource.com wrote: https://reviews.apache.org/r/27932/ On Wed, Nov 12, 2014 at 2:15 PM, Dominic Hamon dha...@twopensource.com wrote: thanks for the head's up - it didn't show up in my linux clang build.

Re: Review Request 27945: Add c++11 initializer_list check to configure

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27945/#review61152 --- m4/ax_cxx_compile_stdcxx_11.m4

Re: Review Request 27605: Add a unit test to stout path

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27605/ --- (Updated Nov. 13, 2014, 12:39 a.m.) Review request for mesos and Ben Mahler.

Review Request 27946: Add new stout/path test to libprocess Makefile

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27946/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description

Re: Review Request 27605: Add a unit test to stout path

On Nov. 10, 2014, 7:50 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, lines 27-29 https://reviews.apache.org/r/27605/diff/1/?file=750087#file750087line27 What's the distinction between these three tests? Seems more like a test of implicit string

Re: Review Request 27945: Add c++11 initializer_list check to configure

On Nov. 13, 2014, 12:38 a.m., Dominic Hamon wrote: m4/ax_cxx_compile_stdcxx_11.m4, line 111 https://reviews.apache.org/r/27945/diff/1/?file=760765#file760765line111 do you also want to check that std::initializer_list can be used as a type in a constructor for a user-defined

Re: Review Request 27932: Fix OSX build error by calling function

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27932/#review61157 --- Patch looks great! Reviews applied: [27932] All tests passed. -

Re: Review Request 27619: Updated CRAMMD5Authentication tests to additionally run against the test authenticator module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27619/#review61161 --- Ship it! LGTM. I can fix the spacing before committing.

  1   2   >