Re: Add hostname or agentid in rescind offers callback

2018-05-02 Thread Varun Gupta
Implementation is only needed for V1 API. On Wed, May 2, 2018 at 7:31 PM Varun Gupta wrote: > We aggregate all the offers for a host, such that placement engine can > pack multiple tasks that can be launched on this host using aggregated > resources. If offers are unused for

Re: Add hostname or agentid in rescind offers callback

2018-05-02 Thread Varun Gupta
We aggregate all the offers for a host, such that placement engine can pack multiple tasks that can be launched on this host using aggregated resources. If offers are unused for that host then they will be implicitly declined. Placement cycle has two components - determine tasks that can be

Re: Add hostname or agentid in rescind offers callback

2018-05-02 Thread Benjamin Mahler
I'm a -1 on adding redundant information in the message. The scheduler can maintain an index of offers by offer id to address this issue: hostname -> offers offer_id -> offer On Wed, May 2, 2018 at 11:39 AM, Vinod Kone wrote: > Can I ask why you are indexing the offers

Re: Add hostname or agentid in rescind offers callback

2018-05-02 Thread Vinod Kone
Can I ask why you are indexing the offers by hostname? Is it to better handle agent removal / unreachable signal? Looking at the code , I think master has the requested information (agent id, hostname) so we can include it

Add hostname or agentid in rescind offers callback

2018-05-02 Thread Varun Gupta
Hi, Currently in our implementation we maintain two maps. Hostname -> []Offers offerID -> Hostname Second map is needed because rescind offers callback only provides offerid and we need hostname to do performant lookup in first map. Is it feasible to add hostname or agentid in rescind offers?

[GitHub] mesos pull request #287: Add fiu to the list of contributor

2018-05-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/mesos/pull/287 ---