Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-04-22 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33109: Allow setting environment variables in mesos-execute

2015-04-22 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 22, 2015, 5:38 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-04-22 Thread Mesos ReviewBot
: ./support/apply-review.sh -n -r 29328 Error: 2015-04-22 17:37:07 URL:https://reviews.apache.org/r/29328/diff/raw/ [2149/2149] -> "29328.patch" [1] error: patch failed: src/slave/flags.hpp:311 error: src/slave/flags.hpp: patch does not apply Failed to apply patch - Mesos ReviewBot On A

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-04-22 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On April 22, 2015, 2:36 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

2015-04-22 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 22, 2015, 9:09 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-04-22 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On April 22, 2015, 6:21 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-04-21 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 21, 2015, 10:09 p.m., Ricardo Cervera-Navarro wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33415: Changed launchers and isolators to adapt to the new orphan cleanup semantics.

2015-04-21 Thread Mesos ReviewBot
atch does not apply Failed to apply patch - Mesos ReviewBot On April 21, 2015, 9:48 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://r

Re: Review Request 33412: Made the launcher recover interface to return a set of orphan containers.

2015-04-21 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 21, 2015, 9:43 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

2015-04-21 Thread Mesos ReviewBot
, 32948, 31017, 33372] All tests passed. - Mesos ReviewBot On April 21, 2015, 8:13 p.m., Niklas Nielsen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

2015-04-21 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 21, 2015, 7:06 p.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33090: Removed unmaintained frameworks code.

2015-04-21 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 21, 2015, 5:09 p.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-04-21 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 21, 2015, 5:14 p.m., Jay Buffington wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2015-04-21 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 21, 2015, 5 p.m., Jim Klucar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

2015-04-21 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 21, 2015, 12:38 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-04-21 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On April 21, 2015, 12:07 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-04-21 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On April 21, 2015, 12:02 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-04-20 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 20, 2015, 10:43 p.m., Jay Buffington wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

2015-04-20 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 20, 2015, 10:38 p.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33257: Fixed recover tasks only by the intiated containerizer.

2015-04-20 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 20, 2015, 9:18 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33372: Added decorator documentation and described the semantic change in Mesos 0.23.0

2015-04-20 Thread Mesos ReviewBot
, 32948, 31017, 33372] All tests passed. - Mesos ReviewBot On April 20, 2015, 9:27 p.m., Niklas Nielsen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32509: Documented the scheduler Event/Call protobufs.

2015-04-20 Thread Mesos ReviewBot
, 32505, 32843, 32506, 32844, 32845, 32509] All tests passed. - Mesos ReviewBot On April 20, 2015, 8:05 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33329: Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error.

2015-04-20 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 20, 2015, 7:16 p.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-04-20 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On April 20, 2015, 4:27 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 31268: Wired up test allocator to allocator tests.

2015-04-20 Thread Mesos ReviewBot
, 31267, 31262, 31263, 31265, 31268] All tests passed. - Mesos ReviewBot On April 20, 2015, 1:51 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-04-20 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 20, 2015, 11:58 a.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32693: Change Http Request log level to VLOG(1)

2015-04-20 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 20, 2015, 7 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33331: Added file headers section to the C++ style guide.

2015-04-17 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On April 18, 2015, 1:34 a.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33330: Fixed C++ style guide formatting.

2015-04-17 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 18, 2015, 1:32 a.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33329: Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error.

2015-04-17 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 18, 2015, 12:35 a.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33257: Fixed recover tasks only by the intiated containerizer.

2015-04-17 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 17, 2015, 7:07 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33318: Fix docker containerizer usage and test.

2015-04-17 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 17, 2015, 6:21 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 27113: Libprocess benchmark cleanup

2015-04-17 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On April 17, 2015, 5:28 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 31667: Piped hashmap from allocator through to sorter.

2015-04-17 Thread Mesos ReviewBot
, 31667] All tests passed. - Mesos ReviewBot On April 17, 2015, 4:57 a.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33266: Check patch command in configure.ac

2015-04-16 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 16, 2015, 5:30 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33263: Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check.

2015-04-16 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 16, 2015, 2:31 p.m., Andrey Dyatlov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-04-15 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 16, 2015, 12:32 a.m., Jay Buffington wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-04-15 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 15, 2015, 9:49 p.m., Ricardo Cervera-Navarro wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-04-15 Thread Mesos ReviewBot
etrics. docs: Add documentation on observability metrics. Review: https://reviews.apache.org/r/33241 docs/metrics.md:1043: new blank line at EOF. Failed to commit patch - Mesos ReviewBot On April 15, 2015, 8:47 p.m., Ricardo Cervera-

Re: Review Request 31268: Wired up test allocator to allocator tests.

2015-04-15 Thread Mesos ReviewBot
/apply-review.sh -n -r 31775 Error: 2015-04-15 14:40:31 URL:https://reviews.apache.org/r/31775/diff/raw/ [5716/5716] -> "31775.patch" [1] error: patch failed: src/master/allocator/allocator.hpp:24 error: src/master/allocator/allocator.hpp: patch does not apply Failed to apply patch - Me

Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-04-14 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 15, 2015, 2:50 a.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2015-04-14 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 14, 2015, 8:32 p.m., Steve Niemitz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 27113: Libprocess benchmark cleanup

2015-04-14 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On April 14, 2015, 7:46 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2015-04-14 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 14, 2015, 4:44 p.m., Steve Niemitz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-04-13 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On April 14, 2015, 2:57 a.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33155: Added commented-out tests for slave removal metrics.

2015-04-13 Thread Mesos ReviewBot
] All tests passed. - Mesos ReviewBot On April 14, 2015, 1:46 a.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32749: Add -Wno-unused-local-typedef for clang 3.6

2015-04-13 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On April 13, 2015, 9:01 p.m., Cody Maloney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2015-04-13 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 13, 2015, 4:55 p.m., Jim Klucar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-04-12 Thread Mesos ReviewBot
: ./support/apply-review.sh -n -r 29328 Error: 2015-04-13 06:44:31 URL:https://reviews.apache.org/r/29328/diff/raw/ [2149/2149] -> "29328.patch" [1] error: patch failed: src/slave/flags.hpp:311 error: src/slave/flags.hpp: patch does not apply Failed to apply patch - Mesos ReviewBot On A

Re: Review Request 33111: Should install apr-util-devel in CentOS 6.5

2015-04-12 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 12, 2015, 9:33 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33109: Allow setting environment variables in mesos-execute

2015-04-12 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 12, 2015, 9:04 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33045: Added Jenkins build script to build Mesos inside Docker container.

2015-04-10 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 11, 2015, 12:20 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33040: Expose qdisc statistics from libnl

2015-04-10 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 10, 2015, 11:17 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33045: Added Jenkins build script to build Mesos inside Docker container.

2015-04-10 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 10, 2015, 9:31 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 33040: Expose qdisc statistics from libnl

2015-04-10 Thread Mesos ReviewBot
ly error: src/linux/routing/queueing/statistics.hpp: does not exist in index error: src/linux/routing/queueing/statistics.cpp: does not exist in index error: patch failed: src/tests/routing_tests.cpp:16 error: src/tests/routing_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot

Re: Review Request 32967: Cleaned upstyle and comments in modules.

2015-04-09 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 9, 2015, 6:40 p.m., Aditi Dixit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32558: Improve compile time of mesos by splitting flags

2015-04-09 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 9, 2015, 6:27 p.m., Cody Maloney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2015-04-09 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 9, 2015, 4:40 p.m., Jim Klucar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32999: Added a document for engineering principles and practices.

2015-04-08 Thread Mesos ReviewBot
, 32999] All tests passed. - Mesos ReviewBot On April 9, 2015, 12:30 a.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 30952: Adding scheduler validations to master

2015-04-08 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 8, 2015, 9:11 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32982: Added reservation user guide.

2015-04-08 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 8, 2015, 6:41 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32398: Persist the reservation state on the slave.

2015-04-08 Thread Mesos ReviewBot
apply Failed to apply patch - Mesos ReviewBot On April 8, 2015, 6:38 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://r

Re: Review Request 32984: Added an example framework for testing persistent volumes.

2015-04-08 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On April 8, 2015, 7:08 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-04-08 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On April 8, 2015, 3:24 p.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32975: MESOS-1790 Adds chown option to CommandInfo.URI

2015-04-08 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 8, 2015, 2:20 p.m., Jim Klucar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32967: [MESOS-2565] Cleaned upstyle and comments in modules

2015-04-08 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 8, 2015, 1:25 p.m., Aditi Dixit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32956: Simplified MemUsage test.

2015-04-07 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 8, 2015, 2:30 a.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32954: Added a 'slave_shutdowns_completed' metric.

2015-04-07 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 8, 2015, 2:29 a.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32955: Simplified ROOT_CGROUPS_Listen test.

2015-04-07 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 8, 2015, 2:29 a.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32939: Bumped the log level for dropped messages.

2015-04-07 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 7, 2015, 9:48 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32911: Fixed sandbox ownership bug for executors without URIs.

2015-04-07 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 7, 2015, 6:10 p.m., Niklas Nielsen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32700: Removed FrameworkID from FrameworkState.

2015-04-07 Thread Mesos ReviewBot
, 32587, 32700] All tests passed. - Mesos ReviewBot On April 7, 2015, 5 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 31268: Wired up test allocator to allocator tests.

2015-04-07 Thread Mesos ReviewBot
, 31262, 31263, 31265, 31268] All tests passed. - Mesos ReviewBot On April 7, 2015, 12:49 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32911: Fixed sandbox ownership bug for executors without URIs.

2015-04-06 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 7, 2015, 12:40 a.m., Niklas Nielsen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32906: Add safety check for staged but uncommitted changes

2015-04-06 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 6, 2015, 11:03 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32903: Eliminate the use of 'echo -n' in EC2 scripts

2015-04-06 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 6, 2015, 10:09 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32898: Eliminate use of 'echo -n'

2015-04-06 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 6, 2015, 10:05 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32898: Eliminate use of 'echo -n'

2015-04-06 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 6, 2015, 7:27 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32895: Environment variables are case sensitive

2015-04-06 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 6, 2015, 6:45 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-04-06 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On April 6, 2015, 6:02 p.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32859: Add Camel-case libprocess variable and method names sample.

2015-04-06 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 6, 2015, 4:36 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32859: Add Camel-case libprocess variable and method names sample.

2015-04-04 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 4, 2015, 7:48 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32850: Moved cram-md5 authenticatee process definition into implementation file.

2015-04-03 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 4, 2015, 3:22 a.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32509: Documented the scheduler Event/Call protobufs.

2015-04-03 Thread Mesos ReviewBot
, 32505, 32843, 32506, 32844, 32845, 32509] All tests passed. - Mesos ReviewBot On April 3, 2015, 11:55 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32845: Renamed UNREGISTER call to UNSUBSCRIBE.

2015-04-03 Thread Mesos ReviewBot
, 32505, 32843, 32506, 32844, 32845] All tests passed. - Mesos ReviewBot On April 3, 2015, 11:50 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32832: Added CHANGELOG for 0.22.1

2015-04-03 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 3, 2015, 10:58 p.m., Niklas Nielsen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32834: Modifiy gdb scripts error message to check gdb is installed.

2015-04-03 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 3, 2015, 10:01 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32832: Added CHANGELOG for 0.22.1

2015-04-03 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 3, 2015, 8:43 p.m., Niklas Nielsen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract & stringify operation

2015-04-03 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 3, 2015, 7:19 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract & stringify operation

2015-04-03 Thread Mesos ReviewBot
/apply-review.sh -n -r 32654 Error: 2015-04-03 18:45:36 URL:https://reviews.apache.org/r/32654/diff/raw/ [1134/1134] -> "32654.patch" [1] error: patch failed: src/tests/port_mapping_tests.cpp:148 error: src/tests/port_mapping_tests.cpp: patch does not apply Failed to apply patch - Me

Re: Review Request 32805: Terminated the perf subprocess once the parent exits.

2015-04-03 Thread Mesos ReviewBot
passed. - Mesos ReviewBot On April 3, 2015, 5:11 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32805: Terminated the perf subprocess once the parent exits.

2015-04-02 Thread Mesos ReviewBot
/apply-review.sh -n -r 32805 Error: 2015-04-03 02:04:58 URL:https://reviews.apache.org/r/32805/diff/raw/ [2268/2268] -> "32805.patch" [1] error: patch failed: src/linux/perf.cpp:29 error: src/linux/perf.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On April 3, 2

Re: Review Request 32798: Add test to verify executor clean up in docker containerizer.

2015-04-02 Thread Mesos ReviewBot
tests passed. - Mesos ReviewBot On April 2, 2015, 11:38 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container

2015-04-02 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 2, 2015, 10:26 p.m., Alson Kemp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract & stringify operation

2015-04-02 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 2, 2015, 7:06 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32744: PortMapping: change to not host namespace symlink handles in /var/run/netns.

2015-04-02 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 2, 2015, 7:06 p.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container

2015-04-01 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 2, 2015, 12:05 a.m., Alson Kemp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32757: [5/5] Added a memory statistics test for writeback.

2015-04-01 Thread Mesos ReviewBot
, 32757] All tests passed. - Mesos ReviewBot On April 1, 2015, 11:18 p.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32654: Clean up HostIPNetwork since every use performs the same extract & stringify operation

2015-04-01 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 1, 2015, 11:07 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 32653: Replace busy loop on ready file with a more relaxed loop

2015-04-01 Thread Mesos ReviewBot
. - Mesos ReviewBot On April 1, 2015, 11 p.m., Paul Brett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

  1   2   3   4   5   6   7   8   9   10   >