Re: [Proposal] Updating levels for verbose logging

2017-10-09 Thread Benjamin Mahler
To elaborate on this, ideally libprocess logging is configurable by the user in a flexible manner that gives them control. For example, in LevelDB you can pass in the info 'Logger' that it will use for logging: https://github.com/google/leveldb/blob/v1.20/include/leveldb/options.h#L64-L68 I'm

Re: [Proposal] Updating levels for verbose logging

2017-10-09 Thread Alex Rukletsov
Ben, I understand why you question that libprocess should log starting from a specific level. I think it is not quite illogical for a library to use lower priority levels. I can see this change being helpful for any user of libprocess, not just Mesos. On Mon, Oct 9, 2017 at 6:34 PM, Benjamin

Re: [Proposal] Updating levels for verbose logging

2017-10-09 Thread Armand Grillet
Thanks for your input Benjamin. After having looked at per-module verbose level, here are the changes I would like to apply: 1. Changing the Mesos common events verbose logs so that they use VLOG(2) instead of 1. The original commit https://github.com/apache/meso

Re: [Proposal] Updating levels for verbose logging

2017-10-06 Thread Benjamin Mahler
It seems unfortunate to establish an ordering between different component's verbosity levels, how is libprocess to know which level to start at? I suppose you can tell it, but it's not clear that the first level of verbosity in libprocess should come after the max level of verbosity in mesos.

Re: [Proposal] Updating levels for verbose logging

2017-10-06 Thread Alex Rukletsov
I support the effort, Armand. On Wed, Oct 4, 2017 at 3:59 PM, Armand Grillet wrote: > Hi all, > > We currently use three levels of verbose logging via the VLOG macro. I > propose to add two levels and change how we use the current ones to make > debugging easier for

[Proposal] Updating levels for verbose logging

2017-10-04 Thread Armand Grillet
Hi all, We currently use three levels of verbose logging via the VLOG macro. I propose to add two levels and change how we use the current ones to make debugging easier for Mesos developers. The current situation is: - VLOG(1) is used for Mesos and libprocess events such as the admission