Re: Authorization Logging

2018-03-08 Thread Greg Mann
ches to try to clean up a little bit the code that calls > > authorization based on ideas from BenH https://reviews.apache.org/r/ > 65311/ > > . > > > > Reviews/comments always welcomed > > > > Alexander Rojas > > alexander.ro...@gmail.com > > >

Re: Authorization Logging

2018-03-07 Thread Benjamin Mahler
omed > > Alexander Rojas > alexander.ro...@gmail.com > > > > > On 28. Feb 2018, at 23:52, Benjamin Mahler wrote: > > When touching some code, I noticed that authorization logging is currently > done rather inconsistently across the call-sites and many cases do not

Re: Authorization Logging

2018-03-01 Thread Alexander Rojas
I noticed that authorization logging is currently > done rather inconsistently across the call-sites and many cases do not log > the request: > > $ grep -R -A 3 'LOG.*Authorizing' src > > Should authorization logging be the concern of an authorizer implementation? > For

Re: Authorization Logging

2018-02-28 Thread James Peach
> On Feb 28, 2018, at 2:52 PM, Benjamin Mahler wrote: > > When touching some code, I noticed that authorization logging is currently > done rather inconsistently across the call-sites and many cases do not log > the request: > > $ grep -R -A 3 'LOG.*Authorizing'

Authorization Logging

2018-02-28 Thread Benjamin Mahler
When touching some code, I noticed that authorization logging is currently done rather inconsistently across the call-sites and many cases do not log the request: $ grep -R -A 3 'LOG.*Authorizing' src Should authorization logging be the concern of an authorizer implementation? For audi