Re: Review Request 17567: Added External Containerizer.

> On April 28, 2014, 7:08 a.m., Benjamin Hindman wrote: > > I've made the minor style cleanups mentioned in this review so I'll be > > committing this now. Thank you so much Ben - especially for doing my work and fixing these remaining issues. > On April 28, 2014, 7:08 a.m., Benjamin Hindman

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review41569 --- Ship it! I've made the minor style cleanups mentioned in this revie

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review41564 --- Bad patch! Reviews applied: [17567] Failed command: git apply --in

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated April 26, 2014, 1:14 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17567: Added External Containerizer.

> On April 19, 2014, 9:33 p.m., Benjamin Hindman wrote: > > src/slave/containerizer/external_containerizer.cpp, lines 184-185 > > > > > > FYI, our style is to keep '+' on previous line and indent as though it > > was

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review41406 --- Bad patch! Reviews applied: [20080, 20668] Failed command: git app

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated April 24, 2014, 8:14 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17567: Added External Containerizer.

> On April 19, 2014, 9:33 p.m., Benjamin Hindman wrote: > > src/examples/python/test_containerizer.py, line 50 > > > > > > s/use/usage/? That function name is already used. > On April 19, 2014, 9:33 p.m., Benjamin

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated April 24, 2014, 2:40 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review40828 --- src/examples/python/test_containerizer.py

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review40741 --- Bad patch! Reviews applied: [19795, 19795] Failed command: git app

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated April 18, 2014, 3:36 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review39528 --- Bad patch! Reviews applied: [19795, 18403, 19901, 19795] Failed co

Re: Review Request 17567: Added External Containerizer.

> On March 31, 2014, 8:03 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, line 508 > > > > > > does this need to be a protobuf? > > Till Toenshoff wrote: > My idea was to adhere to our general communicatio

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated April 4, 2014, 8:39 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review39395 --- Bad patch! Reviews applied: [19795, 18403, 17567] Failed command:

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated April 3, 2014, 3:36 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review39392 --- Bad patch! Reviews applied: [17567] Failed command: git apply --in

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated April 3, 2014, 1:58 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated April 3, 2014, 1:57 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17567: Added External Containerizer.

> On March 31, 2014, 8:03 p.m., Vinod Kone wrote: > > src/slave/containerizer/external_containerizer.cpp, lines 293-295 > > > > > > This seems a bit unfortunate. How about creating a protobuf that wraps > > all the a

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review39245 --- Bad patch! Reviews applied: [19795, 18403, 17567] Failed command:

Re: Review Request 17567: Added External Containerizer.

> On March 31, 2014, 8:03 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, line 498 > > > > > > Just convert the Termination struct in Containerizer to a protobuf and > > use it here. > > > > Maybe do

Re: Review Request 17567: Added External Containerizer.

> On March 31, 2014, 8:03 p.m., Vinod Kone wrote: > > src/slave/containerizer/external_containerizer.cpp, line 1135 > > > > > > If we do the above and if we have MESOS-995, can you just leverage > > subprocess here?

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated April 2, 2014, 2:02 a.m.) Review request for mesos, Ian Downes, Niklas

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review39099 --- Bad patch! Reviews applied: [17567] Failed command: git apply --in

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review38504 --- include/mesos/mesos.proto

Re: Review Request 17567: Added External Containerizer.

Vinod graciously offered to help with this so I can focus on the Registrar work! I won't be looking at this Till ;) On Tue, Mar 25, 2014 at 11:55 AM, Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated March 25, 2014, 6:55 p.m.) Review request for mesos, Ian Downes, Nikla

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review38287 --- Patch looks great! Reviews applied: [18403, 17567] All tests passe

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated March 21, 2014, 8:22 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review38067 --- Bad patch! Reviews applied: [18403, 17567] Failed command: make -j

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review38052 --- I would kindly like to ask for shepherding on this - nominating Vin

Re: Review Request 17567: Added External Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/ --- (Updated March 21, 2014, 4:11 a.m.) Review request for mesos, Adam B, Benjamin