Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-06 Thread Benjamin Hindman
On Oct. 1, 2014, 9:30 p.m., Dominic Hamon wrote: src/slave/status_update_manager.cpp, line 570 https://reviews.apache.org/r/26247/diff/1/?file=710348#file710348line570 this is an unfortunate pattern. I assume your changes in dispatch have somehow changed the template deduction so

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/ --- (Updated Oct. 5, 2014, 6:05 a.m.) Review request for mesos and Dominic Hamon.

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/ --- (Updated Oct. 5, 2014, 6:05 a.m.) Review request for mesos and Dominic Hamon.

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-05 Thread Michael Park
On Oct. 1, 2014, 9:30 p.m., Dominic Hamon wrote: src/slave/status_update_manager.cpp, line 609 https://reviews.apache.org/r/26247/diff/1/?file=710348#file710348line609 nit: trailing whitespace Fixed. On Oct. 1, 2014, 9:30 p.m., Dominic Hamon wrote:

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/#review55466 --- Bad patch! Reviews applied: [26245, 26245] Failed command: git

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/ --- (Updated Oct. 5, 2014, 7:08 a.m.) Review request for mesos and Dominic Hamon.

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/#review55469 --- Bad patch! Reviews applied: [26245, 26245] Failed command: git

Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/ --- Review request for mesos. Repository: mesos-git Description --- These

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-01 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/#review55140 --- src/slave/containerizer/docker.cpp

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/ --- (Updated Oct. 1, 2014, 2:30 p.m.) Review request for mesos and Dominic Hamon.

Re: Review Request 26247: Remove usage of stout/preprocessor.hpp from mesos.

2014-10-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26247/#review55147 --- Bad patch! Reviews applied: [26247] Failed command: