---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71861
---
Ship it!
Ship It!
- Vinod Kone
On Feb. 10, 2015, 10:22 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Feb. 10, 2015, 2:22 p.m.)
Review request for mesos and Vinod Kone.
On Feb. 6, 2015, 6:56 p.m., Vinod Kone wrote:
src/master/master.cpp, line 3601
https://reviews.apache.org/r/27531/diff/7/?file=852243#file852243line3601
Looks like you missed updating metrics here?
Now that I think about it, it's worthwhile to consolidate metrics
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Feb. 9, 2015, 2:39 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71715
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Feb. 6, 2015, 3:22 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71483
---
Patch looks great!
Reviews applied: [27531]
All tests passed.
-
On Feb. 6, 2015, 6:56 p.m., Vinod Kone wrote:
src/master/master.cpp, line 3601
https://reviews.apache.org/r/27531/diff/7/?file=852243#file852243line3601
Looks like you missed updating metrics here?
Now that I think about it, it's worthwhile to consolidate metrics
On Feb. 6, 2015, 10:56 a.m., Vinod Kone wrote:
src/master/master.cpp, line 3601
https://reviews.apache.org/r/27531/diff/7/?file=852243#file852243line3601
Looks like you missed updating metrics here?
Now that I think about it, it's worthwhile to consolidate metrics
On Feb. 6, 2015, 10:56 a.m., Vinod Kone wrote:
src/master/master.cpp, line 3601
https://reviews.apache.org/r/27531/diff/7/?file=852243#file852243line3601
Looks like you missed updating metrics here?
Now that I think about it, it's worthwhile to consolidate metrics
On Feb. 6, 2015, 6:56 p.m., Vinod Kone wrote:
src/master/master.cpp, line 3601
https://reviews.apache.org/r/27531/diff/7/?file=852243#file852243line3601
Looks like you missed updating metrics here?
Now that I think about it, it's worthwhile to consolidate metrics
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71492
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71470
---
src/master/master.cpp
On Feb. 6, 2015, 10:56 a.m., Vinod Kone wrote:
src/master/master.cpp, line 3601
https://reviews.apache.org/r/27531/diff/7/?file=852243#file852243line3601
Looks like you missed updating metrics here?
Now that I think about it, it's worthwhile to consolidate metrics
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Feb. 6, 2015, 9:59 a.m.)
Review request for mesos and Vinod Kone.
On Feb. 5, 2015, 2:40 p.m., Vinod Kone wrote:
src/master/metrics.cpp, line 375
https://reviews.apache.org/r/27531/diff/6/?file=850814#file850814line375
I would put strings::lower(TaskState_Name(state)) + / on next line
for readability.
also updated to use typedefs.
- Dominic
On Feb. 4, 2015, 12:41 p.m., Vinod Kone wrote:
src/master/master.cpp, line 4704
https://reviews.apache.org/r/27531/diff/4/?file=768121#file768121line4704
Not sure why we missed updating metrics for non-terminal states when
we introduced metrics. This is a bug. I'll prep a fix for
On Feb. 4, 2015, 8:41 p.m., Vinod Kone wrote:
src/tests/master_authorization_tests.cpp, lines 365-373
https://reviews.apache.org/r/27531/diff/4/?file=768126#file768126line365
It is a bit weird to see a test for these metrics in authorization
tests. Any particular reason or did
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Feb. 6, 2015, 10:42 a.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71313
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Feb. 5, 2015, 10:07 a.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71023
---
Looks great. Just need some better naming. I suggested one. Feel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Feb. 4, 2015, 4:19 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71080
---
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review71124
---
Bad patch!
Reviews applied: [27531]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Jan. 20, 2015, 1:26 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review67906
---
ping
- Dominic Hamon
On Nov. 18, 2014, 3:14 p.m., Dominic Hamon
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Nov. 18, 2014, 3:14 p.m.)
Review request for mesos, Tobias
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review62093
---
Patch looks great!
Reviews applied: [27531]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-1830
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/
---
(Updated Nov. 3, 2014, 10:24 a.m.)
Review request for mesos, Tobias
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review59615
---
Patch looks great!
Reviews applied: [26817, 26382, 27531]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27531/#review59613
---
src/master/master.cpp
On Nov. 3, 2014, 1:59 p.m., Vinod Kone wrote:
src/master/master.cpp, lines 5078-5094
https://reviews.apache.org/r/27531/diff/1/?file=747568#file747568line5078
We cannot/shouldnot remove these without a deprecation cycle. This is
an API change!
I considered exposing them as
On Nov. 3, 2014, 9:59 p.m., Vinod Kone wrote:
src/master/master.cpp, lines 5078-5094
https://reviews.apache.org/r/27531/diff/1/?file=747568#file747568line5078
We cannot/shouldnot remove these without a deprecation cycle. This is
an API change!
Dominic Hamon wrote:
I
On Nov. 3, 2014, 1:59 p.m., Vinod Kone wrote:
src/master/master.cpp, lines 5078-5094
https://reviews.apache.org/r/27531/diff/1/?file=747568#file747568line5078
We cannot/shouldnot remove these without a deprecation cycle. This is
an API change!
Dominic Hamon wrote:
I
36 matches
Mail list logo
