Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-02-10 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/#review71939 --- Ship it! Minor issues, I'll take care of them and get this

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-02-08 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/#review71559 --- src/master/contender.cpp

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-02-08 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/ --- (Updated Feb. 6, 2015, 11:49 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-02-08 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/ --- (Updated Feb. 7, 2015, 12:34 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-02-08 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/ --- (Updated Feb. 7, 2015, 12:34 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-02-08 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/ --- (Updated Feb. 9, 2015, 12:43 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-02-08 Thread Cody Maloney
On Feb. 7, 2015, 5:40 p.m., Benjamin Hindman wrote: src/master/contender.cpp, line 88 https://reviews.apache.org/r/30195/diff/6/?file=853137#file853137line88 How can this ever be the case? What path brings us to this that doesn't go through a flags load? Can you document as much

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-02-05 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/ --- (Updated Feb. 5, 2015, 10:31 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-02-05 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/ --- (Updated Feb. 5, 2015, 10:30 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-02-03 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/ --- (Updated Feb. 4, 2015, midnight) Review request for mesos, Benjamin Hindman

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-01-29 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/#review70202 --- I think a general solution to workaround `--whitelist` issue is to

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-01-27 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/ --- (Updated Jan. 27, 2015, 11:39 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-01-27 Thread Cody Maloney
On Jan. 27, 2015, 5:58 p.m., Dominic Hamon wrote: src/zookeeper/url.hpp, line 53 https://reviews.apache.org/r/30195/diff/1/?file=830596#file830596line53 keep the * with the type. also, why is this a method? static const char prefix[] = zk://; will work fine. From a

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-01-27 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/ --- (Updated Jan. 27, 2015, 5:26 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/#review69836 --- Bad patch! Reviews applied: [30194, 30195] Failed command:

Re: Review Request 30195: Remove per-flag parsing of file:// arguments

2015-01-27 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/#review69835 --- docs/configuration.md

Review Request 30195: Remove per-flag parsing of file:// arguments

2015-01-22 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30195/ --- Review request for mesos, Benjamin Hindman and Ken Sipe. Bugs: mesos-1806