---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/
---
(Updated April 20, 2015, 1:46 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/
---
(Updated April 15, 2015, 2:17 p.m.)
Review request for mesos, Kapil Arya,
On April 2, 2015, 6:33 p.m., Vinod Kone wrote:
src/Makefile.am, line 1351
https://reviews.apache.org/r/31267/diff/6/?file=912100#file912100line1351
s/drf// to be consistent (e.g., we didn't name libtestauthentication.la
as libcrammd5authentication.la)
Will do.
On April 2,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/
---
(Updated April 7, 2015, 12:47 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/#review78694
---
Ship it!
src/Makefile.am
On March 27, 2015, 4:36 p.m., Alexander Rojas wrote:
src/tests/module.cpp, line 137
https://reviews.apache.org/r/31267/diff/4-5/?file=903021#file903021line137
You may need a `CHECK(modules != NULL)` or a log and return in the NULL
case?
Alexander Rukletsov wrote:
If you
On March 27, 2015, 4:36 p.m., Alexander Rojas wrote:
src/tests/module.cpp, line 137
https://reviews.apache.org/r/31267/diff/4-5/?file=903021#file903021line137
You may need a `CHECK(modules != NULL)` or a log and return in the NULL
case?
If you follow the invokation path, you'll
On March 27, 2015, 4:36 p.m., Alexander Rojas wrote:
src/tests/module.cpp, line 137
https://reviews.apache.org/r/31267/diff/4-5/?file=903021#file903021line137
You may need a `CHECK(modules != NULL)` or a log and return in the NULL
case?
Alexander Rukletsov wrote:
If you
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/#review78509
---
Ship it!
src/tests/module.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/
---
(Updated April 1, 2015, 2:26 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/
---
(Updated March 27, 2015, 3:08 p.m.)
Review request for mesos, Kapil Arya,
On March 24, 2015, 6:07 a.m., Michael Park wrote:
src/tests/module.cpp, line 135
https://reviews.apache.org/r/31267/diff/4/?file=903021#file903021line135
Can we take `Modules*` here instead to keep consistency with
`addAnonymousModules`, etc? or perhaps a patch before this one to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/
---
(Updated March 27, 2015, 4:26 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/#review78070
---
src/tests/module.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/#review77900
---
Can you please mention what this test do at this stage. Apparently
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/#review77903
---
Ship it!
Ship It!
- Alexander Rojas
On March 23, 2015, 3:05
On March 24, 2015, 7:07 a.m., Michael Park wrote:
src/tests/module.cpp, line 141
https://reviews.apache.org/r/31267/diff/4/?file=903021#file903021line141
Looking at the `Isolator` example which has `Cpu` and `Mem` isolators,
it seems to me like we want
On March 24, 2015, 6:07 a.m., Michael Park wrote:
src/tests/module.cpp, line 141
https://reviews.apache.org/r/31267/diff/4/?file=903021#file903021line141
Looking at the `Isolator` example which has `Cpu` and `Mem` isolators,
it seems to me like we want
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/#review77531
---
src/tests/module.cpp
On March 17, 2015, 9:04 p.m., Kapil Arya wrote:
src/examples/test_allocator_module.cpp, line 40
https://reviews.apache.org/r/31267/diff/3/?file=894483#file894483line40
s/HierarchicalDRFAllocator/HierarchicalDRFAllocator()/
Alexander Rukletsov wrote:
There should be no
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/
---
(Updated March 23, 2015, 2:05 p.m.)
Review request for mesos, Kapil Arya,
On March 17, 2015, 9:04 p.m., Kapil Arya wrote:
src/examples/test_allocator_module.cpp, line 40
https://reviews.apache.org/r/31267/diff/3/?file=894483#file894483line40
s/HierarchicalDRFAllocator/HierarchicalDRFAllocator()/
There should be no difference in this case:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/#review76810
---
Ship it!
LGTM minus the issue below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/
---
(Updated March 13, 2015, 9:48 p.m.)
Review request for mesos, Kapil Arya,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/#review75963
---
src/Makefile.am
https://reviews.apache.org/r/31267/#comment123313
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31267/
---
(Updated March 5, 2015, 9:05 p.m.)
Review request for mesos, Kapil Arya,
26 matches
Mail list logo