Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

2015-04-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/#review79904 --- src/master/master.hpp

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

2015-04-13 Thread Kapil Arya
On April 13, 2015, 1:47 p.m., Ben Mahler wrote: src/master/master.hpp, lines 1100-1103 https://reviews.apache.org/r/32585/diff/4/?file=919351#file919351line1100 Did you look back at https://reviews.apache.org/r/19176/ when doing this? What was the motivation for

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

2015-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/#review79799 --- Ship it! Needs a quick rebase before committing. - Adam B On

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

2015-04-07 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/#review79146 --- LGTM, assuming no significant rebases. src/master/master.hpp

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

2015-04-07 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/ --- (Updated April 7, 2015, 12:59 p.m.) Review request for mesos, Adam B and

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

2015-04-01 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/#review78496 --- src/slave/slave.cpp

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

2015-04-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/ --- (Updated April 1, 2015, 3:34 p.m.) Review request for mesos, Adam B and Niklas

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

2015-04-01 Thread Kapil Arya
On April 1, 2015, 5:28 a.m., Adam B wrote: src/slave/slave.cpp, line 1043 https://reviews.apache.org/r/32585/diff/1-2/?file=908253#file908253line1043 Hmm... I was actually thinking that this line of code can be removed now that you're always filling in the id in the FrameworkInfo

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

2015-04-01 Thread Adam B
On April 1, 2015, 2:28 a.m., Adam B wrote: src/slave/slave.cpp, line 1043 https://reviews.apache.org/r/32585/diff/1-2/?file=908253#file908253line1043 Hmm... I was actually thinking that this line of code can be removed now that you're always filling in the id in the FrameworkInfo

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

2015-03-31 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/ --- (Updated March 31, 2015, 4:29 p.m.) Review request for mesos, Adam B and