---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32742/#review78635
---
Patch looks great!
Reviews applied: [32742]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32742/#review78591
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32742/
---
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32742/#review78611
---
Patch looks great!
Reviews applied: [32742]
All tests passed.
-
On April 1, 2015, 9:15 p.m., Ben Mahler wrote:
src/slave/slave.cpp, lines 250-263
https://reviews.apache.org/r/32742/diff/1/?file=912733#file912733line250
ostringstream?
Have you considered just building a setstring and using
strings::join(\n, commands) below? Then
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32742/
---
(Updated April 1, 2015, 10:39 p.m.)
Review request for mesos, Ben Mahler, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32742/#review78618
---
Ship it!
src/slave/slave.cpp