Re: Review Request 26622: Don't pass task-related arguments to mesos-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26622/#review56333 --- Patch looks great! Reviews applied: [26622] All tests passed. -

Framework testing in Mesos

Hi, I am working on a tiny experimental framework for Mesos. I was wondering what is the recommended way of writing testcases for framework testing. I looked at the several existing frameworks, but its still not clear to me. I understand that I might be able to test executor functionality in

Re: Framework testing in Mesos

For our frameworks, we don't tend to do much automated testing of the Mesos interface--instead, we construct the framework state, then send it a message, since our callbacks take the state of the framework + the event as the argument. This way, we don't need to have mesos running, and we can trim

Re: Review Request 26436: Avoid docker inspect on each usage call

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26436/#review56356 --- Patch looks great! Reviews applied: [26436] All tests passed. -

Re: Review Request 26509: Added --module flag for Mesos slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26509/#review56357 --- Ship it! src/slave/main.cpp

Re: Review Request 26509: Added --module flag for Mesos slave.

On Oct. 10, 2014, 11:26 p.m., Till Toenshoff wrote: src/slave/main.cpp, line 117 https://reviews.apache.org/r/26509/diff/5/?file=717907#file717907line117 Not yours but this would trigger a glog warning as it has not yet been initialized. We should possibly check all runnables for

Re: Review Request 26509: Added --module flag for Mesos slave.

On Oct. 12, 2014, 6:56 p.m., Benjamin Hindman wrote: src/slave/main.cpp, lines 126-127 https://reviews.apache.org/r/26509/diff/9/?file=718287#file718287line126 When we can use EXIT(1) please prefer it (see a few lines up for an example). Looks like you can clean up the same from

Re: Review Request 26509: Added --module flag for Mesos slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26509/ --- (Updated Oct. 12, 2014, 4:08 p.m.) Review request for mesos, Niklas Nielsen

Review Request 26629: Replace cerr/exit with EXIT when parsing master flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26629/ --- Review request for mesos, Niklas Nielsen and Till Toenshoff. Repository:

Re: Review Request 26629: Replace cerr/exit with EXIT when parsing master flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26629/#review56361 --- Ship it! Ship It! - Till Toenshoff On Oct. 12, 2014, 8:11 p.m.,

Re: Review Request 26509: Added --module flag for Mesos slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26509/#review56362 --- Patch looks great! Reviews applied: [26509] All tests passed. -

Review Request 26630: Fixed non-deterministic test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26630/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description

Re: Review Request 26629: Replace cerr/exit with EXIT when parsing master flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26629/#review56363 --- Patch looks great! Reviews applied: [26629] All tests passed. -

Re: Review Request 26630: Fixed non-deterministic test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26630/#review56364 --- Ship it! Ship It! - Timothy Chen On Oct. 12, 2014, 10 p.m.,

Re: Review Request 26630: Fixed non-deterministic test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26630/#review56367 --- Patch looks great! Reviews applied: [26611, 26612, 26613, 26614,

Re: Review Request 26614: More simplifications of Docker container launching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26614/#review56370 --- Ship it! Ship It! - Timothy Chen On Oct. 11, 2014, 10:10 p.m.,

Re: Review Request 26629: Replace cerr/exit with EXIT when parsing master flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26629/#review56371 --- LGTM! - Cody Maloney On Oct. 12, 2014, 8:11 p.m., Kapil Arya

Re: Review Request 26622: Don't pass task-related arguments to mesos-executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26622/ --- (Updated Oct. 12, 2014, 8:09 p.m.) Review request for mesos and Benjamin

Review Request 26635: Fixes necessary due to JSON::Array::values change to std::vector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26635/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description

Review Request 26634: Implemented array subscript lookup in JSON::Object::find.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/ --- Review request for mesos, Alexander Rukletsov and Ben Mahler. Repository:

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25622/#review56374 --- Ship it! I'll be committing this now, thanks Alex! - Benjamin

Re: Review Request 26635: Fixes necessary due to JSON::Array::values change to std::vector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26635/#review56376 --- Ship it! Ship It! - Timothy Chen On Oct. 13, 2014, 4:54 a.m.,