---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30006/#review69604
---
src/slave/containerizer/fetcher.cpp
How about InternetAddressStorage (or just InternetAddress), since we don't
like abbreviations in our code?
(Or if 'in_ is short for something else, use it instead.)
On Mon, Jan 26, 2015 at 11:07 AM, Evelina Dumitrescu
evelina_dumitre...@yahoo.com.invalid wrote:
I renamed the IP::Address class
On Jan. 26, 2015, 2:16 p.m., Ben Mahler wrote:
Why is a base class needed here?
The idea here was to refactor RunState so that we can expose just the
RunStateBase and not have to worry about exposing the Task and StatusUpdate
protobufs from messages/messages.proto. Doing this helps us
On Jan. 26, 2015, 6:58 p.m., Ben Mahler wrote:
include/mesos/resources.hpp, line 247
https://reviews.apache.org/r/30131/diff/2/?file=834317#file834317line247
Do you want this implicit? Looks like you're being explicit in the .cpp
code when using this.
made it explicit.
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/#review69661
---
Patch looks great!
Reviews applied: [29288, 29289, 29290]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29290/
---
(Updated Jan. 26, 2015, 6:55 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/
---
(Updated Jan. 26, 2015, 6:56 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
---
(Updated Jan. 26, 2015, 6:56 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30237/#review69654
---
Why is a base class needed here?
- Ben Mahler
On Jan. 24, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/#review69646
---
Ship it!
Modulo the Filter comment, we should consider making that
I renamed the IP::Address class into InAddrStorage, becuase it stores the
in_addr and in6_addr info, but I decided to keep the inner class design.
On Friday, January 23, 2015 7:26 PM, Dominic Hamon
dha...@twitter.com.INVALID wrote:
On Thu, Jan 22, 2015 at 5:30 PM, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30130/#review69643
---
Ship it!
src/master/sorter.hpp
On Jan. 23, 2015, 7:16 a.m., Michael Park wrote:
include/mesos/resources.hpp, lines 174-180
https://reviews.apache.org/r/30131/diff/1/?file=828568#file828568line174
I think the `static bool isPersistentVolume(const Resource)` function
introduced in
On Jan. 22, 2015, 1:12 a.m., Ben Mahler wrote:
include/mesos/resources.hpp, lines 159-180
https://reviews.apache.org/r/30131/diff/1/?file=828568#file828568line159
I'm curious why you chose to stray from the existing Filter design in
resources.cpp, I like that one because it can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30131/
---
(Updated Jan. 26, 2015, 6:21 p.m.)
Review request for mesos, Ben Mahler,
SGTM. I would suggest to first address the non-proto files before changing
the proto files.
On Mon, Jan 26, 2015 at 12:35 PM, Kapil Arya ka...@mesosphere.io wrote:
Hi All,
TLDR: We currently use mesos::internal namespace for almost everything
inside src/. However, in most cases, it is
On Jan. 23, 2015, 10:42 p.m., Timothy St. Clair wrote:
configure.ac, line 260
https://reviews.apache.org/r/29595/diff/3/?file=819045#file819045line260
Do you have system details?
Could you provide ldd and version of the system in question.
Kapil Arya wrote:
On Jan. 23, 2015, 10:38 p.m., Timothy St. Clair wrote:
3rdparty/libprocess/configure.ac, line 178
https://reviews.apache.org/r/30048/diff/1/?file=825235#file825235line178
maybe I'm missing something, but isn't 'test -d' to check directories?
Kapil Arya wrote:
Yeah, that's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30283/#review69678
---
Patch looks great!
Reviews applied: [30283]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30283/
---
Review request for mesos, Ben Mahler and Michael Park.
Summary (updated)
Hi All,
TLDR: We currently use mesos::internal namespace for almost everything
inside src/. However, in most cases, it is directly enclosing another
namespace. This makes the internal namespace redundant and we should
kill it.
I learned from Ben Hindman that the original motivation for
On Jan. 26, 2015, 3:56 p.m., Ian Downes wrote:
Is there benefit to adding the base class to slave/state when it's only
used by the MesosContainer Isolators? Could we have a similar struct
(containerId, pid, directory) in isolator.hpp which is used for
Isolator::recover().
I think
SGTM - but it would probably be a good idea to do some preliminary testing
of the upgrade path it would result in.
Kapil, have you tried to run different mesos processes with and w/o the
internal namespace?
Niklas
On 26 January 2015 at 12:47, Vinod Kone vinodk...@gmail.com wrote:
SGTM. I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29781/
---
(Updated Jan. 26, 2015, 10:16 p.m.)
Review request for mesos, Niklas Nielsen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30238/
---
(Updated Jan. 26, 2015, 10:17 p.m.)
Review request for mesos, Ian Downes,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30237/
---
(Updated Jan. 26, 2015, 10:17 p.m.)
Review request for mesos, Ian Downes,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30296/#review69731
---
Patch looks great!
Reviews applied: [30296]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30298/#review69743
---
Patch looks great!
Reviews applied: [30283, 30298]
All tests
One benefit of having an internal namespace is that it tells the
framework/executor writer that those symbols/method/class are internal to
Mesos core and should not be used.
If we kill all the internal namespaces and move many headers like
isolator.hpp to include/mesos, how does the framework
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30295/
---
Review request for mesos, Alexander Rukletsov, Niklas Nielsen, Till Toenshoff,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30300/
---
(Updated Jan. 26, 2015, 10:10 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29597/
---
(Updated Jan. 26, 2015, 10:12 p.m.)
Review request for mesos, Niklas Nielsen,
Hi Jie,
Thanks for the comments. I have tried to answer them inline. Please let us
know if something isn't clear.
Kapil
On Tue, Jan 27, 2015 at 1:25 AM, Jie Yu yujie@gmail.com wrote:
One benefit of having an internal namespace is that it tells the
framework/executor writer that those
PS: I have created a Jira and have published the following RRs:
1. https://reviews.apache.org/r/30294/
2. https://reviews.apache.org/r/30295/
3. https://reviews.apache.org/r/30300/
On Tue, Jan 27, 2015 at 1:50 AM, Kapil Arya ka...@mesosphere.io wrote:
Hi Jie,
Thanks for the comments. I have
On Jan. 27, 2015, 1:08 a.m., Ben Mahler wrote:
3rdparty/libprocess/include/process/limiter.hpp, lines 37-39
https://reviews.apache.org/r/30192/diff/3/?file=835003#file835003line37
This is a bit confusing to me, couldn't you just say that Discarding
this future cancels the
ok, I will rename it in InternetAddress.
On Monday, January 26, 2015 9:20 PM, Adam Bordelon a...@mesosphere.io
wrote:
How about InternetAddressStorage (or just InternetAddress), since we don't
like abbreviations in our code?
(Or if 'in_ is short for something else, use it instead.)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30297/#review69738
---
Patch looks great!
Reviews applied: [30191, 30192, 30297]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29780/
---
(Updated Jan. 26, 2015, 10:12 p.m.)
Review request for mesos, Niklas Nielsen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29598/
---
(Updated Jan. 26, 2015, 10:12 p.m.)
Review request for mesos, Niklas Nielsen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review69741
---
3rdparty/libprocess/include/process/node.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29071/#review69709
---
Thanks Drob, just some minor things and we'll be good to go.
Could
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30297/
---
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30298/
---
Review request for mesos, Ben Mahler and Michael Park.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30298/
---
(Updated Jan. 27, 2015, 1:07 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30192/#review69714
---
Hm.. with this approach the caller is still limited even though
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30294/
---
Review request for mesos, Alexander Rukletsov, Niklas Nielsen, and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30300/
---
Review request for mesos, Alexander Rukletsov, Niklas Nielsen, Till Toenshoff,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29605/
---
(Updated Jan. 26, 2015, 10:18 p.m.)
Review request for mesos, Niklas Nielsen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30052/
---
(Updated Jan. 26, 2015, 10:18 p.m.)
Review request for mesos, Niklas Nielsen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29606/
---
(Updated Jan. 26, 2015, 10:18 p.m.)
Review request for mesos, Niklas Nielsen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29604/
---
(Updated Jan. 26, 2015, 10:18 p.m.)
Review request for mesos, Niklas Nielsen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/#review69739
---
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
Thanks Kevin.
Can you give me some example/location of those script ?
Chester
On Mon, Jan 26, 2015 at 5:47 PM, Kevin Lyda ke...@ie.suberic.net wrote:
Right now (or at least last I checked, I've been working on a lot of
non-mesos stuff lately sadly), resources were determined by some
config
Right now (or at least last I checked, I've been working on a lot of
non-mesos stuff lately sadly), resources were determined by some
config files at slave start. Mesosphere's packaged mesos had some
pretty scriptable ones.
You could add to those scripts to look for opencl and then use opencl
to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/
---
(Updated Jan. 26, 2015, 9:55 a.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032/
---
(Updated Jan. 26, 2015, 11:23 a.m.)
Review request for mesos, Benjamin Hindman
Chester, you can specify arbitrary resources using the --resources flag to the
slave and Mesos will share out the resources to frameworks, and then your
framework can do as it pleases.
I'm not sure any changes are required in Mesos itself to support this, unless
I'm missing something.
--
I was assuming there might be isolation or something else involved,
but I wasn't sure. If just another resource to share than what Tom
said is sufficient.
Tim
On Mon, Jan 26, 2015 at 12:48 AM, Tom Arnfeld t...@duedil.com wrote:
Chester, you can specify arbitrary resources using the --resources
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/#review69593
---
Patch looks great!
Reviews applied: [27760]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27760/
---
(Updated Jan. 26, 2015, 8:49 a.m.)
Review request for mesos, Adam B, Kapil
Hi Tom
Ya, the GPGPU resources needs to provided from slave , but we need to
extend to have it to query GPGPU resources such as GPU devices
(single or multiple) ,CU(compute unit) , global/local memory embedded
in the slave node, with this info , framework can utilize it as we did
of generic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/#review69596
---
configure.ac
https://reviews.apache.org/r/30263/#comment114292
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032/#review69597
---
Patch looks great!
Reviews applied: [30032]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/
---
(Updated Jan. 26, 2015, 11:11 a.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/#review69599
---
Patch looks great!
Reviews applied: [30263]
All tests passed.
-
For a few releases now, we've had parity on master and slave between the
old metrics endpoints (/stats.json) and the new endpoint
(/metrics/snapshot). As per MESOS-2058
https://issues.apache.org/jira/browse/MESOS-2058, the old endpoints will
be deprecated in 0.23.
0.22 will be released with a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29550/
---
(Updated Jan. 26, 2015, 6:09 p.m.)
Review request for mesos, Cody Maloney,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29551/
---
(Updated Jan. 26, 2015, 6:09 p.m.)
Review request for mesos, Cody Maloney,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29550/#review69697
---
Just tried it on OSX with aclocal112, and the
On Jan. 26, 2015, 11:39 p.m., Timothy Chen wrote:
Just tried it on OSX with aclocal112, and the AM_EXTRA_RECURSIVE_TARGETS
macro couldn't be found.
Will hold onto commiting until this is fixed.
- Timothy
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30289/#review69700
---
Ship it!
Ship It!
- Vinod Kone
On Jan. 26, 2015, 10:40 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30288/#review69702
---
Ship it!
Ship It!
- Vinod Kone
On Jan. 26, 2015, 10:38 p.m.,
I want to note that if there was any change in behavior around this change
that would likely indicate a serious compiler bug. Namespaces are something
that is purely programmer visible in C++, the symbol names will change
slightly for things that were internal, but nothing else. Things need to be
The flag was deprecated in 0.18.0; it was still accepted but ignored. The
flag will be removed in 0.22 and it will no longer be accepted by the slave.
Please remove this flag from any configuration.
https://issues.apache.org/jira/browse/MESOS-2184
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30290/
---
Review request for mesos and Dominic Hamon.
Bugs: MESOS-2184
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30290/#review69691
---
Ship it!
Ship It!
- Dominic Hamon
On Jan. 26, 2015, 2:44 p.m.,
On Jan. 26, 2015, 2:51 p.m., Dominic Hamon wrote:
please also add to the CHANGELOG for 0.22. see
https://reviews.apache.org/r/30288/ for example.
Was already added to docs/upgrades.md at 0.18.0.
- Ian
---
This is an automatically
On Mon, Jan 26, 2015 at 2:09 PM, Niklas Nielsen nik...@mesosphere.io
wrote:
SGTM - but it would probably be a good idea to do some preliminary testing
of the upgrade path it would result in.
Kapil, have you tried to run different mesos processes with and w/o the
internal namespace?
I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30288/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-2058
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30289/
---
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30290/#review69690
---
please also add to the CHANGELOG for 0.22. see
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29550/#review69695
---
Ship it!
Ship It!
- Timothy Chen
On Jan. 26, 2015, 11:09 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30288/#review69696
---
Patch looks great!
Reviews applied: [30288]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30289/#review69706
---
Patch looks great!
Reviews applied: [30289]
All tests passed.
-
On Jan. 23, 2015, 8:39 p.m., Jie Yu wrote:
3rdparty/libprocess/include/process/limiter.hpp, lines 37-38
https://reviews.apache.org/r/30192/diff/2/?file=831283#file831283line37
what do you mean by next permit takes it place? Do you mean the next
caller takes the permit?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30290/#review69708
---
Bad patch!
Reviews applied: [30290]
Failed command:
An addendum:
This will also deprecate the task status counts from /state.json as they
are already present in the new endpoint. /state.json will still retain the
current state of every task.
On Mon, Jan 26, 2015 at 2:31 PM, Dominic Hamon dha...@twopensource.com
wrote:
For a few releases now,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30296/
---
Review request for mesos and Vinod Kone.
Bugs: MESOS-2058
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/#review69713
---
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29288/#review69670
---
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30237/#review69676
---
Is there benefit to adding the base class to slave/state when it's
91 matches
Mail list logo
