Operator HTTP endpoints

2016-01-14 Thread Alex Rukletsov
Folks, I would like to gather your opinions about a concern related to operator HTTP endpoints. From one side we agreed that for simplicity and consistency we should bake all request data in a single JSON. From the other side, some parameters, like a force flag, do not really belong to request

Re: Request Mesos contributor role

2016-01-14 Thread Benjamin Bannier
Hi, >> Error: >> 2016-01-14 09:19:38 URL:https://reviews.apache.org/r/42288/diff/raw/ >> [612/612] -> "42288.patch" [1] >> Total errors found: 0 >> Checking 1 files >> Error: Commit message summary (the first line) must not exceed 72 characters. > >> my patch first line is: >> diff --git

答复: Request Mesos contributor role

2016-01-14 Thread pangbingqiang
Thanks! Yeah, the hooks dir have a commit-msg file, so what I should do to fix this? The file line no more than 72 chars. -邮件原件- 发件人: Benjamin Bannier [mailto:benjamin.bann...@mesosphere.io] 发送时间: 2016年1月14日 20:20 收件人: dev@mesos.apache.org 主题: Re: Request Mesos contributor role Hi, >>

Links in documentation

2016-01-14 Thread Jörg Schad
Hi, just a short note about links in our documentation. In the current documentation we use three different ways to link between different *.md pages: 1. [label](/documentation/latest/foo/) 2. [label](foo.md) 3. [label](https://github.com/apache/mesos/blob/master/docs/foo.md) First of all, option

答复: 回复: Request Mesos contributor role

2016-01-14 Thread pangbingqiang
> I submit a patch in ReviewBoard,MesosReview's reply is: > Bad patch! > Reviews applied: [42288] > Failed command: ./support/apply-review.sh -n -r 42288 > Error: > 2016-01-14 09:19:38 URL:https://reviews.apache.org/r/42288/diff/raw/ > [612/612] -> "42288.patch" [1] > Total errors found: 0 >

Re: Operator HTTP endpoints

2016-01-14 Thread Klaus Ma
+1 for adding "force" in JSON body; used to be a JEE developer for several years, there's a general practice to us: query argument (e.g. "?force=true") is ONLY used by 'GET', all "data" are in body if action is 'POST' (e.g. UPDATE, DELETE). The reason is complex: security, meaning of HTTP action,

Re: Operator HTTP endpoints

2016-01-14 Thread Marco Massenzio
+1 for Lukas's suggestion to have `force` be a query argument (eg, ``?force=true``) and the body respect the ``Content-Type`` header. (although I was part of the conversation of adding the ``force`` flag to the SUBSCRIBE message, I forget the exact details of that one - @Vinod may be able to

Re: Links in documentation

2016-01-14 Thread Kevin Klues
So by 2 you mean relative links to the *.md files vs 3 which is absolute (from the repos topdir). If so, +1 On Thu, Jan 14, 2016 at 11:39 AM, Joris Van Remoortere wrote: >> >> *In fact it seems that all links ending with .md are interpreted as >> relative links on the

Re: find a shepherd

2016-01-14 Thread Timothy Chen
Hi Jian, I can help shepherd these. Tim On Thu, Jan 14, 2016 at 6:53 PM, Jian Qiu wrote: > Hi, > > Anyone could help shepherding on these tickets? Thanks. > > https://issues.apache.org/jira/browse/MESOS-4174 > https://issues.apache.org/jira/browse/MESOS-4161 >

Re: 答复: Request Mesos contributor role

2016-01-14 Thread Adam Bordelon
You'll need to shorten your commit summary, which is derived from the 'Summary' field in ReviewBoard. You can put a longer description in the 'Description' field, and it will also be included in the final commit message (although not in the first line, which is restricted to 72 chars). Also,

Re: 答复: Request Mesos contributor role

2016-01-14 Thread Adam Bordelon
Just run `git log` or `git log --oneline` for many more examples. :) On Thu, Jan 14, 2016 at 11:15 PM, Adam Bordelon wrote: > You'll need to shorten your commit summary, which is derived from the > 'Summary' field in ReviewBoard. You can put a longer description in the >

Re: 答复: Request Mesos contributor role

2016-01-14 Thread Guangya Liu
You can also take a look at following link to get more detail: https://github.com/apache/mesos/blob/master/docs/submitting-a-patch.md https://github.com/apache/mesos/blob/master/docs/effective-code-reviewing.md The last one is from OpenStack git commit, you can also take it as a reference:

Re: Links in documentation

2016-01-14 Thread Neil Conway
On Thu, Jan 14, 2016 at 11:39 AM, Joris Van Remoortere wrote: >> *In fact it seems that all links ending with .md are interpreted as >> relative links on the webpage, i.e. [label](https://test.com/foo.md) is >> rendered into https://test.com/foo/ >> ">label. > > I think this

Re: Links in documentation

2016-01-14 Thread Joris Van Remoortere
> > *In fact it seems that all links ending with .md are interpreted as > relative links on the webpage, i.e. [label](https://test.com/foo.md) is > rendered into https://test.com/foo/ > ">label. I think this should be fixed. We shouldn't be restricted from linking to external documentation. —

request to be added as a contributor

2016-01-14 Thread Ezra Silvera
hi, I want to be assigned myself to the jira issue https://issues.apache.org/jira/browse/MESOS-4369 for which I request to be included in the list of contributors Thanks Ezra Silvera

Re: request to be added as a contributor

2016-01-14 Thread Vinod Kone
done On Thu, Jan 14, 2016 at 7:06 AM, Ezra Silvera wrote: > hi, > I want to be assigned myself to the jira issue > https://issues.apache.org/jira/browse/MESOS-4369 > for which I request to be included in the list of contributors > > Thanks > > Ezra Silvera > >

Re: request to be added as a contributor

2016-01-14 Thread Vinod Kone
done. welcome aboard. On Thu, Jan 14, 2016 at 7:06 AM, Ezra Silvera wrote: > hi, > I want to be assigned myself to the jira issue > https://issues.apache.org/jira/browse/MESOS-4369 > for which I request to be included in the list of contributors > > Thanks > > Ezra Silvera > >

Re: Ignite as Big Data project built on Mesos

2016-01-14 Thread Vinod Kone
Can you send a PR on github/apache/mesos or submit a review ?. On Wed, Jan 13, 2016 at 6:30 PM, Dmitriy Setrakyan wrote: > Hello Mesos community! > > Ignite community would like to add Apache Ignite to this