On March 23, 2015, 10:27 p.m., Michael Park wrote:
src/Makefile.am, lines 234-239
https://reviews.apache.org/r/31776/diff/4/?file=902996#file902996line234
In line with the above comment, it seems like `$(ALLOCATOR_PROTO)`
should live in `include/mesos/allocator/...` rather than
On March 23, 2015, 10:27 p.m., Michael Park wrote:
src/Makefile.am, lines 170-171
https://reviews.apache.org/r/31776/diff/4/?file=902996#file902996line170
Seems to me like these should be `allocator/allocator.pb.cc`, and
`../include/mesos/allocator/allocator.pb.h`. Could you
. `make check -j 8`
3. `./bin/mesos-tests.sh --gtest_shuffle`
Thanks,
Michael Park
On March 24, 2015, 9:32 p.m., Michael Park wrote:
src/common/http.cpp, lines 179-187
https://reviews.apache.org/r/32419/diff/1/?file=903656#file903656line179
Just a suggestion for an alternative pattern here.
Rather than
```
{
JSON::Array
/#review77502
---
On March 24, 2015, 6:32 a.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31977
/31977/diff/
Testing
---
1. `GTEST_FILTER=MasterTest.MasterFailoverLongLivedExecutor GLOG_v=1
./bin/mesos-tests.sh --gtest_repeat=-1` up to 500+ iterations
2. `make check -j 8`
3. `./bin/mesos-tests.sh --gtest_shuffle`
Thanks,
Michael Park
` and `Mem` isolators, it
seems to me like we want `s/testdrfalloactor/testallocator/` here.
- Michael Park
On March 23, 2015, 2:05 p.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/tests/reservation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29748/diff/
Testing
---
make check
Thanks,
Michael Park
/31266/#comment125626
`s/template/template /`
include/mesos/module/allocator.hpp
https://reviews.apache.org/r/31266/#comment125634
I think this should be `create(_create) {}`.
- Michael Park
On March 23, 2015, 2:03 p.m., Alexander Rukletsov wrote
On March 24, 2015, 5:55 a.m., Michael Park wrote:
Hm, upon looking at other files in `include/mesos/module/` it looks like the 2
style issues I mentioned below is apparent in all of them. Is there a reason
for this? or shoud they be fixed as a batch in a separate review request
highlight means.
src/local/local.hpp
https://reviews.apache.org/r/31776/#comment125570
This comment looks useless. Can we just get rid of it?
src/master/main.cpp
https://reviews.apache.org/r/31776/#comment125571
Indent 2 spaces for assignment.
- Michael Park
On March 23, 2015, 2:02
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31775/#review77475
---
LGTM!
- Michael Park
On March 23, 2015, 2:01 p.m., Alexander
7a06c7028eca8164b1f5fdea6a7ecd37ee6826bb
src/tests/reservation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29748/diff/
Testing
---
make check
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32306/#review77234
---
LGTM!
- Michael Park
On March 20, 2015, 2:51 p.m., Itamar
://reviews.apache.org/r/32140/diff/
Testing
---
make check
Thanks,
Michael Park
/tests/master_validation_tests.cpp
c8742928a4e93e86ccd0f5a39856a65cfe8eb74f
Diff: https://reviews.apache.org/r/32150/diff/
Testing
---
make check
Thanks,
Michael Park
: https://reviews.apache.org/r/29748/diff/
Testing
---
make check
Thanks,
Michael Park
---
make check
Thanks,
Michael Park
7a06c7028eca8164b1f5fdea6a7ecd37ee6826bb
src/tests/reservation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29748/diff/
Testing
---
make check
Thanks,
Michael Park
:
https://reviews.apache.org/r/29748/#review76762
---
On March 18, 2015, 10:48 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On March 18, 2015, 12:29 a.m., Alexander Rukletsov wrote:
src/tests/reservation_tests.cpp, line 271
https://reviews.apache.org/r/29748/diff/7/?file=897374#file897374line271
Can we merge this test with the previous one?
Michael Park wrote:
By merge do you mean I can remove
/
Testing
---
make check
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32139/#review76764
---
On March 18, 2015, 7:43 p.m., Michael Park wrote
/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415
Diff: https://reviews.apache.org/r/32149/diff/
Testing
---
make check
Thanks,
Michael Park
c8742928a4e93e86ccd0f5a39856a65cfe8eb74f
Diff: https://reviews.apache.org/r/32150/diff/
Testing
---
make check
Thanks,
Michael Park
://reviews.apache.org/r/32140/diff/
Testing
---
make check
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32140/#review76752
---
On March 18, 2015, 7:44 p.m., Michael Park wrote
c8742928a4e93e86ccd0f5a39856a65cfe8eb74f
Diff: https://reviews.apache.org/r/32150/diff/
Testing
---
make check
Thanks,
Michael Park
/#review76752
---
On March 18, 2015, 7:44 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32140
/#review76837
---
On March 18, 2015, 7:46 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32150
with the unreserve ACLs. An optional `id` may be
introduced in the future as well.
Diffs
-
include/mesos/mesos.proto 9df972d750ce1e4a81d2e96cc508d6f83cad2fc8
Diff: https://reviews.apache.org/r/32139/diff/
Testing
---
make check
Thanks,
Michael Park
Diff: https://reviews.apache.org/r/32140/diff/
Testing
---
make check
Thanks,
Michael Park
/
Testing
---
make check
Thanks,
Michael Park
: MESOS-2477
https://issues.apache.org/jira/browse/MESOS-2477
Repository: mesos
Description
---
See summary.
Diffs
-
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
Diff: https://reviews.apache.org/r/32149/diff/
Testing
---
make check
Thanks,
Michael
src/master/validation.hpp 2d7416c053f82d6316542fa9c35b0e7bc605abec
src/master/validation.cpp 2f2e4ea8ea123c5a0d01446cdec8b308ea60932e
Diff: https://reviews.apache.org/r/32150/diff/
Testing
---
make check
Thanks,
Michael Park
/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
src/master/validation.hpp 2d7416c053f82d6316542fa9c35b0e7bc605abec
src/master/validation.cpp 2f2e4ea8ea123c5a0d01446cdec8b308ea60932e
Diff: https://reviews.apache.org/r/32150/diff/
Testing
---
make check
Thanks,
Michael Park
3059818231c46484039d179cd6916932eff6cd68
src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8
src/tests/reservation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29748/diff/
Testing
---
make check
Thanks,
Michael Park
---
make check
Thanks,
Michael Park
2c99b6884d7296099e19e2e3182cbe11b5e1e059
Diff: https://reviews.apache.org/r/32140/diff/
Testing
---
make check
Thanks,
Michael Park
/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1
src/master/validation.hpp 2d7416c053f82d6316542fa9c35b0e7bc605abec
src/master/validation.cpp 2f2e4ea8ea123c5a0d01446cdec8b308ea60932e
Diff: https://reviews.apache.org/r/32150/diff/
Testing
---
make check
Thanks,
Michael Park
+ iterations
`make check -j 8`
`./bin/mesos-tests.sh --gtest_shuffle`
Thanks,
Michael Park
./bin/mesos-tests.sh --gtest_repeat=-1` up to 500+ iterations
2. `make check -j 8`
3. `./bin/mesos-tests.sh --gtest_shuffle`
Thanks,
Michael Park
:
https://reviews.apache.org/r/31977/#review76218
---
On March 12, 2015, 7:53 a.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On March 12, 2015, 9:20 p.m., Ben Mahler wrote:
docs/mesos-c++-style-guide.md, line 30
https://reviews.apache.org/r/32001/diff/1/?file=892420#file892420line30
Hm, isn't this captured by ending each sentence with a period above?
Alexander Rukletsov wrote:
Yes and no. Trailing
://reviews.apache.org/r/31903/#comment123571
Realized that the Java test framework has a filter here but this one
doesn't. Do we want one here too? or is it more or less arbitrary?
- Michael Park
On March 10, 2015, 6:09 p.m., Jie Yu wrote
```
// Construct C++ Filters from Java Filters.
```
- Michael Park
On March 10, 2015, 12:07 a.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31873
On March 11, 2015, 9:38 p.m., Ben Mahler wrote:
src/master/http.cpp, line 471
https://reviews.apache.org/r/31700/diff/2/?file=888170#file888170line471
Do you know if a move is helpful here or if the compiler is already
optimizing this?
```
object.values[slaves]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31324/#review76183
---
LGTM.
- Michael Park
On March 12, 2015, 12:28 a.m., Niklas
/diff/
Testing
---
make check
Thanks,
Michael Park
---
make check
Thanks,
Michael Park
e2efb27b11dbea42dd73f81e5db0d6d2b0a6034b
src/tests/sorter_tests.cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd
Diff: https://reviews.apache.org/r/31667/diff/
Testing
---
make check
Thanks,
Michael Park
---
make check
Thanks,
Michael Park
/hierarchical.hpp
c0b1da75565d9dc7728c5566f01815234163fc47
src/tests/hierarchical_allocator_tests.cpp
93753d1c04159a04a733927a487eb69505438e32
Diff: https://reviews.apache.org/r/31183/diff/
Testing
---
make check
Thanks,
Michael Park
/mesos/hierarchical.hpp
c0b1da75565d9dc7728c5566f01815234163fc47
src/tests/hierarchical_allocator_tests.cpp
93753d1c04159a04a733927a487eb69505438e32
Diff: https://reviews.apache.org/r/31183/diff/
Testing
---
make check
Thanks,
Michael Park
---
On March 7, 2015, 10:08 a.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183
.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/#review75571
---
On March 7, 2015, 12:21 a.m., Michael Park wrote
/31665).
Diffs (updated)
-
include/mesos/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
Diff: https://reviews.apache.org/r/31664/diff/
Testing
---
make check
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183/#review75486
---
On March 3, 2015, 8:26 p.m., Michael Park wrote:
---
This is an automatically
/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
Diff: https://reviews.apache.org/r/31664/diff/
Testing
---
make check
Thanks,
Michael Park
---
make check
Thanks,
Michael Park
://reviews.apache.org/r/31665).
Diffs (updated)
-
include/mesos/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
Diff: https://reviews.apache.org/r/31664/diff/
Testing
---
make check
Thanks,
Michael Park
, 2015, 8:26 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183/
---
(Updated March 3, 2015, 8:26 p.m
://www.boost.org/doc/libs/1_57_0/libs/utility/operators.htm#symmetry
Michael Park wrote:
You're right. Will fix.
Done.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664/#review75452
., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31667/
---
(Updated March 3, 2015, 8:29 p.m.)
Review request
in
[r31665](https://reviews.apache.org/r/31665).
Diffs (updated)
-
include/mesos/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812
Diff: https://reviews.apache.org/r/31664/diff/
Testing
---
make check
Thanks,
Michael Park
.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31667/#review75561
---
On March 3, 2015, 8:29 p.m., Michael Park wrote
generated e-mail. To reply, visit:
https://reviews.apache.org/r/31666/#review75558
---
On March 3, 2015, 8:28 p.m., Michael Park wrote:
---
This is an automatically generated e-mail
---
On March 3, 2015, 8:27 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31664
On March 4, 2015, 4:13 a.m., Michael Park wrote:
I think there's value in keeping `JSON::Array` to have the symmetric
interface as `std::vector`.
Currently,
```cpp
JSON::Array array(N);
// array.values.size() == 0
```
The equivalent-looking pattern is deceiving
src/master/allocator/sorter/sorter.hpp
e2efb27b11dbea42dd73f81e5db0d6d2b0a6034b
src/tests/sorter_tests.cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd
Diff: https://reviews.apache.org/r/31667/diff/
Testing
---
make check
Thanks,
Michael Park
generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183/#review75011
---
On March 3, 2015, 8:26 p.m., Michael Park wrote:
---
This is an automatically generated e-mail
e2efb27b11dbea42dd73f81e5db0d6d2b0a6034b
src/tests/sorter_tests.cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd
Diff: https://reviews.apache.org/r/31667/diff/
Testing
---
make check
Thanks,
Michael Park
/31665).
Diffs (updated)
-
include/mesos/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
Diff: https://reviews.apache.org/r/31664/diff/
Testing
---
make check
Thanks,
Michael Park
/tests/hierarchical_allocator_tests.cpp
93753d1c04159a04a733927a487eb69505438e32
Diff: https://reviews.apache.org/r/31183/diff/
Testing
---
make check
Thanks,
Michael Park
/diff/
Testing
---
make check
Thanks,
Michael Park
://reviews.apache.org/r/31666/diff/
Testing
---
make check
Thanks,
Michael Park
On March 4, 2015, 4:13 a.m., Michael Park wrote:
I think there's value in keeping `JSON::Array` to have the symmetric
interface as `std::vector`.
Currently,
```cpp
JSON::Array array(N);
// array.values.size() == 0
```
The equivalent-looking pattern is deceiving
On March 4, 2015, 4:13 a.m., Michael Park wrote:
I think there's value in keeping `JSON::Array` to have the symmetric
interface as `std::vector`.
Currently,
```cpp
JSON::Array array(N);
// array.values.size() == 0
```
The equivalent-looking pattern is deceiving
library to keep:
```cpp
JSON::Array array;
array.reserve(N);
// array.values.size() == N
```
```cpp
std::vector v;
v.reserve(N);
// v.size() == N
```
- Michael Park
On March 3, 2015, 8:11 p.m., Alexander Rukletsov wrote
93753d1c04159a04a733927a487eb69505438e32
Diff: https://reviews.apache.org/r/31183/diff/
Testing
---
make check
Thanks,
Michael Park
117c0ee720a60a1d8a25359028bad803f1fc2b07
src/master/master.hpp ce0e0b3645b099d29c6d59312a91241379d5e80c
src/master/master.cpp dae0955d4ab29ea74ea5ab9dd6e19b028c58c6fd
Diff: https://reviews.apache.org/r/31665/diff/
Testing
---
make check
Thanks,
Michael Park
://reviews.apache.org/r/31666/#comment121753
We iterate through the `hashmapSlaveID, Resources` in
[r31667](https://reviews.apache.org/r/31667/) instead since that's where we
have `Sorter::add`, `Sorter::allocated`, etc, are augmented with `SlaveID`.
- Michael Park
On March 3, 2015, 7:38 a.m., Michael
Diff: https://reviews.apache.org/r/31667/diff/
Testing
---
make check
Thanks,
Michael Park
/resources.hpp da6d48871a0061d8bbf5e681dd6e7edac659d812
src/common/resources.cpp 2c99b6884d7296099e19e2e3182cbe11b5e1e059
Diff: https://reviews.apache.org/r/31664/diff/
Testing
---
make check
Thanks,
Michael Park
93753d1c04159a04a733927a487eb69505438e32
Diff: https://reviews.apache.org/r/31183/diff/
Testing
---
make check
Thanks,
Michael Park
c0b1da75565d9dc7728c5566f01815234163fc47
src/tests/hierarchical_allocator_tests.cpp
93753d1c04159a04a733927a487eb69505438e32
Diff: https://reviews.apache.org/r/31183/diff/
Testing
---
make check
Thanks,
Michael Park
dae0955d4ab29ea74ea5ab9dd6e19b028c58c6fd
src/tests/hierarchical_allocator_tests.cpp
93753d1c04159a04a733927a487eb69505438e32
src/tests/mesos.hpp e91e5e484eea4587ac8f2eb9cefeab4acc9f4615
Diff: https://reviews.apache.org/r/31666/diff/
Testing
---
make check
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183/#review74482
---
On Feb. 25, 2015, 1:16 a.m., Michael Park wrote:
---
This is an automatically
in `HierarchicalAllocator`?
Michael Park wrote:
I had considered this and pulled back on it because the call-sites
currently look like:
```cpp
foreachpair (const SlaveID slaveId, const Resources allocated, used) {
roleSorter-allocated(role, slaveId, allocated.unreserved
/r/30911/#review73743
---
On Feb. 24, 2015, 7:48 a.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30911
., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183/
---
(Updated Feb. 24, 2015, 9:07 a.m.)
Review request
., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30911/
---
(Updated Feb. 24, 2015, 7:48 a.m.)
Review request
---
make check
Thanks,
Michael Park
/master/validation.cpp e0936515d763a2cd3631a78062f66a304c0c0944
src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838
src/tests/resources_tests.cpp 4298d108e32758599a28097028cc03b6bd7febfc
Diff: https://reviews.apache.org/r/30911/diff/
Testing
---
make check
Thanks,
Michael Park
On Feb. 20, 2015, 12:16 a.m., Michael Park wrote:
src/master/http.cpp, lines 145-152
https://reviews.apache.org/r/31183/diff/2/?file=869987#file869987line145
It looks like I need to update the webui code to handle these changes.
For example, `framework.resources.cpus
42442353afe7bd3d1a5b43992f8ae191ac19bdcd
Diff: https://reviews.apache.org/r/31183/diff/
Testing
---
make check
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31183/#review73586
---
On Feb. 24, 2015, 11:27 a.m., Michael Park wrote
6b9656b2b858df75e725aaa042c447b755899c87
src/tests/sorter_tests.cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd
Diff: https://reviews.apache.org/r/31183/diff/
Testing
---
make check
Thanks,
Michael Park
60c70043c8266a422ffa03ab5a949da0bc822124
src/tests/sorter_tests.cpp 7ba32b78bdedf754f76f0695dfd1d86aa1f1b5bf
Diff: https://reviews.apache.org/r/31183/diff/
Testing
---
make check
Thanks,
Michael Park
This one was reverted, we're going to use ACLs and principals instead to
achieve this. Let's keep it out.
- Michael Park
On Feb. 23, 2015, 9:23 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit
301 - 400 of 837 matches
Mail list logo
