subject:"答复\: Request Mesos contributor role"

答复: 答复: Request Mesos contributor role

2016-01-24 Thread pangbingqiang

Hi,all:
  I have fix the Review Request #42288,please take a time to review, If have 
any question please me know.
  https://reviews.apache.org/r/42288/


-邮件原件-
发件人: pangbingqiang 
发送时间: 2016年1月22日 11:40
收件人: 'dev@mesos.apache.org'
主题: 答复: 答复: Request Mesos contributor role

Thanks, I have fix it, please review it. If have any problem please let me know.

-邮件原件-
发件人: pangbingqiang
发送时间: 2016年1月21日 12:24
收件人: dev
主题: 答复: 答复: Request Mesos contributor role

Thanks, I have fix it, please rereview it. If have any problem please let me 
know.

-邮件原件-
发件人: Adam Bordelon [mailto:a...@mesosphere.io]
发送时间: 2016年1月15日 15:17
收件人: dev
主题: Re: 答复: Request Mesos contributor role

Just run `git log` or `git log --oneline` for many more examples. :)

On Thu, Jan 14, 2016 at 11:15 PM, Adam Bordelon <a...@mesosphere.io> wrote:

> You'll need to shorten your commit summary, which is derived from the 
> 'Summary' field in ReviewBoard. You can put a longer description in 
> the 'Description' field, and it will also be included in the final 
> commit message (although not in the first line, which is restricted to 72 
> chars).
>
> Also, since the patch's summary ends up being the commit message, 
> please phrase it in terms of what you did to fix the problem, rather 
> than just restating the problem without a solution. For example:
> "Added timestamp to DockerContainerizer's ResourceStatistics."
>
> On Thu, Jan 14, 2016 at 4:36 AM, pangbingqiang 
> <pangbingqi...@huawei.com>
> wrote:
>
>> Thanks! Yeah, the hooks dir have a commit-msg file, so what I should 
>> do to fix this? The file line no more than 72 chars.
>>
>> -邮件原件-
>> 发件人: Benjamin Bannier [mailto:benjamin.bann...@mesosphere.io]
>> 发送时间: 2016年1月14日 20:20
>> 收件人: dev@mesos.apache.org
>> 主题: Re: Request Mesos contributor role
>>
>> Hi,
>>
>> >> Error:
>> >> 2016-01-14 09:19:38
>> >> URL:https://reviews.apache.org/r/42288/diff/raw/
>> >> [612/612] -> "42288.patch" [1] Total errors found: 0 Checking 1 
>> >> files
>> >> Error: Commit message summary (the first line) must not exceed 72
>> characters.
>> >
>> >> my patch first line is:
>> >> diff --git a/src/slave/containerizer/docker.cpp
>> >> b/src/slave/containerizer/docker.cpp
>> >
>> >> how could I to fix this?
>>
>> This refers to the commit message,
>>
>> Docker container REST API /monitor/statistics.json output have no 
>> timestamp field
>>
>> which is too long (I count 81 chars, but a hard max is put at 72 
>> chars); the same automated check also rejects commit summaries not 
>> ending in a period `.`. Additionally, a human reviewer will likely 
>> ask you to use past tense (e.g., “Fixed … for …”).
>>
>> If you rerun `bootstrap` from the project root it should install 
>> local git hooks so that the same checks are run locally on your 
>> machine while you develop.
>>
>>
>> HTH,
>>
>> Benjamin
>>
>
>

答复: 答复: Request Mesos contributor role

2016-01-21 Thread pangbingqiang

Thanks, I have fix it, please review it. If have any problem please let me know.

-邮件原件-
发件人: pangbingqiang 
发送时间: 2016年1月21日 12:24
收件人: dev
主题: 答复: 答复: Request Mesos contributor role

Thanks, I have fix it, please rereview it. If have any problem please let me 
know.

-邮件原件-
发件人: Adam Bordelon [mailto:a...@mesosphere.io]
发送时间: 2016年1月15日 15:17
收件人: dev
主题: Re: 答复: Request Mesos contributor role

Just run `git log` or `git log --oneline` for many more examples. :)

On Thu, Jan 14, 2016 at 11:15 PM, Adam Bordelon <a...@mesosphere.io> wrote:

> You'll need to shorten your commit summary, which is derived from the 
> 'Summary' field in ReviewBoard. You can put a longer description in 
> the 'Description' field, and it will also be included in the final 
> commit message (although not in the first line, which is restricted to 72 
> chars).
>
> Also, since the patch's summary ends up being the commit message, 
> please phrase it in terms of what you did to fix the problem, rather 
> than just restating the problem without a solution. For example:
> "Added timestamp to DockerContainerizer's ResourceStatistics."
>
> On Thu, Jan 14, 2016 at 4:36 AM, pangbingqiang 
> <pangbingqi...@huawei.com>
> wrote:
>
>> Thanks! Yeah, the hooks dir have a commit-msg file, so what I should 
>> do to fix this? The file line no more than 72 chars.
>>
>> -邮件原件-
>> 发件人: Benjamin Bannier [mailto:benjamin.bann...@mesosphere.io]
>> 发送时间: 2016年1月14日 20:20
>> 收件人: dev@mesos.apache.org
>> 主题: Re: Request Mesos contributor role
>>
>> Hi,
>>
>> >> Error:
>> >> 2016-01-14 09:19:38
>> >> URL:https://reviews.apache.org/r/42288/diff/raw/
>> >> [612/612] -> "42288.patch" [1] Total errors found: 0 Checking 1 
>> >> files
>> >> Error: Commit message summary (the first line) must not exceed 72
>> characters.
>> >
>> >> my patch first line is:
>> >> diff --git a/src/slave/containerizer/docker.cpp
>> >> b/src/slave/containerizer/docker.cpp
>> >
>> >> how could I to fix this?
>>
>> This refers to the commit message,
>>
>> Docker container REST API /monitor/statistics.json output have no 
>> timestamp field
>>
>> which is too long (I count 81 chars, but a hard max is put at 72 
>> chars); the same automated check also rejects commit summaries not 
>> ending in a period `.`. Additionally, a human reviewer will likely 
>> ask you to use past tense (e.g., “Fixed … for …”).
>>
>> If you rerun `bootstrap` from the project root it should install 
>> local git hooks so that the same checks are run locally on your 
>> machine while you develop.
>>
>>
>> HTH,
>>
>> Benjamin
>>
>
>

答复: 答复: Request Mesos contributor role

2016-01-20 Thread pangbingqiang

Thanks, I have fix it, please rereview it. If have any problem please let me 
know.

-邮件原件-
发件人: Adam Bordelon [mailto:a...@mesosphere.io] 
发送时间: 2016年1月15日 15:17
收件人: dev
主题: Re: 答复: Request Mesos contributor role

Just run `git log` or `git log --oneline` for many more examples. :)

On Thu, Jan 14, 2016 at 11:15 PM, Adam Bordelon <a...@mesosphere.io> wrote:

> You'll need to shorten your commit summary, which is derived from the 
> 'Summary' field in ReviewBoard. You can put a longer description in 
> the 'Description' field, and it will also be included in the final 
> commit message (although not in the first line, which is restricted to 72 
> chars).
>
> Also, since the patch's summary ends up being the commit message, 
> please phrase it in terms of what you did to fix the problem, rather 
> than just restating the problem without a solution. For example:
> "Added timestamp to DockerContainerizer's ResourceStatistics."
>
> On Thu, Jan 14, 2016 at 4:36 AM, pangbingqiang 
> <pangbingqi...@huawei.com>
> wrote:
>
>> Thanks! Yeah, the hooks dir have a commit-msg file, so what I should 
>> do to fix this? The file line no more than 72 chars.
>>
>> -邮件原件-
>> 发件人: Benjamin Bannier [mailto:benjamin.bann...@mesosphere.io]
>> 发送时间: 2016年1月14日 20:20
>> 收件人: dev@mesos.apache.org
>> 主题: Re: Request Mesos contributor role
>>
>> Hi,
>>
>> >> Error:
>> >> 2016-01-14 09:19:38 
>> >> URL:https://reviews.apache.org/r/42288/diff/raw/
>> >> [612/612] -> "42288.patch" [1] Total errors found: 0 Checking 1 
>> >> files
>> >> Error: Commit message summary (the first line) must not exceed 72
>> characters.
>> >
>> >> my patch first line is:
>> >> diff --git a/src/slave/containerizer/docker.cpp
>> >> b/src/slave/containerizer/docker.cpp
>> >
>> >> how could I to fix this?
>>
>> This refers to the commit message,
>>
>> Docker container REST API /monitor/statistics.json output have no 
>> timestamp field
>>
>> which is too long (I count 81 chars, but a hard max is put at 72 
>> chars); the same automated check also rejects commit summaries not 
>> ending in a period `.`. Additionally, a human reviewer will likely 
>> ask you to use past tense (e.g., “Fixed … for …”).
>>
>> If you rerun `bootstrap` from the project root it should install 
>> local git hooks so that the same checks are run locally on your 
>> machine while you develop.
>>
>>
>> HTH,
>>
>> Benjamin
>>
>
>

答复: Request Mesos contributor role

2016-01-14 Thread pangbingqiang

Thanks! Yeah, the hooks dir have a commit-msg file, so what I should do to fix 
this? The file line no more than 72 chars.

-邮件原件-
发件人: Benjamin Bannier [mailto:benjamin.bann...@mesosphere.io] 
发送时间: 2016年1月14日 20:20
收件人: dev@mesos.apache.org
主题: Re: Request Mesos contributor role

Hi,

>> Error:
>> 2016-01-14 09:19:38 URL:https://reviews.apache.org/r/42288/diff/raw/ 
>> [612/612] -> "42288.patch" [1] Total errors found: 0 Checking 1 files
>> Error: Commit message summary (the first line) must not exceed 72 characters.
> 
>> my patch first line is:
>> diff --git a/src/slave/containerizer/docker.cpp 
>> b/src/slave/containerizer/docker.cpp
> 
>> how could I to fix this?

This refers to the commit message,

Docker container REST API /monitor/statistics.json output have no timestamp 
field

which is too long (I count 81 chars, but a hard max is put at 72 chars); the 
same automated check also rejects commit summaries not ending in a period `.`. 
Additionally, a human reviewer will likely ask you to use past tense (e.g., 
“Fixed … for …”).

If you rerun `bootstrap` from the project root it should install local git 
hooks so that the same checks are run locally on your machine while you develop.


HTH,

Benjamin

Re: 答复: Request Mesos contributor role

2016-01-14 Thread Adam Bordelon

You'll need to shorten your commit summary, which is derived from the
'Summary' field in ReviewBoard. You can put a longer description in the
'Description' field, and it will also be included in the final commit
message (although not in the first line, which is restricted to 72 chars).

Also, since the patch's summary ends up being the commit message, please
phrase it in terms of what you did to fix the problem, rather than just
restating the problem without a solution. For example:
"Added timestamp to DockerContainerizer's ResourceStatistics."

On Thu, Jan 14, 2016 at 4:36 AM, pangbingqiang 
wrote:

> Thanks! Yeah, the hooks dir have a commit-msg file, so what I should do to
> fix this? The file line no more than 72 chars.
>
> -邮件原件-
> 发件人: Benjamin Bannier [mailto:benjamin.bann...@mesosphere.io]
> 发送时间: 2016年1月14日 20:20
> 收件人: dev@mesos.apache.org
> 主题: Re: Request Mesos contributor role
>
> Hi,
>
> >> Error:
> >> 2016-01-14 09:19:38 URL:https://reviews.apache.org/r/42288/diff/raw/
> >> [612/612] -> "42288.patch" [1] Total errors found: 0 Checking 1 files
> >> Error: Commit message summary (the first line) must not exceed 72
> characters.
> >
> >> my patch first line is:
> >> diff --git a/src/slave/containerizer/docker.cpp
> >> b/src/slave/containerizer/docker.cpp
> >
> >> how could I to fix this?
>
> This refers to the commit message,
>
> Docker container REST API /monitor/statistics.json output have no
> timestamp field
>
> which is too long (I count 81 chars, but a hard max is put at 72 chars);
> the same automated check also rejects commit summaries not ending in a
> period `.`. Additionally, a human reviewer will likely ask you to use past
> tense (e.g., “Fixed … for …”).
>
> If you rerun `bootstrap` from the project root it should install local git
> hooks so that the same checks are run locally on your machine while you
> develop.
>
>
> HTH,
>
> Benjamin
>

Re: 答复: Request Mesos contributor role

2016-01-14 Thread Adam Bordelon

Just run `git log` or `git log --oneline` for many more examples. :)

On Thu, Jan 14, 2016 at 11:15 PM, Adam Bordelon  wrote:

> You'll need to shorten your commit summary, which is derived from the
> 'Summary' field in ReviewBoard. You can put a longer description in the
> 'Description' field, and it will also be included in the final commit
> message (although not in the first line, which is restricted to 72 chars).
>
> Also, since the patch's summary ends up being the commit message, please
> phrase it in terms of what you did to fix the problem, rather than just
> restating the problem without a solution. For example:
> "Added timestamp to DockerContainerizer's ResourceStatistics."
>
> On Thu, Jan 14, 2016 at 4:36 AM, pangbingqiang 
> wrote:
>
>> Thanks! Yeah, the hooks dir have a commit-msg file, so what I should do
>> to fix this? The file line no more than 72 chars.
>>
>> -邮件原件-
>> 发件人: Benjamin Bannier [mailto:benjamin.bann...@mesosphere.io]
>> 发送时间: 2016年1月14日 20:20
>> 收件人: dev@mesos.apache.org
>> 主题: Re: Request Mesos contributor role
>>
>> Hi,
>>
>> >> Error:
>> >> 2016-01-14 09:19:38 URL:https://reviews.apache.org/r/42288/diff/raw/
>> >> [612/612] -> "42288.patch" [1] Total errors found: 0 Checking 1 files
>> >> Error: Commit message summary (the first line) must not exceed 72
>> characters.
>> >
>> >> my patch first line is:
>> >> diff --git a/src/slave/containerizer/docker.cpp
>> >> b/src/slave/containerizer/docker.cpp
>> >
>> >> how could I to fix this?
>>
>> This refers to the commit message,
>>
>> Docker container REST API /monitor/statistics.json output have no
>> timestamp field
>>
>> which is too long (I count 81 chars, but a hard max is put at 72 chars);
>> the same automated check also rejects commit summaries not ending in a
>> period `.`. Additionally, a human reviewer will likely ask you to use past
>> tense (e.g., “Fixed … for …”).
>>
>> If you rerun `bootstrap` from the project root it should install local
>> git hooks so that the same checks are run locally on your machine while you
>> develop.
>>
>>
>> HTH,
>>
>> Benjamin
>>
>
>

Re: 答复: Request Mesos contributor role

2016-01-14 Thread Guangya Liu

You can also take a look at following link to get more detail:
https://github.com/apache/mesos/blob/master/docs/submitting-a-patch.md
https://github.com/apache/mesos/blob/master/docs/effective-code-reviewing.md

The last one is from OpenStack git commit, you can also take it as a
reference:
https://wiki.openstack.org/wiki/GitCommitMessages


On Fri, Jan 15, 2016 at 3:16 PM, Adam Bordelon  wrote:

> Just run `git log` or `git log --oneline` for many more examples. :)
>
> On Thu, Jan 14, 2016 at 11:15 PM, Adam Bordelon 
> wrote:
>
> > You'll need to shorten your commit summary, which is derived from the
> > 'Summary' field in ReviewBoard. You can put a longer description in the
> > 'Description' field, and it will also be included in the final commit
> > message (although not in the first line, which is restricted to 72
> chars).
> >
> > Also, since the patch's summary ends up being the commit message, please
> > phrase it in terms of what you did to fix the problem, rather than just
> > restating the problem without a solution. For example:
> > "Added timestamp to DockerContainerizer's ResourceStatistics."
> >
> > On Thu, Jan 14, 2016 at 4:36 AM, pangbingqiang  >
> > wrote:
> >
> >> Thanks! Yeah, the hooks dir have a commit-msg file, so what I should do
> >> to fix this? The file line no more than 72 chars.
> >>
> >> -邮件原件-
> >> 发件人: Benjamin Bannier [mailto:benjamin.bann...@mesosphere.io]
> >> 发送时间: 2016年1月14日 20:20
> >> 收件人: dev@mesos.apache.org
> >> 主题: Re: Request Mesos contributor role
> >>
> >> Hi,
> >>
> >> >> Error:
> >> >> 2016-01-14 09:19:38 URL:https://reviews.apache.org/r/42288/diff/raw/
> >> >> [612/612] -> "42288.patch" [1] Total errors found: 0 Checking 1 files
> >> >> Error: Commit message summary (the first line) must not exceed 72
> >> characters.
> >> >
> >> >> my patch first line is:
> >> >> diff --git a/src/slave/containerizer/docker.cpp
> >> >> b/src/slave/containerizer/docker.cpp
> >> >
> >> >> how could I to fix this?
> >>
> >> This refers to the commit message,
> >>
> >> Docker container REST API /monitor/statistics.json output have no
> >> timestamp field
> >>
> >> which is too long (I count 81 chars, but a hard max is put at 72 chars);
> >> the same automated check also rejects commit summaries not ending in a
> >> period `.`. Additionally, a human reviewer will likely ask you to use
> past
> >> tense (e.g., “Fixed … for …”).
> >>
> >> If you rerun `bootstrap` from the project root it should install local
> >> git hooks so that the same checks are run locally on your machine while
> you
> >> develop.
> >>
> >>
> >> HTH,
> >>
> >> Benjamin
> >>
> >
> >
>

答复: 答复: Request Mesos contributor role

答复: 答复: Request Mesos contributor role

答复: 答复: Request Mesos contributor role

答复: Request Mesos contributor role

Re: 答复: Request Mesos contributor role

Re: 答复: Request Mesos contributor role

Re: 答复: Request Mesos contributor role

7 matches

Site Navigation

Mail list logo

Footer information