答复: 答复: Request Mesos contributor role

Hi,all: I have fix the Review Request #42288,please take a time to review, If have any question please me know. https://reviews.apache.org/r/42288/ -邮件原件- 发件人: pangbingqiang 发送时间: 2016年1月22日 11:40 收件人: 'dev@mesos.apache.org' 主题: 答复: 答复: Request Mesos contributor role Thanks, I

答复: 答复: Request Mesos contributor role

Thanks, I have fix it, please review it. If have any problem please let me know. -邮件原件- 发件人: pangbingqiang 发送时间: 2016年1月21日 12:24 收件人: dev 主题: 答复: 答复: Request Mesos contributor role Thanks, I have fix it, please rereview it. If have any problem please let me know. -邮件原件- 发件人

答复: 答复: Request Mesos contributor role

Thanks, I have fix it, please rereview it. If have any problem please let me know. -邮件原件- 发件人: Adam Bordelon [mailto:a...@mesosphere.io] 发送时间: 2016年1月15日 15:17 收件人: dev 主题: Re: 答复: Request Mesos contributor role Just run `git log` or `git log --oneline` for many more examples

答复: Request Mesos contributor role

Thanks! Yeah, the hooks dir have a commit-msg file, so what I should do to fix this? The file line no more than 72 chars. -邮件原件- 发件人: Benjamin Bannier [mailto:benjamin.bann...@mesosphere.io] 发送时间: 2016年1月14日 20:20 收件人: dev@mesos.apache.org 主题: Re: Request Mesos contributor role Hi, >>

Re: 答复: Request Mesos contributor role

You'll need to shorten your commit summary, which is derived from the 'Summary' field in ReviewBoard. You can put a longer description in the 'Description' field, and it will also be included in the final commit message (although not in the first line, which is restricted to 72 chars). Also,

Re: 答复: Request Mesos contributor role

Just run `git log` or `git log --oneline` for many more examples. :) On Thu, Jan 14, 2016 at 11:15 PM, Adam Bordelon wrote: > You'll need to shorten your commit summary, which is derived from the > 'Summary' field in ReviewBoard. You can put a longer description in the >

Re: 答复: Request Mesos contributor role

You can also take a look at following link to get more detail: https://github.com/apache/mesos/blob/master/docs/submitting-a-patch.md https://github.com/apache/mesos/blob/master/docs/effective-code-reviewing.md The last one is from OpenStack git commit, you can also take it as a reference: