Question on adding commit hook to enforce leading whitespace in comments

2015-12-21 Thread Avinash Sridharan
As a newbie to Apache mesos project I have run into issues of missing whitespace in comments during reviews. Hence, wanted to see if we can add a commit hook to detect this style violation and enforce it by not allowing the commit to go through. Accordingly have created a JIRA (

Re: Question on adding commit hook to enforce leading whitespace in comments

2015-12-21 Thread Adam Bordelon
a) +1 to new cpplint rule for single space after "//" b) I'd vote for single-space before the comment too. I haven't seen anybody do double-spaces in Mesos. The only exception to the single-space rule would be places where we try to align trailing comments. Not sure if we want to continue to allow