Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/165
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/165
Thank you for the review. And sorry for the needless diffs. But now that
things are straightened out, I'll merge ;-)
---
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148438583
--- Diff:
core/src/test/java/org/apache/metamodel/QueryPostprocessDataContextTest.java ---
@@ -60,6 +60,49 @@
private final Table table1
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/128
I've been looking a bit more, and it seems that ANSI SQL does not specify
anything here. PostgreSQL and MS SQL use the behaviour you describe, whereas
Oracle and MySQL return floating
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/128
I'm not saying that I want to return a BigDecimal. Rather I'm saying that
the test isn't correct in my opinion. Rounding a double down to the nearest
integer is doable when wanted. But the
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148367755
--- Diff:
core/src/test/java/org/apache/metamodel/QueryPostprocessDataContextTest.java ---
@@ -60,6 +60,49 @@
private final Table table1 =
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148367081
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -458,15 +459,18 @@ protected String getDefaultSchemaName() throws
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/165
In the one I looked at (QueryPostProcessessDataContext.java), the actual
changes were around 10-15 lines (a little more with the since-introduced
JavaDoc), out of 175 lines changed total, in a 700
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148356156
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -63,24 +64,29 @@
import org.slf4j.LoggerFactory;
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/128
Part of the point is it _should_ always round down when you're using
integers. You're changing the type _and_ the behaviour.
Anyway, it still doesn't fix the base problem with unwanted type
10 matches
Mail list logo
