Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/156
Hey @tomatophantastico, all,
I made https://github.com/tomatophantastico/metamodel/pull/2 some time ago
to help you fix some of the merge conflicts and minor issues. Are you still
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/156
Ah, that might be.
---
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/156
I don't think we can just do that. ASF owns the Travis instance and the
builds are only automatically triggered AFAIK.
---
Github user tomatophantastico commented on the issue:
https://github.com/apache/metamodel/pull/156
First, at this moment i do not see a merit in voting about complexity rules:
As long as there is no one out there who wants to do refactor those massive
amounts if code to fit those
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/156
(Of course, there's a chance that checkstyle fixed the lambda thing since I
checked)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/156
Makes sense!
Though some of them are hard. E.g. indentation because checkstyle doesn't
understand lambda expressions, so you can't get it to agree with the
formatters. So I'd have to vote
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/156
I understand your point and respectfully disagree :-) BUT I do think it is
worthy of a VOTE on the mailing list! So how about we organize a vote where we
list these various checks and let
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/156
Or we could omit having any rules about imports? I mean, it's never in the
imports section that I find anything hard to compare when looking at diffs. So
even if it goes
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/156
@kaspersorensen Regarding explaining settings, we could just export the
formatting rules from the IDEs, and explain in CONTRIBUTE.md to use those. At
least Eclipse and IntelliJ has that option.
Github user tomatophantastico commented on the issue:
https://github.com/apache/metamodel/pull/156
minimum set is a good idea. I used intellij idea and i am not to terribly
familiar with it yet, so this contributed to not so clean commits.
Can we collect some issues regarding
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/156
My opinion of checkstyle is a bit mixed. Essentially I feel that there is a
pitfall which is that it makes it hard for people to contribute good code if
their tool has very minor
Github user tomatophantastico commented on the issue:
https://github.com/apache/metamodel/pull/156
More interestingly: Which rules should be employed?
What are the current rules?
Is a switch to google/sun rules an option?
---
If your project is set up for it, you can reply
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/156
I'm a big fan of using CheckStyle (but not that there's apparently no
GitHub integration to be found. :disappointed:), so I'm all for it. Also for
more aggressive rules.
---
If your project is
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/156
Travis failure seems unrelated. Cassandra startup timed out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
14 matches
Mail list logo
