[GitHub] metron pull request #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-20 Thread mattf-horton
Github user mattf-horton commented on a diff in the pull request: https://github.com/apache/metron/pull/622#discussion_r128650596 --- Diff: metron-analytics/metron-profiler-common/src/main/java/org/apache/metron/profiler/hbase/SaltyRowKeyBuilder.java --- @@ -81,20 +99,19 @@

[GitHub] metron issue #577: METRON-746: Build Custom Checkstyle and IDE formatting se...

2017-07-20 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/577 As a note, I moved the checkstyle version up to 8 and will update the instructions. @mmiklavc This'll be relevant if you look through anything. I don't know that it'll break on 7.7,

[GitHub] metron pull request #654: METRON-1044: Disabled writers are not acking messa...

2017-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/654 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron issue #577: METRON-746: Build Custom Checkstyle and IDE formatting se...

2017-07-20 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/577 Hey @justinleet, apologies for this slipping between the cracks. I'll run this again and see if there's anything specific I can find. --- If your project is set up for it, you can reply to this

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/622 I want to point out that I am also in favor of an audit log for the profiler, but I don't think it's a complete solution for the batch analytics use-case. --- If your project is set up for it,

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/622 Also, while we're in here, is there a strong reason why the prefixed hash is so large? It's just there for uniformity of distribution, correct? I'd propose a non-cryptographic hash for this

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/622 So, in my mind the feature here is the enablement of batch analytics on the profiles. To that end, I'm in general in favor of a decodable row key. I think that the question really isn't a ToC *or*

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-20 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/622 Let me take a look at this more deeply. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] metron issue #577: METRON-746: Build Custom Checkstyle and IDE formatting se...

2017-07-20 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/577 @mmiklavc Any response to the above? I'm also happy to take a look through what you set up and see if there's anything missing in the instructions and so on, if that would help. --- If your

[GitHub] metron issue #656: METRON-1050 Improve Docs of 'profile.period.duration'

2017-07-20 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/656 Thanks @mattf-horton ! That fixed the links. Everything looks good to me. Please take a look guys. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] metron issue #622: METRON-1005 Create Decodable Row Key for Profiler

2017-07-20 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/622 > I don't think our current row key is totally opaque, it just needs a brute-force approach to figure out. Not suitable for interactive queries, but would be acceptable for a one-time pass to

[GitHub] metron issue #614: METRON-992: Create performance tuning guide

2017-07-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/614 +1 by inspection; this is right on the money and a good first pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] metron issue #654: METRON-1044: Disabled writers are not acking messages

2017-07-20 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/654 +1 by inspection, thaks for the test case update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron issue #656: METRON-1050 Improve Docs of 'profile.period.duration'

2017-07-20 Thread mattf-horton
Github user mattf-horton commented on the issue: https://github.com/apache/metron/pull/656 @nickwallen , you found a Github/Doxia difference not previously noticed! Please apply the following patch to site-book/bin/fix-md-dialect.py, and commit it with your docs improvements :

[GitHub] metron issue #580: METRON-942 [NO MERGE UNTIL METRON-777] Rest api and confi...

2017-07-20 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/580 I have changed the PR description and steps to reflect that uninstalling the extension no longer stops the kafka and storm jobs --- If your project is set up for it, you can reply to this

[GitHub] metron issue #481: METRON-322 Global Batching and Flushing

2017-07-20 Thread dlyle65535
Github user dlyle65535 commented on the issue: https://github.com/apache/metron/pull/481 My test environment is being funky, I'm +1 by inspection- thanks for the work, please don't let me hold you up any more. --- If your project is set up for it, you can reply to this email and

[GitHub] metron issue #656: METRON-1050 Improve Docs of 'profile.period.duration'

2017-07-20 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/656 Thanks @mattf-horton . That works for some of the links. It does not seem to work for links with a period in them. Based on Github's rendering, for names with periods I have to drop

[GitHub] metron pull request #636: METRON-1022: Elasticsearch REST endpoint

2017-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/636 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is