[GitHub] metron pull request #788: METRON-1223: Support for adding comments to alerts

2017-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/788 ---

[GitHub] metron pull request #799: METRON-1249 Improve Metron MPack service checks

2017-10-13 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/799 METRON-1249 Improve Metron MPack service checks This PR enhances the Metron 'Service Check' functionality in the MPack. The Service Check is an easy way for a user to know if their Metron

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/710 @nickwallen we can make the fields configurable too. ---

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/710 +1 That works for me. This is a good first pass. Taking care of METRON-1250 would totally side step a probably contentious (and unwinnable) debate as to what the most important fields are. :)

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread james-sirota
Github user james-sirota commented on the issue: https://github.com/apache/metron/pull/710 Ok, I opened https://issues.apache.org/jira/browse/METRON-1250 as a follow on jira for this ---

[GitHub] metron issue #768: Metron 1123: Add group by option using faceted search cap...

2017-10-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/768 @iraghumitra In case you missed it, there are some new merge conflicts based on one of your other PRs being merged into master today. ---

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/710 Everything else is looking really good though, @iraghumitra . * The way that the UI it is laid out is obvious and intuitive. * I manually tested the faceted functionality and all the

[GitHub] metron pull request #768: Metron 1123: Add group by option using faceted sea...

2017-10-13 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/768#discussion_r144644294 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts --- @@ -0,0 +1,319 @@ +/** + * Licensed to

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/710 > A new facet pane is added to GUI that groups data based on the following 'hard coded' fields ('source:type', 'ip_src_addr', 'ip_dst_addr', 'host', 'enrichments:geo:ip_dst_addr:country')

[GitHub] metron pull request #768: Metron 1123: Add group by option using faceted sea...

2017-10-13 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/768#discussion_r144639257 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts --- @@ -0,0 +1,319 @@ +/** + * Licensed to

Re: [DISCUSS] Build broken due to transitive dependencies

2017-10-13 Thread Ryan Merriman
We recently ran into this and the cause was an old C++ compiler version. It wants a compiler that has support for C++11: https://gcc.gnu.org/projects/cxx-status.html#cxx11. On Fri, Oct 13, 2017 at 1:00 PM, Laurens Vets wrote: > ... > [INFO] --- frontend-maven-plugin:1.3:npm

Re: [DISCUSS] Build broken due to transitive dependencies

2017-10-13 Thread Michael Miklavcic
[INFO] Cannot find module 'tough-cookie' - It's as if the build has become sentient and now mocks us On Fri, Oct 13, 2017 at 12:00 PM, Laurens Vets wrote: > ... > [INFO] --- frontend-maven-plugin:1.3:npm (ng build) @ metron-config --- > [DEBUG] Configuring mojo

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/710 Hi @iraghumitra - The commit history looks a little odd. There are commits going back a few months and seem unrelated to this PR. Can you double check that the code that you have submitted is

[GitHub] metron pull request #798: METRON-1247: REST search and findOne endpoints ret...

2017-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/798 ---

[GitHub] metron issue #798: METRON-1247: REST search and findOne endpoints return une...

2017-10-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/798 +1 by inspection, good job! ---