[GitHub] metron pull request #808: METRON-1267: Alerts UI returns a 404 when refreshi...

GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/808 METRON-1267: Alerts UI returns a 404 when refreshing the alerts-list page ## Contributor Comments This PR fixes a small bug that causes a 404 when refreshing the front Alerts UI list page.

[GitHub] metron issue #803: Metron-1252: Build ui for grouping alerts into meta alert...

Github user james-sirota commented on the issue: https://github.com/apache/metron/pull/803 You should not have empty meta alerts. That does not make sense ---

[GitHub] metron issue #803: Metron-1252: Build ui for grouping alerts into meta alert...

Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/803 I did an initial review of this and I see several things we need to work through. It's a pretty significant feature so that's not surprising. I know there are some other PRs being worked on that

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145816832 --- Diff: metron-interface/metron-alerts/src/app/alerts/alerts-list/table-view/table-view.component.scss --- @@ -24,4 +24,12 @@

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145816633 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.html --- @@ -0,0 +1,48 @@ + + + + +

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145816548 --- Diff: metron-interface/metron-alerts/src/styles.scss --- @@ -259,4 +259,61 @@ hr { padding: 0; } - +/** Custom Radio box **/

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145816388 --- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts --- @@ -38,22 +41,27 @@ export class UpdateService {

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145816267 --- Diff: metron-interface/metron-alerts/src/app/service/update.service.ts --- @@ -38,22 +41,27 @@ export class UpdateService {

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145814896 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145814193 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145813076 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145811869 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.module.ts --- @@ -0,0 +1,14 @@ +import { NgModule } from

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145810773 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145809924 --- Diff: metron-interface/metron-alerts/src/app/utils/constants.ts --- @@ -27,5 +30,5 @@ export const ALERTS_COLUMN_NAMES = 'metron-alerts-column-names';

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145809831 --- Diff: metron-interface/metron-alerts/src/app/utils/constants.ts --- @@ -18,6 +18,9 @@ import {environment} from

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145809660 --- Diff: metron-interface/metron-alerts/src/app/alerts/meta-alerts/meta-alerts.component.ts --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] metron pull request #803: Metron-1252: Build ui for grouping alerts into met...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/803#discussion_r145809162 --- Diff: metron-interface/metron-alerts/e2e/alerts-list/tree-view/tree-view.e2e-spec.ts --- @@ -175,7 +175,7 @@ describe('metron-alerts tree view',

Re: [DISCUSS] Build broken due to transitive dependencies

Haha you're too kind Laurens. Glad that was it. On Thu, Oct 19, 2017 at 8:30 AM, Nick Allen wrote: > Thanks for testing the suggested fix, Laurens. I created METRON-1265 so we > can get this dependency doc'd. > > https://issues.apache.org/jira/browse/METRON-1265 > > On

[GitHub] metron issue #796: METRON-1224: Add time range selection to search control

Github user cestella commented on the issue: https://github.com/apache/metron/pull/796 I definitely like the testing section @merrimanr I'd like to see the test in existence in the PR split into the test cases that you suggest. Testing those time range quicklinks turn into sensible

[GitHub] metron issue #796: METRON-1224: Add time range selection to search control

Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/796 I tested this as well. First a couple things I'm curious about: - when I open the date/time range picker why does it say "now/d"? I would expect just "now" or "Now" - when I first

[GitHub] metron pull request #807: METRON-1263: Start Alerts UI service after Metron ...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/807 ---

[GitHub] metron issue #807: METRON-1263: Start Alerts UI service after Metron REST

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/807 +1, Thanks @anandsubbu I ran it up and checked that proper order was maintained when restarting all services and performing service checks. ---

[GitHub] metron pull request #807: METRON-1263: Start Alerts UI service after Metron ...

Github user anandsubbu commented on a diff in the pull request: https://github.com/apache/metron/pull/807#discussion_r145701351 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/addon-services/METRON/CURRENT/role_command_order.json --- @@ -13,16 +13,18

Re: [DISCUSS] Build broken due to transitive dependencies

Thanks for testing the suggested fix, Laurens. I created METRON-1265 so we can get this dependency doc'd. https://issues.apache.org/jira/browse/METRON-1265 On Wed, Oct 18, 2017 at 11:55 AM, Laurens Vets wrote: > I was hesitant to believe Ryan that this was a compiler issue,

[GitHub] metron pull request #807: METRON-1263: Start Alerts UI service after Metron ...

Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/807#discussion_r145695585 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/addon-services/METRON/CURRENT/role_command_order.json --- @@ -13,16 +13,18

[GitHub] metron issue #754: METRON-1184 EC2 Deployment - Updating control_path to acc...

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/754 @JonZeolla What do you think about this one? I remember you fought this specific issue a few months back. ---

[GitHub] metron pull request #807: METRON-1263: Start Alerts UI service after Metron ...

GitHub user anandsubbu opened a pull request: https://github.com/apache/metron/pull/807 METRON-1263: Start Alerts UI service after Metron REST ## Contributor Comments Currently the Alerts UI service starts up before any of the Metron services does. Ideally, it should be started