GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/899
METRON-1405: Add Boyer-Moore majority vote algorithm to Stellar
## Contributor Comments
Addresses https://issues.apache.org/jira/browse/METRON-1405
A proper majority requires 2
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/865
@ottobackwards , I'll try to refresh my review this weekend.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/879
+0
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/879
haha @ottobackwards neutral would be a +0, which is fine. Thanks for your
constructive comments on the discuss thread and here. As always, they're much
appreciated. :)
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/879
I'm not getting in front of the train on this.
I am neutral on this other than my comments to help the conversation and
attempt to focus things.
I don't know how to enter "don't
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/879
Ok, @justinleet has given a +1, do we have any existing reservations after
the discussion thread and the review here on this work? If not, then I'm going
to commit on Monday.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
This is really good work @nickwallen. I am +1 on this, but would like to
see jiras on the next steps entered if possible as a side note.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/894
fwiw, this service check also fails in full dev. Git history shows me as
creating the file because I moved the entire directory (5.6.2 name change) as
part of the ES upgrade, but this code hasn't
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/894
Oh, I see what that is. This appears to be a neglected piece of code. ES
has this but Kibana does not, for instance. The metainfo.xml allows you to add
"commandScript" items that are listed in the
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/894
@anandsubbu did this ever work with CentOS 7 from Apache master? I didn't
touch that service_check.py file, and furthermore I see there are hardcoded
ports for ES.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
Do we have jiras for the next steps on this yet? I would be good if we
recored our intent, and who knows, maybe someone will want to work on it.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/865
__**BUMP**__
@nickwallen , @mmiklavc , @cestella : leaving a breadcrumb so you can
follow the PR to here. This is now a feature branch and is broken up as you
requested, so it is the
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r161240685
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java
---
@@ -0,0
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/888#discussion_r161240092
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
---
@@
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r161239454
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java
---
@@
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/888#discussion_r161239480
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
---
@@
GitHub user MohanDV reopened a pull request:
https://github.com/apache/metron/pull/898
METRON-1398:Exclude the basic-error-controller from being added to the
swagger description
## Contributor Comments
We need to exclude the basic-error-controller and
Github user MohanDV closed the pull request at:
https://github.com/apache/metron/pull/898
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/884
> Is the plan to deploy the jar file in the interpreter directory like the
other interpreters?
I don't know what that is going to look like. We need to do more research
to see how the
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r161236049
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/validation/StellarZookeeperBasedValidator.java
---
@@ -0,0
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/884
Is the plan to deploy the jar file in the interpreter directory like the
other interpreters?
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/896
---
GitHub user MohanDV opened a pull request:
https://github.com/apache/metron/pull/898
METRON-1398:Exclude the basic-error-controller from being added to the
swagger description
## Contributor Comments
We need to exclude the basic-error-controller and
GitHub user MohanDV opened a pull request:
https://github.com/apache/metron/pull/897
METRON-1395:Documentation missing for Produce a message to a Kafka topic
Rest API endpoint
## Contributor Comments
Added documentation for produce a message to a Kafka topic Rest API endpoint
Github user anandsubbu commented on a diff in the pull request:
https://github.com/apache/metron/pull/894#discussion_r161185438
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/5.6.2/package/scripts/elastic_slave.py
---
@@
Github user anandsubbu commented on a diff in the pull request:
https://github.com/apache/metron/pull/894#discussion_r161185471
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/KIBANA/5.6.2/package/scripts/kibana_master.py
---
@@ -93,7
Github user anandsubbu commented on a diff in the pull request:
https://github.com/apache/metron/pull/894#discussion_r161184707
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/ELASTICSEARCH/5.6.2/package/scripts/elastic_master.py
---
27 matches
Mail list logo
