[GitHub] metron issue #814: METRON-1277 Add match statement to Stellar language

2017-11-29 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/814 once travis build completes successfully this looks good +1. ---

[GitHub] metron issue #814: METRON-1277 Add match statement to Stellar language

2017-11-29 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/814 @ottobackwards this looks good to me now. I re-built everything, ran the tests, and played around in stellar shell. The only question I'm still not sure about is the one that deals with backwards

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-11-21 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r152456690 --- Diff: metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4 --- @@ -254,6 +259,7 @@ identifier_operand

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-11-05 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r148965731 --- Diff: metron-stellar/stellar-common/README.md --- @@ -100,6 +102,28 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron issue #814: METRON-1277 Add match statement to Stellar language

2017-11-05 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/814 @ottobackwards something is still going on with this. I'm seeing the following behavior: ```bash [Stellar]>>> foo := 500 [Stellar]>>> match{ foo > 100 => ['o

[GitHub] metron issue #814: METRON-1277 Add match statement to Stellar language

2017-10-28 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/814 Also, I don't think there is an issue with the map function directly. It's actually an issue with the logical_expression `var1` and using/not using a `default` branch. It seems like the stack isn't

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-10-28 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r147557283 --- Diff: metron-stellar/stellar-common/README.md --- @@ -100,6 +102,28 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-10-28 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r147556465 --- Diff: metron-stellar/stellar-common/README.md --- @@ -100,6 +102,28 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-10-28 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r147544977 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/MatchTest.java --- @@ -0,0 +1,202

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-10-28 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r147543792 --- Diff: metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4 --- @@ -67,6 +67,10 @@ ELSE : 'ELSE' | 'else

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-10-28 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r147555077 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/MatchTest.java --- @@ -0,0 +1,202

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-10-28 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r147543426 --- Diff: metron-stellar/stellar-common/README.md --- @@ -100,6 +102,28 @@ In the core language functions, we support basic functional programming primitiv

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-10-28 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r147544129 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/MatchTest.java --- @@ -0,0 +1,202

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-10-28 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r147556583 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/StellarCompiler.java --- @@ -105,59 +107,77 @@ public Object apply

[GitHub] metron pull request #814: METRON-1277 Add match statement to Stellar languag...

2017-10-28 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/814#discussion_r147556836 --- Diff: metron-stellar/stellar-common/src/main/antlr4/org/apache/metron/stellar/common/generated/Stellar.g4 --- @@ -272,4 +278,30 @@ lambda_variable

[GitHub] metron pull request #650: METRON-1038: Stellar should have a better collecti...

2017-08-02 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/650#discussion_r130885709 --- Diff: metron-stellar/stellar-common/README.md --- @@ -101,58 +101,69 @@ In the core language functions, we support basic functional programming

[GitHub] metron issue #652: METRON-1039: Add ZIP function to Stellar

2017-07-21 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/652 @cestella open ticket for ZIP_WITH and ZIP_WITH_INDEX. To make sure we are on the same page for ZIP_WITH_INDEX, can you skim over the jira when you have time? --- If your project is set up

[GitHub] metron issue #657: METRON-1048 Intermittent Test Failure for SimpleHBaseEnri...

2017-07-18 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/657 @nickwallen out of curiosity, what do you think about just deleting these tests? I think the logging they are testing is great, but I don't think these are really needed. --- If your project

[GitHub] metron issue #652: METRON-1039: Add ZIP function to Stellar

2017-07-18 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/652 @cestella I will create a Jira for it and reference the above link. I agree that this ticket isn't the best place to implement this. --- If your project is set up for it, you can reply

[GitHub] metron issue #652: METRON-1039: Add ZIP function to Stellar

2017-07-13 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/652 @cestella I was wondering what you think about having a zip function that we could pass a lambda to. It could potentially be nicer to read than combining a `ZIP` with a `REDUCE

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126841963 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java --- @@ -0,0 +1,169

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126838847 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java --- @@ -0,0 +1,169

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-11 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126838736 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java --- @@ -0,0 +1,169

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-10 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126589803 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/HashFunctions.java --- @@ -0,0 +1,85

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-10 Thread jjmeyer0
Github user jjmeyer0 commented on a diff in the pull request: https://github.com/apache/metron/pull/641#discussion_r126524234 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java --- @@ -0,0 +1,169

[GitHub] metron pull request #641: METRON-539: added HASH function for stellar.

2017-07-10 Thread jjmeyer0
GitHub user jjmeyer0 opened a pull request: https://github.com/apache/metron/pull/641 METRON-539: added HASH function for stellar. ## Contributor Comments Added a hash function to stellar. Many unit tests were created. Along with these tests I opened the Stellar terminal

[GitHub] metron issue #633: METRON-1008: Updating travis to use trusty, moved install...

2017-07-05 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/633 Quote from @justinleet > I'd be inclined towards avoiding splitting the build if we were only getting a couple minutes out of it. I'm a little worried about being able to get three sl

[GitHub] metron pull request #633: METRON-1008: Updating travis to use trusty, moved ...

2017-07-05 Thread jjmeyer0
GitHub user jjmeyer0 opened a pull request: https://github.com/apache/metron/pull/633 METRON-1008: Updating travis to use trusty, moved install to install … …step, moved verify license to earlier step, and added .npm to cache. ## Contributor Comments

[GitHub] metron issue #632: METRON-1008: Updating travis to use trusty

2017-07-05 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/632 Unfortunately I will have to open a new PR. I squashed my commits when this PR was closed. Github doesn't allow to reopen PRs when force pushes occur when the PR is closed. @justinleet

[GitHub] metron issue #632: METRON-1008: Updating travis to use trusty

2017-07-05 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/632 @JonZeolla that was a squashed commit that was probably a typo. I'll remove it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metron pull request #632: METRON-1008: Updating travis to use trusty

2017-07-05 Thread jjmeyer0
GitHub user jjmeyer0 reopened a pull request: https://github.com/apache/metron/pull/632 METRON-1008: Updating travis to use trusty ….npm to cache. Added some more cacheing from 1004 ticket. Revert some changes. Reverted environment and put maven opts

[GitHub] metron pull request #632: METRON-1008: Updating travis to use trusty

2017-07-05 Thread jjmeyer0
Github user jjmeyer0 closed the pull request at: https://github.com/apache/metron/pull/632 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] metron pull request #632: METRON-1008: Updating travis to use trusty

2017-07-05 Thread jjmeyer0
GitHub user jjmeyer0 opened a pull request: https://github.com/apache/metron/pull/632 METRON-1008: Updating travis to use trusty ….npm to cache. Added some more cacheing from 1004 ticket. Revert some changes. Reverted environment and put maven opts

[GitHub] metron issue #567: METRON-891: Changed Kafka API to Create a KafkaConsumer P...

2017-05-16 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/567 @merrimanr @justinleet Accidentally clicked close/comment. Sorry about that. Anyway, does this look good to you all now that the licenses are fixed? --- If your project is set up for it, you can

[GitHub] metron pull request #567: METRON-891: Changed Kafka API to Create a KafkaCon...

2017-05-16 Thread jjmeyer0
GitHub user jjmeyer0 reopened a pull request: https://github.com/apache/metron/pull/567 METRON-891: Changed Kafka API to Create a KafkaConsumer Per Request ## Contributor Comments [Please place any comments here. A description of the problem/enhancement, how to reproduce

[GitHub] metron issue #567: METRON-891: Changed Kafka API to Create a KafkaConsumer P...

2017-05-16 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/metron/pull/567 @merrimanr @justinleet is there anything else --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron issue #567: METRON-891: Changed Kafka API to Create a Kafka...

2017-05-11 Thread jjmeyer0
Github user jjmeyer0 commented on the issue: https://github.com/apache/incubator-metron/pull/567 @merrimanr I reverted the license headers back just in case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your