Re: [DISCUSS] Release Process Update

2017-10-25 Thread Matt Foley
Thanks, Jon. I’ve committed the patch. --Matt On 10/25/17, 9:26 AM, "zeo...@gmail.com" wrote: I still kind of like the build image historically, since not everybody who interfaces with our project will _know_ that the build must always succeed for a release, but I agree that this is

Re: [DISCUSS] Release Process Update

2017-10-25 Thread zeo...@gmail.com
I still kind of like the build image historically, since not everybody who interfaces with our project will _know_ that the build must always succeed for a release, but I agree that this is a clean approach so I rolled back the wiki changes. Thanks, Jon On Tue, Oct 24, 2017 at 2:34 PM Matt Foley

Re: [DISCUSS] Release Process Update

2017-10-24 Thread Matt Foley
The release wouldn’t have been made if the build didn’t succeed. And the Release Manager doesn’t need one more fiddly manual edit to do. I recommend the Release Process instructions be put back, and instead we incorporate https://github.com/apache/metron/pull/815 Rational in https://issues.apache.

Re: [DISCUSS] Release Process Update

2017-10-24 Thread zeo...@gmail.com
Hmm, I kind of like it as a historical validation/confirmation of build success, but I can see where you are coming from. Here is the wiki diff, feel free to critiq

Re: [DISCUSS] Release Process Update

2017-10-24 Thread Kyle Richardson
+1 I agree with Matt and Justin. The Travis build widget doesn't make sense in the published release documentation. No sense in fixing retrospectively. -Kyle On Mon, Oct 23, 2017 at 3:13 PM Matt Foley wrote: > I agree with Justin. This micro-feature is intended as a github widget, > which caus

Re: [DISCUSS] Release Process Update

2017-10-23 Thread Matt Foley
I agree with Justin. This micro-feature is intended as a github widget, which causes the top-level README to give all viewers an immediate flag whether the build is healthy or not. It does not belong in a rendered site-book. Removing the widget during site-book build, can be done with a one-li

Re: [DISCUSS] Release Process Update

2017-10-23 Thread Justin Leet
I'd argue it shouldn't be in the site-book at all. Presumably we aren't releasing while Travis is broken, so it's not useful information for anyone looking at docs. It just carries over from the main README. Seems like we should just scrub it when we do the other fixes to the READMEs to make them

[DISCUSS] Release Process Update

2017-10-23 Thread zeo...@gmail.com
Today I was poking around the Metron site and documentation, and I noticed that the site-book's travis build status image is pointing to master for all of our releases. We should probably update the release process to pin this to