Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/481
Updated and re-ran unit and integration tests. @ottobackwards ,
metron-solr integration tests ran fine. I did see a problem with metron-rest
integration test
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/481
@dlyle65535 yes, I'll clean this up.
I'll run integration tests one more time to make sure I don't see
@ottobackwards 's problem, then commit on the strength of his and your +1. Let
me
Github user dlyle65535 commented on the issue:
https://github.com/apache/metron/pull/481
My test environment is being funky, I'm +1 by inspection- thanks for the
work, please don't let me hold you up any more.
---
If your project is set up for it, you can reply to this email and
Github user dlyle65535 commented on the issue:
https://github.com/apache/metron/pull/481
@mattf-horton - sorry about the hurry up and wait. I'll run this up
tomorrow. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/481
Before committing, I'm going to retest to make sure I'm not missing the
problems @ottobackwards saw. @dlyle65535 , also interested in your feedback if
you have time.
---
If your project is
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/481
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/481
Comment on testing: There are so many permutations it only seemed
reasonable to automate them in unit test, and so I did. As part of code
review, please provide your opinion on whether the
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/481
I am seeing errors like
```bash
---
T E S T S
---
Running
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/481
This is a lot of work, and a great job @mattf-horton. A couple of nit
comments I would like to get response to before a +1
---
If your project is set up for it, you can reply to this email
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/481
@cestella said:
```
Since this is a core change, it bears probably developing an acceptance
test plan.
Something like creating a dummy sensor, creating a batch size of 10 and
Github user dlyle65535 commented on the issue:
https://github.com/apache/metron/pull/481
Awesome! I can run it up on a live system and see what's what. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/481
Hi @dlyle65535 , I would welcome help. I think this weekend I can update
to current master, and integrate the (already done) fixes for @cestella 's
suggestions, including stateful testing with
Github user dlyle65535 commented on the issue:
https://github.com/apache/metron/pull/481
@mattf-horton - Can I offer some help getting back to this? Is a pretty
important fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/481
This is simply waiting for me to have time to return to it. Would like to
leave it open, if agreeable to community.
---
If your project is set up for it, you can reply to this email and have
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/481
What is the status of this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
15 matches
Mail list logo
