[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/675 https://issues.apache.org/jira/browse/METRON-1079 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/675 +1 by inspection, this is good work, @ottobackwards Sorry for jumping to conclusions! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/675 hah no, a JIRA will be necessary ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/675 I'll create a Jira for the NaN thing, unless you have already coded it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/675 Yeah, I'm totally ok with this now. Really sorry about jumping to the wrong conclusion; I saw the errors in the aftermath of the math PR that got in this morning and jumped to the wrong conclusion

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/675 Right. This PR adds the Language Capability to required variables be passed based on the VariableResolver implementation defined. Which can be defined based on the requirements of the 'host'

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/675 Ok, wait, I think I might've misunderstood. This `DefaultVariableResolver` is just being used for tests, validation and Lambda functions now, is that correct? I think I'm ok with that. --- If yo

[GitHub] metron issue #675: METRON-379 STELLAR can differentiate between a value pass...

2017-08-03 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/675 In my opinion, I don't think we want this behavior. I think it may be too severe given how dirty and sparse our data tends to be. Does this mean that if you have a stellar expression `FOO(b