[GitHub] metron issue #702: METRON-1114: Add group by capabilities to search REST end...

2017-09-11 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/702 Updates look good. I'm +1. Thanks again for contributing this. ---

[GitHub] metron issue #702: METRON-1114: Add group by capabilities to search REST end...

2017-09-08 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/702 The latest commit should address the feedback so far. I don't feel like the top hits aggregation is necessary at this point but it could be in the future. I would prefer to wait and keep it

[GitHub] metron issue #702: METRON-1114: Add group by capabilities to search REST end...

2017-09-08 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/702 This is really good, thanks for the contribution! Are we intending (as a follow-on activity), to enable something like top hits aggregation in here so we can get the documents in the buckets

[GitHub] metron issue #702: METRON-1114: Add group by capabilities to search REST end...

2017-08-24 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/702 The latest commit moves this group by function to it's own REST endpoint. Combining groups and search results became too awkward once I started looking into adding sorting and size constraints to

[GitHub] metron issue #702: METRON-1114: Add group by capabilities to search REST end...

2017-08-22 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/702 No, the "from" parameter is not supported. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] metron issue #702: METRON-1114: Add group by capabilities to search REST end...

2017-08-22 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/702 @merrimanr Does the group by support pagination? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have