Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/823
+1, I'm set
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/823
I'm all set. +1
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/823
@jasper-k thanks for the contribution. Really great job.
+1
@cestella @justinleet are you guys all set?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/823
That looks great! Can you close and reopen the PR so we can get a green
build? Looks like there was a failure due to network issues.
---
Github user jasper-k commented on the issue:
https://github.com/apache/metron/pull/823
@ottobackwards
Aligned annotation and README now. Added example and more clear function
description
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/823
Slightly off topic (and not to dissuade from this good work which is much
clearer), but as a bit of stellar code golf, I did find out that you can do
this with `REDUCE`.
For Numerical types
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/823
I'm ok with the functions as they are, but if we are not going to verify
the parameters, then remove the documented restriction.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/823
Also not the
## For Documentation related changes
section of the template. You should verify the readme changes before
pushing
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/823
Please note from the PR submit template above
```bash
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
You should run this before pushing.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/823
Stellar functions need to be documented in the
metron-stellar/stellar-common/README.md
Please document these new functions
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/823
All the code files in the project need to have the apache lic. header at
the top. The two files you have created do not have that, and cannot be
accepted without it.
What you need to
He needs to add lic. to his files.
On November 1, 2017 at 18:08:59, Ryan Merriman (merrim...@gmail.com) wrote:
Which 2 files are in /home/travis/build/apache/
metron/metron-stellar/stellar-common/target/rat.txt? Do you get this same
error when you run mvn apache-rat:check locally? You will need
Which 2 files are in /home/travis/build/apache/
metron/metron-stellar/stellar-common/target/rat.txt? Do you get this same
error when you run mvn apache-rat:check locally? You will need to either
add licenses to those 2 files or add exclusions in /metron/pom.xml if they
should in fact be excluded
Github user jasper-k commented on the issue:
https://github.com/apache/metron/pull/823
The Travis build failed with an error relating to licensing and Rat. I
don't know how to tackle this problem. The error points to the new files I
added in this PR. Locally I could suppress the error
14 matches
Mail list logo
