Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
+1, looks good. Thanks for all the work on the supplemental fixes. Feel
free to skip attribution on the testing PR.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/824
This looks good to me. I will not require attribution to my PR against
this branch and I give this a +1 pending travis.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/824
@justinleet same here. My +1 is imminent pending docs.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
Code-wise, I'm pretty good at this point. Once the docs come in, I'll give
them a once-over and hopefully we're good to go soon.
Thanks a lot for the hard work here!
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
## Patch neither alert and status
Create a metaalerts and get the GUID for the following steps.
### Patch in new field
```
/api/v1/update/patch
curl -X PATCH --header
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
## Patch alert and status
Create a metaalerts and get the GUID for the following steps.
### Attempt to update status field
```
/api/v1/update/patch
curl -X PATCH
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
## Create meta alert with more than 10 alerts
### Find more than 10 alerts alerts
```
/api/v1/search/search
curl -X POST --header 'Content-Type: application/json'
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
## Changing Metaalert status
### Find two alerts
```
/api/v1/search/search
curl -X POST --header 'Content-Type: application/json' --header 'Accept:
application/json' -d
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
## Removing alerts and removing an already removed alert
### Find two alerts
```
/api/v1/search/search
curl -X POST --header 'Content-Type: application/json' --header
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
## Adding alerts and adding a preexisting alert
### Find two alerts
```
/api/v1/search/search
curl -X POST --header 'Content-Type: application/json' --header 'Accept:
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
Double check me on that logic though. I could definitely be masking an off
by one error there.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
@merrimanr I'm okay with excluding metaalerts (although I need to review
what you did there). I wouldn't expect it to go down by two though.
Say I have two matches, I put one in a
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/824
+1 for functionality all the API's are working fine. Great job @merrimanr
ð
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
The latest commit fixes the group by bug found by @iraghumitra and
addresses the feedback
[above](https://github.com/apache/metron/pull/824#pullrequestreview-76466048).
The group by fix
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
@justinleet looking at your results I would expect the count to go down by
2 instead of 1: 1 for the alert that was added to the meta alert and another
for the meta alert itself since they
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
@iraghumitra I'm unable to duplicate the grouping on the current code
(although I admittedly ran through a pretty basic example). Here's what I did,
so let me know if I missed something, or you
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
@iraghumitra Do you have the specific metaalerts and calls that you made?
I'm spinning this up again, but it'll be a bit before I can test something
myself.
---
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/824
@merrimanr @justinleet tested the new API's they are working fine the only
issue I see is
>>When a meta alert is created the meta alert is returned as part of the
group api which was not
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
I also found what I believe are 2 fairly significant architectural issues
with our DAO abstraction:
- https://issues.apache.org/jira/browse/METRON-1314
-
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
The latest commit fixes the bug in the previous comment. The root cause
was that HBaseDao.getAllLatest was not properly returning the sensor type and
causing subsequent updates in Elasticsearch
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
I've spun this up, and `add/alert` throws this exception:
```
{
"responseCode": 500,
"message": "class org.apache.metron.elasticsearch.dao.ElasticsearchDao:
ElasticsearchDao
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/824
whoops, nevermind, I see you already merged master. my bad. :)
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
@merrimanr Can you merge master into this PR? There is at least one fix in
here that caused me problems spinning this up that's in master, so I'd like to
have it pulled in so testing is as stable
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
The latest commits address some outstanding tasks and address a couple
other issues:
- disabling updates to meta alert objects means we can't update a meta
alert name or comments (or other
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
The 2nd most recent commits updates the MetaAlertDao interface by adding
additional methods for interacting with metaalerts. This should make it
easier to use and make the underlying
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
No problem. I am still actively working on this PR and will add the
HBaseDao.findAllLatest implementation task to my list.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/824
I agree with @justinleet. I think this is well within the scope of this PR
since you're introducing a new method at an interface level. In that
situation, we should have either a default
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
@merrimanr For the findAllLatest, can we add a default implementation to
the interface that would cover HBase (i.e. just do a for loop lookup), even if
it's not efficient. Otherwise, it should
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/824
Do we know why the partial update doesn't work? I'm not necessarily
opposed to doing this as a short term fix, but I'd like to know root cause.
It seems like overkill to submit a full
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/824
I have tested the rest-api I am able to see the alert details for all
alerts under meta alerts
I see a couple of new issues:
- When a meta alert is created the meta alert is
30 matches
Mail list logo
