[GitHub] metron issue #825: METRON-1290: Only first 10 alerts are update when a MetaA...

2017-11-16 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/825 Sounds good. I will take a look at #842. ---

[GitHub] metron issue #825: METRON-1290: Only first 10 alerts are update when a MetaA...

2017-11-16 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/825 @nickwallen https://github.com/apache/metron/pull/842 @merrimanr If you're good with that PR, feel free to close this one. ---

[GitHub] metron issue #825: METRON-1290: Only first 10 alerts are update when a MetaA...

2017-11-16 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/825 @nickwallen I'm about to open a PR with an updated integration test. We should be able to close this one, since the changes here aren't relevant anymore. ---

[GitHub] metron issue #825: METRON-1290: Only first 10 alerts are update when a MetaA...

2017-11-16 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/825 Even if the functionality is addressed, are there tests that cover this condition that we can pull in from this PR? I don't think we ever got a proper integration test to cover this issue, but

[GitHub] metron issue #825: METRON-1290: Only first 10 alerts are update when a MetaA...

2017-11-16 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/825 @merrimanr This is already taken care of by the various refactoring in https://github.com/apache/metron/pull/824, right? Can you close this (and the associated jira) if that's accurate? ---

[GitHub] metron issue #825: METRON-1290: Only first 10 alerts are update when a MetaA...

2017-11-07 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/825 +1 for functionality, tested on full dev when status is changed on a meta-alert all the alerts in the meta-alert are updated with the correct status ---

[GitHub] metron issue #825: METRON-1290: Only first 10 alerts are update when a MetaA...

2017-11-06 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/825 Are we able to replicate this defect in the integration tests? Personally, I'd prefer to see the integration tests validate something like this, if at all possible. ---

[GitHub] metron issue #825: METRON-1290: Only first 10 alerts are update when a MetaA...

2017-11-02 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/825 Looks like there is a [bug](https://stackoverflow.com/questions/40984882/mockito-and-powermock-methodnotfoundexception-being-thrown) in the powermock version inherited by this module. Latest