[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/862 Please take care to mark the jira as done ---

[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/862 +1, Thanks for the contribution! ---

[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-12 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/862 Thanks @ottobackwards . Updated the manual verification steps. ---

[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/862 Like, - Spin up Full Dev - Go to Swagger at http://node1:4200(?) - You should see X now ---

[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/862 Great, can you list that as the manual verification please? ---

[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-12 Thread MohanDV
Github user MohanDV commented on the issue: https://github.com/apache/metron/pull/862 Hi @ottobackwards , we don't need new test. Currently on the Swagger UI we see that API '/api/v1/user' is listed with all the Request methods. After this fix we will see it will be listed for only GE

[GitHub] metron issue #862: METRON-1343: Swagger UI for User Controller needs request...

2017-12-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/862 Hi! Thanks for the contribution. How can we test these changes? Do we need new tests in the code for this change ? Please consider the items in the PR checklist ( listed