Github user cestella commented on the issue:
https://github.com/apache/metron/pull/903
Looks good to me!
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/903
+1 still stands
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/903
+1 to that latest round of naming
---
Github user lvets commented on the issue:
https://github.com/apache/metron/pull/903
@nickwallen Fine for me :) This might be even better if you ever decide to
make production ready pre-made ansible deployments (if that makes sense?)
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
Ok, I renamed the development environments.
I went with a slightly different name than I previously mentioned, but it
still matches the suggestions that I received earlier. I thought
Maybe we need an adding support for a new platform doc
On January 25, 2018 at 19:37:47, nickwallen (g...@git.apache.org) wrote:
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
> @lvets: Just for my understanding, but why Ubuntu Trusty? In April that
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
I am liking a combination of the suggestions from @lvets and @cestella.
Something like this maybe?
* `dev-on-centos6`
* `dev-on-ubuntu14`
I like the name because of points made
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
> @lvets: Just for my understanding, but why Ubuntu Trusty? In April that
will be 2 full Ubuntu LTS versions behind the then current one...
Because that's the requirement that I need to
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/903
@lvets trusty is 14.04. As far as I'm aware the only newer LTS is 16.04,
with a new one expected in April. https://wiki.ubuntu.com/Releases
---
Github user lvets commented on the issue:
https://github.com/apache/metron/pull/903
- Wouldn't `dev-on-centos` and `dev-on-ubuntu` or even `metron-dev-centos`
and `metron-dev-ubuntu` make more sense? I don't think we want people to expect
that this VM is sufficient to run in
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/903
Honestly my only beef with this is the directory naming. I think I'd
prefer `metron-deployment/vagrant/{centos_$VERSION,ubuntu_$VERSION}` because
it's possible that we may want 2 separate versions
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
Thanks @ottobackwards . I'll see if we can get any more reviewers before I
merge this.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/903
+1 -> ran up both images, everything checked out
Ship it
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
> @ottobackwards : Do we expect there to be issues with 2.6? Is this PR and
Casey's 2.6 pr going to conflict or have issues?
Yes, we will need to retest one or the other. I am open to
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
I spun this up again on both Ubuntu and CentOS. Both worked successfully.
I am happy with it now @ottobackwards . Give her another go when you can.
Thanks.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/903
@nickwallen let me know when you feel ok about it, I'll run it through
again.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
> @ottobackwards : Failure during vagrant up for metron-on-ubuntu
Thanks, Otto. Yep, I messed that up. I pushed the fix, but I am going to
run through full CentOS and Ubuntu deployments
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/903
Failure during vagrant up for metron-on-ubuntu
```
2018-01-25 10:41:49,302 p=37541 u=ottofowler | [0;31mfatal: [node1]:
FAILED! => {"changed": true, "cmd":
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/903
Trying this now.
Only comment on the content here is there is a _lot_ going on in this pr.
A lot of while I'm here I might as well work.
It might have been better to have kept this
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/903
I am continuing a final round of testing to make sure these changes are
solid. I wanted to get the PR open so I could start getting feedback as soon
as possible.
---
20 matches
Mail list logo
