[GitHub] metron issue #910: METRON-1430: Isolate jackson from being used as arguments...

2018-01-26 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/910 Ah, ok I didn't pick that up from the context, but that makes sense. +1 stands. ---

[GitHub] metron issue #910: METRON-1430: Isolate jackson from being used as arguments...

2018-01-25 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/910 Yeah, this is the first step to moving it out, I'd say. This was useful independent of #907 because it made some things a lot cleaner (namely fewer `new TypeReference>() {}`

[GitHub] metron issue #910: METRON-1430: Isolate jackson from being used as arguments...

2018-01-25 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/910 @ottobackwards I was envisioning a metron-deps project of some sort. Jackson and Guava are perennial offenders in the Hadoop stack, and a facade of some sort would be useful to insulate us from the

[GitHub] metron issue #910: METRON-1430: Isolate jackson from being used as arguments...

2018-01-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/910 This looks awesome at first look. I'm a big fan of doing this regardless of the shading issue. The only thought that comes to mind is that there is a tipping point where a *Utils class isn't