[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/584 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

GitHub user cestella reopened a pull request: https://github.com/apache/metron/pull/584 METRON-950: Migrate storm-kafka-client to 1.1 ## Contributor Comments There are MAJOR performance issues with the storm-kafka-client. Throughput is roughly an order of magnitude faster in

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

Github user cestella closed the pull request at: https://github.com/apache/metron/pull/584 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/584#discussion_r116584769 --- Diff: metron-platform/metron-storm-kafka-override/src/main/java/org/apache/storm/kafka/spout/internal/Timer.java --- @@ -0,0 +1,58 @@ +/** + *

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/584#discussion_r116581475 --- Diff: metron-platform/metron-storm-kafka-override/src/main/java/org/apache/storm/kafka/spout/internal/Timer.java --- @@ -0,0 +1,58 @@ +/** + *

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/584#discussion_r116579916 --- Diff: metron-platform/metron-storm-kafka/src/main/java/org/apache/metron/storm/kafka/flux/SimpleStormKafkaBuilder.java --- @@ -202,31 +240,4 @@ public

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/584#discussion_r116574125 --- Diff: metron-platform/metron-storm-kafka-override/src/main/java/org/apache/storm/kafka/spout/internal/Timer.java --- @@ -0,0 +1,58 @@ +/** + *

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/584#discussion_r116574075 --- Diff: metron-platform/metron-storm-kafka/src/main/java/org/apache/metron/storm/kafka/flux/SimpleStormKafkaBuilder.java --- @@ -165,13 +177,39 @@

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/584#discussion_r116564604 --- Diff: metron-platform/metron-storm-kafka-override/src/main/java/org/apache/storm/kafka/spout/internal/Timer.java --- @@ -0,0 +1,58 @@ +/** +

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/584#discussion_r116566613 --- Diff: metron-platform/metron-storm-kafka/src/main/java/org/apache/metron/storm/kafka/flux/SimpleStormKafkaBuilder.java --- @@ -202,31 +240,4 @@

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/584#discussion_r116568707 --- Diff: pom.xml --- @@ -106,7 +122,7 @@ but I justify it by noting that this should be able to be removed when we migrate to