[GitHub] metron pull request #742: METRON-1168: Add SUBSTRING method to stellar

2017-09-08 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/742#discussion_r137913498 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/StringFunctionsTest.java --- @@ -408,6 +408,23 @@ public

[GitHub] metron pull request #742: METRON-1168: Add SUBSTRING method to stellar

2017-09-08 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/742#discussion_r137913443 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java --- @@ -321,6 +321,46 @@ public Object

[GitHub] metron pull request #742: METRON-1168: Add SUBSTRING method to stellar

2017-09-08 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/742#discussion_r137913436 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java --- @@ -321,6 +321,46 @@ public Object

[GitHub] metron pull request #742: METRON-1168: Add SUBSTRING method to stellar

2017-09-08 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/742#discussion_r137913052 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java --- @@ -321,6 +321,46 @@ public

[GitHub] metron pull request #742: METRON-1168: Add SUBSTRING method to stellar

2017-09-08 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/742#discussion_r137912849 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java --- @@ -321,6 +321,46 @@ public

[GitHub] metron pull request #742: METRON-1168: Add SUBSTRING method to stellar

2017-09-08 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/742#discussion_r137912941 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/StringFunctions.java --- @@ -321,6 +321,46 @@ public

[GitHub] metron pull request #742: METRON-1168: Add SUBSTRING method to stellar

2017-09-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/742 ---

[GitHub] metron pull request #742: METRON-1168: Add SUBSTRING method to stellar

2017-09-08 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/742#discussion_r137883199 --- Diff: metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/StringFunctionsTest.java --- @@ -408,6 +408,19 @@ public

[GitHub] metron pull request #742: METRON-1168: Add SUBSTRING method to stellar

2017-09-08 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/742 METRON-1168: Add SUBSTRING method to stellar ## Contributor Comments Add `SUBSTRING` function to stellar. Testing: Open up the REPL and play with `SUBSTRING` ## Pull